From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31670C4332F for ; Fri, 29 Oct 2021 18:39:58 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id DB67C61075 for ; Fri, 29 Oct 2021 18:39:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org DB67C61075 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 4CBB9940008; Fri, 29 Oct 2021 14:39:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 47972940007; Fri, 29 Oct 2021 14:39:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 36758940008; Fri, 29 Oct 2021 14:39:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0246.hostedemail.com [216.40.44.246]) by kanga.kvack.org (Postfix) with ESMTP id 10BD6940007 for ; Fri, 29 Oct 2021 14:39:57 -0400 (EDT) Received: from smtpin15.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id A155D8249980 for ; Fri, 29 Oct 2021 18:39:56 +0000 (UTC) X-FDA: 78750339192.15.6D11BE2 Received: from mail-ot1-f42.google.com (mail-ot1-f42.google.com [209.85.210.42]) by imf12.hostedemail.com (Postfix) with ESMTP id 4FA2D100009D for ; Fri, 29 Oct 2021 18:39:56 +0000 (UTC) Received: by mail-ot1-f42.google.com with SMTP id x27-20020a9d459b000000b0055303520cc4so14777089ote.13 for ; Fri, 29 Oct 2021 11:39:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ZbJJ3sirvGO1Q5qzFIR+Qcm5nvITBleUPONekunq9do=; b=JhuPOWTlUv0dvoFUsdQX3TZ45A4w4xwPLm3aRc61xHACK/vWmb14Wci65EYRuQDeCS 16gGSRTmuddRc4AMqO4JBKbmv/HwlpJ8uwdyJI6dW84HojhuNodl/rKGzxrM6hegxP7D grc4dKaImGu+g7b+yL2xvWl1d42o9X9Q9jkQ8gVWgW8fOhzEYUihiBc834nq+pHpHnXf VXtOKScheCJfj7sM6ttKzJjrn6J8N92vuVwuOAsX6U2iWTpEXQvE5WEUI0Wj6c0/uTz4 Y5g4HU4GciKMMc35vDS9z0AH++5IyeDNBcvhkB7wm60wv3/IaUtlHINoGbfWh5vimCEe vLKQ== X-Gm-Message-State: AOAM530D27znDC/Y+PTNn7Ve2fN073l9eP9ya/WZLkw/EY8ppe8wUENl b2dgJz45VEuvvfwOtjuZ9JoPceFWz/yMSUdhgAs= X-Google-Smtp-Source: ABdhPJzzT6cB8eCDJmpVcRiVJH/HJQE931S3wWY6YLrIMln0JVWc33duNyd4uacmLGMUV1B0MfAnmK1v5Cm4HHKIGks= X-Received: by 2002:a05:6830:90b:: with SMTP id v11mr9843423ott.254.1635532794570; Fri, 29 Oct 2021 11:39:54 -0700 (PDT) MIME-Version: 1.0 References: <20211018202542.584115-1-tony.luck@intel.com> <20211026220050.697075-1-tony.luck@intel.com> <20211026220050.697075-8-tony.luck@intel.com> In-Reply-To: <20211026220050.697075-8-tony.luck@intel.com> From: "Rafael J. Wysocki" Date: Fri, 29 Oct 2021 20:39:43 +0200 Message-ID: Subject: Re: [PATCH v11 7/7] x86/sgx: Add check for SGX pages to ghes_do_memory_failure() To: Tony Luck Cc: Borislav Petkov , "the arch/x86 maintainers" , "Rafael J. Wysocki" , =?UTF-8?B?SE9SSUdVQ0hJIE5BT1lBKOWggOWPoyDnm7TkuZ8p?= , Andrew Morton , Sean Christopherson , Jarkko Sakkinen , Dave Hansen , Cathy Zhang , linux-sgx@vger.kernel.org, ACPI Devel Maling List , Linux Memory Management List , Linux Kernel Mailing List , Reinette Chatre Content-Type: text/plain; charset="UTF-8" Authentication-Results: imf12.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=kernel.org (policy=none); spf=pass (imf12.hostedemail.com: domain of rjwysocki@gmail.com designates 209.85.210.42 as permitted sender) smtp.mailfrom=rjwysocki@gmail.com X-Stat-Signature: rx7bjcwxfhk7bj33sigjgx77tmqhuqfx X-Rspamd-Queue-Id: 4FA2D100009D X-Rspamd-Server: rspam01 X-HE-Tag: 1635532796-970175 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Oct 27, 2021 at 12:01 AM Tony Luck wrote: > > SGX EPC pages do not have a "struct page" associated with them so the > pfn_valid() sanity check fails and results in a warning message to > the console. > > Add an additional check to skip the warning if the address of the error > is in an SGX EPC page. > > Reviewed-by: Jarkko Sakkinen > Tested-by: Reinette Chatre > Signed-off-by: Tony Luck Acked-by: Rafael J. Wysocki > --- > drivers/acpi/apei/ghes.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/acpi/apei/ghes.c b/drivers/acpi/apei/ghes.c > index 0c8330ed1ffd..0c5c9acc6254 100644 > --- a/drivers/acpi/apei/ghes.c > +++ b/drivers/acpi/apei/ghes.c > @@ -449,7 +449,7 @@ static bool ghes_do_memory_failure(u64 physical_addr, int flags) > return false; > > pfn = PHYS_PFN(physical_addr); > - if (!pfn_valid(pfn)) { > + if (!pfn_valid(pfn) && !arch_is_platform_page(physical_addr)) { > pr_warn_ratelimited(FW_WARN GHES_PFX > "Invalid address in generic error data: %#llx\n", > physical_addr); > -- > 2.31.1 >