From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EFF04C76196 for ; Mon, 10 Apr 2023 14:58:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6F12C280028; Mon, 10 Apr 2023 10:58:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6A10328001E; Mon, 10 Apr 2023 10:58:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 56882280028; Mon, 10 Apr 2023 10:58:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 43D2928001E for ; Mon, 10 Apr 2023 10:58:25 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 0E96D16020F for ; Mon, 10 Apr 2023 14:58:25 +0000 (UTC) X-FDA: 80665787370.17.3A0DF8D Received: from mail-oa1-f49.google.com (mail-oa1-f49.google.com [209.85.160.49]) by imf19.hostedemail.com (Postfix) with ESMTP id 025D51A0004 for ; Mon, 10 Apr 2023 14:58:22 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=none; spf=pass (imf19.hostedemail.com: domain of tanurelinux@gmail.com designates 209.85.160.49 as permitted sender) smtp.mailfrom=tanurelinux@gmail.com; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681138703; a=rsa-sha256; cv=none; b=CZRe6WVZTzJyIzSjvQsZBhdjQkepZ0I7eqV9qlPoTnck3h0Wjhuz00zNakb+aN6IGE5j1i 3iOAkvxAxJAEhu4hothb4jC521RcjBlezA48xtStTGJRPctffqQC/m1wnVXWk+zP5/Q+9Z lOT4gbTr7kO5TxsKDx97DEL/Gpe/ij8= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=none; spf=pass (imf19.hostedemail.com: domain of tanurelinux@gmail.com designates 209.85.160.49 as permitted sender) smtp.mailfrom=tanurelinux@gmail.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681138703; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZC0Mdx6dJbemnObfOPEMw+WA676pFjjKABCK5HPK6ZI=; b=T1Wiz1h/5oVfIteunY+t3mGaEXllen/fKAvnEzyaaGHPsezU5QZ50SThKDG8dhkvfM8djN RQeKId6m7V39I5TPuXCUyjGictnXHfnPcjDy0zLqTG8WpMnNqvgeH/UZ364m2Yia+bFWLj SPctgF8EaZn1zRpbLDzk4k3OhKDeRn0= Received: by mail-oa1-f49.google.com with SMTP id 586e51a60fabf-184549428acso2133599fac.8 for ; Mon, 10 Apr 2023 07:58:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1681138702; x=1683730702; h=content-transfer-encoding:cc:to:subject:message-id:date:from :reply-to:in-reply-to:references:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=ZC0Mdx6dJbemnObfOPEMw+WA676pFjjKABCK5HPK6ZI=; b=TUEqrOqdz/pWVO/icOVhhXq5UrjzS/JYagD+dpk+x/EHd+jn8v8D7+1hLY6Wb2u1o1 J3w4n46K1OBOEDdElxELnf156TIURxXdJc8uOktAjrlTQj5/EPhNt8AgHkLv1/mlLGGf uCb8lPIPSqFVuFRUbF0ZjqRd0yexR41aDRa0K36Py5TH2HWGAPGuVRtTlzPv1DpjtGDi wiY3wZ2WlAQJUVFysmx4e0ZoxuqkRE7syx/MYc51a+hD8YhloY0mjy5E4xTmhN/G446W Eu7Xean8EvhbIatjrY3O6M27iIJ+egTNGRFrolYCvP4NV7oPoFE19HeHBDSlvMvAbkmx D7cA== X-Gm-Message-State: AAQBX9fKbCQfGIH3pqXYM44HB4VdbaAg/0pQbftZtATdxqP8yN75iaVR 3yXSpJvzDheV+epF6B7ma7/Bo8/o1vBJMmHp X-Google-Smtp-Source: AKy350amQ/EFjnlOpSLsBbJ3balYZllo8Eot5z3V8HTzLoOMgrac3k8MM5ycguXi4bdc1AB12W8taQ== X-Received: by 2002:a05:6870:b148:b0:17a:cc85:5b1e with SMTP id a8-20020a056870b14800b0017acc855b1emr6220665oal.3.1681138701867; Mon, 10 Apr 2023 07:58:21 -0700 (PDT) Received: from mail-oa1-f45.google.com (mail-oa1-f45.google.com. [209.85.160.45]) by smtp.gmail.com with ESMTPSA id yy26-20020a056871259a00b001728669a604sm4109315oab.5.2023.04.10.07.58.21 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 10 Apr 2023 07:58:21 -0700 (PDT) Received: by mail-oa1-f45.google.com with SMTP id 586e51a60fabf-1842f69fe1fso6091923fac.11 for ; Mon, 10 Apr 2023 07:58:21 -0700 (PDT) X-Received: by 2002:a05:6870:d608:b0:17d:7221:d80c with SMTP id a8-20020a056870d60800b0017d7221d80cmr3664255oaq.5.1681138701166; Mon, 10 Apr 2023 07:58:21 -0700 (PDT) MIME-Version: 1.0 References: <20230410120017.41664-1-tanure@linux.com> <20230410120017.41664-2-tanure@linux.com> In-Reply-To: Reply-To: tanure@linux.com From: Lucas Tanure Date: Mon, 10 Apr 2023 10:58:10 -0400 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 1/1] of: fdt: Scan /memreserve/ last To: Rob Herring Cc: Frank Rowand , Mike Rapoport , Andrew Morton , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, jbrunet@baylibre.com, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, martin.blumenstingl@googlemail.com, narmstrong@baylibre.com, stefan@agner.ch Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Queue-Id: 025D51A0004 X-Rspamd-Server: rspam01 X-Stat-Signature: 8arqqj8ic4jbc6371zx1hgk9tf1ddcrn X-HE-Tag: 1681138702-144667 X-HE-Meta: U2FsdGVkX18vktbfaRlyIpVHZnafLFa/QK3qS9TGQ/unc+slU1KKuAjBUsuZjRsxOjgKwy4sqPTvYP7dzgOtg8ZjG+9l1gSNh0I13FDzZFsVTqX0WCqI95N50XqV79eCtXQXlatpv8CGCZ8QkJdfpMklzl6Xfq2MHFVsIJbvlyOjijiRweAWFZfoMh2F/MVAqAs2TKxrrw87LaqkYCpnw7+652pLdK1+fjPb1pI9bje2FLiCcFq7Rz9TuFEJPUcykICeepM5xUpwZy7q6+lpnhfeZGOTSVGrmz0+n3f6oFsY1+Nu1iBVLYoDGsG+MtQg26FF5XMPnuwPyXO/868qRzSHJTE4o+N3B3evPVVhYY9yRKqAwwWf1Z4TVfV6yQeXBiy3Q+EL8A9wHEKaZ/VggFuNlXB765CbINMnoaFWsxLaQiXhKmaWey7+qiJq6LADfsvlyewrHITJ1JiTYZi4DaCf3YYouNZmKhuBgRi9X8cSaHFAsQOAk4e4WJfTaqn7Y2Vw84e4fifTn4q/GtUA5Kvp+FSVcPByeZtY9SMqsAvEWflfHy6WvkgslqV4q2p12r0zGjfjkiqf/QdqBGVceK3H9iBiVjyjxfLuW+4oWVi7dkJeKaKotZr9vHzWt5rsGI9aWREXvhPBEdhQSrJ/+Xi1Niri8sx1snW86FZwRTZiXwIUYJ+2eBIsPODerMoUHtEzlLIaoH1zuE468LmmLS6WVj/ofm1YHBzgRZZW69PtRbb24hXwq4TRYkDQeDGogSk57KsLcbXhGDwVnKGsF/CGacW+P4FdEJeD2BCzLvIwbVEt7xqs+zvqzUQjs8VGrEosQiJsNxJOmpA3sCwh1kSqC8jeQUjazJTLyGWgIyI3zjavG20N4dUkfX+YmyVXMEziwTHcz0zN9E1MX/EiqQ09cPXvH3xFJckEUtvzkZPS3dLSKwO7cTqZsw5Aa4X/YvAh0iHD93RUIncw97h cJf5Hxat Sjbt0KofbwI1IcX61TK+CjzKCSTpRn75hOVWaMvzDlBSFvkTToHN/ykid5nfOC42/gWRTm9+fLsTMgIY17H/uudwB6TSjCSaVKowG+vu6Q/vUNAipW470fcCdzk0O/PV/fEoTxEVBKdKNUgTJFyWhGDO0wdULnsb1myVUSv7GdwhDyTtsQDh2rTP8mpCYrLSEsYI2AKQd6wAKkHhbVUV9eUIYGt2CZ77Ac3VaZBTFIcQiCGZk8c7Si+UaEF1dZp0b2M10U8TRVehdCKjuJL8wq2j7dIqsvhTSadpjkNCRPONjBpWNjIr2NHX2buAfKxqyjfDmVn0j6nxD7e/xZaeNJKlqiQP+YZKT2pGvK+ktpdRbx+xmDIm8LAHeIoX+f3rjon9EUIMgZ4BjdKMMB2C9b6CBREG9MgsyMnXL8BtkNoA79wIskeD5P1EJgvEciymuYWnVS9d7eCZ1Fbxm4TIxog8CRrhCl5ZRLaK2CF/ozBFgC3RFb/Pb2xMuXh8UHuyy4Tf2FzVxAkeFRnXSBlrjffjRJk8+xcLWvXapRJtg7HS4iyhNvGjSmq1ra/msFLt0HsxqeN92Q4qWb+YocgAW9/vMkAqD0dhdZQTZOFldXL/1QqgPYPH6x8NQAMG7S4n4fPea X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Apr 10, 2023 at 8:52=E2=80=AFAM Rob Herring wr= ote: > > On Mon, Apr 10, 2023 at 7:00=E2=80=AFAM Lucas Tanure w= rote: > > > > Change the order of scanning /memreserve/ and /reserved-memory node. > > /reserved-memory node should go first, as it has a more updated > > description of the memory regions and it can apply flags, like nomap. > > Also, /memreserve/ should avoid reserving regions described in > > /reserved-memory node. > > Like I said on v1, I think doing this has a high chance of causing > regressions on other platforms. It should probably not go to stable > for some time after a kernel release. > > > Signed-off-by: Lucas Tanure > > --- > > drivers/of/fdt.c | 9 +++++++-- > > 1 file changed, 7 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/of/fdt.c b/drivers/of/fdt.c > > index d1a68b6d03b3..26e608d8025d 100644 > > --- a/drivers/of/fdt.c > > +++ b/drivers/of/fdt.c > > @@ -635,16 +635,21 @@ void __init early_init_fdt_scan_reserved_mem(void= ) > > if (!initial_boot_params) > > return; > > > > + fdt_scan_reserved_mem(); > > + fdt_reserve_elfcorehdr(); > > + > > /* Process header /memreserve/ fields */ > > for (n =3D 0; ; n++) { > > fdt_get_mem_rsv(initial_boot_params, n, &base, &size); > > if (!size) > > break; > > + if (memblock_overlaps_region(&memblock.memory, base, si= ze) && > > + memblock_is_region_reserved(base, size)) > > Just to make sure, a partial overlap will still get reserved? A partial overlap will get reserved if not already reserved by the /reserved-memory node. > > > + break; > > Shouldn't we continue to the next entry rather than stopping. Yes, my mistake; I will send v3. > > > + > > memblock_reserve(base, size); > > } > > > > - fdt_scan_reserved_mem(); > > - fdt_reserve_elfcorehdr(); > > fdt_init_reserved_mem(); > > } > > > > -- > > 2.40.0 > >