From: Gioh Kim <gi-oh.kim@ionos.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: kbuild@lists.01.org, Gioh Kim <gi-oh.kim@cloud.ionos.com>,
kbuild test robot <lkp@intel.com>,
kbuild-all@lists.01.org,
Linux Memory Management List <linux-mm@kvack.org>,
Jens Axboe <axboe@kernel.dk>, Jack Wang <jinpu.wang@ionos.com>,
Leon Romanovsky <leonro@nvidia.com>
Subject: Re: [linux-next:master 13667/14048] drivers/infiniband/ulp/rtrs/rtrs-clt.c:2922 rtrs_clt_rdma_cq_direct() error: uninitialized symbol 'cnt'.
Date: Thu, 29 Apr 2021 11:05:05 +0200 [thread overview]
Message-ID: <CAJX1YtYPQrGC5-WcLSEE6W7rE_xu2VBSG5Vz1sk_zDfuuAOn-Q@mail.gmail.com> (raw)
In-Reply-To: <202104211107.klEwvRy0-lkp@intel.com>
On Thu, Apr 29, 2021 at 10:58 AM Dan Carpenter <dan.carpenter@oracle.com> wrote:
>
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> head: 593ef1658ecf61d3619885bdbbcfffa3d1417891
> commit: fa607fcb87f6e3dca38b9984c4ccde3e36a43721 [13667/14048] block/rnbd-clt: Support polling mode for IO latency optimization
> config: x86_64-randconfig-m031-20210420 (attached as .config)
> compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> smatch warnings:
> drivers/infiniband/ulp/rtrs/rtrs-clt.c:2922 rtrs_clt_rdma_cq_direct() error: uninitialized symbol 'cnt'.
>
> vim +/cnt +2922 drivers/infiniband/ulp/rtrs/rtrs-clt.c
>
> fa607fcb87f6e3 Gioh Kim 2021-04-19 2901 int rtrs_clt_rdma_cq_direct(struct rtrs_clt *clt, unsigned int index)
> fa607fcb87f6e3 Gioh Kim 2021-04-19 2902 {
> fa607fcb87f6e3 Gioh Kim 2021-04-19 2903 int cnt;
> fa607fcb87f6e3 Gioh Kim 2021-04-19 2904 struct rtrs_con *con;
> fa607fcb87f6e3 Gioh Kim 2021-04-19 2905 struct rtrs_clt_sess *sess;
> fa607fcb87f6e3 Gioh Kim 2021-04-19 2906 struct path_it it;
> fa607fcb87f6e3 Gioh Kim 2021-04-19 2907
> fa607fcb87f6e3 Gioh Kim 2021-04-19 2908 rcu_read_lock();
> fa607fcb87f6e3 Gioh Kim 2021-04-19 2909 for (path_it_init(&it, clt);
> fa607fcb87f6e3 Gioh Kim 2021-04-19 2910 (sess = it.next_path(&it)) && it.i < it.clt->paths_num; it.i++) {
> fa607fcb87f6e3 Gioh Kim 2021-04-19 2911 if (READ_ONCE(sess->state) != RTRS_CLT_CONNECTED)
> fa607fcb87f6e3 Gioh Kim 2021-04-19 2912 continue;
>
> What if no sessions are connected? So we dont enter the loop or we
> hit continue every time?
Hi Dan,
I just finished a internal process for the fix of that issue.
In short, I would like to initialize cnt with -1.
So rtrs_clt_rdma_cq_direct will return -1 if there is no session.
And the block layer will not call rtrs_clt_rdma_cq_direct again
because the return value is negative.
I am going to send the patch today with the tags above.
Thank you very much.
>
> fa607fcb87f6e3 Gioh Kim 2021-04-19 2913
> fa607fcb87f6e3 Gioh Kim 2021-04-19 2914 con = sess->s.con[index + 1];
> fa607fcb87f6e3 Gioh Kim 2021-04-19 2915 cnt = ib_process_cq_direct(con->cq, -1);
> fa607fcb87f6e3 Gioh Kim 2021-04-19 2916 if (cnt)
> fa607fcb87f6e3 Gioh Kim 2021-04-19 2917 break;
> fa607fcb87f6e3 Gioh Kim 2021-04-19 2918 }
> fa607fcb87f6e3 Gioh Kim 2021-04-19 2919 path_it_deinit(&it);
> fa607fcb87f6e3 Gioh Kim 2021-04-19 2920 rcu_read_unlock();
> fa607fcb87f6e3 Gioh Kim 2021-04-19 2921
> fa607fcb87f6e3 Gioh Kim 2021-04-19 @2922 return cnt;
> fa607fcb87f6e3 Gioh Kim 2021-04-19 2923 }
>
> ---
> 0-DAY CI Kernel Test Service, Intel Corporation
> https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
>
next prev parent reply other threads:[~2021-04-29 9:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-29 8:58 Dan Carpenter
2021-04-29 9:05 ` Gioh Kim [this message]
2021-04-29 9:30 ` Gioh Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJX1YtYPQrGC5-WcLSEE6W7rE_xu2VBSG5Vz1sk_zDfuuAOn-Q@mail.gmail.com \
--to=gi-oh.kim@ionos.com \
--cc=axboe@kernel.dk \
--cc=dan.carpenter@oracle.com \
--cc=gi-oh.kim@cloud.ionos.com \
--cc=jinpu.wang@ionos.com \
--cc=kbuild-all@lists.01.org \
--cc=kbuild@lists.01.org \
--cc=leonro@nvidia.com \
--cc=linux-mm@kvack.org \
--cc=lkp@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox