From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <owner-linux-mm@kvack.org>
Received: from mail-it0-f72.google.com (mail-it0-f72.google.com [209.85.214.72])
	by kanga.kvack.org (Postfix) with ESMTP id 31EE26B0003
	for <linux-mm@kvack.org>; Thu,  5 Apr 2018 15:57:30 -0400 (EDT)
Received: by mail-it0-f72.google.com with SMTP id 204-v6so4031511itu.6
        for <linux-mm@kvack.org>; Thu, 05 Apr 2018 12:57:30 -0700 (PDT)
Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41])
        by mx.google.com with SMTPS id g129-v6sor907274itd.46.2018.04.05.12.57.29
        for <linux-mm@kvack.org>
        (Google Transport Security);
        Thu, 05 Apr 2018 12:57:29 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <20180405094346.104cf288@gandalf.local.home>
References: <20180404115310.6c69e7b9@gandalf.local.home> <20180404120002.6561a5bc@gandalf.local.home>
 <CAJWu+orC-1JDYHDTQU+DFckGq5ZnXBCCq9wLG-gNK0Nc4-vo7w@mail.gmail.com>
 <20180404121326.6eca4fa3@gandalf.local.home> <CAJWu+op5-sr=2xWDYcd7FDBeMtrM9Zm96BgGzb4Q31UGBiU3ew@mail.gmail.com>
 <CAJWu+opM6RjK-Z1dr35XvQ5cLKaV=cLG5uMu-rLkoO=X03c+FA@mail.gmail.com> <20180405094346.104cf288@gandalf.local.home>
From: Joel Fernandes <joelaf@google.com>
Date: Thu, 5 Apr 2018 12:57:28 -0700
Message-ID: <CAJWu+oqT0oPrEL4mPnWvF3Zt-psg2DWGj9Nrr+fda2JYFzRmqg@mail.gmail.com>
Subject: Re: [PATCH] ring-buffer: Add set/clear_current_oom_origin() during allocations
Content-Type: text/plain; charset="UTF-8"
Sender: owner-linux-mm@kvack.org
List-ID: <linux-mm.kvack.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: LKML <linux-kernel@vger.kernel.org>, Michal Hocko <mhocko@kernel.org>, Zhaoyang Huang <huangzhaoyang@gmail.com>, Ingo Molnar <mingo@kernel.org>, kernel-patch-test@lists.linaro.org, Andrew Morton <akpm@linux-foundation.org>, "open list:MEMORY MANAGEMENT" <linux-mm@kvack.org>, Vlastimil Babka <vbabka@suse.cz>

Hi Steve,

On Thu, Apr 5, 2018 at 6:43 AM, Steven Rostedt <rostedt@goodmis.org> wrote:
> On Wed, 4 Apr 2018 16:59:18 -0700
> Joel Fernandes <joelaf@google.com> wrote:
>
>> Happy to try anything else, BTW when the si_mem_available check
>> enabled, this doesn't happen and the buffer_size_kb write fails
>> normally without hurting anything else.
>
> Can you remove the RETRY_MAYFAIL and see if you can try again? It may
> be that we just remove that, and if si_mem_available() is wrong, it
> will kill the process :-/ My original code would only add MAYFAIL if it
> was a kernel thread (which is why I created the mflags variable).

Tried this. Dropping RETRY_MAYFAIL and the si_mem_available check
destabilized the system and brought it down (along with OOM killing
the victim).

System hung for several seconds and then both the memory hog and bash
got killed.

thanks,

- Joel