From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47BB7C433EF for ; Sat, 14 May 2022 11:51:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5FB8C6B0073; Sat, 14 May 2022 07:51:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5AB136B0075; Sat, 14 May 2022 07:51:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 44BAD6B0078; Sat, 14 May 2022 07:51:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 32AFB6B0073 for ; Sat, 14 May 2022 07:51:38 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 0A80231F12 for ; Sat, 14 May 2022 11:51:38 +0000 (UTC) X-FDA: 79464183876.25.941269F Received: from mail-vs1-f52.google.com (mail-vs1-f52.google.com [209.85.217.52]) by imf25.hostedemail.com (Postfix) with ESMTP id 35AEBA00B4 for ; Sat, 14 May 2022 11:51:16 +0000 (UTC) Received: by mail-vs1-f52.google.com with SMTP id e19so10908599vsu.12 for ; Sat, 14 May 2022 04:51:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=SYetQsXYJ6v4hzBkbaZT00INLkhixyLbrap2Z4dI6sg=; b=WztLMRU9Cjluo2wWZ0TOGFYm+8EbrUXp9qx6VlONLF9nKwn0AIjiLc0JbQA6UHDC5N EDBNdozkQXEC+KVxvsXzVN2uaOUEcvAIRc7ZUJ1l5Tr92zF2RdsuYcJzd4Epx7EbWYAh zGtYtlFxRg8sRT7O8kaqzmNQ9Gdrh4uUgLYqs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=SYetQsXYJ6v4hzBkbaZT00INLkhixyLbrap2Z4dI6sg=; b=430TxZFel4P3X8nCwwRCAEg6Dr03myTLny9T+2fTXaTGWYLdJsdJlOmUFjAdZTiVzS mvLtJL2XXfHS34a0wmc/YIGdrcWp/+QQUy5UkfOcOpN1bYp4lXuo6M+IwnuuvWx6PGGr 8ExgBKRiNv0vIfLB3VlW7dTCVqnc1AUzNWqGd/OrEBm/eEgsLsZAR/knjCb+lBuG1lZW NEB5er1N2qV69I65JSEl3lNNqi+o9fBRci1VpNfP/ABkT45TUc6buo+vxA0LrlxPgq6+ MsfDsGhH9to4R72QWNuQxMyM03tpp3KkrBopJLaS/a7tNpPu5tf/jwKO2x6BBTEe1sH8 wTwQ== X-Gm-Message-State: AOAM5302g0hJvUPnsuz/JbEpWU4aKXS2qfCYhTdxNw1Tq/qlD/sBao7w W25u8walgvK2VFTLU9V9rBLZiFVwD3bVAZ4342hpBw== X-Google-Smtp-Source: ABdhPJwoHCwk6II6x3Gb99Z/RwHHsskVHwjSngD75R3yC1XCHsE6XFtSJZtHG0htRjlvQULyvlV47VSj6U5X1KuJNl0= X-Received: by 2002:a67:f445:0:b0:32c:c32c:c7c1 with SMTP id r5-20020a67f445000000b0032cc32cc7c1mr3479858vsn.51.1652529096680; Sat, 14 May 2022 04:51:36 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Hsin-Yi Wang Date: Sat, 14 May 2022 19:51:10 +0800 Message-ID: Subject: Re: squashfs performance regression and readahea To: Matthew Wilcox Cc: Xiongwei Song , Phillip Lougher , Zheng Liang , Zhang Yi , Hou Tao , Miao Xie , Andrew Morton , Linus Torvalds , "Song, Xiongwei" , "linux-mm@kvack.org" , "squashfs-devel@lists.sourceforge.net" Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 35AEBA00B4 X-Stat-Signature: ojyzfweomij115bqnfo9m5oidtkf6nsh X-Rspam-User: Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=WztLMRU9; spf=pass (imf25.hostedemail.com: domain of hsinyi@chromium.org designates 209.85.217.52 as permitted sender) smtp.mailfrom=hsinyi@chromium.org; dmarc=pass (policy=none) header.from=chromium.org X-HE-Tag: 1652529076-806708 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, May 14, 2022 at 2:12 AM Matthew Wilcox wrote: > > On Sat, May 14, 2022 at 12:43:47AM +0800, Hsin-Yi Wang wrote: > > > One stupid question, see below code from your patch: > > > > > > + } > > > + > > > + kfree(actor); > > > + return; > > > + > > > +skip_pages: > > > > > > when release page pointers array after pages cached? I don't see > > > any chance to do that. > > > > > actor is not a page pointer. This is allocated from > > squashfs_page_actor_init() and should be freed after use. Or do you > > mean skip_pages? There are some situations where we can't decompress > > the whole block, so we will skip those pages. > > I think the concern is that you don't seem to kfree(pages) on this > exit path. Got it. I'll update in the next version.