From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F0D1C433EF for ; Tue, 10 May 2022 12:47:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1229D6B0073; Tue, 10 May 2022 08:47:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0AB656B0074; Tue, 10 May 2022 08:47:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E67008D0001; Tue, 10 May 2022 08:47:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id D63EB6B0073 for ; Tue, 10 May 2022 08:47:57 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id E1274218A9 for ; Tue, 10 May 2022 12:47:49 +0000 (UTC) X-FDA: 79449810258.08.3B62837 Received: from mail-vk1-f170.google.com (mail-vk1-f170.google.com [209.85.221.170]) by imf17.hostedemail.com (Postfix) with ESMTP id 71091400A3 for ; Tue, 10 May 2022 12:47:31 +0000 (UTC) Received: by mail-vk1-f170.google.com with SMTP id j14so5645063vkp.4 for ; Tue, 10 May 2022 05:47:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=FGn9sKlm8/KLTuSL2PYTkdb7eNaudg4yFMJpLEDFWcM=; b=UJtXkzwKZoXMrDpvnHvsjZPo3qS/kJVI/Rl8DDPUo7afD1nYOh4ViB06V7w+29W0hq dT8tvZFybapl4g9tnMvarxquEmjvMBx7SmUn9r+E6ear9HnMj9XUGIkyzSsiDSRjoLW+ PJ7Iv2n9/91j6l4GGzvgDF31/y66DrewUaaqs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=FGn9sKlm8/KLTuSL2PYTkdb7eNaudg4yFMJpLEDFWcM=; b=wCWJ9QZZMtv6LjoFVqMRDpdy3tmr+5EoLuT2IZMZZSwYUtxwb9YO4J4m3LNxEtegOf I8mmK6lxCkA3nRdfzTC79MibpZ5hkt08uk7TanQmGpMWWr1HMzi1X0iardyJ0jJFm4N6 6P8bZGtgUIGyoZcB+Qg0yjMR9eivEoxw6ogolpWo0piIsp95jUK7atb0/2D9tHMTMkmj lYXDI6YV4tE1XJLpL/ixu130C3AXdIgx+AJnc/1QmZz96Q++9bKYKPx0mI4RqVOHjRig 0u8yskT0tbY1ZFLqoEWuKsyvVZu953VwuEWa8HQjVMeIWLUaDUBHSm08Hgx1VxwBYSun dqzg== X-Gm-Message-State: AOAM533iFqz95pdJMKkE+L43fhpo+OxwSdzMB+FRA/ZH7WMtblKkVX8C A1+lK9B63PX8dI8L0ODPVkqRopBq2j3KkBA8i1AHDA== X-Google-Smtp-Source: ABdhPJyuNLiEBXxbagfBEPMGKdlK1Y1KP3aZJ4Syz58dSxtTXqm4UbcDizv0/DY3+kuxB0uqKK6GwMHKoUoeTe4jKtM= X-Received: by 2002:a05:6122:20ab:b0:352:1914:5358 with SMTP id i43-20020a05612220ab00b0035219145358mr11709735vkd.6.1652186868480; Tue, 10 May 2022 05:47:48 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Hsin-Yi Wang Date: Tue, 10 May 2022 20:47:22 +0800 Message-ID: Subject: Re: squashfs performance regression and readahea To: Xiongwei Song Cc: Matthew Wilcox , Zheng Liang , Phillip Lougher , Zhang Yi , Hou Tao , Miao Xie , Andrew Morton , Linus Torvalds , "Song, Xiongwei" , "linux-mm@kvack.org" , "squashfs-devel@lists.sourceforge.net" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=UJtXkzwK; spf=pass (imf17.hostedemail.com: domain of hsinyi@chromium.org designates 209.85.221.170 as permitted sender) smtp.mailfrom=hsinyi@chromium.org; dmarc=pass (policy=none) header.from=chromium.org X-Rspam-User: X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 71091400A3 X-Stat-Signature: m34xpythuybpcjx5mbnui5ajjfwbo5wr X-HE-Tag: 1652186851-472356 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, May 10, 2022 at 8:31 PM Xiongwei Song wrote: > > Hi Hsin-Yi, > > On Mon, May 9, 2022 at 10:29 PM Hsin-Yi Wang wrote: > > > > On Mon, May 9, 2022 at 9:21 PM Matthew Wilcox wro= te: > > > > > > On Mon, May 09, 2022 at 08:43:45PM +0800, Xiongwei Song wrote: > > > > Hi Hsin-Yi and Matthew, > > > > > > > > With the patch from the attachment on linux 5.10, ran the command a= s I > > > > mentioned earlier, > > > > got the results below: > > > > 1:40.65 (1m + 40.65s) > > > > 1:10.12 > > > > 1:11.10 > > > > 1:11.47 > > > > 1:11.59 > > > > 1:11.94 > > > > 1:11.86 > > > > 1:12.04 > > > > 1:12.21 > > > > 1:12.06 > > > > > > > > The performance has improved obviously, but compared to linux 4.18,= the > > > > performance is not so good. > > > > > > I think you shouldn't compare the performance with 4.18 directly, > > since there might be other factors that impact the performance. > > Make sense. > > >I'd suggest comparing the same kernel version with: > > a) with this patch > > b) with c1f6925e1091 ("mm: put readahead pages in cache earlier") rever= ted. > > With 9eec1d897139 ("squashfs: provide backing_dev_info in order to disabl= e > read-ahead") reverted and applied 0001-WIP-squashfs-implement-readahead.p= atch, > test result on linux 5.18=EF=BC=9A > 1:41.51 (1m + 41.51s) > 1:08.11 > 1:10.37 > 1:11.17 > 1:11.32 > 1:11.59 > 1:12.23 > 1:12.08 > 1:12.76 > 1:12.51 > > performance worse 1 ~ 2s than linux 5.18 vanilla. > Can you share the pack file you used for testing? Thanks > > > > According to https://lore.kernel.org/linux-mm/Ynfzh2ifG85MZEoN@casper.i= nfradead.org/t/ > > It seems to be a 3 sec difference? > > 5 ~ 6s difference. > > Regards, > Xiongwei > > > > > 1:37.16 (1m + 37.16s) > > 1:04.18 > > 1:05.28 > > 1:06.07 > > 1:06.31 > > 1:06.58 > > 1:06.80 > > 1:06.79 > > 1:06.95 > > 1:06.61 > > > > > > Moreover, I wanted to test on linux 5.18. But I think I should reve= rt > > > > 9eec1d897139 ("squashfs: provide backing_dev_info in order to disab= le > > > > read-ahead"), > > > > right? Otherwise, the patch doesn't work? > > > > > > I've never seen patch 9eec1d897139 before. If you're going to point > > > out bugs in my code, at least have the decency to cc me on it. It > > > should never have gone in, and should be reverted so the problem can > > > be fixed properly.