From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C62E4C43334 for ; Fri, 3 Jun 2022 14:55:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2A92D8D0001; Fri, 3 Jun 2022 10:55:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 255506B0072; Fri, 3 Jun 2022 10:55:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 11C558D0001; Fri, 3 Jun 2022 10:55:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 004376B0071 for ; Fri, 3 Jun 2022 10:55:28 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id C7CED34E2D for ; Fri, 3 Jun 2022 14:55:28 +0000 (UTC) X-FDA: 79537223136.24.4FA06FE Received: from mail-ej1-f48.google.com (mail-ej1-f48.google.com [209.85.218.48]) by imf04.hostedemail.com (Postfix) with ESMTP id 419E840029 for ; Fri, 3 Jun 2022 14:55:08 +0000 (UTC) Received: by mail-ej1-f48.google.com with SMTP id kq6so3408684ejb.11 for ; Fri, 03 Jun 2022 07:55:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=jti+/hClusDdX5mEjQ70q82JHacK1xdb+tp2pVFM1n8=; b=Fd9xTBcSvNG6BRqet4SbqmnC1o3LYHcv4CmibDdJ8jlBhCN89cgV6tGGevXEhJtNOM 2fmDmh7rlRG1bghvDHAveyYs6VAYgDIXgalaPpPAUrOFNuqUpIPeFs/oRlyMUJoDcSHX QpaFtonZHOmgcLiH8hJKm6wePMRLDdrliq3Nc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=jti+/hClusDdX5mEjQ70q82JHacK1xdb+tp2pVFM1n8=; b=FOT1uzlAzkRgAJJR9vEyyrwExho13LX4zWFyS5LIEtI0jApBb1dLQgxMa3wj2Ynbkx hKQj1INZWdWyj0r9Slobk94mAfzuR3Wi8VB5MvalUBBY8iQXA5bdd1FIXIFxcINJwwK3 COP0GwVNzZ6I8wXc0pq997JY5XZO6yoycCEcK7aSQDN3B7QUuIOUmf1vdxcFiEm9CQjM X1tmzQRsegRifzk5n6P5Sa0AI8hVEA87yiqTSQMOz7MCkSDGUT7mvWGb+J60LFsQF+X+ S7AjbtuTgt0nG8Q32blVcHYjHShvz6Y/gVXox/A7T+IivC4PCkvR2a1nk9CwqGUW2L/A PeQA== X-Gm-Message-State: AOAM532BvYyqW/sFz9FETbRmP9Zamcmv60tg4hoDfKCUJbi4RnojVph8 oxyo2SSKzLl+++Qz34LRdKoToEy865Ms7hFal2ApvQ== X-Google-Smtp-Source: ABdhPJxO8HK7gbiywtFok3ZbT24PxpO7hjRYRksLcHtuGaNcwI5NE2DPOLztaWmWayq8D4Inf84tbhgzpCYcD2wq8yw= X-Received: by 2002:a17:906:1b19:b0:70d:6fe8:eb44 with SMTP id o25-20020a1709061b1900b0070d6fe8eb44mr4340593ejg.129.1654268126818; Fri, 03 Jun 2022 07:55:26 -0700 (PDT) MIME-Version: 1.0 References: <20220601103922.1338320-1-hsinyi@chromium.org> <20220601103922.1338320-4-hsinyi@chromium.org> <90b228ea-1b0e-d2e8-62be-9ad5802dcce7@samsung.com> In-Reply-To: <90b228ea-1b0e-d2e8-62be-9ad5802dcce7@samsung.com> From: Hsin-Yi Wang Date: Fri, 3 Jun 2022 22:55:01 +0800 Message-ID: Subject: Re: [PATCH v4 3/3] squashfs: implement readahead To: Marek Szyprowski Cc: Matthew Wilcox , Phillip Lougher , Xiongwei Song , Zheng Liang , Zhang Yi , Hou Tao , Miao Xie , Andrew Morton , "linux-mm @ kvack . org" , "squashfs-devel @ lists . sourceforge . net" , linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=Fd9xTBcS; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf04.hostedemail.com: domain of hsinyi@chromium.org designates 209.85.218.48 as permitted sender) smtp.mailfrom=hsinyi@chromium.org X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 419E840029 X-Rspam-User: X-Stat-Signature: o5wqsp4t4xzqjoosci188o5gmp6m483e X-HE-Tag: 1654268108-434022 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jun 3, 2022 at 10:10 PM Marek Szyprowski wrote: > > Hi Matthew, > > On 03.06.2022 14:59, Matthew Wilcox wrote: > > On Fri, Jun 03, 2022 at 02:54:21PM +0200, Marek Szyprowski wrote: > >> On 01.06.2022 12:39, Hsin-Yi Wang wrote: > >>> Implement readahead callback for squashfs. It will read datablocks > >>> which cover pages in readahead request. For a few cases it will > >>> not mark page as uptodate, including: > >>> - file end is 0. > >>> - zero filled blocks. > >>> - current batch of pages isn't in the same datablock or not enough in a > >>> datablock. > >>> - decompressor error. > >>> Otherwise pages will be marked as uptodate. The unhandled pages will be > >>> updated by readpage later. > >>> > >>> Suggested-by: Matthew Wilcox > >>> Signed-off-by: Hsin-Yi Wang > >>> Reported-by: Matthew Wilcox > >>> Reported-by: Phillip Lougher > >>> Reported-by: Xiongwei Song > >>> --- > >> This patch landed recently in linux-next as commit 95f7a26191de > >> ("squashfs: implement readahead"). I've noticed that it causes serious > >> issues on my test systems (various ARM 32bit and 64bit based boards). > >> The easiest way to observe is udev timeout 'waiting for /dev to be fully > >> populated' and prolonged booting time. I'm using squashfs for deploying > >> kernel modules via initrd. Reverting aeefca9dfae7 & 95f7a26191deon on > >> top of the next-20220603 fixes the issue. > > How large are these files? Just a few kilobytes? > > Yes, they are small, most of them are smaller than 16KB, some about > 128KB and a few about 256KB. I've sent a detailed list in private mail. > Hi Marek, Are there any obvious squashfs errors in dmesg? Did you enable CONFIG_SQUASHFS_FILE_DIRECT or CONFIG_SQUASHFS_FILE_CACHE? Thanks > Best regards > -- > Marek Szyprowski, PhD > Samsung R&D Institute Poland >