From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43F07CCA47B for ; Mon, 13 Jun 2022 14:55:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CF0B78D0197; Mon, 13 Jun 2022 10:55:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C7BE68D0171; Mon, 13 Jun 2022 10:55:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A31A98D0197; Mon, 13 Jun 2022 10:55:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 824D78D0171 for ; Mon, 13 Jun 2022 10:55:41 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 57B37A21 for ; Mon, 13 Jun 2022 14:55:41 +0000 (UTC) X-FDA: 79573511682.26.68415F6 Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) by imf24.hostedemail.com (Postfix) with ESMTP id 0FFC7180165 for ; Mon, 13 Jun 2022 14:54:29 +0000 (UTC) Received: by mail-wr1-f43.google.com with SMTP id v14so7475176wra.5 for ; Mon, 13 Jun 2022 07:54:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=oz0TSHV6YibOu6tc/5orXXjHQ8MbMxUcncoqA4aXgsw=; b=n7JdFwECnhhUL1dLeSQ//ZJYsNONYjH51NPj+wkg/wrQ7bvBJRdyt8UrWsFim/C61O 96YUEqosV7TbGGXls0LrpNdpOaQskhlQoQYSw57/cTyQQorCQ/k9zYzof7BpsCqKfBU3 g5ZXP/ZXGEK+WCUOTl7e3G7UtklbBZIWme6Z0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=oz0TSHV6YibOu6tc/5orXXjHQ8MbMxUcncoqA4aXgsw=; b=IlGBeIyZJadPbAzK3nM13jrNGhY75BctCodwq9eEAk3YcJ/KaUbLzRLCYFMb0ttfGS GXwTT7jILHY4EZln7ESzhbopCGjaevHsP2B9BzPijarFs0SrwR2kl5XICavlhPJeFCye uaJhbcNTz1zRvBH92906ThuPtNTShI5jq2204rZy/IjWFx28aKFTDe2keAjBLkPOb1IB 6mE4yADZBLrVqi56FhPGEKRMo+l9QI9wEiz3iDd/+TkrIvj0JrHEoP7rfyKAF8sTl4Y+ Yys4eY1C2UQAYJvzEni2OogqyN0DTatHzO4oh06VU94fCoaZM6bpgAmOZLBqqjr+BFeu hJkw== X-Gm-Message-State: AJIora+K2D55yt7Ld0cIdvD9SSeVuQUPXttBrkSCK9LiWepvwFr3cA4h tSk2jK02wCVBbSgjQkEzq6LAFafII1RBZfbmexSXy+8GqzBkdw== X-Google-Smtp-Source: ABdhPJyvmkSgw072UHRnxND0KgUWRAzqc9nZk+izs23tKS/t6KazemOaZFtDajiE/juzKvXO8q+b2oLKjsmpxv6p55s= X-Received: by 2002:a17:906:c347:b0:718:ca61:e7b7 with SMTP id ci7-20020a170906c34700b00718ca61e7b7mr3050168ejb.746.1655127959979; Mon, 13 Jun 2022 06:45:59 -0700 (PDT) MIME-Version: 1.0 References: <20220601103922.1338320-1-hsinyi@chromium.org> <20220601103922.1338320-4-hsinyi@chromium.org> <31ed17e7-29d1-55e8-cb09-a750ab80da15@squashfs.org.uk> <701bee9a-a06d-8b1a-bf23-d893249c7764@samsung.com> In-Reply-To: <701bee9a-a06d-8b1a-bf23-d893249c7764@samsung.com> From: Hsin-Yi Wang Date: Mon, 13 Jun 2022 21:45:34 +0800 Message-ID: Subject: Re: [PATCH v4 3/3] squashfs: implement readahead To: Marek Szyprowski Cc: Phillip Lougher , Matthew Wilcox , Xiongwei Song , Zheng Liang , Zhang Yi , Hou Tao , Miao Xie , Andrew Morton , "linux-mm @ kvack . org" , "squashfs-devel @ lists . sourceforge . net" , linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1655132070; a=rsa-sha256; cv=none; b=ny3hEqzjlJVFbs/jerhtO8HY0ELPC7Nmbh5/xM3YUSV4Z3t27pNzLs+X7IDG+pA8aEbtbj tWpK3Szc5+fhSrj9M9QpVDfAxZe48SahWNm2eeli9xpBZiJxvy1ls9IEEwb+C3fG9TPLqo vtiSWMZW3pA9ey5W/hPv0TFx/YC5pqc= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=n7JdFwEC; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf24.hostedemail.com: domain of hsinyi@chromium.org designates 209.85.221.43 as permitted sender) smtp.mailfrom=hsinyi@chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1655132070; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=oz0TSHV6YibOu6tc/5orXXjHQ8MbMxUcncoqA4aXgsw=; b=HQCgXfstUyrOZ3WlKUWYT8yI6KhaKVnlanYIV1mZ8b8u7UA8dsDMevz3o3kf2SXEbOVs6j t3BoYBXmXtgT5LJPLEfladOcW/lvqyGvocrFns/dOXMgrSqnRqplIxmn/mldsiWFTA8l2n TwHGzILejWqwhS813A4T5DGs8kk3j34= X-Rspam-User: Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=n7JdFwEC; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf24.hostedemail.com: domain of hsinyi@chromium.org designates 209.85.221.43 as permitted sender) smtp.mailfrom=hsinyi@chromium.org X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 0FFC7180165 X-Stat-Signature: p964qjksmmd9snjc6ywss8he3f5hg4fg X-HE-Tag: 1655132069-494538 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jun 13, 2022 at 8:08 PM Marek Szyprowski wrote: > > Hi Phillip, > > On 07.06.2022 09:35, Phillip Lougher wrote: > > On 03/06/2022 13:54, Marek Szyprowski wrote: > >> Hi, > >> > >> On 01.06.2022 12:39, Hsin-Yi Wang wrote: > >>> Implement readahead callback for squashfs. It will read datablocks > >>> which cover pages in readahead request. For a few cases it will > >>> not mark page as uptodate, including: > >>> - file end is 0. > >>> - zero filled blocks. > >>> - current batch of pages isn't in the same datablock or not enough in a > >>> datablock. > >>> - decompressor error. > >>> Otherwise pages will be marked as uptodate. The unhandled pages will be > >>> updated by readpage later. > >>> > >>> Suggested-by: Matthew Wilcox > >>> Signed-off-by: Hsin-Yi Wang > >>> Reported-by: Matthew Wilcox > >>> Reported-by: Phillip Lougher > >>> Reported-by: Xiongwei Song > >>> --- > >> > >> This patch landed recently in linux-next as commit 95f7a26191de > >> ("squashfs: implement readahead"). I've noticed that it causes serious > >> issues on my test systems (various ARM 32bit and 64bit based boards). > >> The easiest way to observe is udev timeout 'waiting for /dev to be fully > >> populated' and prolonged booting time. I'm using squashfs for deploying > >> kernel modules via initrd. Reverting aeefca9dfae7 & 95f7a26191deon on > >> top of the next-20220603 fixes the issue. > >> > >> Let me know how I can help debugging this issue. There is no hurry > >> though, because the next week I will be on holidays. > > > > Hi Marek, > > > > Can you supply an example Squashfs filesystem and script that > > reproduces the slow-down? Failing that, can you supply a copy > > of your initrd/root-filesystem that can be run under emulation > > to reproduce the issue? (I don't have any modern ARM embedded > > systems). > > > > Again failing that, are you happy to test some debug code? > > > > Thanks > > > > Phillip (Squashfs maintainer and author). > > I've just got back from my holidays. > > Is this still relevant? I've noticed that v6 has been posted, but I > failed to apply it on top of next-20220610 as mentioned in the > cover-letter to test. I've also tried also to apply the mentioned > 'Squashfs: handle missing pages decompressing into page cache' patchset. > On the other hand, next-20220610 seems to be working fine on my setup now. > hi Marek, next-20220610 contains v5 of the series. To apply v6, you need to revert ca1505bf4805 ("squashfs: implement readahead") and 9d58b94aa73a ("squashfs: always build "file direct" version of page actor") first, then apply 'Squashfs: handle missing pages decompressing into page cache' patchset, then finally apply v6, since v6 is dependent on the patchset. Thanks. > > Best regards > -- > Marek Szyprowski, PhD > Samsung R&D Institute Poland >