From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21A44C433EF for ; Mon, 16 May 2022 10:47:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9C7D96B0072; Mon, 16 May 2022 06:47:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 977F26B0073; Mon, 16 May 2022 06:47:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 83E6B6B0075; Mon, 16 May 2022 06:47:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 707A96B0072 for ; Mon, 16 May 2022 06:47:29 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 4B57333A3C for ; Mon, 16 May 2022 10:47:29 +0000 (UTC) X-FDA: 79471279818.21.CDB57E8 Received: from mail-vk1-f175.google.com (mail-vk1-f175.google.com [209.85.221.175]) by imf10.hostedemail.com (Postfix) with ESMTP id 25633C00A8 for ; Mon, 16 May 2022 10:47:01 +0000 (UTC) Received: by mail-vk1-f175.google.com with SMTP id q136so7272032vke.10 for ; Mon, 16 May 2022 03:47:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=cyzBmAuy85hTG407fSwXszxBhDeY0JEI9Vsim/drlp0=; b=fYHp5Ibgf6MU75g8M8dbc1iSHzvS5K4/hMPc3yTsfMlxDqqNFVmGAcoDLdOXY1uZhe kxXLoaC7sVNiyhGnqUUD2FPW4gu/Yr0Y4tvBzGtbxoBJiAr0NwSXfatjNeQaTMUYNbCF u9IV+SW0L+bO2nvFYGIzQla+Mqp+mz/O9Wa8o= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=cyzBmAuy85hTG407fSwXszxBhDeY0JEI9Vsim/drlp0=; b=TV6RdSw1DG5OC7JnEqGzKXroCTbwM7IpdNUXXIlGl2r2XQ7iTtYjXMSf+ZhqrUDsJb Am4cIjgVt7NLHwLeI0b4uI2UzFp9WHm5eSZ6p5HhhfTLq2vABe3X9v9mKMIQo2802VVQ Vcybw/KR3TtE64gYoCr2ZdYDCn9pFGHYTt60276po1dtq8owgeBU3HOkVpDgTjsx9hUT jQkiloomuIAn4etKz+XrMYdFIvu7obfbIwnaZg4M1T1rtYqDYS4KpQXcBoKC3z8uHHKQ Y13mYCSrH6Yl6D5fsGgM7i6KSENlWX+0ZzXQ09RAA96tM3zC9oaV9/DZMv3DjGQMDCTD qDng== X-Gm-Message-State: AOAM533c/CPsojqoI+WKG3b/MSzThmKeLWV0b9bBV12nHebTCVZNwglc twz2SnUFBtvB931KT3QJ7WZKinOGAmMjbfiqXRy9+A== X-Google-Smtp-Source: ABdhPJw30mOuCBmzAFwBccM5ilcLCgr57LGu0Vj+MV2y0pvq4kJocvrhJbs9ahsylTcg8yw7LbLYezAiyeApW8mi718= X-Received: by 2002:a05:6122:da8:b0:331:3b30:8b40 with SMTP id bc40-20020a0561220da800b003313b308b40mr5718489vkb.30.1652698048140; Mon, 16 May 2022 03:47:28 -0700 (PDT) MIME-Version: 1.0 References: <20220516104209.1407388-1-hsinyi@chromium.org> In-Reply-To: <20220516104209.1407388-1-hsinyi@chromium.org> From: Hsin-Yi Wang Date: Mon, 16 May 2022 18:47:02 +0800 Message-ID: Subject: Re: [PATCH 0/3] Implement readahead for squashfs To: Phillip Lougher , Matthew Wilcox , Xiongwei Song Cc: Zheng Liang , Zhang Yi , Hou Tao , Miao Xie , Andrew Morton , "linux-mm @ kvack . org" , "squashfs-devel @ lists . sourceforge . net" , linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 25633C00A8 X-Stat-Signature: 91seho9fbsqxt5gzg5ning9sbp9o46ry Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=fYHp5Ibg; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf10.hostedemail.com: domain of hsinyi@chromium.org designates 209.85.221.175 as permitted sender) smtp.mailfrom=hsinyi@chromium.org X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1652698021-256729 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, May 16, 2022 at 6:42 PM Hsin-Yi Wang wrote: > > Commit c1f6925e1091("mm: put readahead pages in cache earlier") requires > fs to implement readahead callback. Otherwise there will be a > performance regression. > > Commit 9eec1d897139("squashfs: provide backing_dev_info in order to > disable read-ahead") mitigates the performance drop issue for squashfs > by closing readahead for it. > > This series implements readahead callback for squashfs. The previous > discussion are in [1] and [2]. > > [1] https://lore.kernel.org/all/CAJMQK-g9G6KQmH-V=BRGX0swZji9Wxe_2c7ht-MMAapdFy2pXw@mail.gmail.com/T/ > [2] https://lore.kernel.org/linux-mm/Yn5Yij9pRPCzDozt@casper.infradead.org/t/#m4af4473b94f98a4996cb11756b633a07e5e059d1 > > Hsin-Yi Wang (3): > Revert "squashfs: Convert squashfs to read_folio" > Revert "squashfs: provide backing_dev_info in order to disable > read-ahead" > squashfs: implement readahead > > fs/squashfs/file.c | 82 +++++++++++++++++++++++++++++++++++++++++-- > fs/squashfs/super.c | 33 ----------------- > fs/squashfs/symlink.c | 5 ++- > 3 files changed, 81 insertions(+), 39 deletions(-) > > -- > 2.36.0.550.gb090851708-goog > hi, please ignore this for now. I'll resend a correct cover letter.