From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81A90C433F5 for ; Thu, 19 May 2022 07:56:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B14186B0072; Thu, 19 May 2022 03:56:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AC39F6B0073; Thu, 19 May 2022 03:56:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 98BCF6B0074; Thu, 19 May 2022 03:56:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 8A6CB6B0072 for ; Thu, 19 May 2022 03:56:35 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay13.hostedemail.com (Postfix) with ESMTP id 57638608E5 for ; Thu, 19 May 2022 07:56:35 +0000 (UTC) X-FDA: 79481735550.05.38FD7CC Received: from mail-ua1-f52.google.com (mail-ua1-f52.google.com [209.85.222.52]) by imf11.hostedemail.com (Postfix) with ESMTP id 96567400D7 for ; Thu, 19 May 2022 07:56:28 +0000 (UTC) Received: by mail-ua1-f52.google.com with SMTP id x11so1715012uao.2 for ; Thu, 19 May 2022 00:56:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=/sVrKXlJiB/91I00QzAeuxvXVjT/UwmC0od05LnN4Ac=; b=AC38FJV1YuWB/BkOesEaJHr3dzZ7Q+idSrisH07SMypwxIVbFNgVBSAdRRwR3tLqyk qfwgle2EbFIcdL92L8m3UrgASGG3WjWvXdWGzUO6PmhiMO7x/iJjuIekVu9gHlvVMtze 7TzqphYNHEBRTsUOi381kY0v85l/9awSZo/BE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=/sVrKXlJiB/91I00QzAeuxvXVjT/UwmC0od05LnN4Ac=; b=tC8e4Io67F9yimZVjV4hEZ05QgGdIcKNDKY9jMhzuhddNUOg/JzGcsE2qeu8z0mTD1 Gz3lUxxsNFr0OpIKQfLCFyI3Lc8hx7oaU0V4oYH26Cz2mL2CoRmIg1+/LdwhBhn6r2YS cnim0SYUCuRDB1oVmWkO1mTWtFTKVthIhM/NTqyVtak2v/voUZrQXKmJrw8Q71wExAdq u2CRimrsL6PapLeHna6RcD7FnYrwn6joRhw70FjYgVivloQhxlXgSl42KPb70UWhKfrQ XC2we17mrK1tcb5Us1TGbH8FZ87IJ2Qr+XHBHdC1KxvM2JB3CQsR67DQ1fkaShKJrL+J B9FA== X-Gm-Message-State: AOAM531R7moH26PVOvXqW7UchXPBS4KOa7xVeGQJUSunV+1wrT0jzzYq Bcs3UwoPG5nj/My6vmbFvwch0gkBZ6nzkfg8tRNYYg== X-Google-Smtp-Source: ABdhPJz4i7Oj3ex34dYsu4NsY1yNrvFQpe/Im0zienEazrsD4IFDnDjBf6pQTr/ySGIEDvbCJM5cQGeaV207VRGixJw= X-Received: by 2002:ab0:3492:0:b0:368:b577:bfd with SMTP id c18-20020ab03492000000b00368b5770bfdmr1449813uar.110.1652946993961; Thu, 19 May 2022 00:56:33 -0700 (PDT) MIME-Version: 1.0 References: <20220517082650.2005840-1-hsinyi@chromium.org> <20220517082650.2005840-4-hsinyi@chromium.org> In-Reply-To: From: Hsin-Yi Wang Date: Thu, 19 May 2022 15:56:08 +0800 Message-ID: Subject: Re: [PATCH v2 3/3] squashfs: implement readahead To: Xiongwei Song Cc: Phillip Lougher , Matthew Wilcox , Xiongwei Song , Zheng Liang , Zhang Yi , Hou Tao , Miao Xie , Andrew Morton , "linux-mm @ kvack . org" , "squashfs-devel @ lists . sourceforge . net" , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 96567400D7 X-Stat-Signature: c4jua6htxfcdrtcce1g7ap7xrzbq6gem X-Rspam-User: Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=AC38FJV1; spf=pass (imf11.hostedemail.com: domain of hsinyi@chromium.org designates 209.85.222.52 as permitted sender) smtp.mailfrom=hsinyi@chromium.org; dmarc=pass (policy=none) header.from=chromium.org X-Rspamd-Server: rspam09 X-HE-Tag: 1652946988-416630 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, May 17, 2022 at 5:17 PM Xiongwei Song wrote: > > On Tue, May 17, 2022 at 4:28 PM Hsin-Yi Wang wrote: > > > > Implement readahead callback for squashfs. It will read datablocks > > which cover pages in readahead request. For a few cases it will > > not mark page as uptodate, including: > > - file end is 0. > > - zero filled blocks. > > - current batch of pages isn't in the same datablock or not enough in a > > datablock. > > Otherwise pages will be marked as uptodate. The unhandled pages will be > > updated by readpage later. > > > > Suggested-by: Matthew Wilcox > > Signed-off-by: Hsin-Yi Wang > > Reported-by: Matthew Wilcox > > Reported-by: Phillip Lougher > > Reported-by: Xiongwei Song > > "xiongwei.song@windriver.com" too. > ack.