From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C80DC433F5 for ; Wed, 5 Oct 2022 17:33:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 04B386B0072; Wed, 5 Oct 2022 13:33:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F3D576B0073; Wed, 5 Oct 2022 13:33:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DDD5B6B0074; Wed, 5 Oct 2022 13:33:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id C74416B0072 for ; Wed, 5 Oct 2022 13:33:04 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 77DCE80F92 for ; Wed, 5 Oct 2022 17:33:04 +0000 (UTC) X-FDA: 79987591488.24.10F0A84 Received: from mail-lj1-f177.google.com (mail-lj1-f177.google.com [209.85.208.177]) by imf11.hostedemail.com (Postfix) with ESMTP id 04CFE40017 for ; Wed, 5 Oct 2022 17:33:03 +0000 (UTC) Received: by mail-lj1-f177.google.com with SMTP id bn8so6068042ljb.6 for ; Wed, 05 Oct 2022 10:33:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=zF8ApOxTSxGt6c09yLSFGtRLqEmB/dPLWQduCaYYtw8=; b=evq0KrIxDPo8NwkEl8xTIcAGxRhwLUGvnQcNERuM6PX+rf3Q40SvNGxSvBpXhTL+QM Syv8vm1KgNE40cCsBB4Xa3fUrZSsQ2CMPD1f8Fy4FWFJizY4zDYwDj+anvXjpbaeDL+T H5HM66JWD+V9cgRK2j9fGPcUtEJKVJY6PPvXOYfEDDUQUAyOiIiWM9EATrkwAjnebYWk lw78+b56KNzyq9ClmThD2Cx9wgVY0GGS8NC/VdlUmqE9yQHQxaeRHNWNrAFQTy+QYUNe S23I1FYxXfVewDWXKPkpam/syFwFl9H1Swbse+aP02S/9NuGy/1TLvIg//qcyjwFDy1G RB1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=zF8ApOxTSxGt6c09yLSFGtRLqEmB/dPLWQduCaYYtw8=; b=U7Src1xb8cn5jNJjm0jnfTllWGr1GzBR0ztgLmxZcxgSwF5BOl2bmadcXQZDSnZ3pE r83Cdy8n5QzDhGUZCeUaYB/VNL5/v0AxAUYO0atHq0WNGSLwSwqA29zUIeVs0pGgyQMn oU20auknSyDMs0Wd1D3bAyYMmzyaRnbWQE9FLfeeUQsWKsk5R+MHl4dXm+jh3MDxCwcE p2yaNw/hBOtwNofzW9eYzIo5HcQ8bQTGI27+xZ96/jZgEHicOopX314BxyWE357koVXz 8AVEKIxgw/VMKcyAl5bvBCQJknAZcYYzSXjFmd3Ru4sucXgV4SgsdLWsNiGSRX+VIJcQ Uoug== X-Gm-Message-State: ACrzQf0nAUvqhyvJhlg+6m7/jqkT8CV6gee/WWa6pscqk+RuDyZeNRNC kwpAjSz6eAVXsAleeSQ8UHoZuRu0wnUnCpD06LPZ7w== X-Google-Smtp-Source: AMsMyM7OAFeL/ZAlYBOIc4JpSBfZ6QMJZquGE48eaDQsMjnAOqI2aWL8JxgUlyfgLW4mWzc5HU2BSjJO3nFDz+b7gkI= X-Received: by 2002:a2e:bd0b:0:b0:26d:ffdc:120f with SMTP id n11-20020a2ebd0b000000b0026dffdc120fmr261097ljq.526.1664991182182; Wed, 05 Oct 2022 10:33:02 -0700 (PDT) MIME-Version: 1.0 References: <20221004214125.120993-1-peterx@redhat.com> <20221004214125.120993-2-peterx@redhat.com> In-Reply-To: From: Axel Rasmussen Date: Wed, 5 Oct 2022 10:32:25 -0700 Message-ID: Subject: Re: [PATCH 1/4] selftests/vm: Use memfd for hugetlb tests To: Peter Xu Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , Mike Kravetz Content-Type: text/plain; charset="UTF-8" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1664991184; a=rsa-sha256; cv=none; b=BYgTwbxSaT3FYQTduaka5PJDxD/mZCZEYIcvUXUT4wcrh8ttB/mJxxl7FRmjAInpvn4W6Z e9FB8KxLFz5jKnoTvZowWBFIW+gELTb4YZpz/GMeRbavgI9p637FLneVxTkREiLlhhbeTB Vn7UGP72vaul8yVNu379t9KSP376Tac= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=evq0KrIx; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf11.hostedemail.com: domain of axelrasmussen@google.com designates 209.85.208.177 as permitted sender) smtp.mailfrom=axelrasmussen@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1664991184; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=zF8ApOxTSxGt6c09yLSFGtRLqEmB/dPLWQduCaYYtw8=; b=1m9WVOBEnp3Np12/+eMrM21LMhCHoyQhc2QAGp5JYKB2XvpC8HKuEkbGpW5tdAnJUF/jl4 yPpZKo03eEs3QvpB2kxi1QlLIx5406az9VTkPBeTGSG8gjWvNeitzi9tAuJJvVyI+k4+NT JWPKOWKjeIsTmNo9bUwM4+oICZkEJ8c= Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=evq0KrIx; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf11.hostedemail.com: domain of axelrasmussen@google.com designates 209.85.208.177 as permitted sender) smtp.mailfrom=axelrasmussen@google.com X-Rspam-User: X-Stat-Signature: 3c8znpwnoshrautur53618cb6u5dfdqm X-Rspamd-Queue-Id: 04CFE40017 X-Rspamd-Server: rspam03 X-HE-Tag: 1664991183-959870 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000225, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Oct 5, 2022 at 7:44 AM Peter Xu wrote: > > On Tue, Oct 04, 2022 at 03:04:23PM -0700, Axel Rasmussen wrote: > > We should also update the examples / help text near the top of the > > file, since we're changing what arguments this accepts. > > Definitely, I missed that. > > > > > It might also be better to squash the changes to test arguments in > > run_vmtests.sh into each patch, so if we're bisecting we'll have a > > matching / working test + run_vmtests.sh combo at each commit. > > I can do that, but may not be required - note that I did the first three > patches just to make sure they're still compatible with the old cmdlines, > by ignoring the extra params. Ah! In that case, forget it. :) > > [...] > > > This is a nice simplification! Thanks for doing it. Besides the > > comments above, the rest of the code here looks correct to me. Feel > > free to take: > > > > Reviewed-by: Axel Rasmussen > > Thanks! > > -- > Peter Xu >