From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BDD2EC433EF for ; Mon, 18 Jul 2022 18:07:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2CC486B0072; Mon, 18 Jul 2022 14:07:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 256106B0073; Mon, 18 Jul 2022 14:07:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0F8816B0074; Mon, 18 Jul 2022 14:07:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id F10256B0072 for ; Mon, 18 Jul 2022 14:07:58 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id BFCE9A0D for ; Mon, 18 Jul 2022 18:07:58 +0000 (UTC) X-FDA: 79701004236.14.62F81E3 Received: from mail-io1-f54.google.com (mail-io1-f54.google.com [209.85.166.54]) by imf24.hostedemail.com (Postfix) with ESMTP id 6BD3018008A for ; Mon, 18 Jul 2022 18:07:58 +0000 (UTC) Received: by mail-io1-f54.google.com with SMTP id p81so9949910iod.2 for ; Mon, 18 Jul 2022 11:07:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=KTCpJmC4pecTn3Rx1irJxkC3X2lBUkxseTUJWSLvFWo=; b=FXckv+DCJB3SLoCnbb5nkk2+lua/3016I0o2hoZdhYIwogZteGz2j1/S0kClXLkGaA XEaMc4YFH8vBGsIHViFRKEPRvezi9A+36iEHQn/gKJrNJDYBoJb1V8NQgL0pbzvGeVy5 2j9Tj3TeWNkXp+8Ou8QcHvU0VPcUDxfzNQAbDOj4PBmFgFWAZGOs2aQfVuRzQF0JtYzf wMepw9N4kGJK2rI5D9nHwfQHqrIT4bVaCEsfSJSAItl+KyP28Rpt9p3tJ2sJ+vxrE9vH pGkCiQBXaWINuwWCw41VJOj2TrmzXAl2xvyDAknWlF1DV0iSkOEdSomuueMKNV5iOOyc KOVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=KTCpJmC4pecTn3Rx1irJxkC3X2lBUkxseTUJWSLvFWo=; b=oCL8YTPmXl6g7B2SGHaXnMBSs6VpJ0H5L+mN5aiW2ZqhX/KVMU48wSGrzTf+cXfOz0 6Tzq9hNdP+d/uC/WUxbeLa8TfJJaoZTBguX1XlHSwV70YyA2f7CYMG57GXIXIydFsJ/Y qBS/ve2vjuyOI6iK+czPYkd09C/v010i1x4sqRm4dwCXa0Uno1NB1PcsHD91wqsIjH9i MaWSGnxUrqBN4F/qC1RujFFI0TfKybekgGFlVWm4HE/tqQK41M1zgf/NT3hY6e1sC1jZ et48bgZ5wT1cWa7GKMlYNSz02DT2Mh384M+gQ+zeBG4FA0T9sOTxLtFbwmy97i8aE/Xw 3QDg== X-Gm-Message-State: AJIora90LlnDw/Fm1gdCr9SRCXjz80R3L2FyBY4/NYZ5hZu6IaAtiI8i hQwNj8Ep46QP+PFoD4ZePHdg1n9KRrvJE3qETIoxdA== X-Google-Smtp-Source: AGRyM1sTup4B+a2XbBmpCjJcMLtlqKrEXWZNvm193+nbm66d2mxBG5Tp8/CncXpoJPLMeUbCZoRZ5z2YN8ywGEs7WBM= X-Received: by 2002:a05:6638:50:b0:33f:17b9:be63 with SMTP id a16-20020a056638005000b0033f17b9be63mr15969485jap.92.1658167677547; Mon, 18 Jul 2022 11:07:57 -0700 (PDT) MIME-Version: 1.0 References: <20220712130542.18836-1-linmiaohe@huawei.com> <20220713102357.8328614813db01b569650ffd@linux-foundation.org> <20220716160629.d065828c84ad2423c10f7733@linux-foundation.org> <0dcf8902-b14a-860a-cb66-46e57b6d14a9@huawei.com> In-Reply-To: <0dcf8902-b14a-860a-cb66-46e57b6d14a9@huawei.com> From: Axel Rasmussen Date: Mon, 18 Jul 2022 11:07:21 -0700 Message-ID: Subject: Re: [PATCH] mm/hugetlb: avoid corrupting page->mapping in hugetlb_mcopy_atomic_pte To: Miaohe Lin Cc: Andrew Morton , Peter Xu , Mike Kravetz , Muchun Song , Linux MM , LKML Content-Type: text/plain; charset="UTF-8" ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=FXckv+DC; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf24.hostedemail.com: domain of axelrasmussen@google.com designates 209.85.166.54 as permitted sender) smtp.mailfrom=axelrasmussen@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1658167678; a=rsa-sha256; cv=none; b=ZVDTc0b2mFbQsS3clb4+h4K15V/k0ZE3GL6TfI8/DfTkgwD41RHzX8NzC96o8pxwGzHky8 C+KAPyUxMPrYBiJm0105dD264EGhShzWnhZJfD77YZ7EAbr+xMvp4tR4e4pSjgsYqqbdaF 7RlyVgWcSUJ0sLcUD/vm/hosqaA0kbg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1658167678; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=KTCpJmC4pecTn3Rx1irJxkC3X2lBUkxseTUJWSLvFWo=; b=kOAK9uIcQXitgHMJrfSLAD7NBzkYzT0M1XcO4oOetiHEllJRuxb+/MzIbKa2YnYB+jWZLn QSKXMYylF4DfESOyH6+B7m5eY162qbiv6BZFDhtcym36jx7k3PLo8ad4Lz/7c6bn15FhMr XbllPzymisH/DUa3ARVZ/GpUUqrTDhs= Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=FXckv+DC; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf24.hostedemail.com: domain of axelrasmussen@google.com designates 209.85.166.54 as permitted sender) smtp.mailfrom=axelrasmussen@google.com X-Rspam-User: X-Stat-Signature: w5f615tu1dd4fmc9renzja9hta9k9hzz X-Rspamd-Queue-Id: 6BD3018008A X-Rspamd-Server: rspam03 X-HE-Tag: 1658167678-991302 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Jul 17, 2022 at 7:25 PM Miaohe Lin wrote: > > On 2022/7/17 7:06, Andrew Morton wrote: > > On Thu, 14 Jul 2022 17:59:53 +0800 Miaohe Lin wrote: > > > >> On 2022/7/14 1:23, Andrew Morton wrote: > >>> On Tue, 12 Jul 2022 21:05:42 +0800 Miaohe Lin wrote: > >>> > >>>> In MCOPY_ATOMIC_CONTINUE case with a non-shared VMA, pages in the page > >>>> cache are installed in the ptes. But hugepage_add_new_anon_rmap is called > >>>> for them mistakenly because they're not vm_shared. This will corrupt the > >>>> page->mapping used by page cache code. > >>> > >>> Well that sounds bad. And theories on why this has gone unnoticed for > >>> over a year? I assume this doesn't have coverage in our selftests? > >> > >> As discussed in another thread, when minor fault handling is proposed, only > >> VM_SHARED vma is expected to be supported > > > > So... do we feel that this fix should be backported? And if so, is > > there a suitable commit for the Fixes:? > > I tend to backport this fix. And I think the Fixes tag in this patch should be suitable, > i.e. Fixes: f619147104c8 ("userfaultfd: add UFFDIO_CONTINUE ioctl"). Agreed, it is worth backporting. > > Thanks. > > > . > > >