From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7EBF3CDB474 for ; Tue, 17 Oct 2023 22:14:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D46958D0012; Tue, 17 Oct 2023 18:14:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CF6028D0005; Tue, 17 Oct 2023 18:14:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BBE7F8D0012; Tue, 17 Oct 2023 18:14:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id A8D258D0005 for ; Tue, 17 Oct 2023 18:14:54 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 8CD31120EFF for ; Tue, 17 Oct 2023 22:14:54 +0000 (UTC) X-FDA: 81356359308.11.182A537 Received: from mail-ej1-f54.google.com (mail-ej1-f54.google.com [209.85.218.54]) by imf02.hostedemail.com (Postfix) with ESMTP id B1F0C80017 for ; Tue, 17 Oct 2023 22:14:52 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=a09zEevL; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf02.hostedemail.com: domain of axelrasmussen@google.com designates 209.85.218.54 as permitted sender) smtp.mailfrom=axelrasmussen@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1697580892; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=22eF3O2TV81lbDaOLeeipX0IchRIXInorQwN4073ktY=; b=ClFKouIhUd50W39Z2iUQ4FhHyif76ZxHBANmDjh88LTvS7dv6h3Ceoqn4svu4u0KlNZAxA E/sBjyShGhp1mUAVynLnWSqmxvnHqE4Q6Cw7NkCIYbhrOBtYxq7HIPPKeBFmt1yJl4BH3e 28HsnopmqonLa2R6ohcPoWANRElFzdM= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=a09zEevL; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf02.hostedemail.com: domain of axelrasmussen@google.com designates 209.85.218.54 as permitted sender) smtp.mailfrom=axelrasmussen@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1697580892; a=rsa-sha256; cv=none; b=qfxa7rrX43gyCCksvtKKJFdJPPcCG2bkMbSAuLJhyuGkXMN0t43tCAfOhj8Ss/5DpLXA3d ugWUaTrwpwykJltDB+w8aFvsX+ORNL96xLuPZd8cE1jdDxVuAgeHGxj3hQKSRKgZdBB1qw b4yNwUFw5NVOlzF9Z64QGf82f432tkk= Received: by mail-ej1-f54.google.com with SMTP id a640c23a62f3a-99357737980so1014854266b.2 for ; Tue, 17 Oct 2023 15:14:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1697580891; x=1698185691; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=22eF3O2TV81lbDaOLeeipX0IchRIXInorQwN4073ktY=; b=a09zEevLK6jI/gf0ST7f5QBUcwbSS9A1xGK3XkdTMwGOsXGXFQm8yXNWYqBN6F4IDS d/oAS2P5qZ5GlWq4BimZ9sOPSFikHIfZXkeQL2i7yggSUBXVX1R82Zz6MNxgWod6oEI5 CjyAskDkc4+fzlQlP2g08CMmFF+oPZTShPIQtD2Kn3Ec73POEC3BKB0x5fYV9Il1xzrj 4nbuDqNb3+ELnGxCF3Gd6/Lg2H2NuCGfBiWgX+XRYQO4X9ge7plkVOb6Uu44XueLkRrD ppV2pFEcFclDsuC8zB5w+4DX4EVtGiTPzzNvnMj+KFL9kRp8GhyJ3MuXtXkuCwx3EyIk zt1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697580891; x=1698185691; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=22eF3O2TV81lbDaOLeeipX0IchRIXInorQwN4073ktY=; b=FLzs+3E5JFgzLYvjOoW5t+AWaX4NSgNiboJWW1nchck3AYkodSGP54y5JyNNGTFfvk SYDpwH1nGZNPp7LGemmzbTzv+qzTVfHklPsf3nWA2BxI4GfoW+9150E5QbhJBbI03VVX OzgKho7qpj0XJH7iJ9IODbK6MplwVNdxN6rWdX8v8vVEkRi3X7l4zO7C0dU+hMzypinj bg5MUUz3XulNZzkaL3clpKM0HuXtojUrBSKPVOaYCPDPSM6Tm3+FO1yvzjy6BolpL24c toS6TG54kfGXwq/j8X6zcLwyh0tcMFZBLF2/cdOQbWCnsstAMAeBFGWA2zsy4QJlzSCf T14Q== X-Gm-Message-State: AOJu0YzXJF9qIj2/lat2Oo8YufhHWMgx/kujA539/cIKnhJlUUM28o73 OVu3IY0YbuiEWqoktH87WcNp3cd7tWMERCM0TRZ7TQ== X-Google-Smtp-Source: AGHT+IG+XmqggKBq5nwPvXK6m2hCydWFbDeVYOhBwPQFOK1zKkDPFI+mPRGPCEEOINmjQKitWoKVYkXAmGAMLNuQh5k= X-Received: by 2002:a17:907:2688:b0:9c5:2806:72e2 with SMTP id bn8-20020a170907268800b009c5280672e2mr2457377ejc.34.1697580891048; Tue, 17 Oct 2023 15:14:51 -0700 (PDT) MIME-Version: 1.0 References: <20231003194547.2237424-1-axelrasmussen@google.com> <20231003194547.2237424-5-axelrasmussen@google.com> In-Reply-To: From: Axel Rasmussen Date: Tue, 17 Oct 2023 15:14:13 -0700 Message-ID: Subject: Re: [PATCH v2 4/5] ioctl_userfaultfd.2: fix / update UFFDIO_REGISTER error code list To: Alejandro Colomar Cc: Guillem Jover , Peter Xu , linux-man@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Mike Rapoport Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: B1F0C80017 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: xapxkna6xo6p1c4rowa9fgdhhmm5nfe1 X-HE-Tag: 1697580892-686314 X-HE-Meta: U2FsdGVkX1/KOJJI4xwlu1G58XbybKbiyAA5aaX+ObDriqrkZYI+7PwETQKluPt3jIXJkRmCOS1ZHt+yalCel4b2/sOBi0UHGV9VrWVqn81g1YMHMjMJ4YwZoCp1TGyZYvlzHXLGGaZzUuTf8g+dMpwoDRWo41JEZ6OnhietT9Fb0Y7mdaHIjLInBwUbiXiYPoo347OiQ0IzNB3pigvy4trpcMgRTWhwCqIfYuexyeDFwpvLDiXHuwiiJpXDOz/cbtcmHRDWqEZByDFXdfm0Uab244NMSKgm8eIQxcpAABqqJh02FRCldydc+R5WsORYONVxB0xciy2z25PdwNZTlv0FTcRwMkjTtB6b+gpsBOeBSur41HFxKIz1984z3VVp5sn/DXtrzcaICjIRKydHPB9LN+K84VNBXyXXO0vTjuBDTN9AhGO+NSEmEPe9jskIEiOW9/Vn26FCDI7CivDYxESzeXGLYfTKYLfjivhwilCxNAmBYNCZgw7/r8ah2Tch9UypTcS2dj+JwNc0+v3wii0k40vl2fTb+V0XeU/zFDw1RbsUnKM0HlhJy1lbZBOn5QkGgwO0PrvxhwcduHZHUeBUqAjKN1BFZ+b+DtfHHAekwm4PplLwbykW+ceSobr60V3A3So65fPUhOxYN7/Me2/gSJVAe3bOJfQ3rgBnNvVM1ia6miJagxNQtQg0JOE57axPvjpCNHgJHyLXI5aBe6J5mAT4njTgTd3qZZsoul+G8QGFLPdDW5xyWmzsKhGAhOZkEsgjJkOSM4I6GGHdFqaLpAzHeztdhsmamMogBBUdikYMEUI9II/lPliCWsMu0PvC3Zx2ROVPpwgFqh+QXkB4gWGPbZA0kBCMm+WW0NxfYCOc/O7WokkQaVsvPeZx3mzx63VsPX2psDCVT5HfeEF2k93YQZs/njceiEaWcorL4xhN84oQ4H7LV3sNthjQJvo05sSRlblAyclK17g 1Y/lXHI5 5pteX6IeKloAKzPTufTOYElSGdYcT/0QPvCcvcjT+m3+rZOQql7h+YbtybH2kUb3xBle4CDMmBsw+lw36u1BV3vwpjSouV1p+I/vMdEVYqmX7TnDfW0B5c8ksui6J19orQUsygS80BShHk6nIzWlolW6LOZLEFTxuHwfrMfGvRvGen2pWiwkaUB7p+oMugw407KW0NPpLcuJdkh1Te25TpBRtBwgBn2pd6pssQ91N3AoYOKYGE1yR/Hmq9+ATpcJ55g/UwnEsx5V95181aVAuJDlUhTz9QHFvbGXf2iQJIm6b6/XaLaFmmbMYFAca/Mb5wvpFEPiClDd7ROZ7HUI1qXDL83UKcfFMilkjgXUCrhqrZ7pslY2a4LK1aGiHI7p7k6MECkQaByYDZCA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.005370, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Oct 17, 2023 at 2:42=E2=80=AFPM Alejandro Colomar = wrote: > > Hi Guillem! > > On Tue, Oct 17, 2023 at 11:23:10PM +0200, Guillem Jover wrote: > > Hi! > > > > On Mon, 2023-10-09 at 00:06:48 +0200, Alejandro Colomar wrote: > > > This produces some unwanted space. Please apply the following fix to > > > your patch. > > > > > > diff --git a/man2/ioctl_userfaultfd.2 b/man2/ioctl_userfaultfd.2 > > > index 6e954e98c..795014794 100644 > > > --- a/man2/ioctl_userfaultfd.2 > > > +++ b/man2/ioctl_userfaultfd.2 > > > @@ -432,11 +432,11 @@ .SS UFFDIO_REGISTER > > > no mapping exists in the given range, > > > or the mapping that exists there is invalid > > > (e.g. unsupported type of memory), > > > -or the range values ( > > > -.I range.start > > > +or the range values > > > +.IR ( range.start > > > > I think you meant =C2=AB.RI=C2=BB here? > > Yup! Good catch. Thanks, I'll apply this change in a v3. > > Cheers, > Alex > > > > > > or > > > -.I range.len > > > -) are not multiples of the relevant page size, > > > +.IR range.len ) > > > +are not multiples of the relevant page size, > > > or > > > .I range.len > > > is zero. > > > > > > > Regards, > > Guillem Regarding the -EBUSY ordering, I did it this way because that's the order in which the conditions are checked in the code. But, I agree that isn't very obvious / useful to any reader of the man page :) and alphabetical order is preferred. I'll correct that in v3. > > -- >