From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D478EC10F1A for ; Thu, 9 May 2024 18:14:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4E6256B0089; Thu, 9 May 2024 14:14:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 46F1B6B008C; Thu, 9 May 2024 14:14:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2EA9F6B0092; Thu, 9 May 2024 14:14:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 0D3916B0089 for ; Thu, 9 May 2024 14:14:34 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id AFE2A160DE3 for ; Thu, 9 May 2024 18:14:33 +0000 (UTC) X-FDA: 82099657626.30.2771C4D Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) by imf12.hostedemail.com (Postfix) with ESMTP id DE34340018 for ; Thu, 9 May 2024 18:14:30 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=YiKM8i2W; spf=pass (imf12.hostedemail.com: domain of axelrasmussen@google.com designates 209.85.221.49 as permitted sender) smtp.mailfrom=axelrasmussen@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715278471; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=YkVHyBMrNVy/mhlt5buLaXZgmPiU5YnVS2XKhBxY72k=; b=mWa3HaIyaz8VqGW6i05gp3uOdtZnhusheGwHSu2bIe2TUVzR20Y0HfvaTJMxwHRlhATuHH efdKIf4srFn5D62FNcpKv/PvAS88UhO8SYGxAPtTogIbO8cB5qlpH95+lsbxlke+FRWDGk ea297H3+1DKXHU/Wm+d4B8XpUvU3bQc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715278471; a=rsa-sha256; cv=none; b=6E98zfVi18DM7oynjqIrDBDMsH5ahD/JkX6okzTbbn07iXvj/QflhDnZ4VmhLv8aRQrJnf P5fqPJblKKiB1CESG+wAGz9mFitiqZ3o3zNt/GbhYqSDwPJqdoSNLGuUflYjPEa8B2s3Ad 1Qq591FYdrmUajfzHJOtxKYExUxgVSM= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=YiKM8i2W; spf=pass (imf12.hostedemail.com: domain of axelrasmussen@google.com designates 209.85.221.49 as permitted sender) smtp.mailfrom=axelrasmussen@google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-wr1-f49.google.com with SMTP id ffacd0b85a97d-346359c8785so820964f8f.0 for ; Thu, 09 May 2024 11:14:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1715278469; x=1715883269; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=YkVHyBMrNVy/mhlt5buLaXZgmPiU5YnVS2XKhBxY72k=; b=YiKM8i2WALyBg9zb4nGzNZdhQwkCu6dzWdA/ZttBmlZ3MOYz0iq1/1lukrmNJggIkr KwC2xs5LZqWooMS70jQZsl/6fQqU02ENQXyjj64pdRLR3ZVnpngL6GTbi7HuQXcgny0Y tGRnksb5ttHzxdyvFIHOIubLfVAjE0uXUuxvYSFhFOTI9ExjgX9RhGWm1c6ZoL4r568E 48J7L1Ivb1px+Rw10ZkeVoCBTRphHuinWYgG7zgxMhNYPh7+pwKyvAHyQpVIzhZ5uHva dyvNiTYC8WDyC+5FzDc/6N8d+ndsz+I6pnuTg/oWe/QRWmIEQQpAKfqQsX7Pa+uVRzKb bkUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715278469; x=1715883269; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YkVHyBMrNVy/mhlt5buLaXZgmPiU5YnVS2XKhBxY72k=; b=NUh8End0LV53Zo/f8e8CoJxrOwDA4VXBorK/5wVrFM9krtg1jZX6E/QRmlcmQIyXS1 sP6lOjpDtrc7dNfD8lxTIKCTzXBl0oNGMLrkXMDny1wRk57qBnoiEyJDP7ERYj6QL01y zRogaNZPn2qQbqmAvAlmcn6A52S1NPhqGdVKeli/2jptMHiTFkkXUjJ9GEGZeKsfc8x8 PurX3KrTlBJKgzQcrf2v0aeRr3jxlCaijEkmw1VnWZsx80Bj3O88iXkIkHYpiADrKWW+ c471EeeNxrVW/FAG93RM0HBwSsBrKPVow6ZaYyx6tOBGk9xrSC+apK8ve/OHx2FTXQWW ymiw== X-Forwarded-Encrypted: i=1; AJvYcCVx1f7ieFIcFhAgb2dZvbTo7hksJx3UNl+jew9zBzP21i7/inp1isrQJgKkpQuRr/OQlgWVXHQbgcn8267k/1BgmiA= X-Gm-Message-State: AOJu0YyGpLnEuxSWqvqQgt6GKhzutuM9exRIIYK9cCgkdjQ9oUghD805 ofx7LSl4KpLPXm0+aurLu8az4mfJnI/byQN3KO7LWefEA37JzbVYYnx8dqNg77xtj8/W+Uua4lR 5841r2bhbatk0XLH+nEzoFeXfmIzF55Gtq3NT X-Google-Smtp-Source: AGHT+IFEBzEdjhOEiKmfPO2uLKnUu7B6VTjtb2JD+mFLsKtCP1/91pTQm4Kr4v+etrsn+JFIt5PnkJ+q3Hjl87Bdr9Y= X-Received: by 2002:adf:e80b:0:b0:34c:77bc:6c51 with SMTP id ffacd0b85a97d-3504a61c6a0mr249933f8f.1.1715278469112; Thu, 09 May 2024 11:14:29 -0700 (PDT) MIME-Version: 1.0 References: <20240509100148.22384-1-osalvador@suse.de> In-Reply-To: From: Axel Rasmussen Date: Thu, 9 May 2024 11:13:50 -0700 Message-ID: Subject: Re: [PATCH 0/2] Minor fixups for hugetlb fault path To: Peter Xu Cc: Oscar Salvador , Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Muchun Song , Liu Shixin Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Stat-Signature: wnrix4temkatd556ewt65wx53gwbd49z X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: DE34340018 X-HE-Tag: 1715278470-38020 X-HE-Meta: U2FsdGVkX1/4aJUlCC3GwFUu/G99QcabdPNT7ZcSntdHtSHTgkrfUJH1vcXYelFbHe2sFezhxTdWNk+sWdW2jUD9ZNlhUFM1nBHQu3c59sFUTI4BoWijOOljFFkw5u46Efliz2EBesnycMri4RRzT2gQhm/5Kkb866lmVPCsfTMAd8f7MMKxJEhRamnwle/u1F7OQmqQVXSFpjyskLpnidqXF6C/Cysg5eZBP2lzC47Vz53qFRo7bIEjew+sf42Q1NIjqoS2bLXUFjz1bYOr88kzIENVoSxgTKNJ7KVPMna36AaOTCClMOlmrMaAhEzXAQJHdKgi4oMgSeo47Pprray7zqnC/L6ARLy/OgPqC3DFphZGBiSVHlWTtNpaVFlnlD0MwqU3yK7YLWLzOHIIgylbKoEJ3zsWUiQi5XFlPjC8VOJ57MTA3j6YQSc9FFxkHaL6D2s+BTuKOXvRM1aF2pTCqGsducnrvkpIOiRAImnbuJrLVeTul1a8j+xN2T0m4thmVuRyGtPw5DcoDZOiE0hLj3HJMaYiJRi+1QkllomxnxeIqN7hAJ33nsjyOZj8KQlcdgg9WObrPrcjtC/UPRV2ZBNzYAQvVtEqB9SwRUHM9U6B5tmUDwzv1CnLK1gd48Uk5he5TjBRRBg/EQ4I0oGZwsOM5VZaV0vtVDEk0XGIEPA4kSaljOjzHYrgLX2cIO0DAR5GEHmJ8+LIihjmojIcvignaCAFQY9XE36Wr3S74i6Pm7wpqC+wpZpoEb9eO07M9thOg7AJr8MjoL+JEB8UMBKeKDK4datABaj0Pl/AWeSOKOTZM/mC/sR6SMoH9SwpyFjZIfUClg+pSmUsQ4ckyzFzxkH7QJJaiWk/jLP2XkRVkksmbzLX5tn5EqVti9+xy4/DfYdoTkZVk+0aJP84p4mJp6T9TXoL7QoKLGtWxwYHMuvlnRScpczPZR59lALNOs7FFwad48hsSV8 cEzfAhje 4KtZLUODtNyLAOoRpyiF3Ba7Ix5HZc8bz56xc+Qd6HhhM/aXcZtTsaDHWIjqc6INemhPlG2dVMI2rkoxOLA6oJfZ0kusDJ00DgBGBdNKKO7r4mvlSmg7AKGjbSMIY28+ruk9sCzqZWUzQcGa7+BW9bKv9ZVpHa8dthDFHQnWvN6tnWUrxOLVOkflvkbZ/lLKyxRZu5ZEOmfNP6KzrLVqnaYHGmvptaVGwedZwz+eqBOrZf34vur55/XIcLF0sb7Ae65glpNYEsuJY7qFZBnFzSIY2dA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.165813, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, May 9, 2024 at 6:26=E2=80=AFAM Peter Xu wrote: > > On Thu, May 09, 2024 at 12:01:46PM +0200, Oscar Salvador wrote: > > Hi, > > > > this series contains a couple of fixups for hugetlb_fault and hugetlb_w= p > > respectively, where a VM_FAULT_SET_HINDEX call was missing. > > > > I did not bother with a Fixes tag because the missing piece here is tha= t > > we will not report to userspace the right extension of the faulty area > > by adjusting struct kernel_siginfo.si_addr_lsb, but I do not consider t= hat > > to be a big issue because I assume that userspace already knows the siz= e > > of the mapping anyway. > > Acked-by: Peter Xu Looks correct to me as well. Thanks! Acked-by: Axel Rasmussen > > -- > Peter Xu >