From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C943C761A6 for ; Sat, 1 Apr 2023 01:58:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 16FC56B0072; Fri, 31 Mar 2023 21:58:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0F9456B0074; Fri, 31 Mar 2023 21:58:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EB47A6B0075; Fri, 31 Mar 2023 21:58:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id D70BB6B0072 for ; Fri, 31 Mar 2023 21:58:22 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id A00E880115 for ; Sat, 1 Apr 2023 01:58:22 +0000 (UTC) X-FDA: 80631162444.28.2521460 Received: from mail-lf1-f51.google.com (mail-lf1-f51.google.com [209.85.167.51]) by imf27.hostedemail.com (Postfix) with ESMTP id C590140002 for ; Sat, 1 Apr 2023 01:58:20 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=cTMO764N; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf27.hostedemail.com: domain of axelrasmussen@google.com designates 209.85.167.51 as permitted sender) smtp.mailfrom=axelrasmussen@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680314300; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Vq3rSG2aoZXhHoIZpsTLA7CDeNmLWnFMK9f5Q3ElX6U=; b=glgMdgyGQRju1Vrct/j50/w7FFj6QRyhxVESOtQEn+9VTq0keLm5cbdwQlVXFHkXcOifSZ z/BaGZ9l5QRzIZAaGQlszNyvjoGbeIeyr0Kvqzh9eFWkhKaYwbY/f/jN6Zjpi40O1O4W35 kiJO1FnSA2xU07s8aMQsTsUQGS+M3tA= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=cTMO764N; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf27.hostedemail.com: domain of axelrasmussen@google.com designates 209.85.167.51 as permitted sender) smtp.mailfrom=axelrasmussen@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680314300; a=rsa-sha256; cv=none; b=u6tfzvnpYHz6Suikmaw8kpVIv5boooB/YsTTZdSpxfETkCGebNSf8Q0wyRy6IxFzCIDWlG 426B4TBykhSMHyftYlxHQs8F0iPggGnbF1ootnFE5Sl17mV+c70MJLyY/w5wIqGiMuclqo Q2TtMJmVJbknA6qMX1uIZA9JdGs9TDw= Received: by mail-lf1-f51.google.com with SMTP id y15so31176399lfa.7 for ; Fri, 31 Mar 2023 18:58:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; t=1680314299; x=1682906299; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Vq3rSG2aoZXhHoIZpsTLA7CDeNmLWnFMK9f5Q3ElX6U=; b=cTMO764NVMfDQ02GmKYpwGW7uOyjMtRDGKwa69UXSukBmcjeHe9AlVqCgIM1W2mmNR zxTP4P4tyCpMy2GQ021fSPFRncsiv+E1CAfEXicYI5K/0TPUELO4gxS/WYJ+P7TtZtGx c2IToFU2gQV0xX8jb32yq9c9Z3L+sWD6x1CMCKxJEklErWPAmeZquTqGPpewiI9pHvPa cFNq8D1Q/o/3xs01WinP2ydg75sHOSYXghmrG++K3YSRtR42y4Ezkoe8jxR1XM7aDMOK 3Usa2vJJngCWsZ36ADKfAC6RPFVYTjPnNxGDqh2RNIMKZLFQ4GUmWo//PRVnvbSmKunN MtWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680314299; x=1682906299; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Vq3rSG2aoZXhHoIZpsTLA7CDeNmLWnFMK9f5Q3ElX6U=; b=JISwiM1D4Oci2k7qUEXmS4HyVGC3jgeEGGSFDPLPgcZwtyCexU/eNwlSF9tmYOKh66 gwci2ZjyWc5a8ShnBhHlUcM4TBMNmOSNkdbjk+PxvGB2zCDOeV8GqNi6LN7ORBb9QY/D qyLi7n9ZOCiX58gG4Y3Ec/RePuZ7z2TgUwP1IZvkPaPtwLU7EH+fVBvHtIFf3WkHA4Pl ALfsiGedThgW7mTz0JxE2ma/lVp3x9ivjoFtWP5mign/ftTfIZ5ALcnKVgcKszszDaeT a+pqu3bJr3uHji5GQJNuqOn09i0PhGxOxisBYtfxPU81RGwb3pPUZGyU8D7iDoC7m5A+ HDXw== X-Gm-Message-State: AAQBX9c/qpNF27fj9t9Q/rt0JjQAwwX69r4Zw4wNOKAf+zxMnfrm2toT aWLhxeuIwi4kPpsslKwz9QleIxL0/TynxDkx5yx0WA== X-Google-Smtp-Source: AKy350axl64hB+NsJXRL/NGZ1OWlEZ7je83H8wof4NheuQHKtsQWreaDEyvoljdWcrxhAVbQEG9f9iONspCnq/gmV6s= X-Received: by 2002:ac2:59c4:0:b0:4eb:d8d:6c17 with SMTP id x4-20020ac259c4000000b004eb0d8d6c17mr6349126lfn.10.1680314298620; Fri, 31 Mar 2023 18:58:18 -0700 (PDT) MIME-Version: 1.0 References: <20230330155707.3106228-1-peterx@redhat.com> <20230330160714.3106999-1-peterx@redhat.com> <20230331183726.GD12460@monkey> In-Reply-To: <20230331183726.GD12460@monkey> From: Axel Rasmussen Date: Fri, 31 Mar 2023 18:57:41 -0700 Message-ID: Subject: Re: [PATCH 10/29] selftests/mm: Test UFFDIO_ZEROPAGE only when !hugetlb To: Mike Kravetz Cc: Peter Xu , linux-mm@kvack.org, linux-kernel@vger.kernel.org, David Hildenbrand , Andrew Morton , Andrea Arcangeli , Leonardo Bras Soares Passos , Mike Rapoport , Nadav Amit Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: C590140002 X-Stat-Signature: 3wq77xrp3gmso6i5we8uwgwh5ntprxwg X-HE-Tag: 1680314300-762229 X-HE-Meta: U2FsdGVkX1/Q8WtEV6MvcHsYYP+SAf0O2Oa6a0rhpkPH4qHDuvxHjgahUGKVuwqHWg1Qo9OEwxj+ATx5KvSN1gOqu8AtQMJ6EOXVUJLtGbiL5M6GpGISFeLGh7Gt7fW5kMvEXA0KcxzlllzZmCbAf0g5fNMp4OYOXyt+NA3znKRcd0SwBl6PBcOJFfKZQpwbLkbzjRzRbl0BFtTrEgLm/KDh2tEDuwoVP4yfP7NWRgtvgwVBpnJ+jUJwLAdaJFnKZmhX3uVhhKSbQ7We77VoLtTfv4/gORH+NbqSLsJwTUHW/MBDYtnWLngz954MrHQ6Hv+02SA6H0xJm9+68OlIYx/FSE6/M2HW3nL2ZEZ/q8JMmSlKUhZl2cqKkHVrWTo/V+6IA9CJLiAcBoTaxk58xmSid54Q1VhYBqtvv+JoY231fWLtiuH9DsrFz4xSu9dFz9A2+UxA/9Nmk4IP8zKCYNPjnZgNwrGo+sQ/S5cD18O+xDceWRPE2EBYgy0daNj/9AgdZcfQgDYqTaPgCtpk8qcg6jeTqZT4jtMMv6uP/Ae4AbiE2TIg51nLTU5IB//I9FmO74GlCxiwKMpVMpCyiwtq8DFHD3uMV47oughJ2q1rryqQkt14IfYLx3e/rHu2e65MTMGUbtcAEnZH7frAHwbRNRUjeF7kLZeBvcnq7w+ZBCom73i4tczlYnhjcC3gQ/Am9r18LjqB/+uidq2IId8Q+B5M6f5jKN2Kpxo+xmUcbngc/F6oL2dMRw+JBFGuuqq3BGyk7jHo/YGsQi5GhONrSeWhVhMnbENHkhsBF8f2R3HwkVfrlPVlKsm5uxT3nBgH95ZvscejozCZz64Wc2cz0a7T/+UTnIAa2B21jX0Fh+KzhUxb4wvluct0myv26LeFYSq0XEqWTyQEJYowNoX0yIi7R1BLiTGK8Yhf3WKCijEtDpdVzXsiEm4C/NK/A+QrKsFcS2Om09vOaCa rHeiTTHZ Ngiws9lrKqOy2y2GAisP9RZ0kWuRlGAumQMquM/IzarLdrlviogCmgxLYzgb7axK3qc/Ib1YPE9YyDKdP/yguRVKeYFYIzMLTHzc3rTuxrfIzIMI23rML4dYZL8LKn8YV2r0KuwGCryTFFkw7alUXLV8jTgEgDMCIHnXWa8g4HmoTOfPPwf1yHd79VJtYITmtH/R4hFjUhvL7dloXjTjDZfjoVxq8Syrd5wHiPcwFhycJ/XLWxMH1e1oVHogOLA6R4q5Gr6CsX1tAtbCuwc73xwY2jR1+lchI4vdyklQ+sCQErvEYqlLVETfGNYu75BzxF908xfahyOSuHsZmrhGOCzQa/ptjwiy08AmNFISlxHN0rrvkIZoT/ACCUZInKXe8rs599K14NTpXUmtDLbHpvoZyNsl3wCFBuJQIB5KWeo6Hih8K6BYyz8jJWV31op2fK6cnSMgxiWLoaOg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000570, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Mar 31, 2023 at 11:37=E2=80=AFAM Mike Kravetz wrote: > > On 03/30/23 12:07, Peter Xu wrote: > > Make the check as simple as "test_type =3D=3D TEST_HUGETLB" because tha= t's the > > only mem that doesn't support ZEROPAGE. > > > > Signed-off-by: Peter Xu > > --- > > tools/testing/selftests/mm/userfaultfd.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/tools/testing/selftests/mm/userfaultfd.c b/tools/testing/s= elftests/mm/userfaultfd.c > > index 795fbc4d84f8..d724f1c78847 100644 > > --- a/tools/testing/selftests/mm/userfaultfd.c > > +++ b/tools/testing/selftests/mm/userfaultfd.c > > @@ -1118,7 +1118,7 @@ static int __uffdio_zeropage(int ufd, unsigned lo= ng offset, bool retry) > > { > > struct uffdio_zeropage uffdio_zeropage; > > int ret; > > - bool has_zeropage =3D get_expected_ioctls(0) & (1 << _UFFDIO_ZERO= PAGE); > > + bool has_zeropage =3D !(test_type =3D=3D TEST_HUGETLB); > > It is true that hugetlb is the only mem type that does not support zeropa= ge. > So, the change is correct. > > However, I actually prefer the explicit check that is there today. It se= ems > more like a test of the API. And, is more future proof is code changes. > > Just my opinion/thoughts, not a strong objection. I agree. The existing code is more robust to future changes where we might support or stop supporting this ioctl in some cases. It also proves that the ioctl works, any time the API reports that it is supported / ought to work, independent of when the *test* thinks it should be supported. Then again, I think this is unlikely to change in the future, so I also agree with Mike that it's not the biggest deal. > -- > Mike Kravetz