From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17793C433EF for ; Mon, 18 Apr 2022 22:16:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5E1FA8D001A; Mon, 18 Apr 2022 18:16:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 56A956B00BA; Mon, 18 Apr 2022 18:16:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3E34F8D001A; Mon, 18 Apr 2022 18:16:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.26]) by kanga.kvack.org (Postfix) with ESMTP id 2C74A6B00B9 for ; Mon, 18 Apr 2022 18:16:40 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay13.hostedemail.com (Postfix) with ESMTP id E6A44601A1 for ; Mon, 18 Apr 2022 22:16:39 +0000 (UTC) X-FDA: 79371410118.19.3084804 Received: from mail-io1-f41.google.com (mail-io1-f41.google.com [209.85.166.41]) by imf21.hostedemail.com (Postfix) with ESMTP id ED4BB1C0005 for ; Mon, 18 Apr 2022 22:16:38 +0000 (UTC) Received: by mail-io1-f41.google.com with SMTP id p21so15773936ioj.4 for ; Mon, 18 Apr 2022 15:16:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=iRLvii3wRAA3vQqjW9pHEytsLQcX5vHIJz2bIP/mpx4=; b=l6QEevJfwQF14gPbgXrbOj0DmBzybU00tiIMo0wMBNpJ+H/iRLzKkLka/OWxBkrYgP jFXty4kByQJE7YEw+QyAAXhwje7LxvzaYzrJgtIywhL5R4TzsPTf7ZPsfjydy2/wC9GZ 2QtkecKsAm9gQaSrCYsu76ShmelvchXR13qLsXehL7MnXy7cab7Aq7lXUu9cx6qDOZJs jBzyi/MGOtDHy4WojVI5IDZQRenbCs3vX4OQ9lx931wLS3dG1FE0PZ1WP0NYBeOuMfDe 2uIifMXWh4CLqpUfeTlSsuebHidMGk6LM7gBaGRg4MhQizsJXQXlf5b5neKLTTja+2uY r9vg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=iRLvii3wRAA3vQqjW9pHEytsLQcX5vHIJz2bIP/mpx4=; b=sWEUjZuaXAEE1lkbcHMkdgWe+o5uaEdrbS+92WQcJuA8OFMloNIuMu6EDG7rMgUAAM pCju3yolCGyRDquETtLbEVsLyUuORRF/7QZh9diEoP0M4caCZcYg53OUDYcopSsIG8PI VnuPBzVlmZkDROnvuS4bf8NGE2U+QkCd9TggZhboc1ia5AzByk+aaOHdWqgzBdq8Lr8+ Rh+55IjFDYVbfRCRQ3xK8dAyR0OULAg7b5ZrjQwGIbKXtevuXkQNu11EvrqKY+x/k0Tr I20DT4yIny3tiS4G/qOjizIkffJxbrgZODeh3h9GMN7MlyMYQczFV/j9FcmSeoRVl3QD E4Qw== X-Gm-Message-State: AOAM5328dDA9ShxvAQ1flqd3SRKm0e/e4vHCx/PUasjBKZXSKfiKgIv/ M0Gqmfxo0km2tnAsOQ9JV43GYGfOto9WBfrOXttPRA== X-Google-Smtp-Source: ABdhPJxsJdCxOAMl+kcTMlllD0Q7WmZl5V5sQ2KLaucRT2Yn25NMbujljxWpzrlbsSukgVjL6caYOrhYQz1SG9lH/3k= X-Received: by 2002:a05:6602:168b:b0:646:3bbb:7db4 with SMTP id s11-20020a056602168b00b006463bbb7db4mr5564505iow.134.1650320198599; Mon, 18 Apr 2022 15:16:38 -0700 (PDT) MIME-Version: 1.0 References: <20220412202942.386981-1-axelrasmussen@google.com> <20220412202942.386981-2-axelrasmussen@google.com> <20220412134159.f0a1d0d77f5b01638007bf4b@linux-foundation.org> In-Reply-To: <20220412134159.f0a1d0d77f5b01638007bf4b@linux-foundation.org> From: Axel Rasmussen Date: Mon, 18 Apr 2022 15:16:02 -0700 Message-ID: Subject: Re: [PATCH 2/2] userfaultfd: selftests: modify selftest to use /dev/userfaultfd To: Andrew Morton Cc: Alexander Viro , "Dmitry V . Levin" , Gleb Fotengauer-Malinovskiy , Mike Kravetz , Nadav Amit , Peter Xu , Shuah Khan , linux-fsdevel@vger.kernel.org, LKML , Linux MM , Linuxkselftest Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: ED4BB1C0005 X-Rspam-User: Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=l6QEevJf; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf21.hostedemail.com: domain of axelrasmussen@google.com designates 209.85.166.41 as permitted sender) smtp.mailfrom=axelrasmussen@google.com X-Stat-Signature: qdgbmonz4f9yb99wzym7trdsy6a7ietz X-HE-Tag: 1650320198-870234 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000840, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Thanks for looking Andrew. And, fair criticism. In keeping with the status quo, I'm thinking of just adding a new command-line argument which toggles between the two modes. But, if I'm honest, it's starting to feel like the test has way too many arguments... I'm tempted to refactor the test to use the kselftest framework [1], get rid of all these command line arguments, and just always test everything. But, this seems like a big and perhaps controversial refactor, so I may take it up after this series... [1]: https://www.kernel.org/doc/html/latest/dev-tools/kselftest.html On Tue, Apr 12, 2022 at 1:42 PM Andrew Morton wrote: > > On Tue, 12 Apr 2022 13:29:42 -0700 Axel Rasmussen wrote: > > > Prefer this new interface, but if using it fails for any reason just > > fall back to using userfaultfd(2) as before. > > This seems a poor idea - the old interface will henceforth be untested. > > Why not tweak the code to test both interfaces?