From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-23.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C592C433DB for ; Wed, 10 Mar 2021 21:27:09 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E894664FC4 for ; Wed, 10 Mar 2021 21:27:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E894664FC4 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 24B6D8D0211; Wed, 10 Mar 2021 16:27:08 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 222278D01ED; Wed, 10 Mar 2021 16:27:08 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0C2C18D0211; Wed, 10 Mar 2021 16:27:08 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0115.hostedemail.com [216.40.44.115]) by kanga.kvack.org (Postfix) with ESMTP id E57A08D01ED for ; Wed, 10 Mar 2021 16:27:07 -0500 (EST) Received: from smtpin29.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id A8B0A4DA4 for ; Wed, 10 Mar 2021 21:27:07 +0000 (UTC) X-FDA: 77905250094.29.8E87458 Received: from mail-il1-f174.google.com (mail-il1-f174.google.com [209.85.166.174]) by imf24.hostedemail.com (Postfix) with ESMTP id 76138A0009CE for ; Wed, 10 Mar 2021 21:27:03 +0000 (UTC) Received: by mail-il1-f174.google.com with SMTP id e7so16960679ile.7 for ; Wed, 10 Mar 2021 13:27:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=e6D5z3mafEzY8yrWw6TNKSwod1RWWNCgjnlei0AA4Yg=; b=sqQvvFfF9Rv0VE0JwuclYzO/9N0bN+joIEu77n22nsqkxRelcawXlykkuDoGb4K9wa z/ajL4jkgypagouVW5k65wZIDFdSiwXmrXS9zddpZyOxURu7qhkO/IOFyJWULxkV3roM 9WAZIGHSplakE0vgu+Nhl2dZWx2L1jS6TlQrAH6tD6uBorrz40sHEoAEN6PAJxVi4FS2 SBmMpf/c5cEB2bCNUpBJypDC7u24baxee4WBz5NzyctAEJq3PEEq+nG84MeYqbVg3Ns+ Nc585bsochmyJvVAJlH3YJFaLhvsPKsonYRoCgnQC4aqACNosnsc/OIDgBpM67Tk46Lr bX2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=e6D5z3mafEzY8yrWw6TNKSwod1RWWNCgjnlei0AA4Yg=; b=YZyUjH5lXRmXWqlfV/0EHu6eqhXcaFYpIphj4M5lWGzqVACttb7jgjz2Vmf3JZPEoz y6iF7xBR07mKSKjwvsWAhPyjIgeEpe7SzyEKOclWVlu4+UP1zlL8x65TAGUk6ZkNuvvm l/f0L9gDQyjQGyQTBLh9rAU9u0sKbA6ytwQPe/X1i/sCnIU3Nr2/ecN91MNrm/IY0Y2b qvYB8sK81gH6P9Kd7DNv83QQIoUvP5MLn6IPTbBVndfKGjBm/98jcoqAHBRUlG1yzHX2 hP/jx7Q8VcankhKAdrfThEhgy5uOnQ2SFogsyY2D65vmaQa7MaEfqTfUN1ELOYBsS0My aMpA== X-Gm-Message-State: AOAM531QWAIugP3AqSl1LWLRO+cCgm3BUUoGCyxsuqSCHIdaV2alpNEn 80beN+1WcLJGMR4vTWsLe81g2wAixvgy9JyULdPJ9w== X-Google-Smtp-Source: ABdhPJyPVwTTHE1TsFxNCU6mx29jBLudL6jpgWl9CE4iX0JZiitRwaeTOniNdwI68K66urDGyjaWVnzufYaYGVgMp18= X-Received: by 2002:a92:d6d2:: with SMTP id z18mr4402514ilp.30.1615411626484; Wed, 10 Mar 2021 13:27:06 -0800 (PST) MIME-Version: 1.0 References: <20210310004511.51996-1-peterx@redhat.com> In-Reply-To: <20210310004511.51996-1-peterx@redhat.com> From: Axel Rasmussen Date: Wed, 10 Mar 2021 13:26:29 -0800 Message-ID: Subject: Re: [PATCH 0/5] userfaultfd/selftests: A few cleanups To: Peter Xu Cc: Linux MM , LKML , Andrew Morton , Andrea Arcangeli , Nadav Amit Content-Type: text/plain; charset="UTF-8" X-Stat-Signature: 74meiiaspwd9a7jsnsigibbitjync97j X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 76138A0009CE Received-SPF: none (google.com>: No applicable sender policy available) receiver=imf24; identity=mailfrom; envelope-from=""; helo=mail-il1-f174.google.com; client-ip=209.85.166.174 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1615411623-556599 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: These look like good cleanups to me! I reviewed all of the patches, and tried out the resulting selftest program, it seems to work correctly. So, for what it's worth: Reviewed-by: Axel Rasmussen On Tue, Mar 9, 2021 at 4:45 PM Peter Xu wrote: > > Based on v5.12-rc2-mmots-2021-03-08-21-54. > > I wanted to cleanup userfaultfd.c fault handling for a long time. If it's not > cleaned, when the new code grows the file it'll also grow the size that needs > to be cleaned... This is my attempt to cleanup the userfaultfd selftest on > fault handling, to use an err() macro instead of either fprintf() or perror() > then another exit() call. > > The huge cleanup is done in the last patch. The first 4 patches are some other > standalone cleanups for the same file, so I put them together. > > Please review, thanks. > > Peter Xu (5): > userfaultfd/selftests: Use user mode only > userfaultfd/selftests: Remove the time() check on delayed uffd > userfaultfd/selftests: Dropping VERIFY check in locking_thread > userfaultfd/selftests: Only dump counts if mode enabled > userfaultfd/selftests: Unify error handling > > tools/testing/selftests/vm/userfaultfd.c | 742 +++++++---------------- > 1 file changed, 235 insertions(+), 507 deletions(-) > > -- > 2.26.2 > >