From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80E0BEB64D9 for ; Fri, 7 Jul 2023 17:04:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DB05D6B007E; Fri, 7 Jul 2023 13:04:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D38096B0080; Fri, 7 Jul 2023 13:04:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BD89F8D0003; Fri, 7 Jul 2023 13:04:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id AF8106B007E for ; Fri, 7 Jul 2023 13:04:54 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 7D3DCC07D0 for ; Fri, 7 Jul 2023 17:04:54 +0000 (UTC) X-FDA: 80985440508.25.E612E67 Received: from mail-lj1-f175.google.com (mail-lj1-f175.google.com [209.85.208.175]) by imf03.hostedemail.com (Postfix) with ESMTP id 0D5622007D for ; Fri, 7 Jul 2023 17:04:33 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=OwYvnUtj; spf=pass (imf03.hostedemail.com: domain of axelrasmussen@google.com designates 209.85.208.175 as permitted sender) smtp.mailfrom=axelrasmussen@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1688749474; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=nIecGmLz1MlH+va/QFWif8XrmmDnlbqD98dJPxGNA64=; b=p7B3R13QN2dz93E5k8lQwLMaaRLNAA0AzfgCqX5iT2TAfdAjdzgvxESaz0Eos0hVPL+rve wmOp96pQSxStfhQyyOs93WNi2trpu8xByy3hoIFPXCWHJC6tdw0aF5FxHpIFTIL3djQXPe mQ5IUo2XBr4xThl56paHKNUKJRVjN3w= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1688749474; a=rsa-sha256; cv=none; b=8qDcoKo/3UKbRXiUIWcGm+bkp24LWJs2nk0+E0noVMkE7VCAT3twu7Q6ZeJluntxNhUCU5 ruOMR3ZEVAP7pFlsrFm8a+MOOjqhjfQMXpItVV4V7ZtemP3omjUGheAO92BE8qnYb0ixse KdIsyMkqYxtznIXoxpVA4FkmXz0M7cM= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=OwYvnUtj; spf=pass (imf03.hostedemail.com: domain of axelrasmussen@google.com designates 209.85.208.175 as permitted sender) smtp.mailfrom=axelrasmussen@google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-lj1-f175.google.com with SMTP id 38308e7fff4ca-2b5c231c23aso34797951fa.0 for ; Fri, 07 Jul 2023 10:04:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1688749472; x=1691341472; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=nIecGmLz1MlH+va/QFWif8XrmmDnlbqD98dJPxGNA64=; b=OwYvnUtjF7ahSmumagnned4jibeNbglj/gEaLa7engmpvPADf/SqNog7qaoecsz+bz qg272OVvIl8aMDi2KbW3ytwr+UPSdYA5SP9MrudFeKxwLWHZXx2effACfixn4ba85enw jBzBE2qnFUSmNTgX6U7Rp+WH0qJkZGnEiVFAnG0FwyYy2ejrUbraUHaWx8bWzt9WBJQn Dk2zXG2eO0XAU7pPdSQ/XuKdulSawH0pxfHmrCBkgLzQSjv3yCseholEErz9vmDBgBmh 0yJAAlFBtczoky1ZBsx/izYr7EvqD7ojK8IrH0KhnBB/E8GbnkJG5VUMhWejXA2emDIV LoyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688749472; x=1691341472; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nIecGmLz1MlH+va/QFWif8XrmmDnlbqD98dJPxGNA64=; b=MKZoMhXMjcvYM0THPyp+nqtZ7unCL6heF7AgDqAeAs7NcaVKf9TiioPkDcB4UxCz0M PKUR8Kq1OMvSn2eqedcenDvQjR11kr9B5FuE4a8blSkKJdBNODM57sha/JIIIWyC9OaY UObwie0YWZszXYQzKUnSBbOAMBZhQdTryb4sp+dPLXoXAN8TmB9fYNxH3AU9TpF9OmlJ c/zE9Uspdy4018foiJEvKMJAg0La9Z3cY9kOXN0YIl+UJpw46yq1Gl18m8ukDAfVDVBD gYVFsFpafWMae85Czt51/vd58k+SRi/qkpEMpwk8attv8ffL/CUXOUdJIgwFdtBSJoHo W5+g== X-Gm-Message-State: ABy/qLa3n6PCJVXcsUSEC+e2H5JiJBNbneIVDeGDYMsZkKDWUVD+5o22 7EBUhdvi8/V6m6zvdvql6EBSKjgDMwmSgwHYnBHXdA== X-Google-Smtp-Source: APBJJlE+uUzC9dQYc/1nYMgq7EH9eX449paNaogkV+J1Pnfqq+ImNuTvrVj3o/GwqoxD3e2JidduSFie88A3cb/Pa/w= X-Received: by 2002:a2e:9b15:0:b0:2b6:d8cf:2f44 with SMTP id u21-20020a2e9b15000000b002b6d8cf2f44mr4204788lji.13.1688749471534; Fri, 07 Jul 2023 10:04:31 -0700 (PDT) MIME-Version: 1.0 References: <20230706225037.1164380-1-axelrasmussen@google.com> <20230706225037.1164380-8-axelrasmussen@google.com> In-Reply-To: From: Axel Rasmussen Date: Fri, 7 Jul 2023 10:03:55 -0700 Message-ID: Subject: Re: [PATCH v3 7/8] selftests/mm: refactor uffd_poll_thread to allow custom fault handlers To: Peter Xu Cc: Alexander Viro , Andrew Morton , Brian Geffon , Christian Brauner , David Hildenbrand , Gaosheng Cui , Huang Ying , Hugh Dickins , James Houghton , "Jan Alexander Steffens (heftig)" , Jiaqi Yan , Jonathan Corbet , Kefeng Wang , "Liam R. Howlett" , Miaohe Lin , Mike Kravetz , "Mike Rapoport (IBM)" , Muchun Song , Nadav Amit , Naoya Horiguchi , Ryan Roberts , Shuah Khan , Suleiman Souhlal , Suren Baghdasaryan , "T.J. Alumbaugh" , Yu Zhao , ZhangPeng , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: ajcus394csfg31cq8w1h1kw4fjc5fbd3 X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 0D5622007D X-Rspam-User: X-HE-Tag: 1688749473-926973 X-HE-Meta: U2FsdGVkX18H53L7i3Y56bZMeSQD4B23AVwQr3XZv809qyCu/PdBCT2Vz5yzJaldx2IsQcSgPZghbasFOop2Ko+fYAUAk10KKsLg4uTHvb1qv8JiJ6zB6MhesaY+eZ8MyxwZny7rxJjPmtJ4v/AnBnHttrGcS8agajAoxQiemdwFZCvaICBPNbPJ4pdQNiiGCM/POAvb4teTUNktidM6+yFO07iRijCI26UthM6dw1/VuzCyzb/Ag0z9+l8QsXjZurxlyX+ZAdp4ywVcAR1LnNNuQaEH9bnMEw13ppUithILFLPvHDHf/+YRjYcEQigSEKaDJHZFOY8Mtf79MRxxGZq6hhGAgLhHrZ5CrnbkshwtYfUUR85pjwlSTZz/EfNP+Yl1mFp+hcuqHAoU7IoJlLw4K+dMpJJp2YAKzxVAxiOSQ3i7EgoblIWXIv0ExTWYDRTMAd0+CBuJ8NUHU6nbgQOqBpsVnqxdNfRgwlmqvhmQmrQtRxmf/vQpNNcz6iBzAnKG3kobwcHCvSFg6m0NZHcgDgTUuLUWOrflnhkzZ8rdoB6BdDontmsiKSVgDDYK+idhTkwpyBpEflwLilRCh9eq1Ra4BfDSidNr2dGpNYd2c0s0wST12JPVbDlAdrc0rd+kc1COusTukgfuPBk+tuGgEsBFZiMz8QcbykxOJCcF/YEls+aMzqVRKZ855Y0DCxZlQoQt1nbRTp2xGl4xFMhZUiIoseyzH6B6f51WRsv9b6l3dZn//rTg2onug8/YIlrmKTnruriNrFFQFckylZlN4UjTKzSEhkvuuxF1GmHQSIawFeRE0RI2o8Ywf78qN0QpVDJzqtz04QUGCnw61CVE3pQ1xmXBHJbe+pubBJzZlABrIfb1ELc+tCHdDHf7rxAnkuHYwUF7rU1Qd8frzVRxMXc8sJSUQCMVspBOVwHS+AdJ1bS1fNNqBRA0CyCaxYfMMueVM2SVFrXbSo8 Fcf8pIOX JsAi8C4Fvcn0n3F6wxhzhzdLFbggISEvjc6O8+XYSF0Xo2TVxLA5Xk1GamYi6SQGrjfskNekDroEv7wVn7G4EsKrNCCXZ5jTCBtweD8rgO0oaz+9CDHd1R+Lxu7w8ZT49VxTx4jSWao2SATcKBvn0y/HakKNGuRGOBNnrvISr8qI0j6akEKekLZhONojUUgvm8pMHnm0NqSFUKiqk/LxEViJamze055yruBiSeLXV6f9V8aPBqf4rBUe+Dq0GYPHuS+jsuM3xFqPgQCdKnFfA1D7Uap5BJtKMMaR2u/j2ZBhOpcT/yGVbsYc4m7XKpzUzaLP7 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jul 7, 2023 at 6:42=E2=80=AFAM Peter Xu wrote: > > On Thu, Jul 06, 2023 at 03:50:35PM -0700, Axel Rasmussen wrote: > > @@ -247,9 +245,13 @@ static int userfaultfd_stress(void) > > { > > void *area; > > unsigned long nr; > > - struct uffd_args args[nr_cpus]; > > + struct uffd_args *args; > > uint64_t mem_size =3D nr_pages * page_size; > > > > + args =3D calloc(nr_cpus, sizeof(struct uffd_args)); > > + if (!args) > > + err("allocating args array failed"); > > This is trivial, but I think I requested a "free" (or keep it allocate on > stack) in previous version but it didn't get a response on why we cannot > and it kept going.. could you help explain? Oh, sorry! I had meant to change this after our discussion, and simply overlooked it while reworking the patches. I'll include this change in a v4 which also addresses e.g. the comments on commit 1. > > -- > Peter Xu >