From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1B55C433FE for ; Tue, 4 Oct 2022 22:05:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 472746B0073; Tue, 4 Oct 2022 18:05:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 422418E0001; Tue, 4 Oct 2022 18:05:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2EACD6B0075; Tue, 4 Oct 2022 18:05:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 1D54F6B0073 for ; Tue, 4 Oct 2022 18:05:07 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id E220B160A39 for ; Tue, 4 Oct 2022 22:05:06 +0000 (UTC) X-FDA: 79984648212.26.035B663 Received: from mail-lj1-f177.google.com (mail-lj1-f177.google.com [209.85.208.177]) by imf17.hostedemail.com (Postfix) with ESMTP id 85D264001E for ; Tue, 4 Oct 2022 22:05:06 +0000 (UTC) Received: by mail-lj1-f177.google.com with SMTP id s10so16812960ljp.5 for ; Tue, 04 Oct 2022 15:05:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=i4aLMA4TA4CUFLBRQaS0urvmpnTEansyOz9PB91rDxQ=; b=fvOz7nE9Sf/CQGQN+iCHQaNaUiAVy2Jwui0QCRrMq7g3Ms3toSbqY+oLHQJ/7s+BzB czGGifrvjdzwm3YGI3g+x58+awgwBtR9YMx8zzFiQcGB0paUSISCH03JltfgD7ri93Bl TI9qgHM4HLipzOCxMazfjR09DmzFu66q/7Mo9/9ZHrey8+dntRR/H2WRHTF7od2po8ql HQDOGCUDuIWJ5Z/WGpUtMRs45Lxe/b3eMn5hW1tSI1/kvRdFqcAt/ojhb7BAw21n+7TB mNK9zbbVGK+JqMi7nFikmmHJvY3T44efBBW6Oa6hsfY1UzVq4zxpx0uuB+jmMPbgfe4b fQLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=i4aLMA4TA4CUFLBRQaS0urvmpnTEansyOz9PB91rDxQ=; b=02YysKeRHq4VlrXH1VxKTI59c+9EI2RU/vpiV3vj0KM65lsnajuZHa3bZR0Nwuzn6N 9lky2PFIPkrRxoxMw3slU5uJTvYZnAftdFWFl3ZIPXU4GlRZk6WxoZPs49OgI24B1fYo /OfN43C1RZYp3zyWL8coI0BQQD9uRn2t1+vBnUC2YrO2Dr79EZPlcVGDaFc8bbr+1wdY UhVU2ebzLWep/31TYi9PUgq0/4OBCokTo82M6DKDxrQVzk8ddNl4f0/V1w5ETCRMPfSe cd7rAQc5a4P05KpC7nRumKJkJ9jj5lByGTv/y0WCdEmxCcaDBoRHhJRB5vsj2FmzgvBO 5tbQ== X-Gm-Message-State: ACrzQf093y7X6UtVEAM9xuXgB14VHjSsObkPY+T17xChSu6c7mCZDTAK wj3oRJa1T4RYqQxJJDlrthgbAJcjFpeZotx6+q9zTA== X-Google-Smtp-Source: AMsMyM7d7jCfiWrDjkaNdcqhsSyr1Id9/3igeyAAckgYGEWVBIqHNHJtrjzHjy/zi7gkx/0qPizYnb7ArhemyDEsrUo= X-Received: by 2002:a2e:8190:0:b0:26b:d94b:75e9 with SMTP id e16-20020a2e8190000000b0026bd94b75e9mr9429804ljg.379.1664921104881; Tue, 04 Oct 2022 15:05:04 -0700 (PDT) MIME-Version: 1.0 References: <20221004214125.120993-1-peterx@redhat.com> <20221004214305.121405-1-peterx@redhat.com> In-Reply-To: <20221004214305.121405-1-peterx@redhat.com> From: Axel Rasmussen Date: Tue, 4 Oct 2022 15:04:28 -0700 Message-ID: Subject: Re: [PATCH 4/4] selftests/vm: Drop mnt point for hugetlb in run_vmtests.sh To: Peter Xu Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Mike Kravetz , Andrew Morton Content-Type: text/plain; charset="UTF-8" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1664921106; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=i4aLMA4TA4CUFLBRQaS0urvmpnTEansyOz9PB91rDxQ=; b=ocWgUXwL6XjoMpxTaUAPxp00yZVJ+YztbHvXwKaUY/Q3tnVA8mA0MsIQLM8XDIZCIkd3ny mewGetoW6h/7U0X4MPc8J2nrkyIHKD3wg/1KteEBqxXB4qKU7DbaommHhdUKAS3DoKMTt9 S0UfRnR3tkHEjasYRQUypFcVxa9mRw4= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=fvOz7nE9; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf17.hostedemail.com: domain of axelrasmussen@google.com designates 209.85.208.177 as permitted sender) smtp.mailfrom=axelrasmussen@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1664921106; a=rsa-sha256; cv=none; b=RUl/LqKR17bMVdiNn61aOFLV1O84Nus2VHXZCTlCGgdUSNw0q7onIMG4gjDozDVxPKNsnj BtrQ8X7JKbTzekZT3DEcbGdPawUarafiu8Gxeu80irh87AyxGkw4eXox7Ok9n+nuFs0/VE uAU0M4mE6qm5dBhfqf63e9rm9f0MkZo= X-Rspamd-Queue-Id: 85D264001E Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=fvOz7nE9; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf17.hostedemail.com: domain of axelrasmussen@google.com designates 209.85.208.177 as permitted sender) smtp.mailfrom=axelrasmussen@google.com X-Rspam-User: X-Rspamd-Server: rspam10 X-Stat-Signature: ykdpgp1n9cnswnwuujdhx9mkhuw7s819 X-HE-Tag: 1664921106-797629 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Oct 4, 2022 at 2:43 PM Peter Xu wrote: > > After converting all the three relevant testcases (uffd, madvise, mremap) > to use memfd, no test will need the hugetlb mount point anymore. Drop the > code. > > Signed-off-by: Peter Xu > --- > tools/testing/selftests/vm/run_vmtests.sh | 18 +++--------------- > 1 file changed, 3 insertions(+), 15 deletions(-) > > diff --git a/tools/testing/selftests/vm/run_vmtests.sh b/tools/testing/selftests/vm/run_vmtests.sh > index e780e76c26b8..0dc9f545a32d 100755 > --- a/tools/testing/selftests/vm/run_vmtests.sh > +++ b/tools/testing/selftests/vm/run_vmtests.sh > @@ -5,7 +5,6 @@ > # Kselftest framework requirement - SKIP code is 4. > ksft_skip=4 > > -mnt=./huge > exitcode=0 > > #get huge pagesize and freepages from /proc/meminfo > @@ -84,9 +83,6 @@ run_test() { > fi > } > > -mkdir "$mnt" > -mount -t hugetlbfs none "$mnt" > - > run_test ./hugepage-mmap > > shmmax=$(cat /proc/sys/kernel/shmmax) > @@ -98,14 +94,9 @@ echo "$shmmax" > /proc/sys/kernel/shmmax > echo "$shmall" > /proc/sys/kernel/shmall > > run_test ./map_hugetlb > - > -run_test ./hugepage-mremap "$mnt"/huge_mremap > -rm -f "$mnt"/huge_mremap > - > +run_test ./hugepage-mremap > run_test ./hugepage-vmemmap > - > -run_test ./hugetlb-madvise "$mnt"/madvise-test > -rm -f "$mnt"/madvise-test > +run_test ./hugetlb-madvise > > echo "NOTE: The above hugetlb tests provide minimal coverage. Use" > echo " https://github.com/libhugetlbfs/libhugetlbfs.git for" > @@ -126,14 +117,11 @@ for mod in "${uffd_mods[@]}"; do > # Hugetlb tests require source and destination huge pages. Pass in half > # the size ($half_ufd_size_MB), which is used for *each*. > run_test ./userfaultfd hugetlb${mod} "$half_ufd_size_MB" 32 > - run_test ./userfaultfd hugetlb_shared${mod} "$half_ufd_size_MB" 32 "$mnt"/uffd-test > - rm -f "$mnt"/uffd-test > + run_test ./userfaultfd hugetlb_shared${mod} "$half_ufd_size_MB" 32 > run_test ./userfaultfd shmem${mod} 20 16 > done > > #cleanup > -umount "$mnt" > -rm -rf "$mnt" > echo "$nr_hugepgs" > /proc/sys/vm/nr_hugepages > > run_test ./compaction_test > -- > 2.37.3 > Feel free to take: Reviewed-by: Axel Rasmussen