From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 747DFC4332F for ; Thu, 2 Nov 2023 21:32:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E1D458D00AA; Thu, 2 Nov 2023 17:32:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DA6688D000F; Thu, 2 Nov 2023 17:32:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BF9558D00AA; Thu, 2 Nov 2023 17:32:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id AB4C58D000F for ; Thu, 2 Nov 2023 17:32:44 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 7E10CA0F69 for ; Thu, 2 Nov 2023 21:32:44 +0000 (UTC) X-FDA: 81414313848.14.E085B22 Received: from mail-ej1-f51.google.com (mail-ej1-f51.google.com [209.85.218.51]) by imf28.hostedemail.com (Postfix) with ESMTP id A7ADCC0020 for ; Thu, 2 Nov 2023 21:32:42 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=NWQCDO4K; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf28.hostedemail.com: domain of axelrasmussen@google.com designates 209.85.218.51 as permitted sender) smtp.mailfrom=axelrasmussen@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1698960762; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Vq5NPo4MczJen086IQAvce9UPFocIswVxg9xIedCGQw=; b=dN678+4lXRxmpI4p1iNrniSLjVpYt2mAn4u1fCHciAZtsG0qg6sQDqTk99neRZVGR8wx5M OFZ915NKaym5/gMn93DeWBHt+NgCUzFS7k+iQoJeyXZne6GS7SzixlMXgUlJjaZStR5F5u J+hDAO3KOaGw11HpF7f6RNSYvhJeHFA= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=NWQCDO4K; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf28.hostedemail.com: domain of axelrasmussen@google.com designates 209.85.218.51 as permitted sender) smtp.mailfrom=axelrasmussen@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1698960762; a=rsa-sha256; cv=none; b=s38l5UnkEKFk9iNdJQelS1awdoEl5mbU6I4NT854HOQeAVMMm7Ky23oghiu/rGRgEXLRxk Ae5nBFbwKgE767yc4ZoR+1uSmekRYmhSOat9/QM0kcb4NxYzT5E73QA28iYa0qajOap0X9 SxI6qOuIg2Yaix8xtiwHyD78PIpmvQM= Received: by mail-ej1-f51.google.com with SMTP id a640c23a62f3a-9d242846194so214830166b.1 for ; Thu, 02 Nov 2023 14:32:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1698960761; x=1699565561; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Vq5NPo4MczJen086IQAvce9UPFocIswVxg9xIedCGQw=; b=NWQCDO4KsGmFYcmvbALG8VDBS9Y3D15xtpkMyolCI2EwWnF5ejbIQmSTznLt61E5io XJ141ZNaKImRJLHSVznWs8qQE/ZHH63zfLoWtWagC9xyg2j12fnDBJeEXezPGvUPIn1z eIOqMwZF+g10saT/x4RI46PpOfG0NsNqiB0tfjH7hgf5qdpsSB2RtBbKOzEz+BwwzMab g7KKFawzlUy0n/r46VX8RDkViITqpau5zeqt6zk0JHr5VS8WQaF9IiYVncmwFhXqNaOL SnfNIydZrOEcZQkIEwz0ezfT5zskVHNlgSamTX7l1ZlxVjOrExQrsUrEWNEw1f16jlTh +O/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698960761; x=1699565561; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Vq5NPo4MczJen086IQAvce9UPFocIswVxg9xIedCGQw=; b=KGjF0w4miBTOwvXwufZPQSZI1iQXj+EFoXvCZg7A4DJW4zhJkuuuwxxMSeRG0M4nax /rgEkFVMisjD4yeauXBvywLG/nPM3APxOOMHEnuM0C8YHm1Wuu2/08bd77vijYkMwAU7 caMBHUlEPGjFh6/yf52h/I8UXbDciw6ChsP2gLIJeXb3s73faW1hspWnwHrIhbtcuz4H xDyqxJNPs93iq/t7ccqd2H3lTlnVLrFPys7wJQnMymfSYoyQA5fFHNf0pPje/HYa/EYA K2plbfC6dvuaqLdm9l3H3LP1sFYIYAbGW6fO/MAnxCFg2ZwzR9Gf4PbIwZVX/6eTHg0E /I7w== X-Gm-Message-State: AOJu0YzpYOeHvckiqWMFExlHDTJqFCGk4Wwi7/MFLV8GcBG+up7eQ+Jr TP6hY/6xQIs0u7nH+1j5QyPkyUgUPrtlL+gq12O2EA== X-Google-Smtp-Source: AGHT+IGyZP9u6aAbNP6NikHtNCgyA7xGVqp3DPsClZgLA9ftj3/+w+BBKe6H9xBGihWxGn5Wl/jeqaf7Czg+Qc1ZkLA= X-Received: by 2002:a17:907:954f:b0:9c4:4b20:44a1 with SMTP id ex15-20020a170907954f00b009c44b2044a1mr3798351ejc.65.1698960760931; Thu, 02 Nov 2023 14:32:40 -0700 (PDT) MIME-Version: 1.0 References: <20231028003819.652322-1-surenb@google.com> <20231028003819.652322-4-surenb@google.com> In-Reply-To: From: Axel Rasmussen Date: Thu, 2 Nov 2023 14:32:02 -0700 Message-ID: Subject: Re: [PATCH v4 3/5] selftests/mm: call uffd_test_ctx_clear at the end of the test To: Peter Xu Cc: Suren Baghdasaryan , akpm@linux-foundation.org, viro@zeniv.linux.org.uk, brauner@kernel.org, shuah@kernel.org, aarcange@redhat.com, lokeshgidra@google.com, david@redhat.com, hughd@google.com, mhocko@suse.com, rppt@kernel.org, willy@infradead.org, Liam.Howlett@oracle.com, jannh@google.com, zhangpeng362@huawei.com, bgeffon@google.com, kaleshsingh@google.com, ngeoffray@google.com, jdduke@google.com, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, kernel-team@android.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: A7ADCC0020 X-Stat-Signature: bndiaguprhp8g8wsz76g6j8hao8xac6k X-HE-Tag: 1698960762-10435 X-HE-Meta: U2FsdGVkX18Jq5Pqx4Dfm6RgcMisELiyOKpcxmIiO5UauZQU5Hq4lyh7AWJIhlYzt9nmJOU8CIHZVoXjPlS71R/MoznogfLMKKiiyl00Ymrdbm32gDBDi3x4ahtY2Ve3VtHJCm8Eu7EjXYjchwCHCQHGGGlKl3CJXIeh0Cvzmuaq23L0IlNyQSCkAEX96VjZo/klGxoOvBwgAyqvlQHqz3TdD+cNdgLdD/BV6CQrT5YL6NwrvyvdnXz2NJmhxs8BiCmEzZdROV76iC898DmePDrpTag8B94daKGGqDzvCYaXDO2aG4AkAAkVvc5GuTf1DUcy0lAwsHVYO+qp3ZlYQ9tw+9njLlJj7Vhe2lVmPfvj3FGnsLssnIrQfMiuBqAz8YudKkeRnGi42T44L1yRs/AZeRkKyMUslwewpFTPyaiXJ+2htMM4GtNx8/Z/e98EzrxAUlLmhIZY6aUGtx5KmiWcMLEapqkikVX7fTTjF7wJu19bhmNT1FLjRTj+rw5xy066Wh9xDVxcyOCQX93GOD1MVPJgr+p9JIfMogt8FDBqb/awXB+zq3bLQXTFb5x4OunXiWjtOFCVVne6HZ6wL/tuioyFihCAWxHbh/jx3HVrlIrBY4KLtt2nRNOav3UpeG87KJt6w7S5TW/GGhGnI2WufBsrCp9FSC2eKi2d805oQhDvjYJl2wOxELB9LJOroqFgvYnEkD7sWmnMSFed5y6t304rXgMr+rV8SozEtATrZK8Twruty9Lv+N5pEx7a6aOxZXUQ35FkJt5yryxYcX/+93dJE4x9RTHvGf7lT22OrbGdt6YuShb5wZ+nZhSgXxTRUWRB99+dI064tBI6Qzj0r6sZ+UWkldALxr3SLpJF6vhZJyFliya3FxfPhBRckfa5F2xJOpNd5z4xmnFNOgT2RxsMpQHtBeUmglZF2XET1qP1NWbZDu7euApUeHA/bGynQOrnrJrlFboRFkJ nNnSBEgM NPE4cl1hb11XmeX2zCaP0r+p5UgV2KJHkSBZToHx54A4HU5KwGLIhWKneZ+LEiJ33z0Mj6Jc2Tmz7hJtZ9yGnMfB3zqomnoYkkFIj66hiL32vI6fnKw1AGukjKK1OoqRsURbxySAokZM7I2trqA4dzGRpg8DzsjYGwgTuzYK1at1TjsMajWQFaUZbnFVoBNcv3H2cTZEYVf4acaIjTjrjDhG0iGWvAhouyDSFtRyJdbvkqIGE7sqj21OYBBcJLCq6kJzHK0Oi+1oxCULOeByWvAm40XMo7zty/DkBDjAbYifjnAS3EEqcDn5/qQQS5zO7ECG8n7IRYDj4aPC9DuDoIkHUqCes9d2CSJQ8Ql3aGKWyqhjfkJQfVVWsp5hIaWKESvuz X-Bogosity: Ham, tests=bogofilter, spamicity=0.023205, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Oct 30, 2023 at 1:14=E2=80=AFPM Peter Xu wrote: > > On Fri, Oct 27, 2023 at 05:38:13PM -0700, Suren Baghdasaryan wrote: > > uffd_test_ctx_clear() is being called from uffd_test_ctx_init() to unma= p > > areas used in the previous test run. This approach is problematic becau= se > > while unmapping areas uffd_test_ctx_clear() uses page_size and nr_pages > > which might differ from one test run to another. > > Fix this by calling uffd_test_ctx_clear() after each test is done. > > > > Signed-off-by: Suren Baghdasaryan > > Reviewed-by: Peter Xu Looks correct to me as well. Thanks for fixing this, Suren! Reviewed-by: Axel Rasmussen > > -- > Peter Xu >