From: Axel Rasmussen <axelrasmussen@google.com>
To: Peter Xu <peterx@redhat.com>
Cc: Suren Baghdasaryan <surenb@google.com>,
akpm@linux-foundation.org, viro@zeniv.linux.org.uk,
brauner@kernel.org, shuah@kernel.org, aarcange@redhat.com,
lokeshgidra@google.com, david@redhat.com, hughd@google.com,
mhocko@suse.com, rppt@kernel.org, willy@infradead.org,
Liam.Howlett@oracle.com, jannh@google.com,
zhangpeng362@huawei.com, bgeffon@google.com,
kaleshsingh@google.com, ngeoffray@google.com, jdduke@google.com,
linux-mm@kvack.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
kernel-team@android.com
Subject: Re: [PATCH v4 3/5] selftests/mm: call uffd_test_ctx_clear at the end of the test
Date: Thu, 2 Nov 2023 14:32:02 -0700 [thread overview]
Message-ID: <CAJHvVcibtwWom6w=jdYa+712ZEVM3Kcy9RQwgfgHi8b=1nF9jg@mail.gmail.com> (raw)
In-Reply-To: <ZUAOsn9Fj/qCo+xg@x1n>
On Mon, Oct 30, 2023 at 1:14 PM Peter Xu <peterx@redhat.com> wrote:
>
> On Fri, Oct 27, 2023 at 05:38:13PM -0700, Suren Baghdasaryan wrote:
> > uffd_test_ctx_clear() is being called from uffd_test_ctx_init() to unmap
> > areas used in the previous test run. This approach is problematic because
> > while unmapping areas uffd_test_ctx_clear() uses page_size and nr_pages
> > which might differ from one test run to another.
> > Fix this by calling uffd_test_ctx_clear() after each test is done.
> >
> > Signed-off-by: Suren Baghdasaryan <surenb@google.com>
>
> Reviewed-by: Peter Xu <peterx@redhat.com>
Looks correct to me as well. Thanks for fixing this, Suren!
Reviewed-by: Axel Rasmussen <axelrasmussen@google.com>
>
> --
> Peter Xu
>
next prev parent reply other threads:[~2023-11-02 21:32 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-28 0:38 [PATCH v4 0/5] userfaultfd move option Suren Baghdasaryan
2023-10-28 0:38 ` [PATCH v4 1/5] mm/rmap: support move to different root anon_vma in folio_move_anon_rmap() Suren Baghdasaryan
2023-10-30 20:15 ` Peter Xu
2023-10-28 0:38 ` [PATCH v4 2/5] userfaultfd: UFFDIO_MOVE uABI Suren Baghdasaryan
2023-10-28 7:43 ` kernel test robot
2023-10-28 0:38 ` [PATCH v4 3/5] selftests/mm: call uffd_test_ctx_clear at the end of the test Suren Baghdasaryan
2023-10-30 20:14 ` Peter Xu
2023-11-02 21:32 ` Axel Rasmussen [this message]
2023-10-28 0:38 ` [PATCH v4 4/5] selftests/mm: add uffd_test_case_ops to allow test case-specific operations Suren Baghdasaryan
2023-10-28 0:38 ` [PATCH v4 5/5] selftests/mm: add UFFDIO_MOVE ioctl test Suren Baghdasaryan
2023-10-30 20:14 ` Peter Xu
2023-10-30 20:22 ` Suren Baghdasaryan
2023-10-30 20:35 ` Peter Xu
2023-10-30 21:22 ` Suren Baghdasaryan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJHvVcibtwWom6w=jdYa+712ZEVM3Kcy9RQwgfgHi8b=1nF9jg@mail.gmail.com' \
--to=axelrasmussen@google.com \
--cc=Liam.Howlett@oracle.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=bgeffon@google.com \
--cc=brauner@kernel.org \
--cc=david@redhat.com \
--cc=hughd@google.com \
--cc=jannh@google.com \
--cc=jdduke@google.com \
--cc=kaleshsingh@google.com \
--cc=kernel-team@android.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lokeshgidra@google.com \
--cc=mhocko@suse.com \
--cc=ngeoffray@google.com \
--cc=peterx@redhat.com \
--cc=rppt@kernel.org \
--cc=shuah@kernel.org \
--cc=surenb@google.com \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
--cc=zhangpeng362@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox