From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 123D7C761A6 for ; Thu, 30 Mar 2023 19:08:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9CDE36B0074; Thu, 30 Mar 2023 15:08:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 97E53900003; Thu, 30 Mar 2023 15:08:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 81EEB900002; Thu, 30 Mar 2023 15:08:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 6CC516B0074 for ; Thu, 30 Mar 2023 15:08:04 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 378B31C687E for ; Thu, 30 Mar 2023 19:08:04 +0000 (UTC) X-FDA: 80626499688.06.6D237F8 Received: from mail-lf1-f46.google.com (mail-lf1-f46.google.com [209.85.167.46]) by imf27.hostedemail.com (Postfix) with ESMTP id 62D8640007 for ; Thu, 30 Mar 2023 19:08:02 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=OAORZJ8B; spf=pass (imf27.hostedemail.com: domain of axelrasmussen@google.com designates 209.85.167.46 as permitted sender) smtp.mailfrom=axelrasmussen@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680203282; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UkfHhmuNDtES3wYzezkCW7sqz9SEBsf93iKb4NtAWWA=; b=eRsiGHv5Pw55RfOw4RuS/OaEW6JbuZfbzv+HvJi02UPvtKoz6AY5BhO1F/pcItF6TJiFng 3u3NLLdEb1tAfPFthE3+Fh6ENrIxO0N3Q/ioN6x/NkqnGPe6B5ftp2ddRVFkKWbtCdFo0L egUAZLU/QbBngrbn3GyeEV4VSu+nE24= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=OAORZJ8B; spf=pass (imf27.hostedemail.com: domain of axelrasmussen@google.com designates 209.85.167.46 as permitted sender) smtp.mailfrom=axelrasmussen@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680203282; a=rsa-sha256; cv=none; b=1VfyZfUSL6lwdiNCJEz/hsXlaj1yhGkC+8sLCG2dFbs1p7eyXtoREFW4ZFTvLR2/do396I oHzy9/25Y4UkGUpqO1jieEsX4ryvSZ4/ALtUoq43eGQ+rIViwXBPOladE8BGQqluR2xG71 LW+OWiUqVFmuRXHOsq9TcJiOBaOUXpg= Received: by mail-lf1-f46.google.com with SMTP id q16so25815170lfe.10 for ; Thu, 30 Mar 2023 12:08:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; t=1680203281; x=1682795281; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=UkfHhmuNDtES3wYzezkCW7sqz9SEBsf93iKb4NtAWWA=; b=OAORZJ8B+8ILUveEQSOditFI7MMuGWICgBkrpgTQ2xdhvDWj7J/d0D4CvFK7NkGQ+f KkshquZXiFWKUu9VIJPRxmzVwn2aDGy0L+9JkgeaH7qOD3cd8G0WZSV+5erFU9jx8KOI OxNzjaUcyKtiNUoumP5e8zlQycBurpLjhXrn4pjRBwTUfApID38epXge+2vkQjCD2gKr Cr+42b1RJDE/kSlr1oaWM73CegUJ2A2GV1lHYoRyTL+PbabmBOaSWv9zc9YLr4nnfXZy MLT7UJHXlwCmrgzV2qYlqkAmqxM54pdZUJM5aMMjpNtjy8qGsTOXkCR+JjVxYIeiAFD+ lp6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680203281; x=1682795281; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=UkfHhmuNDtES3wYzezkCW7sqz9SEBsf93iKb4NtAWWA=; b=oweV2dwOfuy3Uai1PyPzweLH8OE/YB/LTMGOMEl5o0DB9kkln/6dcojrKcjzevWFa3 3Ohufk9JrnGTM6bTiH201/Fhi7uceJXwN6Qnw58A2Zzb3kdfhoBHmKgW+JqeCtYIRDMI ijinEVpajC0H2aZKmtX4uhopfm5Ba4nYLoNSwwBTBPY5vJV76bH35Y3pq+6lg1DkP8YB Ax/kXF8Zx3RIy5AjIFfEzlFmIITGIOs4XZU7d0X+wzGKFFWgP5d2dO6IlxUlaR321nti PflXj88UB9h/zTz/TZYwuQklnCSN8GfOCBdTDN4RYd+2MycpFQVc2p0Dl/VWkG+9CHSb 0BgA== X-Gm-Message-State: AAQBX9cSzQYT3JTv2N6seSCJJH4gIhqAewKVldUSVTaHhb27AekTDMWi uCw7dkUHGBB5Pciw9E5S4HtMovlbND7q03kvk1C9DA== X-Google-Smtp-Source: AKy350YDDs/afajur7OK3Ca3KVN76ejnOJuk5Tc5kvk9hEjc+j+Mk0udD+7c4Hm707MMe6h5g0SuPMQWzFpnMlMK98U= X-Received: by 2002:ac2:50c3:0:b0:4d5:ca32:6aea with SMTP id h3-20020ac250c3000000b004d5ca326aeamr7320661lfm.10.1680203280564; Thu, 30 Mar 2023 12:08:00 -0700 (PDT) MIME-Version: 1.0 References: <20230330155707.3106228-1-peterx@redhat.com> <20230330160646.3106903-1-peterx@redhat.com> In-Reply-To: <20230330160646.3106903-1-peterx@redhat.com> From: Axel Rasmussen Date: Thu, 30 Mar 2023 12:07:24 -0700 Message-ID: Subject: Re: [PATCH 03/29] selftests/mm: Dump a summary in run_vmtests.sh To: Peter Xu Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, David Hildenbrand , Andrew Morton , Andrea Arcangeli , Mike Kravetz , Leonardo Bras Soares Passos , Mike Rapoport , Nadav Amit Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: no3suung9tgknz3i53oe9gshd9rttnym X-Rspamd-Queue-Id: 62D8640007 X-HE-Tag: 1680203282-445491 X-HE-Meta: U2FsdGVkX1/XOk2I8qe7lElgFacRr6Vfvm8nEFc2Eps7MYegK1wFLr41jZvQuAT+53hj8D9aEiPd/2mHBpI5sMJXxS/eLveiUEjc2cP+qG1vLmL/jPYCFjdYfv1IIj52ieMySkA3OUHzqL8TynjwZLCgOpcslsI3j7OVwEaigvuSXr94slRpwAZIv58bnQaLII6cjdhqjwjVmr9J6RPWc5OAi5TR6YQ7WxgNyTwjwxgKcBeNNMxorT6Q42Gild5H6KOy4HGtZFAjxeD9NyiJXtYG1PFqh0x8o+ubtk59WjcHikKU48wqSu1RQWoxkKrnwauIa+OqTdnlCKlAr8rYzE/h0l8niw7/BjQkd4btGanMXfeRokOZmDcjNJ+G/k21DttDdsfJShksMD1BtaNb+ppgrFjequOII858GvaIjIfPdNyMkwceyC0o2nDa8jTq/dZlYuYYzfKJcrbI49TPm3kimEj/KJZDjjJUkp5Nvxry4GYquTExkVgBOTm+wVjUAE8cabaffvDNkRiAGcHoxmzEKXHsl1tuZpNc4CZRfejOnZFobjMM3L/CeYfLHRAcVMv9dVmOwXo+0R3FO3Ra1HmmM8maWM7Hy+6iDeSVTWXSk2gG/U5aSj39Hzya1Gql0EM0JtqQAOoIo0xhybzWIt34c6AUAu5+za0fImJPOoAzfiZGwkNFmXsydI4yWi0V1NHLyitlQawCfsH7SncaQNtjDbb76J0SXHhRz/+adA1eQPsiU3j29v9Uw8e3KdQer9HJL0oiGSZ/xCY6RuEptqcUVJFKcLAhC2Uj9IpUzIgoPWRNJaHRV1YWf24K2cepSCxU3iiZNJDm6etQjTCbDHl/OaDX5h7AYmeVOdc9M1IwKXEfqwYkVgDY154DinvUPjkQvT3orqlT1v708sV2R+EuTgqbXz/CrgEqICK23WKUEUtfy62RXeP5TkmBh2REfDGAtwVSLGgdaSX+0Ej JV9x+cm+ T60bfOfWIdyvpatEcjxis0SEEW8JLyUGvnGn+8J5iD7BErWuUBX0mCQAS05nfX6VSdp9YqnwJcgMG+BBnJ5Mf2pDZeHv5MlwUG/HQ04+TtnCDYU3QBfrXv1pvGX6YlhH8CjgcUHEfggXonkfyOxoUwQALpvHkBL+j1fyUNNFIKFPrX7IGG9aYbhyp17DHDKDjL4Q41yHEHCVUTm7c89yck87k4Q5yggyDcYXJl12AG8qUlbQxdAXd/5iMCVVOFlnOcXU8o84Z2DtPBvQh+0RkUKV9TSqYyhYhFN6VKeh4frOPmidIiW05ak6zEYVTl3J3c3Ir72jtfBZNYkFi0UoWrcAaflcdp33MyRIY44eUmI93+298j8Lksxt3/rdWMTHii/W9BV/5O1iW+jf1/6JOKCMzIwu14Fivp4D+ X-Bogosity: Ham, tests=bogofilter, spamicity=0.002931, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Mar 30, 2023 at 9:06=E2=80=AFAM Peter Xu wrote: > > Dump a summary after running whatever test specified. Useful for human > runners to identify any kind of failures (besides exit code). > > Signed-off-by: Peter Xu > --- > tools/testing/selftests/mm/run_vmtests.sh | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/tools/testing/selftests/mm/run_vmtests.sh b/tools/testing/se= lftests/mm/run_vmtests.sh > index c0f93b668c0c..9cc33984aa9f 100644 > --- a/tools/testing/selftests/mm/run_vmtests.sh > +++ b/tools/testing/selftests/mm/run_vmtests.sh > @@ -5,6 +5,9 @@ > # Kselftest framework requirement - SKIP code is 4. > ksft_skip=3D4 > > +count_pass=3D0 > +count_fail=3D0 > +count_skip=3D0 > exitcode=3D0 > > usage() { > @@ -149,11 +152,14 @@ run_test() { > "$@" > local ret=3D$? > if [ $ret -eq 0 ]; then > + count_pass=3D$(( $count_pass + 1 )) Actually, inside $(( )) there's no need to prefix variable names with $ too. Running "shellcheck" over the script written this way will generate a warning. Same applies below. > echo "[PASS]" > elif [ $ret -eq $ksft_skip ]; then > + count_skip=3D$(( $count_skip + 1 )) > echo "[SKIP]" > exitcode=3D$ksft_skip > else > + count_fail=3D$(( $count_fail + 1 )) > echo "[FAIL]" > exitcode=3D1 > fi > @@ -279,4 +285,6 @@ CATEGORY=3D"soft_dirty" run_test ./soft-dirty > # COW tests > CATEGORY=3D"cow" run_test ./cow > > +echo "SUMMARY: PASS=3D${count_pass} SKIP=3D${count_skip} FAIL=3D${count_= fail}" > + > exit $exitcode > -- > 2.39.1 > Besides the nitpick: Reviewed-by: Axel Rasmussen