From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7AF32C433B4 for ; Tue, 27 Apr 2021 20:29:54 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 0979A613E8 for ; Tue, 27 Apr 2021 20:29:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0979A613E8 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 47F986B0036; Tue, 27 Apr 2021 16:29:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 42F336B006E; Tue, 27 Apr 2021 16:29:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2A8DE6B0070; Tue, 27 Apr 2021 16:29:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0215.hostedemail.com [216.40.44.215]) by kanga.kvack.org (Postfix) with ESMTP id 0BEAB6B0036 for ; Tue, 27 Apr 2021 16:29:53 -0400 (EDT) Received: from smtpin38.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id B0A54181AF5C4 for ; Tue, 27 Apr 2021 20:29:52 +0000 (UTC) X-FDA: 78079288224.38.2525ADF Received: from mail-io1-f51.google.com (mail-io1-f51.google.com [209.85.166.51]) by imf22.hostedemail.com (Postfix) with ESMTP id D3B52C0007EA for ; Tue, 27 Apr 2021 20:29:45 +0000 (UTC) Received: by mail-io1-f51.google.com with SMTP id f21so24773122ioh.8 for ; Tue, 27 Apr 2021 13:29:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=WzJWSS3LQ6tF0DgK++1lrPiC81dYzxiPck8oPTQIuQM=; b=gbNFD7FoTA7n8IPPyw2KHOylIt8tzudj0Lpkdgu7mzsab/vYDoCX8VQ2+pW2PafQbp JxR1XGRxzePWZg0k/lL8HrzfJX1SnDe5TpFzpooVXmvhCVtquqkAHffLdiPX/s4G6iTl 9ONp86hzSzE7P1p3W+LL5QOZ/CQ3Ze/kT8jGK0OwsPFtA9fF3Z8j93LJX1jAzWtovcFo wraUFwADLhrGc/ZRhKyMAE1vzcpZTFlKnS3wTfzLUX/OyuUTfXrJrtKvBZoyZWbDyJDM IGj8vWkjpL1dSCRy2ZHIBkB+wFNwbbCdZZCFIG8416YkWzweIhGhpxBxMpCiUWXMipAc 5UdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=WzJWSS3LQ6tF0DgK++1lrPiC81dYzxiPck8oPTQIuQM=; b=Usvx5EkSn07JwtQnUa+/jbpdfHh3Uyh04qC5HDuP5afuZyLr9T2GT1+Ae14KVFgrC+ R6PbXUeZfemkpgXZbwbY6JEDCDAkTv9P9OEBPvQ7z3GUKgckOMfmWnCZjMsu0NJUWeT4 fV5KOMVQVFwb1E4B8e3W7w/0uYLC4qzMmDzT8L0yWXi+DTJw4a1qpsgsoCMB5L1wTox7 cWdz12hVlm7S6yS4TSFEIWqb+adTxkPBOyOOBU7FreFk/iqn5fxwaNSDquQY5hM0CrV+ uLQtSeSvDmYeXdIpJfeLYJN8LQ7woyaff6zPkYDDecML+9bosGGn2MYh3UZGLkkRn+o2 FlCQ== X-Gm-Message-State: AOAM532MKVQEmgaMziQCptolQLk5c9ajtbY4plZLvDRnF6WXF+SLAYfK WPFA/jl2EDEfTmk97dvBGMNB/uLxGCY9u2ZgwyHidg== X-Google-Smtp-Source: ABdhPJz7iNqaf7JHZFiCQ426WqlOiaRzxCMbG8Vk0qKa7/LDNoylh0febweO3CgkD2dvFe5U0B95hMpS/QZFyMb3tpE= X-Received: by 2002:a05:6638:3387:: with SMTP id h7mr12471126jav.96.1619555391579; Tue, 27 Apr 2021 13:29:51 -0700 (PDT) MIME-Version: 1.0 References: <20210420220804.486803-1-axelrasmussen@google.com> <20210420220804.486803-4-axelrasmussen@google.com> <20210427155414.GB6820@xz-x1> <20210427180314.GD6820@xz-x1> In-Reply-To: <20210427180314.GD6820@xz-x1> From: Axel Rasmussen Date: Tue, 27 Apr 2021 13:29:14 -0700 Message-ID: Subject: Re: [PATCH v4 03/10] userfaultfd/shmem: support UFFDIO_CONTINUE for shmem To: Peter Xu Cc: Hugh Dickins , Alexander Viro , Andrea Arcangeli , Andrew Morton , Jerome Glisse , Joe Perches , Lokesh Gidra , Mike Kravetz , Mike Rapoport , Shaohua Li , Shuah Khan , Stephen Rothwell , Wang Qing , linux-api@vger.kernel.org, linux-fsdevel@vger.kernel.org, LKML , linux-kselftest@vger.kernel.org, Linux MM , Brian Geffon , "Dr . David Alan Gilbert" , Mina Almasry , Oliver Upton Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: D3B52C0007EA X-Stat-Signature: 1rrx7fk77et85w885sfqz9pk1ic7jkhp X-Rspamd-Server: rspam02 Received-SPF: none (google.com>: No applicable sender policy available) receiver=imf22; identity=mailfrom; envelope-from=""; helo=mail-io1-f51.google.com; client-ip=209.85.166.51 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1619555385-44005 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Apr 27, 2021 at 11:03 AM Peter Xu wrote: > > On Tue, Apr 27, 2021 at 09:57:16AM -0700, Axel Rasmussen wrote: > > I'd prefer to keep them separate, as they are not tiny patches (they > > are roughly +200/-150 each). And, they really are quite independent - > > at least in the sense that I can reorder them via rebase with no > > conflicts, and the code builds at each commit in either orientation. I > > think this implies they're easier to review separately, rather than > > squashed. > > > > I don't have a strong feeling about the order. I slightly prefer > > swapping them compared to this v4 series: first introduce minor > > faults, then introduce CONTINUE. > > > > Since Peter also has no strong opinion, and Hugh it sounds like you > > prefer it the other way around, I'll swap them as we had in some > > previous version of this series: first introduce minor faults, then > > introduce CONTINUE. > > Yes I have no strong opinion, but that's probably the least I prefer. :-) > > Because you'll declare UFFD_FEATURE_MINOR_SHMEM and enable this feature without > the feature being completely implemented (without UFFDIO_CONTINUE, it's not > complete since no one will be able to resolve that minor fault). > > Not a big deal anyway, but since we're at it... Basically I think three things > to do for minor shmem support: > > (1) UFFDIO_CONTINUE (resolving path) > (2) Handle fault path for shmem minor fault (faulting path) > (3) Enablement of UFFD_FEATURE_MINOR_SHMEM (from which point, user can detect > and enable it) > > I have no preference on how you'd like to merge these steps (right now you did > 1 first, then 2+3 later; or as Hugh suggested do 1+2+3 together), but I'd still > hope item 3 should always be the last, if possible... In that case, I'll split the patch which adds the faulting path in two: add the faulting path hook and registration mode, and then in a separate commit advertise the feature flag as available. Then I'll order them like so, which I think is the order Hugh finds more natural: 1. MInor fault registration / faulting path 2. CONTINUE ioctl to resolve the faults 3. Advertise the feature as supported Sound okay? > > Thanks, > > -- > Peter Xu >