From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B126C433FE for ; Mon, 11 Apr 2022 17:30:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E58A86B0074; Mon, 11 Apr 2022 13:30:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E07AF6B0075; Mon, 11 Apr 2022 13:30:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CD0806B0078; Mon, 11 Apr 2022 13:30:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.28]) by kanga.kvack.org (Postfix) with ESMTP id BFEF26B0074 for ; Mon, 11 Apr 2022 13:30:08 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay13.hostedemail.com (Postfix) with ESMTP id 9842A61C35 for ; Mon, 11 Apr 2022 17:30:08 +0000 (UTC) X-FDA: 79345286496.03.9E80D0B Received: from mail-il1-f178.google.com (mail-il1-f178.google.com [209.85.166.178]) by imf28.hostedemail.com (Postfix) with ESMTP id 1CC19C000C for ; Mon, 11 Apr 2022 17:30:07 +0000 (UTC) Received: by mail-il1-f178.google.com with SMTP id t4so11904752ilo.12 for ; Mon, 11 Apr 2022 10:30:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Wx78erCIL7oR7fuzQUCoSTa4jxpH/qON65mW2OiVq+c=; b=LPanMdQ5FPo2cPnX36yeIHEw4gCGnVmExm6OVTI5WFTvQshN4lGKZ5aKhJDkiAa0Zj wOii7DiFGFk2iv8cYIz7BdZJY6twaKl426mPUsr8zFY5GtMXVCs41LDbSdrFaZs8dKdn Jb3J+iaqiyPERuzYCu8fAtS/F2DUIag8H2UDdPcvCSc2AiNGJSIUk4czNg+pVJvI0XQB dslMuI2IckQmpy/XIYQkrRkcg+Ja4tZdfpCs26ciQFpL/QzM76FvHdt+TjQguNX6JtPI PNZzniafk84EwaNOE0Emy89fmlAvLb6KfI34WRKm8peF9BmQcEtzW9DbjFYZyj5I3MTi q3lw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Wx78erCIL7oR7fuzQUCoSTa4jxpH/qON65mW2OiVq+c=; b=0I3PXlgzbQ+eoKqGe6iy5IKr1qWpX0jQCQEHF/SNR4cCzhVCRp/9Ng4x3oQF3jdVvo fqpuxkrwuSxOBUPryETThbi01zlgl8nMY/fieu8IWUQqxplJQ5dgd22cwlHhHFZSgjnl t6nzoLaEgNZ9jxrPwav/2MwCraHVkrQzuDsfnMU14NREeWH535Oa6Xlb3++k8ySV3aMC 7hzjSMe0mDl/Fs3B7dIueVAdaVaCgCvXZ5JkBRJV5WSniEpmchHBmxzevgeSm2a7gTIU +w9yi054Gl8xeP9dh0IxPNn/QCRkYkp1X4m0Bqa7JvK4ov97pUsvd+3O/GSPXm6PvnM0 G8wQ== X-Gm-Message-State: AOAM531KC/VXiZUhGWNYqx5hAcG8RtH5Vd46e6Jx9Rx0Ck7emTyxJjP+ yIa/AMhptd4DcRXgv3cIeivoy2OP8s2B3XmumOC8pY5ZQB8= X-Google-Smtp-Source: ABdhPJzbLEEKY75FBQhIUb7lp8Fu0HXkOSUBQ/JrbGUsnUssoVrba+/xdKUk7Bry+5ZA368bu8sr4/jaXoR5GVpWa08= X-Received: by 2002:a92:7d02:0:b0:2ca:4447:c1fb with SMTP id y2-20020a927d02000000b002ca4447c1fbmr13996595ilc.275.1649698207064; Mon, 11 Apr 2022 10:30:07 -0700 (PDT) MIME-Version: 1.0 References: <20220324210909.1843814-1-axelrasmussen@google.com> <20220407135053.6652bdad545fe98fc9babfbc@linux-foundation.org> In-Reply-To: <20220407135053.6652bdad545fe98fc9babfbc@linux-foundation.org> From: Axel Rasmussen Date: Mon, 11 Apr 2022 10:29:31 -0700 Message-ID: Subject: Re: [PATCH] mm/secretmem: fix panic when growing a memfd_secret To: Andrew Morton Cc: Matthew Wilcox , Mike Rapoport , Linux MM , LKML , stable@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Stat-Signature: 95s7zbweu5zisutmsuboeja4ytc9tynq X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 1CC19C000C Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=LPanMdQ5; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf28.hostedemail.com: domain of axelrasmussen@google.com designates 209.85.166.178 as permitted sender) smtp.mailfrom=axelrasmussen@google.com X-Rspam-User: X-HE-Tag: 1649698207-458171 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000055, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: It's a reasonable option. Worth noting though that today when it says "larger than the maximum file size", it refers to the global MAX_NON_LFS (2^31), not necessarily growing in general. So, we're extending the meaning a bit. But, I'm happy to send a v2 with EINVAL instead. On Thu, Apr 7, 2022 at 1:50 PM Andrew Morton wrote: > > On Thu, 31 Mar 2022 10:42:12 -0700 Axel Rasmussen wrote: > > > Any strong opinions on which error code is used? I think overall I > > would still pick EOPNOTSUPP, but happy to change it if anyone feels > > strongly. > > > > - I think ENOSYS is specific to syscall nr not defined > > - I think ENOTTY is specific to ioctls > > - The kernel (sort of mistakenly) defines ENOTSUPP instead of ENOTSUP, > > but it's marked deprecated and it's recommended to use EOPNOTSUPP > > instead (despite POSIX saying these should be distinct and for > > different uses). > > `man ftruncate' sayeth > > EINVAL The argument length is negative or larger than the maximum file > size. > > which reasonably accurately describes what we're doing here? > > + if ((ia_valid & ATTR_SIZE) && inode->i_size) > + return -EOPNOTSUPP; > >