From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16620C433EF for ; Thu, 31 Mar 2022 17:40:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 83AFB6B0072; Thu, 31 Mar 2022 13:40:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7EB656B0073; Thu, 31 Mar 2022 13:40:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6B2776B0074; Thu, 31 Mar 2022 13:40:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0142.hostedemail.com [216.40.44.142]) by kanga.kvack.org (Postfix) with ESMTP id 5BDF86B0072 for ; Thu, 31 Mar 2022 13:40:55 -0400 (EDT) Received: from smtpin27.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 1678AA759C for ; Thu, 31 Mar 2022 17:40:55 +0000 (UTC) X-FDA: 79305396870.27.A87F25A Received: from mail-il1-f179.google.com (mail-il1-f179.google.com [209.85.166.179]) by imf02.hostedemail.com (Postfix) with ESMTP id A30B180007 for ; Thu, 31 Mar 2022 17:40:54 +0000 (UTC) Received: by mail-il1-f179.google.com with SMTP id 8so306546ilq.4 for ; Thu, 31 Mar 2022 10:40:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=HyGHrtWUT2Fics+gVqtcmwsLpUDfu48pACTmB8yx1t8=; b=Y+2Qeep8CJL31pD+UDsvHcRdkZq5dTqoTzcYBK/kU0l2pOVe0yIkOd0zkAOBmIEdvz YsJDI6i9EMPHBuTRI8FxIs33CMn1p4HJHc0riKdHCx0KhRn/Dwqd337YJuEvy4MALqHB Ca/LQgSe0wG6FkliXJ/fPDP0ynsKazQSGW4pWz3lL6PAJkBPqlwd4R98p/OuUDgyOA3i 0JzMPlXl0496qMdpSHUf+OxEWLq71TrhzYsj4XWo0778uS4oVQ6vNDTwS60QoeqIItix FvH9x1fef/D5QK+6isICwKQLRIkNMiN3zqmz5Ih3LHTG141PCMmQx1IOeWyNJ1kGDAvs 6GmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=HyGHrtWUT2Fics+gVqtcmwsLpUDfu48pACTmB8yx1t8=; b=Qi/TrvqFEbfgkUGoz8aFX+XCkRIN5F6tVV4bI3lDjfuVUfZ0FggyBtAM7iDftyc8Ug E0v6ICVCmK4K+7mwwR7xKVvEsXES/U9MGs1mChcYZchayA/OtYSW44Eq2+oYS1TUXUdI M6DHzLb4NSx7cmOHKhp8le6+2Uc2kMW6LYIez7Bb30WjFiFCPp2rXrJx6WIhrU+Ghssc bsUSQOLvQAMmK42bUtmXQdrqcCbedSOvhUK4iUc9x1bCHL2rTz2XldgMgR6+drdM70W8 VR/Dr/FMpVK+z9f1snA6XvXyODRGH6ExtjLyzhRat+/SQcRQopXkaZeM2fg1CfhBWhn+ Ihog== X-Gm-Message-State: AOAM531Vbeww4Ap5J62LslBYy5ebSyydiob8otA5934eHWOT1/80ePPR 5RUYibow3yFQinPrM1wnJUPWmI5nAY3GryCqg+5Fog== X-Google-Smtp-Source: ABdhPJxYhTs4+s1jh5yCfY9ZXSqoPOeAI+WRsxV81sHUy8RK+dwLIGYcYEXBl53Khry6sclnu4sUkwNABtaJalzXlqw= X-Received: by 2002:a05:6e02:20c6:b0:2c9:d552:20de with SMTP id 6-20020a056e0220c600b002c9d55220demr6870949ilq.137.1648748453774; Thu, 31 Mar 2022 10:40:53 -0700 (PDT) MIME-Version: 1.0 References: <202204010033.oeIla4qb-lkp@intel.com> In-Reply-To: From: Axel Rasmussen Date: Thu, 31 Mar 2022 10:40:18 -0700 Message-ID: Subject: Re: [RFC PATCH linux-next] mm/secretmem: secretmem_iops can be static To: kernel test robot Cc: kbuild-all@lists.01.org, Linux Memory Management List , Andrew Morton , LKML Content-Type: text/plain; charset="UTF-8" X-Stat-Signature: k474p9xqkby5t8zg7eykhaekjouruhrd X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: A30B180007 Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=Y+2Qeep8; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf02.hostedemail.com: domain of axelrasmussen@google.com designates 209.85.166.179 as permitted sender) smtp.mailfrom=axelrasmussen@google.com X-Rspam-User: X-HE-Tag: 1648748454-435129 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Thanks kernel test robot, it should indeed be static. I'll send a v2 with this fix. On Thu, Mar 31, 2022 at 9:55 AM kernel test robot wrote: > > mm/secretmem.c:173:31: warning: symbol 'secretmem_iops' was not declared. Should it be static? > > Fixes: 24209f2f4d62 ("mm/secretmem: fix panic when growing a memfd_secret") > Reported-by: kernel test robot > Signed-off-by: kernel test robot > --- > mm/secretmem.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/secretmem.c b/mm/secretmem.c > index a83e98aa3a7b3..ddf45c0435be7 100644 > --- a/mm/secretmem.c > +++ b/mm/secretmem.c > @@ -170,7 +170,7 @@ static int secretmem_setattr(struct user_namespace *mnt_userns, > return simple_setattr(mnt_userns, dentry, iattr); > } > > -const struct inode_operations secretmem_iops = { > +static const struct inode_operations secretmem_iops = { > .setattr = secretmem_setattr, > }; >