From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59D5DC3DA7F for ; Mon, 12 Aug 2024 22:46:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 906266B007B; Mon, 12 Aug 2024 18:46:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 88ED86B0095; Mon, 12 Aug 2024 18:46:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7309C6B0098; Mon, 12 Aug 2024 18:46:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 56C896B007B for ; Mon, 12 Aug 2024 18:46:25 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 0C7C3C0492 for ; Mon, 12 Aug 2024 22:46:25 +0000 (UTC) X-FDA: 82445078730.28.D5ADC2F Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) by imf22.hostedemail.com (Postfix) with ESMTP id 3FC34C0015 for ; Mon, 12 Aug 2024 22:46:23 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=DMnNThof; spf=pass (imf22.hostedemail.com: domain of axelrasmussen@google.com designates 209.85.128.50 as permitted sender) smtp.mailfrom=axelrasmussen@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723502728; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Ra0vNY+3JSbv4IVQwD/1uhLFvMw53ariqz6DtVyqbWE=; b=EZEMSKP2Ft7JeQierLQp3NKQ6a1C/2heArKuYjeG5JieLdUGdY4fHitxk8h6D/hsjznbH9 fP0sOPbKJgtyRsPuf84a3FEkHqpywu+SUxU1b+/KRTmdFt6+t5Ss5+y+ZYnlMx7qJTtx5I VSyUnmrH1TAlXrqIM+9zPNPIWSf0i1Q= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=DMnNThof; spf=pass (imf22.hostedemail.com: domain of axelrasmussen@google.com designates 209.85.128.50 as permitted sender) smtp.mailfrom=axelrasmussen@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723502728; a=rsa-sha256; cv=none; b=z5FJkdwR39PnC6SbptZaqNcuI5u/KtzvMlGqOZX4ji0X6V5vN3TGbpHK9rllBcbDT8gZEJ 7avbqygFJwryFvCEzd9u2C2O/bA7WsoadZtGnmBhFQXJFyvS47pOOClj27f5Q3ewvVJ9Vp LUzM54LdwnNTEiwMEjrZUYnv1aexB0M= Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-42817f1eb1fso34398855e9.1 for ; Mon, 12 Aug 2024 15:46:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1723502782; x=1724107582; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Ra0vNY+3JSbv4IVQwD/1uhLFvMw53ariqz6DtVyqbWE=; b=DMnNThofwMjA8jkWmgQqQbwf1OzbHGtxnm9JDIPYpAk8iSc7A6k0+xBB9C14KpN+sE QIeojgbvaKIgHaZ3ZpF6vG0jAQnhqawKEOueEdmkmCVRY8ncmI1AtT3UGhLfq8tUrPA6 Pbwo6hLAHFzSTMmzWUSDzkupZOmg1PQRigTl6X7W0r9izkfpJesuYRBokf5h/PFWcIEw yFc4OK67YKePwwgcTTd8EfUU4cM5vHLfgBAwgw6wGrYVsZK/6Owa2SLOX8i1XCXjOICe /ud1j1HwH3mNjjsyZA7CsfmVSl+/xWu+NZYt+mB9JOmdufwE+p3HDpOPTx8zUH0NBmEC fg5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723502782; x=1724107582; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Ra0vNY+3JSbv4IVQwD/1uhLFvMw53ariqz6DtVyqbWE=; b=s3I2vwlnFPPe4Ht6OPsvYbXnYbguE/4ChkAMOJhFA4JfDNZzmC2FnbAJrJndXcxEUG 6YmfOQAthEmgtB2tLRd8489MLyfQ1hbBMcFoya0X+Ph2gPHaajJeSs98xo+2RyDMSiN2 T5A0MY3RzQ14spIV0Ak1vnJyCssO8ljBQYtK3DSKx0FhZ0yd1jFeErSFqksO55viJRnU Qa9Wc3yHzNh7H6/5z4IRKxQVBGZFCGiE8LWR33hHvKs0lhh9L8Z12Ne01BruGiiJ0s5f Xf0CTJ+fR+j1jAfeZwMkwf8H3sR8egR5Adu6EUa4Ov8p8stTnl03YSnOkr8qPxJhpJVw K8zg== X-Forwarded-Encrypted: i=1; AJvYcCU5wEiJrg/XkLrR/Tv4sSH6fnAnALgIf+eaKxrK6mYhH/Sc6VoyQQJRM/BDzKc0vwxT7hcKfq148jkAch2Rsb0noMs= X-Gm-Message-State: AOJu0YyRTldJRLCNdE4/xrVpwbtijYuhTM2v1UO3Rdd7HKOKIogK/ZlV Jyld1A8wWzZQWiRMqlvZRmuigNTU018QlFIKtg4bYTBN2FYY5NKubW49VJ4Tkdnx6sW/WBYkp8o K7+s3Nygz8gRgMFk76+3QHqj6CixjsVH+9DrE X-Google-Smtp-Source: AGHT+IEU+vOuyo14kw+euYFd9LEDJFYcB8RLRm7z0Gj6kGyapDjzoF/wqJ3BamNUS1JnOpdw2adZ01R70SRqZSl/pCA= X-Received: by 2002:a05:600c:1391:b0:426:6416:aa73 with SMTP id 5b1f17b1804b1-429d4828df2mr11145995e9.12.1723502781513; Mon, 12 Aug 2024 15:46:21 -0700 (PDT) MIME-Version: 1.0 References: <20240806232649.3258741-1-axelrasmussen@google.com> <6951700d-b6c0-b9b7-6587-1823a9d8c63d@google.com> In-Reply-To: <6951700d-b6c0-b9b7-6587-1823a9d8c63d@google.com> From: Axel Rasmussen Date: Mon, 12 Aug 2024 15:45:44 -0700 Message-ID: Subject: Re: [PATCH] mm, slub: print CPU id on slab OOM To: David Rientjes Cc: Vlastimil Babka , Andrew Morton , Christoph Lameter , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Joonsoo Kim , Pekka Enberg , Roman Gushchin , linux-kernel@vger.kernel.org, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: qdtu5z9osdzm5fpjs17dc7er5j3sh8qn X-Rspam-User: X-Rspamd-Queue-Id: 3FC34C0015 X-Rspamd-Server: rspam02 X-HE-Tag: 1723502783-143050 X-HE-Meta: U2FsdGVkX19TnVQCWBjKabbaZr0RvW8TVbCVFX1uFuM0Q33qP5XXU5U+8HZWFM++e15JiNDi4AU2b36iG7uWzZ2xyV7wRQEo5fznLi0q9RPWCO7uJ4qNKQ7EKESX1bzIap61yhKu0p/Y0DUaf8G4DzNcdtKdrNjv/4KWJ3p2Vb5qdBplrUJDwIGawJVJCboclFnbMlJZ4H2g44LfExqOyWSA9pbpwDbsdEui1CIrhKQZ++VI9HovkBFdFZADz17VgqBoSt2IHD92VlHQcVjoURVrlVexs5nsEMQ2vpwqEbS6tORu9SU8nwrkncyH20d/krRp3YyXPwK/5gB6Z8HNpMOKoTDw1FKNfYiW/rs1tiEzxPj8c4lWXSJUMLkJYfgPYxCkRz29HxoqX62I6OkjTOhjfCwbA8EMI2+mhdDrycATmtU2inCStXZOVVVxDy6I7MOj1tRDjydPiVKG5qJmIwR7ON5QiY7RjGPO6i45EPOrcTdAjkTsVb46OMJv2rh/OGz4pi4kwe91Ys88diXHMejBZzKE1/B68sjdSljypji2khySPElEIJNBhlgTu8xaPRL1Ma0y5Z/02ikK2mcM8PZxtIjV1H5yuhKkyevGIAS8OQhY/svQJknWlhapDOQXEIRTMU2X1vCoJfPe3GubneI9iO+58BP6V0tXG5d6SU+kAzcj7k0Cf7ZNQPWEoglxhmPCBRbqZNcoNxqygsW1sESbZRUXeoG8/0LM27VAYue/uYFMY09tUY3BieaaeSW/H9NP0cVnP0Xhk0e4c7JrMhvwVSZLdmg1ZdK3VbyfcGzwljj/Cm/MlrQLHIRLM5pEfSzn1217AKdyOFNt+Y1r7K31p7vz4J4VVCN6+nnlIpM3wZKZ7mdNaEMpnPFeRrvdqFi6CtbVnBWvUTwmmx36+/4XsOYgz270WHma8vgtkvT9A1CmQXMOfzm/o0H3tGXBbHfSEvhHfMM4G6pc4mY 2JJSJnpR GfDKBGGB/rE5E1LzJxOrkYou9pO4oALaB4ejnou2F0+3veJ2ALEWbeR5T3fyO0fF/t8iJiucIeRhV5PoUqcSZeiRBn/FBX2CjwzKdcnBFmFID32Lt7WfTRM1A32zQfgjILUXVA27637+WKoJwYj/Ur1D8cH/X18D5NzSQUv1CLY2mgwdcQNEgi7JMvlCBq3nbpWoQQENKSHFUykQ0ZcOCJynpIF/ymJmC4HaiTXB8b8Jo5jzni42lbUGV15QuwYJBBkIhCJeUK8Z+YP4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, Aug 11, 2024 at 1:21=E2=80=AFPM David Rientjes wrote: > > On Sun, 11 Aug 2024, Vlastimil Babka wrote: > > > > diff --git a/mm/slub.c b/mm/slub.c > > > index c9d8a2497fd6..7148047998de 100644 > > > --- a/mm/slub.c > > > +++ b/mm/slub.c > > > @@ -3422,7 +3422,8 @@ slab_out_of_memory(struct kmem_cache *s, gfp_t = gfpflags, int nid) > > > if ((gfpflags & __GFP_NOWARN) || !__ratelimit(&slub_oom_rs)) > > > return; > > > > > > - pr_warn("SLUB: Unable to allocate memory on node %d, gfp=3D%#x(%p= Gg)\n", > > > + pr_warn("SLUB: Unable to allocate memory for CPU %u on node %d, g= fp=3D%#x(%pGg)\n", > > > > BTW, wouldn't "on CPU" be more correct, as "for CPU" might be misleadin= g > > that we are somehow constrained to that CPU? > > > > Agreed. No objection to the rewording. > > When I suggested this patch, I was trying to ascertain whether something > was really wonky based on some logs that we were seeing. > > node 0: slabs: 223, objs: 11819, free: 0 > node 1: slabs: 951, objs: 50262, free: 218 > > This is for a NUMA_NO_NODE allocation, so I wanted to know if the cpu was > on node 0 or node 1. > > Even with the patch, that requires knowing the cpu-to-node mapping. If w= e > add the CPU output here, we likely also want to print out cpu_to_node(). Seems reasonable. Of course we could always look it up separately, but it would be convenient to just print it directly. I can send a v2 to add this. > > > > + preemptible() ? raw_smp_processor_id() : smp_processor_id= (), > > > > Also could we just use raw_smp_processor_id() always here? I don't see > > this has any advantage or am I missing something? > > > > This matches my understanding as well. That's fair, in any case it seems to matter very little for this use case whether the read is "stable" or not. Better to keep it simple. I can send a v2 with this tweak too.