From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx117.postini.com [74.125.245.117]) by kanga.kvack.org (Postfix) with SMTP id 3B7986B0031 for ; Mon, 5 Aug 2013 00:40:09 -0400 (EDT) Received: by mail-oa0-f43.google.com with SMTP id i10so5289509oag.30 for ; Sun, 04 Aug 2013 21:40:08 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <51fe08c6.87ef440a.10fc.1786SMTPIN_ADDED_BROKEN@mx.google.com> References: <1375593061-11350-1-git-send-email-manjunath.goudar@linaro.org> <51fe08c6.87ef440a.10fc.1786SMTPIN_ADDED_BROKEN@mx.google.com> Date: Mon, 5 Aug 2013 10:10:08 +0530 Message-ID: Subject: Re: [PATCH] MM: Make Contiguous Memory Allocator depends on MMU From: Manjunath Goudar Content-Type: multipart/alternative; boundary=90e6ba6e870a29030504e32be795 Sender: owner-linux-mm@kvack.org List-ID: To: Wanpeng Li Cc: linux-arm-kernel@lists.infradead.org, patches@linaro.org, arnd@linaro.org, dsaxena@linaro.org, linaro-kernel@lists.linaro.org, IWAMOTO Toshihiro , Hirokazu Takahashi , Dave Hansen , linux-mm@kvack.org, Johannes Weiner , Michal Hocko , Balbir Singh , KAMEZAWA Hiroyuki , hyojun.im@lge.com, Nataraja KM/LGSIA CSP-4 --90e6ba6e870a29030504e32be795 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 4 August 2013 13:24, Wanpeng Li wrote: > On Sun, Aug 04, 2013 at 10:41:01AM +0530, Manjunath Goudar wrote: > >s patch adds a Kconfig dependency on an MMU being available before > >CMA can be enabled. Without this patch, CMA can be enabled on an > >MMU-less system which can lead to issues. This was discovered during > >randconfig testing, in which CMA was enabled w/o MMU being enabled, > >leading to the following error: > > > > CC mm/migrate.o > >mm/migrate.c: In function =91remove_migration_pte=92: > >mm/migrate.c:134:3: error: implicit declaration of function > =91pmd_trans_huge=92 > >[-Werror=3Dimplicit-function-declaration] > > if (pmd_trans_huge(*pmd)) > > ^ > >mm/migrate.c:137:3: error: implicit declaration of function > =91pte_offset_map=92 > >[-Werror=3Dimplicit-function-declaration] > > ptep =3D pte_offset_map(pmd, addr); > > > > Similar one. > > http://marc.info/?l=3Dlinux-mm&m=3D137532486405085&w=3D2 In this patch MIGRATION config is not required MMU, because already CMA config depends on MMU and HAVE_MEMBLOCK if both are true then only selecting MIGRATION and MEMORY_ISOLATION. > > > >Signed-off-by: Manjunath Goudar > >Acked-by: Arnd Bergmann > >Cc: Deepak Saxena > >Cc: IWAMOTO Toshihiro > >Cc: Hirokazu Takahashi > >Cc: Dave Hansen > >Cc: linux-mm@kvack.org > >Cc: Johannes Weiner > >Cc: Michal Hocko > >Cc: Balbir Singh > >Cc: KAMEZAWA Hiroyuki > >--- > > mm/Kconfig | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > >diff --git a/mm/Kconfig b/mm/Kconfig > >index 256bfd0..ad6b98e 100644 > >--- a/mm/Kconfig > >+++ b/mm/Kconfig > >@@ -522,7 +522,7 @@ config MEM_SOFT_DIRTY > > > > config CMA > > bool "Contiguous Memory Allocator" > >- depends on HAVE_MEMBLOCK > >+ depends on MMU && HAVE_MEMBLOCK > > select MIGRATION > > select MEMORY_ISOLATION > > help > >-- > >1.7.9.5 > > > >-- > >To unsubscribe, send a message with 'unsubscribe linux-mm' in > >the body to majordomo@kvack.org. For more info on Linux MM, > >see: http://www.linux-mm.org/ . > >Don't email: email@kvack.org > > Thanks Manjunath Goudar --90e6ba6e870a29030504e32be795 Content-Type: text/html; charset=windows-1252 Content-Transfer-Encoding: quoted-printable

On 4 August 2013 13:24, Wanpeng Li <liwanp@linux.vnet.ibm.com> wrote:
On Sun, Aug 04, 2013 at 10:41:01AM +0530, Manjunath Gouda= r wrote:
>s patch adds a Kconfig dependency on an MMU being available before
>CMA can be enabled. =A0Without this patch, CMA can be enabled on an
>MMU-less system which can lead to issues. This was discovered during >randconfig testing, in which CMA was enabled w/o MMU being enabled,
>leading to the following error:
>
> CC =A0 =A0 =A0mm/migrate.o
>mm/migrate.c: In function =91remove_migration_pte=92:
>mm/migrate.c:134:3: error: implicit declaration of function =91pmd_tran= s_huge=92
>[-Werror=3Dimplicit-function-declaration]
> =A0 if (pmd_trans_huge(*pmd))
> =A0 ^
>mm/migrate.c:137:3: error: implicit declaration of function =91pte_offs= et_map=92
>[-Werror=3Dimplicit-function-declaration]
> =A0 ptep =3D pte_offset_map(pmd, addr);
>

Similar one.

http://marc.info/?l=3Dlinux-mm&m=3D137532486405085&= amp;w=3D2

In this patch MIGRATION confi= g is not required MMU, because already CMA config depends=A0
on MMU and HAVE_MEMBLOCK if both are true=A0then only selecting MIGRAT= ION and=A0
MEMORY_ISOLATION.
=

>Signed-off-by: Manjunath Goudar <manjunath.goudar@linaro.org>
>Acked-by: Arnd Bergmann <arnd@lin= aro.org>
>Cc: Deepak Saxena <dsaxena@lin= aro.org>
>Cc: IWAMOTO Toshihiro <iwam= oto@valinux.co.jp>
>Cc: Hirokazu Takahashi <taka@v= alinux.co.jp>
>Cc: Dave Hansen <haveblue@us.= ibm.com>
>Cc: linux-mm@kvack.org
>Cc: Johannes Weiner <hannes@cm= pxchg.org>
>Cc: Michal Hocko <mhocko@suse.cz>
>Cc: Balbir Singh <bsingharo= ra@gmail.com>
>Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
>---
> mm/Kconfig | =A0 =A02 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/mm/Kconfig b/mm/Kconfig
>index 256bfd0..ad6b98e 100644
>--- a/mm/Kconfig
>+++ b/mm/Kconfig
>@@ -522,7 +522,7 @@ config MEM_SOFT_DIRTY
>
> config CMA
> =A0 =A0 =A0 bool "Contiguous Memory Allocator"
>- =A0 =A0 =A0depends on HAVE_MEMBLOCK
>+ =A0 =A0 =A0depends on MMU && HAVE_MEMBLOCK
> =A0 =A0 =A0 select MIGRATION
> =A0 =A0 =A0 select MEMORY_ISOLATION
> =A0 =A0 =A0 help
>--
>1.7.9.5
>
>--
>To unsubscribe, send a message with 'unsubscribe linux-mm' in >the body to majordomo@kvack.org<= /a>. =A0For more info on Linux MM,
>see: http://www.= linux-mm.org/ .
>Don't email: <a href=3Dmailto:"dont@kvack.org"> email= @kvack.org </a>

Thanks
Manjunath Goudar
--90e6ba6e870a29030504e32be795-- -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org