From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64B63C46CD4 for ; Fri, 22 Dec 2023 08:11:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E961C6B0085; Fri, 22 Dec 2023 03:11:28 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E1F786B0088; Fri, 22 Dec 2023 03:11:28 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CE5B26B0089; Fri, 22 Dec 2023 03:11:28 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id BDA026B0085 for ; Fri, 22 Dec 2023 03:11:28 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 7B684160686 for ; Fri, 22 Dec 2023 08:11:28 +0000 (UTC) X-FDA: 81593734656.21.C92A9F9 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf12.hostedemail.com (Postfix) with ESMTP id 75A654000D for ; Fri, 22 Dec 2023 08:11:25 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=ThJHIAWS; spf=pass (imf12.hostedemail.com: domain of guoren@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=guoren@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1703232685; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Exojwv7ObzcZGSnEBXNzoU0+GLRSyFVbo0h6MIrG11w=; b=p4DTRF7hjzYG89m0dcpHgiM1ll13z7nh102ZxS9YAF2A5LPiH71YymYvbhIxL9L5gt+wwC OXd88TeWVlrOpjwJ3ZAVXIVZK4oL0SHYgy/OFdY/6nGvBDvbDMKi413iQh90o7P86CW/xN UtPnDCdr0VtDnVRy8JngzDBQhM7zyOw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1703232685; a=rsa-sha256; cv=none; b=DnOssoXTN0Oo77ZTJZMmPzSQ+EdF2ZAL3B9edp+ZbSMlIilsi5uutCgwsMpspaYhKNa724 3ncFg+2fTJ7xSVgRsyerD1C/s4pZHacna+4aajNTrx+VOY+Sg7mRvrTI5pYkhEriUItifP RHQTHvrJqCNyTTidMj1aYPRc3TGSjXI= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=ThJHIAWS; spf=pass (imf12.hostedemail.com: domain of guoren@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=guoren@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 9738261B80 for ; Fri, 22 Dec 2023 08:11:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DA15DC433B7 for ; Fri, 22 Dec 2023 08:11:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1703232683; bh=xlvrw1s0T46Tz1knGooTW4HgxuEaVE6Yt4gVH7KsSNs=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=ThJHIAWScS67tO4MPkBAG639WxhdKDyUoCbBibMIwOUCJSm4eLx5TYNjMlPfj2Euu EZZnLtFeL/Vz0lhk12fZaMNiHJLD5uIN47v8qoOS9iemaIwTaQkpzKExUBNRIHy4nv s4Jgd6KWl6FeJMwvuW/P+N4QQxpZnfiojXLU9BrQRcrO27M7kXtfGAenghgNeH6NRi c0NuJM835BWWVGTGNChon2OX+8Ifb7UfIIzWBKh/tzF2905e2gt4q1MfBTAFZY1u3w OV6Arg0gB3HvO3ovldS4JPJxJQV0jOhxwtJzGJ/DgFROvm0vwEXlkfUpxV76Qt2/uW AROH4os7cmJAg== Received: by mail-ed1-f53.google.com with SMTP id 4fb4d7f45d1cf-552d39ac3ccso4901896a12.0 for ; Fri, 22 Dec 2023 00:11:23 -0800 (PST) X-Gm-Message-State: AOJu0YwGBuwlLOWXGRVQ0C4g3epBeTtsAabSGFDavI5scPztt5GmD7eK nkZr+19XOyBmRgUmEhi0Vh12nZ1g1CG+zIjmV/A= X-Google-Smtp-Source: AGHT+IG2QDqYm9J7T4aV4Gi9QMXZcNjKi+BwCgA9nxbLz37NE8zlLTmwMUaMZL0C8EpuHRmgEsm9wh+mRbWDQIvom3M= X-Received: by 2002:a17:907:9392:b0:a25:a0c6:ebf5 with SMTP id cm18-20020a170907939200b00a25a0c6ebf5mr762193ejc.21.1703232682173; Fri, 22 Dec 2023 00:11:22 -0800 (PST) MIME-Version: 1.0 References: <20231222074605.452452-1-leobras@redhat.com> <20231222074605.452452-5-leobras@redhat.com> In-Reply-To: <20231222074605.452452-5-leobras@redhat.com> From: Guo Ren Date: Fri, 22 Dec 2023 16:11:10 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [RFC PATCH 4/4] riscv: Introduce set_compat_task() in asm/compat.h To: Leonardo Bras Cc: Paul Walmsley , Palmer Dabbelt , Albert Ou , Eric Biederman , Kees Cook , Oleg Nesterov , Conor Dooley , Andy Chiu , Greg Ungerer , Vincent Chen , Xiao Wang , Charlie Jenkins , Andrew Morton , Alexandre Ghiti , Kemeng Shi , David Hildenbrand , "Matthew Wilcox (Oracle)" , Qinglin Pan , Greentime Hu , =?UTF-8?B?QmrDtnJuIFTDtnBlbA==?= , =?UTF-8?B?Q2zDqW1lbnQgTMOpZ2Vy?= , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 75A654000D X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: ekmnamxuumpqid19axoi4455x1fqncrm X-HE-Tag: 1703232685-697679 X-HE-Meta: U2FsdGVkX18KEYB3aNILwGZhFdTE8I07B02yJUDOhLhhq6Bsl3wfPxMQoLLCpYdmuUQAej5VgvuEvMZnQbAkfRVBzHJM44WzMyEqcVPakKNnxFOXhX29+gZ+hGhuIv61ZfdLJPs6lx3yiYBCutDlWBVctkN9yDz5lpXudX4l+WohQYS2olVuDdsPC8/3UzK1/PptjbaA2CWMV74ljls5qWlkpb7iTm/CN8cFwu3UMiOTxNeRQ5dFj1sWNZP3KjWdgilgvOfeO8DSFQiSDlUhxnIvB8V8xcI3ifjPSZj3nPVCgDoJv0F1IK6+9fzf3my4yR1yIz6yNZkIJylSP6GoSDKDu291pUEtaapO6/37x1GUOPG2/rCkVM+5vc9DOZb8KP+M9BSSYhRvdHDEVT/jYS/3sAsRvRO3rZnLMiUwFxQchf/curAph9vB9IGLtfAbHAzmdvTAAyFI1ppTXNWi9g1/u3CiiUFBgmfp6RAjm4rn9dFUhn00LHnHOVGVZFQspUmlpP3Hsk8cTS6elruEIrc2l03HCW1kf6HH3bKkvZNZcjXX7Meh3YnfLSJSfozApm+EevfV+yWo+zN8lO9l+vKN1Iw/uAXqhXOJrvCYuLTA5a420HKxM15nv8QmQ5ZEG58gO36pwMTbJEU8O4FfkwowRYoVSTpzRBxGyFwmUUBGMrXiAquh2c/kEtYznWZmLgqu0wOeNcRAWyxgl74J407OpwtMNGjYQyeycxVZTdXsmjaLzNXU0h5YVtoB4FYK3fmpbVgUDNUCXI9udoj9VOfeb/8Yzgy0n0J1KnUOUCnnDiliaIAHVx4O6CiqEz0zLiMEtRSK+6I4yZiTvySlWdVFSqQjUkbm7TArIWI2MF21V+BkjHIecUV4egOI0ekWIF2fBCS0wM3wSKFCBMrM30I42kuwfsbb4RAb7dB63pC5mOLegUe5Ou0PaFt4HxnxOsOtzFALBe5wny3Lyiy ASO+8qJR VAiXze7dJ8Eh2uiGtkUyjHmlOCvstQawtAFt2km0qwdO3CAZestPumML1z8W21uGSg3GZXkXFNnpitaT9SyCUb9qiMfD7v+35d0lLqW/6rvTBmEIgjEo+mdUN9Gm5nlR535178925oKKs2ZUhzDu/ThkovWj+R215CzC7agkJYj15J2AGH0mqfdlxaLUOKrZFmFFFxAY/v2LsjEc+3LnK2yNbyGeSjAFN/tKTk0ck3nKGWgVrmU9KTJFV/IgY7J/0K3nS84gE+MCOLrIMCzMix1RdBDM9Cp6s9iJDG4Uc86f4gztXczPyaMP7qgnJ14PmsEADhsVWSANTjwwbFu8Nw+t3MAkIrc7263Y3 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Dec 22, 2023 at 3:47=E2=80=AFPM Leonardo Bras = wrote: > > In order to have all task compat bit access directly in compat.h, introdu= ce > set_compat_task() to set/reset those when needed. > > Also, since it's only used on an if/else scenario, simplify the macro usi= ng > it. > > Signed-off-by: Leonardo Bras > --- > arch/riscv/include/asm/compat.h | 8 ++++++++ > arch/riscv/include/asm/elf.h | 5 +---- > 2 files changed, 9 insertions(+), 4 deletions(-) > > diff --git a/arch/riscv/include/asm/compat.h b/arch/riscv/include/asm/com= pat.h > index da4b28cd01a95..aa103530a5c83 100644 > --- a/arch/riscv/include/asm/compat.h > +++ b/arch/riscv/include/asm/compat.h > @@ -28,6 +28,14 @@ static inline int is_compat_thread(struct thread_info = *thread) > return test_ti_thread_flag(thread, TIF_32BIT); > } > > +static inline void set_compat_task(bool is_compat) > +{ > + if (is_compat) > + set_thread_flag(TIF_32BIT); > + else > + clear_thread_flag(TIF_32BIT); > +} > + > struct compat_user_regs_struct { > compat_ulong_t pc; > compat_ulong_t ra; > diff --git a/arch/riscv/include/asm/elf.h b/arch/riscv/include/asm/elf.h > index 2e88257cafaea..c7aea7886d22a 100644 > --- a/arch/riscv/include/asm/elf.h > +++ b/arch/riscv/include/asm/elf.h > @@ -135,10 +135,7 @@ do { = \ > #ifdef CONFIG_COMPAT > > #define SET_PERSONALITY(ex) \ > -do { if ((ex).e_ident[EI_CLASS] =3D=3D ELFCLASS32) \ > - set_thread_flag(TIF_32BIT); \ > - else \ > - clear_thread_flag(TIF_32BIT); \ > +do { set_compat_task((ex).e_ident[EI_CLASS] =3D=3D ELFCLASS32); \ > if (personality(current->personality) !=3D PER_LINUX32) \ > set_personality(PER_LINUX | \ > (current->personality & (~PER_MASK))); \ > -- > 2.43.0 > LGTM Reviewed-by: Guo Ren --=20 Best Regards Guo Ren