From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A747C433F5 for ; Fri, 24 Sep 2021 06:09:39 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C7F9F60E97 for ; Fri, 24 Sep 2021 06:09:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org C7F9F60E97 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 61A866B006C; Fri, 24 Sep 2021 02:09:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5C9976B0071; Fri, 24 Sep 2021 02:09:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4B943900002; Fri, 24 Sep 2021 02:09:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0119.hostedemail.com [216.40.44.119]) by kanga.kvack.org (Postfix) with ESMTP id 3B8C06B006C for ; Fri, 24 Sep 2021 02:09:38 -0400 (EDT) Received: from smtpin36.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id CF9E232065 for ; Fri, 24 Sep 2021 06:09:37 +0000 (UTC) X-FDA: 78621440394.36.06C2E78 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf25.hostedemail.com (Postfix) with ESMTP id 818A0B000183 for ; Fri, 24 Sep 2021 06:09:37 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 9A11A60E97 for ; Fri, 24 Sep 2021 06:09:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1632463776; bh=ZOiKLlqiRvlFc3D7uDzwSfVO+ILpnPmwhZUWQMKKk2c=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=GwSIAfagfLLYpa3iFFHxyLe+dw74ke2k53XYWqgLtnj2fDgOKVCmvTdC6j88xGl4G gLwjMk4p2Ryk0mc9NaYFWDzqd3wK98+ncTaJ1S7HN6X9gCQfaariwv6OZSYEVefOhm LVMi0ByBAma0G4eIeCgj9XEV04GGlpci8lynt1Ol/6RghyMEVq+Pk4bQRMZCVY95nl AGNzM2gHaubeLcew1cw+dgwUupo8xYUxBEO+Jf91CjFHdAAHnjy8+Cazv0af1Q+D7A 3z05ungRDUb+j8ctxXMTVl9PWmawJvSEkdXxCkkHg2Ro4FqHZJYu0NA7bp5291N1Gz HYKrwF/x2LzGw== Received: by mail-vs1-f41.google.com with SMTP id x74so8874663vsx.13 for ; Thu, 23 Sep 2021 23:09:36 -0700 (PDT) X-Gm-Message-State: AOAM533bX3cVmUH8X5MoVAq757nS9wnyifmngaq1ZySn/nqVMWwcyq7D J6d+JE1Z6YVkfrVK3OC6fdO3onElnKUnn/zIQNc= X-Google-Smtp-Source: ABdhPJzqFJpZxwcQU7NlvCwFlTAZrRJi8bOkUsHWlRKge2v87Wu+bU0EljWXNZvMDY+K+80SsW90iKUFwLq5h//3kHE= X-Received: by 2002:a67:3204:: with SMTP id y4mr7516832vsy.28.1632463775776; Thu, 23 Sep 2021 23:09:35 -0700 (PDT) MIME-Version: 1.0 References: <20210924060654.1137902-1-guoren@kernel.org> In-Reply-To: <20210924060654.1137902-1-guoren@kernel.org> From: Guo Ren Date: Fri, 24 Sep 2021 14:09:24 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] mm: debug_vm_pgtable: Don't use __P000 directly To: Guo Ren , Andrew Morton Cc: Linux-MM , Linux Kernel Mailing List , Guo Ren Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 818A0B000183 X-Stat-Signature: 6jc96e6wpqhhjkynx64spm479da6s84f Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=GwSIAfag; spf=pass (imf25.hostedemail.com: domain of guoren@kernel.org designates 198.145.29.99 as permitted sender) smtp.mailfrom=guoren@kernel.org; dmarc=pass (policy=none) header.from=kernel.org X-Rspamd-Server: rspam06 X-HE-Tag: 1632463777-391231 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Sorry, the patch forgets to add --prefix PATCH V2, abandon. Review the V2, thx. On Fri, Sep 24, 2021 at 2:07 PM wrote: > > From: Guo Ren > > The __Pxxx/__Sxxx macros are only for protection_map[] init. All > usage of them in linux should come from protection_map array. > > Because a lot of architectures would re-initilize protection_map[] > array, eg: x86-mem_encrypt, m68k-motorola, mips, arm, sparc. > > Using __P000 is not rigorous. > > Signed-off-by: Guo Ren > Reviewed-by: Andrew Morton > > --- > > Changes since V2: > - s/init protection_map[]/protection_map[] init/ > - s/Becasue/Because/ > - Remove unclear part > - Replace __P000 and __S000 with protection_map[0] and > protection_map[8] > --- > mm/debug_vm_pgtable.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/mm/debug_vm_pgtable.c b/mm/debug_vm_pgtable.c > index 1403639302e4..228e3954b90c 100644 > --- a/mm/debug_vm_pgtable.c > +++ b/mm/debug_vm_pgtable.c > @@ -1104,13 +1104,14 @@ static int __init init_args(struct pgtable_debug_args *args) > /* > * Initialize the debugging data. > * > - * __P000 (or even __S000) will help create page table entries with > - * PROT_NONE permission as required for pxx_protnone_tests(). > + * protection_map[0] (or even protection_map[8]) will help create > + * page table entries with PROT_NONE permission as required for > + * pxx_protnone_tests(). > */ > memset(args, 0, sizeof(*args)); > args->vaddr = get_random_vaddr(); > args->page_prot = vm_get_page_prot(VMFLAGS); > - args->page_prot_none = __P000; > + args->page_prot_none = protection_map[0]; > args->is_contiguous_page = false; > args->pud_pfn = ULONG_MAX; > args->pmd_pfn = ULONG_MAX; > -- > 2.25.1 > -- Best Regards Guo Ren ML: https://lore.kernel.org/linux-csky/