From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4771EC36011 for ; Thu, 27 Mar 2025 12:47:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 92C952800EA; Thu, 27 Mar 2025 08:47:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 816AB2800E4; Thu, 27 Mar 2025 08:47:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 642102800EA; Thu, 27 Mar 2025 08:47:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 3D6CA2800E4 for ; Thu, 27 Mar 2025 08:47:33 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 12B46C0DAF for ; Thu, 27 Mar 2025 12:47:34 +0000 (UTC) X-FDA: 83267307228.17.30EBAE0 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf14.hostedemail.com (Postfix) with ESMTP id 39E8D100015 for ; Thu, 27 Mar 2025 12:47:32 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=ry+3lJ4j; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf14.hostedemail.com: domain of guoren@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=guoren@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1743079652; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6VlUaRLki5jgX31CwdGfCgnByN2/gg3fEesz/lw3Ze8=; b=wIQjhbk/UxY4ZVSgLV5I71Whqc6TkLItmmzrFoYIttW+jPvClvxxXr2vuOtw3AAaRjyRC8 6d89OPNFVD6K1ttkQ24TdH6IU9Bmw7wT4gtkoVL6uc22a/MbZH+BO3Fvuy6WKEWOOfF28S 82Y9RcYjBp6aJYRkX/i22oROVuRwVfs= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1743079652; a=rsa-sha256; cv=none; b=YbWLYnuSnmsPf1Rw0kXY/HeyQ5CPFYOehKi54145ZkGc1i6tzym5/g5eWITnxanq1dnKS9 xar2pqbaPv/dSOK89r3xNvIYT4QU7W4HeeZxxGA0llOShATIaco4mAwBZzhgCG5yWjOjyU v3gp2WRRDlktSqLGWKN8Irl8c/dfgUU= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=ry+3lJ4j; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf14.hostedemail.com: domain of guoren@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=guoren@kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 100715C6668 for ; Thu, 27 Mar 2025 12:45:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8E447C4CEFB for ; Thu, 27 Mar 2025 12:47:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1743079650; bh=tWRtgxQFfYLGIe+M3bP4npfrIUeWm1/2DsIIszdvZ1Y=; h=References:In-Reply-To:From:Date:Subject:To:From; b=ry+3lJ4jOXxi94y5mI1NbXnalzo+G/pnZhSjrID66dTcLVpvSN5jxYLjoTFSpm8t2 RVmKewcN7zdZNd9LKSrvUmI7Bitb6RSvE7xtBxsyaXOJotG+IzA+4cSiX8s5XJcd4a Gflk19wroRN6hPkMWa+MtGfvaJAZL2ppLItlCErXCvjy0HVn2BGenZE8FkLMdyZJYX btnwncSVrJy5++ND3g+6x3gmSehP4lsafQ7UigXG8+8I+Idsw/U+sgz5n2nwr8zWSp H++QkUGRCbXL4b+bUxPVKQyPP9wfeJA4D52pvQD5Qmb8PrgNvDFT5Gco7rpxg0Rv5D +Xv0BqRwjjbZg== Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-43cf628cb14so13991905e9.1 for ; Thu, 27 Mar 2025 05:47:30 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCUE1EFreC/WKim1Zt0t6MtVvGv7QC5+UJo4Qko42O1XvpF1aJ67iZUj1PEEPxCge8YDu3to9JFhvQ==@kvack.org X-Gm-Message-State: AOJu0Yx9C/rFJusb2m7sRGiZm9Lcl/1dgmqMzX9RtuyjrRLoykKh82Js YK2scrfstuMI/UaqvcEDXWGhrjmwBUPMFo4s//p93W4KE3WTbosr2ChyAHqE3eriuNifBuRVu8Y oVRFWvFBkYM3FngZQrN/2TRiB4Oc= X-Google-Smtp-Source: AGHT+IHmUYVhD/X+fFCk9mo6iUY3GGy6zSlwPlvt9V5E3bXgq4+AzDcNpwzxGBSsif+BeffRslEST7FtUwPlgXmmxiQ= X-Received: by 2002:a5d:5f43:0:b0:391:65c:1b05 with SMTP id ffacd0b85a97d-39c099cd2bbmr115764f8f.11.1743079648810; Thu, 27 Mar 2025 05:47:28 -0700 (PDT) MIME-Version: 1.0 References: <20250325121624.523258-1-guoren@kernel.org> <20250325121624.523258-32-guoren@kernel.org> <4gph4xikdbg6loy2id72uyxgldsldecc7gquhymusl3vreiw3a@ephk5ahhrdw7> In-Reply-To: <4gph4xikdbg6loy2id72uyxgldsldecc7gquhymusl3vreiw3a@ephk5ahhrdw7> From: Guo Ren Date: Thu, 27 Mar 2025 20:47:15 +0800 X-Gmail-Original-Message-ID: X-Gm-Features: AQ5f1JoN57xvarY3Pp887PY64wPP4HS8fDT1YiKKfNiabWlzF5M2aRc4_YpAz7M Message-ID: Subject: Re: [RFC PATCH V3 31/43] rv64ilp32_abi: maple_tree: Use BITS_PER_LONG instead of CONFIG_64BIT To: "Liam R. Howlett" , guoren@kernel.org, arnd@arndb.de, gregkh@linuxfoundation.org, torvalds@linux-foundation.org, paul.walmsley@sifive.com, palmer@dabbelt.com, anup@brainfault.org, atishp@atishpatra.org, oleg@redhat.com, kees@kernel.org, tglx@linutronix.de, will@kernel.org, mark.rutland@arm.com, brauner@kernel.org, akpm@linux-foundation.org, rostedt@goodmis.org, edumazet@google.com, unicorn_wang@outlook.com, inochiama@outlook.com, gaohan@iscas.ac.cn, shihua@iscas.ac.cn, jiawei@iscas.ac.cn, wuwei2016@iscas.ac.cn, drew@pdp7.com, prabhakar.mahadev-lad.rj@bp.renesas.com, ctsai390@andestech.com, wefu@redhat.com, kuba@kernel.org, pabeni@redhat.com, josef@toxicpanda.com, dsterba@suse.com, mingo@redhat.com, peterz@infradead.org, boqun.feng@gmail.com, xiao.w.wang@intel.com, qingfang.deng@siflower.com.cn, leobras@redhat.com, jszhang@kernel.org, conor.dooley@microchip.com, samuel.holland@sifive.com, yongxuan.wang@sifive.com, luxu.kernel@bytedance.com, david@redhat.com, ruanjinjie@huawei.com, cuiyunhui@bytedance.com, wangkefeng.wang@huawei.com, qiaozhe@iscas.ac.cn, ardb@kernel.org, ast@kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, kvm@vger.kernel.org, kvm-riscv@lists.infradead.org, linux-mm@kvack.org, linux-crypto@vger.kernel.org, bpf@vger.kernel.org, linux-input@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-serial@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-arch@vger.kernel.org, maple-tree@lists.infradead.org, linux-trace-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-atm-general@lists.sourceforge.net, linux-btrfs@vger.kernel.org, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, linux-nfs@vger.kernel.org, linux-sctp@vger.kernel.org, linux-usb@vger.kernel.org, linux-media@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 39E8D100015 X-Stat-Signature: enkcby46febtk8qzqgxkwoxhafwzmjw1 X-Rspam-User: X-HE-Tag: 1743079652-598504 X-HE-Meta: U2FsdGVkX19FeEekpLNU8rTz+QfLjc5sw2RaxbQej/Rzr7Eapr76sya5r4f6twxiramBslBQFz2RtDNiDrPuHqLYG4YYA46Q/41EgSvOsoaEtYqlzSbVzNvx9iQT2QcBKBJv1/i+jd6os/Bt6zXe6WRJcW7kXAIVaIOezbWHZ+LuVLG3uPtScRw0ed3NlitV4kdrL7hxSTi/rAUdPhW2X5WQDBKL9Gj/ZYSwgBU8+bxok3R+Ho/KaPbWRX8gS94/k6LoEycsViGHwWWVhbgc7/Wq5for/+ZbOxqLHsynv7na3VREZcYZhcXCPg8GrUUQpUqjWc2Ck5ek7+6B68fLthiNLgZNjhAFM6N7DFHzfjlCQTrSMzcPsIWf3kHFS/CH/AYUCTWrCm3CRH8IupkPH4HGGDAjUwu2A6FnTMmDCDyEvCSTxaZKi+2yCHfNLDE7OUDqsKmVZdIG9e1VkCdwazJ1RNNk1qr6PlSIOZvP0UeqYxZxCP95df5VFpWrGDWfovWY1pCB0S1AN0TeMlYPyKdnv+s7pnG7aAeJOunNZjT1OYSwCVtqzCIIKz7Qd/Cu2OGRPAJqgq0+Jddw5SC0Xxo70y3LluLoDjXdiJkyzEeeKUQ0GYdAOZlslCRy9wRplx5nU8IiMZ8dNiOQ+DG+ZkH8w6F4Xngp3ugLhVT83BotpXS3qSneeaemR+rTDZk7c/oPqSa77fXd1YZdCxX8GQHmn1rY5t/W5swxskf7p/OQ/b3fLPVFWnEV807ZakHDo601awY+y8lxltqaOV7tiHs/8j5FBcZMIMRhUm2VFS+B2hg8y706Hl9bpRugEz+/s4MrKaFzXDpxMyqHExKq9BitisW4yFwhfy5WrfmVkz5STtd9a1/xIPzYMgFQFCpEuZeUwPfZGYBQGgGbNpvbm9Q7tydyI7Ks/TLYjojNROKmiTuvKhEyhRD9hckNkJ9/qcdTJ6XEYoyzVBHYtLu pfo+v/rf UVolw1S9oO3gvj2pF2Qn0fIEhJQhxscySXVp1QWTKq1lnDiidZLzHTqWPnC2Qt66l1gmEH2B2npLfvTGKJkSvXTnKaKrSIs+1fKo3Ia4kjjZhYtg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Mar 26, 2025 at 3:10=E2=80=AFAM Liam R. Howlett wrote: > > * guoren@kernel.org [250325 08:24]: > > From: "Guo Ren (Alibaba DAMO Academy)" > > > > The Maple tree algorithm uses ulong type for each element. The > > number of slots is based on BITS_PER_LONG for RV64ILP32 ABI, so > > use BITS_PER_LONG instead of CONFIG_64BIT. > > > > Signed-off-by: Guo Ren (Alibaba DAMO Academy) > > --- > > include/linux/maple_tree.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/include/linux/maple_tree.h b/include/linux/maple_tree.h > > index cbbcd18d4186..ff6265b6468b 100644 > > --- a/include/linux/maple_tree.h > > +++ b/include/linux/maple_tree.h > > @@ -24,7 +24,7 @@ > > * > > * Nodes in the tree point to their parent unless bit 0 is set. > > */ > > -#if defined(CONFIG_64BIT) || defined(BUILD_VDSO32_64) > > +#if (BITS_PER_LONG =3D=3D 64) || defined(BUILD_VDSO32_64) > > This will break my userspace testing, if you do not update the testing as > well. This can be found in tools/testing/radix-tree. Please also look > at the Makefile as well since it will generate a build flag for the > userspace. I think you are talking about the following: =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D ../shared/shared.mk: ifndef LONG_BIT LONG_BIT :=3D $(shell getconf LONG_BIT) endif generated/bit-length.h: FORCE @mkdir -p generated @if ! grep -qws CONFIG_$(LONG_BIT)BIT generated/bit-length.h; then = \ echo "Generating $@"; = \ echo "#define CONFIG_$(LONG_BIT)BIT 1" > $@; = \ echo "#define CONFIG_PHYS_ADDR_T_$(LONG_BIT)BIT 1" >> $@; = \ fi $ grep CONFIG_64BIT * -r -A 2 generated/bit-length.h:#define CONFIG_64BIT 1 generated/bit-length.h-#define CONFIG_PHYS_ADDR_T_64BIT 1 -- maple.c:#if defined(CONFIG_64BIT) maple.c-static noinline void __init check_erase2_testset(struct maple_tree = *mt, maple.c- const unsigned long *set, unsigned long size) -- maple.c:#if CONFIG_64BIT maple.c- MT_BUG_ON(mt, data_end !=3D mas_data_end(&mas)); maple.c-#endif -- maple.c:#if CONFIG_64BIT maple.c- MT_BUG_ON(mt, data_end - 2 !=3D mas_data_end(&mas)); maple.c-#endif -- maple.c:#if CONFIG_64BIT maple.c- MT_BUG_ON(mt, data_end - 4 !=3D mas_data_end(&mas)); maple.c-#endif -- maple.c:#if defined(CONFIG_64BIT) maple.c- /* Captures from VMs that found previous errors */ maple.c- mt_init_flags(&tree, 0); =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D First, we don't introduce rv64ilp32-abi user space, which means these testing codes can't run on rv64ilp32-abi userspace currently. So, the problem you mentioned doesn't exist. Second, CONFIG_32BIT is determined by LONG_BIT, so there's no issue in maple.c with future rv64ilp32-abi userspace. That means rv64ilp32-abi userspace would use CONFIG_32BIT to test radix-tree. It's okay. > > This raises other concerns as the code is found with a grep command, so > I'm not sure why it was missed and if anything else is missed? > > If you consider this email to be the (unasked) question about what to do > here, then please CC me, the maintainer of the files including the one > you are updating here. > > Thank you, > Liam > --=20 Best Regards Guo Ren