From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16D74C38A2D for ; Mon, 24 Oct 2022 08:04:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 80A658E0003; Mon, 24 Oct 2022 04:04:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7B9AF8E0001; Mon, 24 Oct 2022 04:04:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6AAAC8E0003; Mon, 24 Oct 2022 04:04:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 5B0098E0001 for ; Mon, 24 Oct 2022 04:04:25 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 231E380A46 for ; Mon, 24 Oct 2022 08:04:25 +0000 (UTC) X-FDA: 80055105690.18.28985FF Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf19.hostedemail.com (Postfix) with ESMTP id 894111A003B for ; Mon, 24 Oct 2022 08:04:24 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id B2307B80EA1 for ; Mon, 24 Oct 2022 08:04:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CDDFFC43145 for ; Mon, 24 Oct 2022 08:04:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1666598660; bh=zMRCR9aO2hv7wIrVCElL/LTJoQUq5XjLprILNRp63eY=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=q39Z0Jl1UbJQ+ydOt0a6xHmvicc/CX107NlZd3AVvTnKjNVdSgR0yjGIvpQIeKoF4 x8ScpUmx4bU5yFkA8Q2mPwRADEbzogttzxfhc5qzex2wOgJXhACgAce/zDCqs9i3XG NaMEfTGrBDIjxA/FxD4lj8kEquBpzogImnn96Af3ycNgLiTD5C4072MGl1jtDduFrQ tEbxO3hNlFVws9P3RAaG8UOjIIJzc0l2hiDgGRKKUWZdqrdXkg4p94POm7JdNESXoI +p02DGC+oLj+KXmw39glLG3xh67JSd9QYCbOAceb1shPxLGQ3MUWshAft+HLP28MCi gpswHMEoSy9uQ== Received: by mail-ot1-f46.google.com with SMTP id z11-20020a05683020cb00b00661a95cf920so5482675otq.5 for ; Mon, 24 Oct 2022 01:04:20 -0700 (PDT) X-Gm-Message-State: ACrzQf1rnKzHO/Y1Zj3PBrDib6h4g27MiNiJ/BtkUQPCnuKmrRnBEYXE /OzF7r3m77sbzIwW4Vm9QAaP8+Nij/gJ9jcFUZA= X-Google-Smtp-Source: AMsMyM5Cx/80n+ESwscTL8gLYrU0vtuSa4ffmqiRXpnSWEObRQEOy2bsVIlgF7y6VDAQAMzssohT33tmfwmul1u3/3E= X-Received: by 2002:a9d:58c6:0:b0:663:c327:8bb with SMTP id s6-20020a9d58c6000000b00663c32708bbmr4290089oth.308.1666598659933; Mon, 24 Oct 2022 01:04:19 -0700 (PDT) MIME-Version: 1.0 References: <20221024070105.306280-1-chenhuacai@loongson.cn> <20221024070105.306280-5-chenhuacai@loongson.cn> In-Reply-To: <20221024070105.306280-5-chenhuacai@loongson.cn> From: Guo Ren Date: Mon, 24 Oct 2022 16:04:06 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH V13 4/4] LoongArch: Enable ARCH_WANT_HUGETLB_PAGE_OPTIMIZE_VMEMMAP To: Huacai Chen Cc: Arnd Bergmann , Huacai Chen , Thomas Bogendoerfer , Dave Hansen , Andy Lutomirski , Peter Zijlstra , Catalin Marinas , Will Deacon , Dinh Nguyen , loongarch@lists.linux.dev, linux-arch@vger.kernel.org, Xuefeng Li , Xuerui Wang , Jiaxun Yang , Andrew Morton , linux-mm@kvack.org, linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Feiyang Chen , =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=q39Z0Jl1; spf=pass (imf19.hostedemail.com: domain of guoren@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=guoren@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1666598664; a=rsa-sha256; cv=none; b=HFNGHXCKkkVoIGY0vZDE3+Iw/WmGy4L8EVay6xLqutaGZZ3FF4gUDvffoFHg+P+pzmMJVV KC48SvrY6S6uPrDQ1fksUn0fC5hBUO8sBl6fObA89xQyTgxMEpyaP4qz2uNdvvkp8/Mv9P EZRnFVAd7yXAJiQ5ZDfCFITuZl9+kZo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1666598664; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Pwe5xSoDf1uSWwLyLBsr2H6Q2HXGfgNQST99cSKLbEM=; b=6JDy3YJlEpEx81KZwUKTiq1t/zUDP335I6U9697CvWSTikvDYm49OfPRoFuX9o0ic45Uom sJMcHb86hgtlNIEZT+3fGt4pVfeKd3yswN6mLK7sGqHcl1geEBsYi/N1Fze3icdiFwpJkS QSiulplCaOIemgZ/aiw3Gktq8K008wo= Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=q39Z0Jl1; spf=pass (imf19.hostedemail.com: domain of guoren@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=guoren@kernel.org; dmarc=pass (policy=none) header.from=kernel.org X-Rspam-User: X-Rspamd-Server: rspam10 X-Stat-Signature: u77jsmkf6ntzuirig7awgcbbxbddfkus X-Rspamd-Queue-Id: 894111A003B X-HE-Tag: 1666598664-279190 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Oct 24, 2022 at 3:05 PM Huacai Chen wrote: > > From: Feiyang Chen > > The feature of minimizing overhead of struct page associated with each > HugeTLB page is implemented on x86_64. However, the infrastructure of > this feature is already there, so just select ARCH_WANT_HUGETLB_PAGE_ > OPTIMIZE_VMEMMAP is enough to enable this feature for LoongArch. > > To avoid the following build error on LoongArch we should include linux/ > static_key.h in page-flags.h. This is straightforward but the build > error is implicitly a LoongArch-specific problem, because ARM64 and X86 > have already include static_key.h from their arch-specific core headers. > > In file included from ./include/linux/mmzone.h:22, > from ./include/linux/gfp.h:6, > from ./include/linux/mm.h:7, > from arch/loongarch/kernel/asm-offsets.c:9: > ./include/linux/page-flags.h:208:1: warning: data definition has no > type or storage class > 208 | DECLARE_STATIC_KEY_MAYBE(CONFIG_HUGETLB_PAGE_OPTIMIZE_VMEMMAP_DEFAU= LT_ON, > | ^~~~~~~~~~~~~~~~~~~~~~~~ > ./include/linux/page-flags.h:208:1: error: type defaults to 'int' in > declaration of 'DECLARE_STATIC_KEY_MAYBE' [-Werror=3Dimplicit-int] > ./include/linux/page-flags.h:209:26: warning: parameter names (without > types) in function declaration > 209 | hugetlb_optimize_vmemmap_key); > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ > ./include/linux/page-flags.h: In function 'hugetlb_optimize_vmemmap_enabl= ed': > ./include/linux/page-flags.h:213:16: error: implicit declaration of > function 'static_branch_maybe' [-Werror=3Dimplicit-function-declaration] > 213 | return static_branch_maybe(CONFIG_HUGETLB_PAGE_OPTIMIZE_VMEMMAP_DEF= AULT_ON, > | ^~~~~~~~~~~~~~~~~~~ > ./include/linux/page-flags.h:213:36: error: > 'CONFIG_HUGETLB_PAGE_OPTIMIZE_VMEMMAP_DEFAULT_ON' undeclared (first > use in this function); did you mean > 'CONFIG_HUGETLB_PAGE_OPTIMIZE_VMEMMAP'? > 213 | return static_branch_maybe(CONFIG_HUGETLB_PAGE_OPTIMIZE_VMEMMAP_DEF= AULT_ON, > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > | CONFIG_HUGETLB_PAGE_OPTIMIZE_VMEMMAP > ./include/linux/page-flags.h:213:36: note: each undeclared identifier > is reported only once for each function it appears in > ./include/linux/page-flags.h:214:37: error: > 'hugetlb_optimize_vmemmap_key' undeclared (first use in this > function); did you mean 'hugetlb_optimize_vmemmap_enabled'? > 214 | &hugetlb_optimize_vmemmap_key); > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ > | hugetlb_optimize_vmemmap_enabled > > Reviewed-by: Philippe Mathieu-Daud=C3=A9 > Signed-off-by: Feiyang Chen > Signed-off-by: Huacai Chen > --- > arch/loongarch/Kconfig | 1 + > include/linux/page-flags.h | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/arch/loongarch/Kconfig b/arch/loongarch/Kconfig > index 6f7fa0c0ca08..0a6ef613124c 100644 > --- a/arch/loongarch/Kconfig > +++ b/arch/loongarch/Kconfig > @@ -52,6 +52,7 @@ config LOONGARCH > select ARCH_USE_QUEUED_RWLOCKS > select ARCH_USE_QUEUED_SPINLOCKS > select ARCH_WANT_DEFAULT_TOPDOWN_MMAP_LAYOUT > + select ARCH_WANT_HUGETLB_PAGE_OPTIMIZE_VMEMMAP > select ARCH_WANT_LD_ORPHAN_WARN > select ARCH_WANTS_NO_INSTR > select BUILDTIME_TABLE_SORT > diff --git a/include/linux/page-flags.h b/include/linux/page-flags.h > index 0b0ae5084e60..1aafdc73e399 100644 > --- a/include/linux/page-flags.h > +++ b/include/linux/page-flags.h > @@ -9,6 +9,7 @@ > #include > #include > #include > +#include Em... riscv needn't this. > #ifndef __GENERATING_BOUNDS_H > #include > #include > -- > 2.31.1 > --=20 Best Regards Guo Ren