From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98C9AC433EF for ; Sat, 25 Jun 2022 03:07:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 26ABA8E0288; Fri, 24 Jun 2022 23:07:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1F3238E0287; Fri, 24 Jun 2022 23:07:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 06C718E0288; Fri, 24 Jun 2022 23:07:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id E69568E0287 for ; Fri, 24 Jun 2022 23:07:39 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id B97BF325 for ; Sat, 25 Jun 2022 03:07:39 +0000 (UTC) X-FDA: 79615273038.21.3463C93 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf12.hostedemail.com (Postfix) with ESMTP id 2FF0540014 for ; Sat, 25 Jun 2022 03:07:39 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 34CB7620B5 for ; Sat, 25 Jun 2022 03:07:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BB131C341D0 for ; Sat, 25 Jun 2022 03:07:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1656126456; bh=oXHgCaP4HoPf+EWVcl07MPhIxJZH52Q6LkxiX0QDRik=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=FU+dZqhPCI7WaKDA+AjLnOS95m8QPJ0z8ReiNhcC2P4NI+ZrmxNZzDJ5YJTkaoQPc SatgzVUTcSgwyHrsucOh+GM4g3/1+h+GgSSKqGqW1IBs4BT6j/vgsdecXBdHRGrd/2 AqxR5wuq64YrbhfjN2MwpcKf3vhLfmFGvSGSPpQJKPSvpHYebZMLXmOJS28s2TD7Ve tSI/XbxbVWusqsHNpvvUVuXqKWV5X3nWDwd3AKdS2EZyyoyoyyVia9ScMoTkLyaHef IZZEeQ2fgwO8fwjgwOcJcINmgNazhx1HiRXE5XjDpGoZob6l6d4Fa9hcpl/FGH0gH1 y2/GNgWsUtZKQ== Received: by mail-vs1-f46.google.com with SMTP id t127so3933118vsb.8 for ; Fri, 24 Jun 2022 20:07:36 -0700 (PDT) X-Gm-Message-State: AJIora/XhCReo149Zfz1yakndkGDbrNsl8c9Vl01TndoQlUmRZLyLxIk 2+Tu9bY4m+JBMest83VSz68jmShYIF5Qg0JhEcw= X-Google-Smtp-Source: AGRyM1vKaBnKP+OKs0X53+qz3soArX9HkvW+CKQD7jqShPo7H3ehVP4Gjy9lyocTRtcrWI2zFmWCsaDUISHvTXAw0RU= X-Received: by 2002:a05:6102:3e93:b0:353:a8fb:e922 with SMTP id m19-20020a0561023e9300b00353a8fbe922mr711833vsv.51.1656126455677; Fri, 24 Jun 2022 20:07:35 -0700 (PDT) MIME-Version: 1.0 References: <20220624044339.1533882-1-anshuman.khandual@arm.com> <20220624044339.1533882-18-anshuman.khandual@arm.com> In-Reply-To: <20220624044339.1533882-18-anshuman.khandual@arm.com> From: Guo Ren Date: Sat, 25 Jun 2022 11:07:24 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH V4 17/26] csky/mm: Enable ARCH_HAS_VM_GET_PAGE_PROT To: Anshuman Khandual Cc: Linux-MM , Christoph Hellwig , Christophe Leroy , Andrew Morton , linuxppc-dev , sparclinux , "the arch/x86 maintainers" , Openrisc , "open list:TENSILICA XTENSA PORT (xtensa)" , linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, Parisc List , linux-alpha@vger.kernel.org, linux-riscv , linux-s390 , linux-ia64@vger.kernel.org, "open list:BROADCOM NVRAM DRIVER" , linux-m68k@lists.linux-m68k.org, linux-snps-arc@lists.infradead.org, Linux ARM , linux-um@lists.infradead.org, linux-sh@vger.kernel.org, Linux Kernel Mailing List , Geert Uytterhoeven Content-Type: text/plain; charset="UTF-8" ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=FU+dZqhP; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf12.hostedemail.com: domain of guoren@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=guoren@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1656126459; a=rsa-sha256; cv=none; b=pRt95FBNWlSchmVF0mzFMShnCC5YJlFUJRaFjH50xyJ7+RBp1WSYKzNGgtsvYOYt6thIuD crd3Kj1fu0YXVjKrMiYJjdznHlwc/HQHqiaLWEZq9G7Dut+6GK10DKNeymdzp/K6DO+SvZ T9Ahzr2g1IFIprbDLkZkm+RfdOFrSUU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1656126459; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hLqGsHWpK5WdIMo+N+bhUvhVGdW+LflLZ02tmMsQc+4=; b=pjYmtrWhH1twtrOgLaSFo01bKPDS0aw7bDlPgF7XBL8HNUr5CJ2qdCLwwMO8TjMYbkGV53 yZrpRvU4G6HyU1CWDAUAxQxwgCqB0Uw0C0n9Vylz4lQSW4/qeNOEhJfpVE94nb6l+8y58i EVgCUo3V46PjqBEWkhYigBA991HGAbo= X-Stat-Signature: nfrbqoz9tt3wea8ene53xq4itdpz4ah9 X-Rspamd-Server: rspam08 X-Rspam-User: X-Rspamd-Queue-Id: 2FF0540014 Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=FU+dZqhP; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf12.hostedemail.com: domain of guoren@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=guoren@kernel.org X-HE-Tag: 1656126459-720051 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: For csky part. Acked-by: Guo Ren On Fri, Jun 24, 2022 at 12:48 PM Anshuman Khandual wrote: > > This enables ARCH_HAS_VM_GET_PAGE_PROT on the platform and exports standard > vm_get_page_prot() implementation via DECLARE_VM_GET_PAGE_PROT, which looks > up a private and static protection_map[] array. Subsequently all __SXXX and > __PXXX macros can be dropped which are no longer needed. > > Cc: Geert Uytterhoeven > Cc: linux-csky@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Signed-off-by: Anshuman Khandual > --- > arch/csky/Kconfig | 1 + > arch/csky/include/asm/pgtable.h | 18 ------------------ > arch/csky/mm/init.c | 20 ++++++++++++++++++++ > 3 files changed, 21 insertions(+), 18 deletions(-) > > diff --git a/arch/csky/Kconfig b/arch/csky/Kconfig > index 21d72b078eef..588b8a9c68ed 100644 > --- a/arch/csky/Kconfig > +++ b/arch/csky/Kconfig > @@ -6,6 +6,7 @@ config CSKY > select ARCH_HAS_GCOV_PROFILE_ALL > select ARCH_HAS_SYNC_DMA_FOR_CPU > select ARCH_HAS_SYNC_DMA_FOR_DEVICE > + select ARCH_HAS_VM_GET_PAGE_PROT > select ARCH_USE_BUILTIN_BSWAP > select ARCH_USE_QUEUED_RWLOCKS > select ARCH_WANT_FRAME_POINTERS if !CPU_CK610 && $(cc-option,-mbacktrace) > diff --git a/arch/csky/include/asm/pgtable.h b/arch/csky/include/asm/pgtable.h > index bbe245117777..229a5f4ad7fc 100644 > --- a/arch/csky/include/asm/pgtable.h > +++ b/arch/csky/include/asm/pgtable.h > @@ -77,24 +77,6 @@ > #define MAX_SWAPFILES_CHECK() \ > BUILD_BUG_ON(MAX_SWAPFILES_SHIFT != 5) > > -#define __P000 PAGE_NONE > -#define __P001 PAGE_READ > -#define __P010 PAGE_READ > -#define __P011 PAGE_READ > -#define __P100 PAGE_READ > -#define __P101 PAGE_READ > -#define __P110 PAGE_READ > -#define __P111 PAGE_READ > - > -#define __S000 PAGE_NONE > -#define __S001 PAGE_READ > -#define __S010 PAGE_WRITE > -#define __S011 PAGE_WRITE > -#define __S100 PAGE_READ > -#define __S101 PAGE_READ > -#define __S110 PAGE_WRITE > -#define __S111 PAGE_WRITE > - > extern unsigned long empty_zero_page[PAGE_SIZE / sizeof(unsigned long)]; > #define ZERO_PAGE(vaddr) (virt_to_page(empty_zero_page)) > > diff --git a/arch/csky/mm/init.c b/arch/csky/mm/init.c > index bf2004aa811a..1bf7b2a748fd 100644 > --- a/arch/csky/mm/init.c > +++ b/arch/csky/mm/init.c > @@ -197,3 +197,23 @@ void __init fixaddr_init(void) > vaddr = __fix_to_virt(__end_of_fixed_addresses - 1) & PMD_MASK; > fixrange_init(vaddr, vaddr + PMD_SIZE, swapper_pg_dir); > } > + > +static pgprot_t protection_map[16] __ro_after_init = { > + [VM_NONE] = PAGE_NONE, > + [VM_READ] = PAGE_READ, > + [VM_WRITE] = PAGE_READ, > + [VM_WRITE | VM_READ] = PAGE_READ, > + [VM_EXEC] = PAGE_READ, > + [VM_EXEC | VM_READ] = PAGE_READ, > + [VM_EXEC | VM_WRITE] = PAGE_READ, > + [VM_EXEC | VM_WRITE | VM_READ] = PAGE_READ, > + [VM_SHARED] = PAGE_NONE, > + [VM_SHARED | VM_READ] = PAGE_READ, > + [VM_SHARED | VM_WRITE] = PAGE_WRITE, > + [VM_SHARED | VM_WRITE | VM_READ] = PAGE_WRITE, > + [VM_SHARED | VM_EXEC] = PAGE_READ, > + [VM_SHARED | VM_EXEC | VM_READ] = PAGE_READ, > + [VM_SHARED | VM_EXEC | VM_WRITE] = PAGE_WRITE, > + [VM_SHARED | VM_EXEC | VM_WRITE | VM_READ] = PAGE_WRITE > +}; > +DECLARE_VM_GET_PAGE_PROT > -- > 2.25.1 > -- Best Regards Guo Ren ML: https://lore.kernel.org/linux-csky/