From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77867C36008 for ; Wed, 26 Mar 2025 09:23:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 81B4128006E; Wed, 26 Mar 2025 05:22:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7CBD4280069; Wed, 26 Mar 2025 05:22:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6934028006E; Wed, 26 Mar 2025 05:22:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 4DB42280069 for ; Wed, 26 Mar 2025 05:22:59 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 37AE059F59 for ; Wed, 26 Mar 2025 09:23:00 +0000 (UTC) X-FDA: 83263162920.01.7D85E77 Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by imf13.hostedemail.com (Postfix) with ESMTP id 1821C2000C for ; Wed, 26 Mar 2025 09:22:57 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=s50PwZt5; spf=pass (imf13.hostedemail.com: domain of guoren@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=guoren@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1742980978; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5Qcio3ipYiuBJ+YGTFveVpMecIngaSNM3zgbQiRqaH0=; b=gzK7NB8797HlwMQBYqw/TsbOmS2T6L3hQq9ylKd99Tb431FFyL8QtG5FkuMuOdm/ArWE/b XAgl/HzoCU8JwpSFtg7WTFBw8qRzN0ONvlbkCYAngJWDREELxk45c1tPY40+6LbeKwcLEh oSIJo1spsPoPvYRRV9nB2pSPvsY128U= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=s50PwZt5; spf=pass (imf13.hostedemail.com: domain of guoren@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=guoren@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1742980978; a=rsa-sha256; cv=none; b=WWR56gYIHZFeVq/fb1zDNUKJ06GdaS0QXXl2HUm/NmEROoEpPxRXfIlQ/PNVP8n43rch3h MGzVpIrISH+jXeLaRI0tsR+YiqZp/XD1PoLdkqYzpfOyXIwY/sZ6/Rsj8tNpylPW8mFQ8I UP+ov+KY5xVLyBmifGQzfnr/xOlmBHQ= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 5F4FB44120 for ; Wed, 26 Mar 2025 09:22:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 96372C4CEEA for ; Wed, 26 Mar 2025 09:22:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1742980976; bh=qxtF6khLwId9LK15aaIK1R6QxhmJS+7IKsOAe3rcYSQ=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=s50PwZt5zoEHQFKwW/oYZWE1K07t8vLMrgQRSGzC/Oy/aL79dZg+dbtEjlleSecDT VtdygfOfXFS/GCiVqXkKIKE3s0Oq6/xcwKqAMQx2EadKeHnI1N+NSwSr4CrsSrat0a s87heplEso1LAhDM3bqU7MxGGrioRLbJT3hCTEqLu3r7MwSqIEtLDK4Gb8MM14sIBc f1unkZELp8aSlPGMn9CR2JsUxtBm+xvZEqn5EgNDFQtp67ynt6vhbCVwZObLSngZLT rLgeBMwEQauN+k0rw/PTd/s3vdYaki8t/S+mmO5ODNjwPWTJUp5GN634XLwZJ6ze4f +KtDEcmx4hwfA== Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-3913958ebf2so5260725f8f.3 for ; Wed, 26 Mar 2025 02:22:56 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCUqycEq5sThVHWucOjycvBcEwSj2PlfL34Et/q2tle6pV9LNcQn/dk2QZa/2b8fuHBxjFkvItkAhg==@kvack.org X-Gm-Message-State: AOJu0YzUT6+fju9sYw3DPGgHaERIZIhSFKjc1ldlbaD5IIXopVubQS41 WvwZhGp4j1RxDnUg0qCMVOWUY17CgN9+VOCYZuPAI8YEGs59ImxLqb42P8/RBL/t/+HGoyD6Z/G JyWPIVYGl7xgxwbuzZJPoCpYdIoI= X-Google-Smtp-Source: AGHT+IF3jZFlaB+ZbNTy99aWKHRW0ahCYMSSdgm6iKEF0x/RcYEZFdBlnTMpJzR5i/QwTCeteoihHBZi+8MLpfxSmpw= X-Received: by 2002:a05:6000:2a6:b0:391:20ef:6300 with SMTP id ffacd0b85a97d-3997f93962dmr16836387f8f.37.1742980974678; Wed, 26 Mar 2025 02:22:54 -0700 (PDT) MIME-Version: 1.0 References: <20250325121624.523258-1-guoren@kernel.org> <20250325121624.523258-26-guoren@kernel.org> <05fec753-cdaa-45a5-a029-b6435c30eb07@omp.ru> In-Reply-To: <05fec753-cdaa-45a5-a029-b6435c30eb07@omp.ru> From: Guo Ren Date: Wed, 26 Mar 2025 17:22:41 +0800 X-Gmail-Original-Message-ID: X-Gm-Features: AQ5f1Joqx3oO-95jEhIdt3VHkcZ-PNWMEgaxjEOC2faFZmARHVgyLTPNu3C9X9I Message-ID: Subject: Re: [RFC PATCH V3 25/43] rv64ilp32_abi: exec: Adapt 64lp64 env and argv To: Sergey Shtylyov Cc: arnd@arndb.de, gregkh@linuxfoundation.org, torvalds@linux-foundation.org, paul.walmsley@sifive.com, palmer@dabbelt.com, anup@brainfault.org, atishp@atishpatra.org, oleg@redhat.com, kees@kernel.org, tglx@linutronix.de, will@kernel.org, mark.rutland@arm.com, brauner@kernel.org, akpm@linux-foundation.org, rostedt@goodmis.org, edumazet@google.com, unicorn_wang@outlook.com, inochiama@outlook.com, gaohan@iscas.ac.cn, shihua@iscas.ac.cn, jiawei@iscas.ac.cn, wuwei2016@iscas.ac.cn, drew@pdp7.com, prabhakar.mahadev-lad.rj@bp.renesas.com, ctsai390@andestech.com, wefu@redhat.com, kuba@kernel.org, pabeni@redhat.com, josef@toxicpanda.com, dsterba@suse.com, mingo@redhat.com, peterz@infradead.org, boqun.feng@gmail.com, xiao.w.wang@intel.com, qingfang.deng@siflower.com.cn, leobras@redhat.com, jszhang@kernel.org, conor.dooley@microchip.com, samuel.holland@sifive.com, yongxuan.wang@sifive.com, luxu.kernel@bytedance.com, david@redhat.com, ruanjinjie@huawei.com, cuiyunhui@bytedance.com, wangkefeng.wang@huawei.com, qiaozhe@iscas.ac.cn, ardb@kernel.org, ast@kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, kvm@vger.kernel.org, kvm-riscv@lists.infradead.org, linux-mm@kvack.org, linux-crypto@vger.kernel.org, bpf@vger.kernel.org, linux-input@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-serial@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-arch@vger.kernel.org, maple-tree@lists.infradead.org, linux-trace-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-atm-general@lists.sourceforge.net, linux-btrfs@vger.kernel.org, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, linux-nfs@vger.kernel.org, linux-sctp@vger.kernel.org, linux-usb@vger.kernel.org, linux-media@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 1821C2000C X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: f5ga3gwwkmp6frkn8b33enckkmrih7f9 X-HE-Tag: 1742980977-964542 X-HE-Meta: U2FsdGVkX1+9hk7ZEWFZKj0yHZP7jGp9WLTBndAs7E4TmBP34fxhbQZW+kAYWa20dNXnHhWiNt2vhKKcWKw+dE8X/Q4Z3XT4az82oAOKmCvfShsFosMf94/pdPQq4LmpWm4JyLtN0zP1iJmM2RSwctjRAeP5QQtmiX3ZZE5djhOIhN69OVMGeTKwRhqOFAXVVQ6YK8Nq0ipgZ7ubZTSrwDTRK4qmNhuOU8TLR+DLek8Wfbe3MdwM73hxWPFYkiEaVop8OM65KAG2BDNUcd1XAMCjZrj4Ym4Khwhs68L6yghhBlDuymxkqPtOvYlmBI/kIGLh24HaqomDcX+6hFgjvSXRPongcK2bBBHOo/1x8EBrbCKlE+gEB9iQaoQHLu0llZUWHZkRL5ZeRa0Q9CiRk8A9a0wBSV2hOtUVk0SE1vukks7hHJRAkuzBPqJE/l8815yJWigtdsyXunWq1dJjPjaF6nr7FQS1SX244FNy5Je3Imd2bw0wtwIpsizLIlqTmnFKwLM6a2RoFYiF+LmVa7bFAluQ3Chp5B+EytY5BT6UxFIaYy2ciRjUJpAOA+66aPmzhHDP12OuHL0ypIXJQ1wUGctQkyoFYzavHLG/8fblOwq1KiOjIPY+oCswI69ajj8ToUPCDC8/YYQrzqX3HT0mKVbMQdo6RJfJdK0Di2gfbojSxflADjMgE6ETTv+8Ay2FaE9IJc3n0yeTBJtiAuaYiTLxWmDuDb6FFPJl+33wuF2kSpbvy6CujuFCK4uW72wLTy3LK5qv9g+2XreeklMXx0BTVRvfKcgS0y+GucqWkGgwWlkwDhPc2Cf5zmmXojTp+1bGKfwzpYCIjxuZf2BxUdzIJEoKA1sDBOoQa4ddALSOKa0ZjI+4p6S1q3XBJ284DhCuMG9uqC0W5Afqx3ajlc+6NnCdXC8UDMZYvuCNirITPwtlhyjRJw6w7ky58eCIIfSGs50+F0+HexD lYlYmJ/T k2Ge2Ep7oSif72ehE5ZJmTWvI+TMYQPlNFnbaiDIgmZPJraVZE5OQIF6yOBsz2rrlQor+M2FYJ99QPS92OWEcfN1oBN/zAwnBC386oA7Ioq9nnCZl715DcrjuLte9FtqOXpv4HJBblJWDzcJ6OuE/io3ew6CIrBdAid0VoH6AGD3MFMD6bU4WbDD7FSp5hVc+bN+Wd1KCNGW26DrTl2gjmPZi1b2Akv61tNVtao1jclCBR+CBK5UC/Dr6etH3y1TH9BJVSPkwWBxm0a8jCkpxva7vKugBA5+Iv0C5iyJ7z0mi3ZtNI0szcl28TlSEqhjb1Q/52bx9iet0R4KKhNfvz+gYnRdH1fIUx2smk4feZ3Ivo5axfYkAZBUz169vLelJnrmFuGNRWgFZcAY7YmGXMQShOPv6BOOQ/wKOL3uAM0ALC0s2dWqlG0KtE+YzSpj+Rul/w5qQWWzop4DekrwOnFMJi3q4OpZ9KaIu0Ua5pntSuCg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Mar 26, 2025 at 1:19=E2=80=AFAM Sergey Shtylyov = wrote: > > On 3/25/25 3:16 PM, guoren@kernel.org wrote: > > > From: "Guo Ren (Alibaba DAMO Academy)" > > > > The rv64ilp32 abi reuses the env and argv memory layout of the > > lp64 abi, so leave the space to fit the lp64 struct layout. > > > > Signed-off-by: Guo Ren (Alibaba DAMO Academy) > > --- > > fs/exec.c | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/fs/exec.c b/fs/exec.c > > index 506cd411f4ac..548d18b7ae92 100644 > > --- a/fs/exec.c > > +++ b/fs/exec.c > > @@ -424,6 +424,10 @@ static const char __user *get_user_arg_ptr(struct = user_arg_ptr argv, int nr) > > } > > #endif > > > > +#if defined(CONFIG_64BIT) && (BITS_PER_LONG =3D=3D 32) okay, #if defined(CONFIG_64BIT) && BITS_PER_LONG =3D=3D 32 > > Parens don't seem necessary... > > > + nr =3D nr * 2; > > Why not nr *=3D 2? okay, nr *=3D 2; --=20 Best Regards Guo Ren