From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51EDDC433EF for ; Sat, 4 Jun 2022 12:14:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 72AA46B0071; Sat, 4 Jun 2022 08:14:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 68E856B0073; Sat, 4 Jun 2022 08:14:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 555A16B0074; Sat, 4 Jun 2022 08:14:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 420276B0071 for ; Sat, 4 Jun 2022 08:14:05 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay13.hostedemail.com (Postfix) with ESMTP id 1B81461125 for ; Sat, 4 Jun 2022 12:14:05 +0000 (UTC) X-FDA: 79540445250.26.E6F6169 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf01.hostedemail.com (Postfix) with ESMTP id CA8CC40051 for ; Sat, 4 Jun 2022 12:13:55 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9505F60B84 for ; Sat, 4 Jun 2022 12:14:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 33046C341C8 for ; Sat, 4 Jun 2022 12:14:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1654344842; bh=P9g5evQvLeCWlEOvlwctyGL5SApo79l0tSxaVcIHKPA=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=GIyFj6BBzBZ4owCCVP5Aw4h3f0cXtR3hEqmrT9g670pZU/aQzIAQ2WfJvI/DknBRp 4bYKwydQ0aYuGH1L5fBQCLpyzXIofO9higKucAr9Sy6M/NdNgRTqlWLPjz76TpemCg o5/euygaM3XOLTr8By89APAq6jiMVCST2z+Q9PMv3E7nS9Z42DH7R0OrYd6SVheduF EZlfIsJBqn4SM90nhHS8OrgxuSA94ZHCoBGkUfXicORrA8v5ly8ntcA/nQuwU0e9It FE7DXLjmfzYeTqs7rwtKtwfeJR+KZPybsrMoiF6VsZOU0EImc2irdP0IzRClSsVLBw zeZ+URjHsYFVg== Received: by mail-vs1-f49.google.com with SMTP id n4so754049vsm.6 for ; Sat, 04 Jun 2022 05:14:02 -0700 (PDT) X-Gm-Message-State: AOAM531EH0mq0U4ZjuhCEWG9Xvn9xeKKd2FRCn/Kbtk14ghLbRGaYy4z HrE1YO4SbCiClKwx90Jv6Vvs5nuYLVez47TMpcM= X-Google-Smtp-Source: ABdhPJwwEZX9ryeNihnPAt9cIeqrE+zZlFv6d4BeVpnc8qN7eqFa9hlNwwNfnB2L+k7vfA514WdPGRvZColxx5FoxRk= X-Received: by 2002:a05:6102:292b:b0:34b:9fad:2b63 with SMTP id cz43-20020a056102292b00b0034b9fad2b63mr2132145vsb.51.1654344840935; Sat, 04 Jun 2022 05:14:00 -0700 (PDT) MIME-Version: 1.0 References: <20220603101411.488970-1-anshuman.khandual@arm.com> <20220603101411.488970-5-anshuman.khandual@arm.com> In-Reply-To: <20220603101411.488970-5-anshuman.khandual@arm.com> From: Guo Ren Date: Sat, 4 Jun 2022 20:13:50 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 4/6] csky/mm: Enable ARCH_HAS_VM_GET_PAGE_PROT To: Anshuman Khandual Cc: Linux-MM , Catalin Marinas , Will Deacon , Michael Ellerman , Paul Mackerras , "David S. Miller" , Thomas Gleixner , Ingo Molnar , Heiko Carstens , Vasily Gorbik , Thomas Bogendoerfer , Geert Uytterhoeven , Dinh Nguyen , Jonas Bonn , Andrew Morton , "the arch/x86 maintainers" , Openrisc , linux-csky@vger.kernel.org, "open list:BROADCOM NVRAM DRIVER" , Linux ARM , linuxppc-dev , sparclinux , linux-s390 , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=GIyFj6BB; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf01.hostedemail.com: domain of guoren@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=guoren@kernel.org X-Stat-Signature: 9ifa7eerq5cjmsbcpckmscwtes4jp7je X-Rspam-User: X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: CA8CC40051 X-HE-Tag: 1654344835-512411 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Acked-by: Guo Ren On Fri, Jun 3, 2022 at 6:15 PM Anshuman Khandual wrote: > > This defines and exports a platform specific custom vm_get_page_prot() via > subscribing ARCH_HAS_VM_GET_PAGE_PROT. Subsequently all __SXXX and __PXXX > macros can be dropped which are no longer needed. > > Cc: Geert Uytterhoeven > Cc: linux-csky@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Acked-by: Guo Ren > Signed-off-by: Anshuman Khandual > --- > arch/csky/Kconfig | 1 + > arch/csky/include/asm/pgtable.h | 18 ------------------ > arch/csky/mm/init.c | 32 ++++++++++++++++++++++++++++++++ > 3 files changed, 33 insertions(+), 18 deletions(-) > > diff --git a/arch/csky/Kconfig b/arch/csky/Kconfig > index 21d72b078eef..588b8a9c68ed 100644 > --- a/arch/csky/Kconfig > +++ b/arch/csky/Kconfig > @@ -6,6 +6,7 @@ config CSKY > select ARCH_HAS_GCOV_PROFILE_ALL > select ARCH_HAS_SYNC_DMA_FOR_CPU > select ARCH_HAS_SYNC_DMA_FOR_DEVICE > + select ARCH_HAS_VM_GET_PAGE_PROT > select ARCH_USE_BUILTIN_BSWAP > select ARCH_USE_QUEUED_RWLOCKS > select ARCH_WANT_FRAME_POINTERS if !CPU_CK610 && $(cc-option,-mbacktrace) > diff --git a/arch/csky/include/asm/pgtable.h b/arch/csky/include/asm/pgtable.h > index bbe245117777..229a5f4ad7fc 100644 > --- a/arch/csky/include/asm/pgtable.h > +++ b/arch/csky/include/asm/pgtable.h > @@ -77,24 +77,6 @@ > #define MAX_SWAPFILES_CHECK() \ > BUILD_BUG_ON(MAX_SWAPFILES_SHIFT != 5) > > -#define __P000 PAGE_NONE > -#define __P001 PAGE_READ > -#define __P010 PAGE_READ > -#define __P011 PAGE_READ > -#define __P100 PAGE_READ > -#define __P101 PAGE_READ > -#define __P110 PAGE_READ > -#define __P111 PAGE_READ > - > -#define __S000 PAGE_NONE > -#define __S001 PAGE_READ > -#define __S010 PAGE_WRITE > -#define __S011 PAGE_WRITE > -#define __S100 PAGE_READ > -#define __S101 PAGE_READ > -#define __S110 PAGE_WRITE > -#define __S111 PAGE_WRITE > - > extern unsigned long empty_zero_page[PAGE_SIZE / sizeof(unsigned long)]; > #define ZERO_PAGE(vaddr) (virt_to_page(empty_zero_page)) > > diff --git a/arch/csky/mm/init.c b/arch/csky/mm/init.c > index bf2004aa811a..f9babbed17d4 100644 > --- a/arch/csky/mm/init.c > +++ b/arch/csky/mm/init.c > @@ -197,3 +197,35 @@ void __init fixaddr_init(void) > vaddr = __fix_to_virt(__end_of_fixed_addresses - 1) & PMD_MASK; > fixrange_init(vaddr, vaddr + PMD_SIZE, swapper_pg_dir); > } > + > +pgprot_t vm_get_page_prot(unsigned long vm_flags) > +{ > + switch (vm_flags & (VM_READ | VM_WRITE | VM_EXEC | VM_SHARED)) { > + case VM_NONE: > + return PAGE_NONE; > + case VM_READ: > + case VM_WRITE: > + case VM_WRITE | VM_READ: > + case VM_EXEC: > + case VM_EXEC | VM_READ: > + case VM_EXEC | VM_WRITE: > + case VM_EXEC | VM_WRITE | VM_READ: > + return PAGE_READ; > + case VM_SHARED: > + return PAGE_NONE; > + case VM_SHARED | VM_READ: > + return PAGE_READ; > + case VM_SHARED | VM_WRITE: > + case VM_SHARED | VM_WRITE | VM_READ: > + return PAGE_WRITE; > + case VM_SHARED | VM_EXEC: > + case VM_SHARED | VM_EXEC | VM_READ: > + return PAGE_READ; > + case VM_SHARED | VM_EXEC | VM_WRITE: > + case VM_SHARED | VM_EXEC | VM_WRITE | VM_READ: > + return PAGE_WRITE; > + default: > + BUILD_BUG(); > + } > +} > +EXPORT_SYMBOL(vm_get_page_prot); > -- > 2.25.1 > -- Best Regards Guo Ren ML: https://lore.kernel.org/linux-csky/