* [PATCH] csky/mm: fix build errors cause by folio flags changes
@ 2025-10-15 6:47 Mike Rapoport
2025-10-15 7:51 ` Guo Ren
0 siblings, 1 reply; 4+ messages in thread
From: Mike Rapoport @ 2025-10-15 6:47 UTC (permalink / raw)
To: Andrew Morton
Cc: Guo Ren, Matthew Wilcox, Mike Rapoport, linux-csky, linux-kernel,
linux-mm
From: "Mike Rapoport (Microsoft)" <rppt@kernel.org>
Kernel compilation on csky fails because csky was not updated during
conversion of folio flags to memdesc_flags_t:
arch/csky/abiv2/inc/abi/cacheflush.h: In function 'flush_dcache_folio':
arch/csky/abiv2/inc/abi/cacheflush.h:23:39: error: passing argument 2 of 'const_test_bit' from incompatible pointer type [-Werror=incompatible-pointer-types]
23 | if (test_bit(PG_dcache_clean, &folio->flags))
| ^~~~~~~~~~~~~
| |
| memdesc_flags_t *
include/linux/bitops.h:47:24: note: in definition of macro 'bitop'
47 | const##op(nr, addr) : op(nr, addr))
| ^~~~
arch/csky/abiv2/inc/abi/cacheflush.h:23:13: note: in expansion of macro 'test_bit'
23 | if (test_bit(PG_dcache_clean, &folio->flags))
| ^~~~~~~~
Update references of folio->flags in arch/csky.
Fixes: 53fbef56e07d ("mm: introduce memdesc_flags_t")
Signed-off-by: Mike Rapoport (Microsoft) <rppt@kernel.org>
---
arch/csky/abiv2/cacheflush.c | 2 +-
arch/csky/abiv2/inc/abi/cacheflush.h | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/csky/abiv2/cacheflush.c b/arch/csky/abiv2/cacheflush.c
index 876028b1083f..064b0f0f95ca 100644
--- a/arch/csky/abiv2/cacheflush.c
+++ b/arch/csky/abiv2/cacheflush.c
@@ -21,7 +21,7 @@ void update_mmu_cache_range(struct vm_fault *vmf, struct vm_area_struct *vma,
folio = page_folio(pfn_to_page(pfn));
- if (test_and_set_bit(PG_dcache_clean, &folio->flags))
+ if (test_and_set_bit(PG_dcache_clean, &folio->flags.f))
return;
icache_inv_range(address, address + nr*PAGE_SIZE);
diff --git a/arch/csky/abiv2/inc/abi/cacheflush.h b/arch/csky/abiv2/inc/abi/cacheflush.h
index 6513ac5d2578..da51a0f02391 100644
--- a/arch/csky/abiv2/inc/abi/cacheflush.h
+++ b/arch/csky/abiv2/inc/abi/cacheflush.h
@@ -20,8 +20,8 @@
static inline void flush_dcache_folio(struct folio *folio)
{
- if (test_bit(PG_dcache_clean, &folio->flags))
- clear_bit(PG_dcache_clean, &folio->flags);
+ if (test_bit(PG_dcache_clean, &folio->flags.f))
+ clear_bit(PG_dcache_clean, &folio->flags.f);
}
#define flush_dcache_folio flush_dcache_folio
base-commit: 3a8660878839faadb4f1a6dd72c3179c1df56787
--
2.50.1
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] csky/mm: fix build errors cause by folio flags changes
2025-10-15 6:47 [PATCH] csky/mm: fix build errors cause by folio flags changes Mike Rapoport
@ 2025-10-15 7:51 ` Guo Ren
2025-10-15 12:09 ` Matthew Wilcox
0 siblings, 1 reply; 4+ messages in thread
From: Guo Ren @ 2025-10-15 7:51 UTC (permalink / raw)
To: Mike Rapoport
Cc: Andrew Morton, Matthew Wilcox, linux-csky, linux-kernel, linux-mm
Thanks for the fixup. If you want to go through your tree, please add the tag:
Acked-by: Guo Ren <guoren@kernel.org>
On Wed, Oct 15, 2025 at 2:48 PM Mike Rapoport <rppt@kernel.org> wrote:
>
> From: "Mike Rapoport (Microsoft)" <rppt@kernel.org>
>
> Kernel compilation on csky fails because csky was not updated during
> conversion of folio flags to memdesc_flags_t:
>
> arch/csky/abiv2/inc/abi/cacheflush.h: In function 'flush_dcache_folio':
> arch/csky/abiv2/inc/abi/cacheflush.h:23:39: error: passing argument 2 of 'const_test_bit' from incompatible pointer type [-Werror=incompatible-pointer-types]
> 23 | if (test_bit(PG_dcache_clean, &folio->flags))
> | ^~~~~~~~~~~~~
> | |
> | memdesc_flags_t *
> include/linux/bitops.h:47:24: note: in definition of macro 'bitop'
> 47 | const##op(nr, addr) : op(nr, addr))
> | ^~~~
> arch/csky/abiv2/inc/abi/cacheflush.h:23:13: note: in expansion of macro 'test_bit'
> 23 | if (test_bit(PG_dcache_clean, &folio->flags))
> | ^~~~~~~~
>
> Update references of folio->flags in arch/csky.
>
> Fixes: 53fbef56e07d ("mm: introduce memdesc_flags_t")
> Signed-off-by: Mike Rapoport (Microsoft) <rppt@kernel.org>
> ---
> arch/csky/abiv2/cacheflush.c | 2 +-
> arch/csky/abiv2/inc/abi/cacheflush.h | 4 ++--
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/csky/abiv2/cacheflush.c b/arch/csky/abiv2/cacheflush.c
> index 876028b1083f..064b0f0f95ca 100644
> --- a/arch/csky/abiv2/cacheflush.c
> +++ b/arch/csky/abiv2/cacheflush.c
> @@ -21,7 +21,7 @@ void update_mmu_cache_range(struct vm_fault *vmf, struct vm_area_struct *vma,
>
> folio = page_folio(pfn_to_page(pfn));
>
> - if (test_and_set_bit(PG_dcache_clean, &folio->flags))
> + if (test_and_set_bit(PG_dcache_clean, &folio->flags.f))
> return;
>
> icache_inv_range(address, address + nr*PAGE_SIZE);
> diff --git a/arch/csky/abiv2/inc/abi/cacheflush.h b/arch/csky/abiv2/inc/abi/cacheflush.h
> index 6513ac5d2578..da51a0f02391 100644
> --- a/arch/csky/abiv2/inc/abi/cacheflush.h
> +++ b/arch/csky/abiv2/inc/abi/cacheflush.h
> @@ -20,8 +20,8 @@
>
> static inline void flush_dcache_folio(struct folio *folio)
> {
> - if (test_bit(PG_dcache_clean, &folio->flags))
> - clear_bit(PG_dcache_clean, &folio->flags);
> + if (test_bit(PG_dcache_clean, &folio->flags.f))
> + clear_bit(PG_dcache_clean, &folio->flags.f);
> }
> #define flush_dcache_folio flush_dcache_folio
>
>
> base-commit: 3a8660878839faadb4f1a6dd72c3179c1df56787
> --
> 2.50.1
>
--
Best Regards
Guo Ren
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] csky/mm: fix build errors cause by folio flags changes
2025-10-15 7:51 ` Guo Ren
@ 2025-10-15 12:09 ` Matthew Wilcox
2025-10-16 6:42 ` Guo Ren
0 siblings, 1 reply; 4+ messages in thread
From: Matthew Wilcox @ 2025-10-15 12:09 UTC (permalink / raw)
To: Guo Ren; +Cc: Mike Rapoport, Andrew Morton, linux-csky, linux-kernel, linux-mm
On Wed, Oct 15, 2025 at 03:51:53PM +0800, Guo Ren wrote:
> Thanks for the fixup. If you want to go through your tree, please add the tag:
> Acked-by: Guo Ren <guoren@kernel.org>
Why haven't you merged the original patch from October 6th?
Message-Id: <20251006-csky-folio-flags-v1-1-a91dcbdbf988@linutronix.de>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] csky/mm: fix build errors cause by folio flags changes
2025-10-15 12:09 ` Matthew Wilcox
@ 2025-10-16 6:42 ` Guo Ren
0 siblings, 0 replies; 4+ messages in thread
From: Guo Ren @ 2025-10-16 6:42 UTC (permalink / raw)
To: Matthew Wilcox
Cc: Mike Rapoport, Andrew Morton, linux-csky, linux-kernel, linux-mm
On Wed, Oct 15, 2025 at 8:09 PM Matthew Wilcox <willy@infradead.org> wrote:
>
> On Wed, Oct 15, 2025 at 03:51:53PM +0800, Guo Ren wrote:
> > Thanks for the fixup. If you want to go through your tree, please add the tag:
> > Acked-by: Guo Ren <guoren@kernel.org>
>
> Why haven't you merged the original patch from October 6th?
Sorry, I didn't pick that patch up and just replied to the acked-by.
I'll investigate it tonight.
>
> Message-Id: <20251006-csky-folio-flags-v1-1-a91dcbdbf988@linutronix.de>
>
--
Best Regards
Guo Ren
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-10-16 6:42 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-10-15 6:47 [PATCH] csky/mm: fix build errors cause by folio flags changes Mike Rapoport
2025-10-15 7:51 ` Guo Ren
2025-10-15 12:09 ` Matthew Wilcox
2025-10-16 6:42 ` Guo Ren
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox