From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A78F9C3ABC9 for ; Tue, 13 May 2025 17:33:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9BAD06B00C6; Tue, 13 May 2025 13:33:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 968D66B00F5; Tue, 13 May 2025 13:33:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7BADF6B00F6; Tue, 13 May 2025 13:33:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 5B5676B00C6 for ; Tue, 13 May 2025 13:33:58 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 7D64BBED79 for ; Tue, 13 May 2025 17:33:58 +0000 (UTC) X-FDA: 83438582556.03.4C11221 Received: from mail-qt1-f179.google.com (mail-qt1-f179.google.com [209.85.160.179]) by imf24.hostedemail.com (Postfix) with ESMTP id 9F705180008 for ; Tue, 13 May 2025 17:33:56 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=eXNHGqLh; spf=pass (imf24.hostedemail.com: domain of jyescas@google.com designates 209.85.160.179 as permitted sender) smtp.mailfrom=jyescas@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747157636; a=rsa-sha256; cv=none; b=dGGllQ4+vH4FjjPsCDg1SIMgeM1SU1R3wG4qmNv1TjmlR0SGHBjlnNP72iZBIBoUC1uHVl F+q87QE0AWrrTtclp8pAeJxjc5wgUQtFMS2IIsjmUxvgIoL1C4RF+9mruUFYS6DkynMNAh ycz7JbZ0KzDS0f95g5EWNNl9XM9fryg= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=eXNHGqLh; spf=pass (imf24.hostedemail.com: domain of jyescas@google.com designates 209.85.160.179 as permitted sender) smtp.mailfrom=jyescas@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747157636; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=OGZhE1s2JEZR2aghl+eaXgLkZsMZTnt2KxW/7xIZ5zM=; b=tdqYIM+kzz6XydxLHJnA/a87stCzkhzgBZV7Vomdb2ZUHs5bx3qQ1h/fMZvWRVLA1O6/42 hJ3JIRuES5V3mjaRCwX4Wxhk3hZfCFRIH5QCVhbvgifMrYuuVnpil3Yupxwj8UkMfsAuKA EXeJmGDChgSC6WKAXKSyWxafI0w3gcY= Received: by mail-qt1-f179.google.com with SMTP id d75a77b69052e-48b7747f881so24431cf.1 for ; Tue, 13 May 2025 10:33:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1747157636; x=1747762436; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=OGZhE1s2JEZR2aghl+eaXgLkZsMZTnt2KxW/7xIZ5zM=; b=eXNHGqLhGhF1nSllcA6fsS5eB9eQcnzARyqvOZVBWyvxzpyn1iCL7sPW0MAJS0AFLo 7ht5Qw3NX4GIENL/ZTcCyesrkx2ObK/nZJiVKm0c4q3jkdmSmsBMpUoi6t6NlWEgeAOY gU1O1Z6M4NfoNgYOyrwcCnRJKvnflZww0frdnOiHhCTMOwhp05K09Xqr36g29opcwAfr cdyLyPus0xe3CGPCx3YAPlxBY8XlZUHYaPyF3KvQMqZ1CVq288ryMlKoRizyaw61xk0Q 9VqLKOeqlv/ARPCS4vCpDxtmxIlbcXMB17aE5K3a8tcAeMpXpyTiR2K9+YV6B0MdrJi0 bspg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747157636; x=1747762436; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=OGZhE1s2JEZR2aghl+eaXgLkZsMZTnt2KxW/7xIZ5zM=; b=QXtn878CXU2NqYY2q0tn79PIwe7L8i8/x9QdFxiqW6vx2720a9EFnA3QsSGfWW5acs aywHUotHG+kskyhean30O7lKGeCD0Yv7JrIpagHIdhDJoHrz2S5vqh1h46p2iRLgxHWq RgQzwRi/xRd/vc6LhF4BURUWr98WPUKsFqeao1mDHi8MJAwv5qvbQh6IZv2LnNHrZ52L 3PQX97axnERbl3fuutDfR35e8u+/B3MMnHjEOvV+dPxrNB3aBrdJayz3tEA1s0D7e0J9 6Tl4oYqLjDBjBFCkLC+APEsKfVc1GGg6qcG42M3vzfF31uOoGT0RcIfnDDxhG76fK0Eo adnw== X-Forwarded-Encrypted: i=1; AJvYcCUx/Osa9GMpn1m6ogarjGkiI0j+PkDkdPmcX4lzkI4kUYnB0wM05UfPR7y1YKs+3elrwjASuB2Shw==@kvack.org X-Gm-Message-State: AOJu0YxpbXK+idddyO8cXnOOK53qfXDsUn1vzh2zAzU87JS/zA/84RHk yp6Ot4CxOaeOCb1uJp3B120qmfhnIM92ck7e6j6Q9fu72kF/Ao/xbMWOLFP8/7sFRcJK3IX50yq oyYEGrSqmq9/WSVl7Se/cYip1e67uXRTisd58kUGE X-Gm-Gg: ASbGncse8D10F4teGBpi7AUEp8ezTOclbr7JEfzuG0JMed3PBrPx+20YeoXPqoBJe/j MhtEpAZD0E6q8My6o549mUj8WAiOnd0Ts+F1YnSWQ/JcF8EtwWSBq2eEgKXUenfUJUVxQDWtkkO 7dXx3R2Avowf0nI3oS0lp2D+fDB8kCE+Ky5A== X-Google-Smtp-Source: AGHT+IGR+aRkPDQu30C21Yg15jM/Rvta9kt+tqUIrVd3aCPyFeFOfxhT65b2G1ZByAMG9Pqd6bcFcqMCzMjko1MYtA0= X-Received: by 2002:ac8:598d:0:b0:466:8c23:823a with SMTP id d75a77b69052e-494898efdb9mr4013011cf.17.1747157635413; Tue, 13 May 2025 10:33:55 -0700 (PDT) MIME-Version: 1.0 References: <20250510010338.3978696-1-jyescas@google.com> <202505110035.wtOWnL8o-lkp@intel.com> <2513BE19-5527-45A4-8BE8-A447B53654C0@nvidia.com> <9A5BA016-179F-4BFF-AB1E-61F39CA0C1C2@nvidia.com> In-Reply-To: <9A5BA016-179F-4BFF-AB1E-61F39CA0C1C2@nvidia.com> From: Juan Yescas Date: Tue, 13 May 2025 10:33:43 -0700 X-Gm-Features: AX0GCFssEtVKMlvc2w89Raz7x1SKnlM6TwuuCt_fA0gC2KTM19wyfhtp99168uo Message-ID: Subject: Re: [PATCH v4] mm: Add CONFIG_PAGE_BLOCK_ORDER to select page block order To: Zi Yan Cc: Andrew Morton , kernel test robot , linux-kernel@vger.kernel.org, oe-kbuild-all@lists.linux.dev, Linux Memory Management List , tjmercier@google.com, isaacmanjarres@google.com, surenb@google.com, kaleshsingh@google.com, Vlastimil Babka , "Liam R. Howlett" , Lorenzo Stoakes , David Hildenbrand , Mike Rapoport , Minchan Kim Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 9F705180008 X-Stat-Signature: 1t5gyfuizfageqds48w5gpyz4fsi1rek X-HE-Tag: 1747157636-662968 X-HE-Meta: U2FsdGVkX18KcD458YqjJPGTJeNLbkDMAFYRBX7qwIdm+h4GKdZHFFM6JRfiZOncXfZpkdalJKk0HdhcghKZGKNFCoaF+ADWxHyyLDXq0G+yhNwYWZJ1GM6qJoYBlUqHL3NgWmT+eLCz/FtMx7tndbfU/bZ5U8LcVrw3jfwz/EruG0N+dHBMaOWGOtk9pcTxszzi8fBc1JnRHykG03jeP/Eoi5klWhvx+Q6CRN9tUPZrOioAuCHDOhZ7QXSX5g5KseBhNgnHMLmAtXXTosnhZPsjbG1TM4nQZ9vaZd/XShMuxAXSBlWKaSnuuuJDLi6XTsrVRcHKQ//B1+pM6okYiWaQjfUQbZydoMd4UvOXoIJV5BcyZUUoX1ncaw0GTIzREhEjY62QbGx4S0/E/qvghEvBUU/5M+baqdOJm2VPlZxnefnrehs2O1exLSrK/HUsVSNWw7+Ma92HgbREkFSwWw6Z3ZHm3rpNUYyr00yorngXGD+BK5kupV1oDB46tnhOM7lRBN/QsZyNN+wUtMLTN/PQk8Z0bhqMdTZdJzwW0ebc6z/vFrosOequovyr+7T3ibVFR4xwEDt4mhG4HnYHgO4BPgQ8yBkEchn4IE5xJ+aHa3FmhbOYkzD4Eata2iXrtESOYVHj8dGG+QJF3+2F8cBZHn7CBPwWAl1VyIUdrBOaNXlFlWB9KcIW5rzuw6qG4PNOX01042pAmxhuZbheVB4dzRNIxy4MXx/Bg+HmHCcklra3LGuSvkiR+DHz4HEYkliP4qUuDNmD6Rm3gf/e73eCfHBxK5rIq0HhZSuYDqBOiynD62kUFFT8RDIdQR0BsnF33Ce9/1I+9xHDlddeNwCsdMWCpM3f7Qs/buW6okhwYPce06QZYm03ab53B7Orfvozi+3yuWK7XFTrSpdJ5bdDYx7QZAavunRIrh1hsIu4CIGadaYcROeoEX+rNfKuvA0D1la1Bnt4MOZ42Hi aW5wsAgI OpwKQX+89+MxykL1fxtJxPYg8KLWzEDJDYQTFifCy6qG46tAmfNdo9TD8XFXj87P7OxAo5WLh3qeGW0cdJ8NXSPSGWK9jNf2TLyxDiUSnqUVeAKqsobdbv8PLrHeXrBmb07Q8MJ5UPSpllpNIvOU+HXimVvGu8s2l5kmQmC1p+O/QAjZEx9aD8lwI6LUmAB3sz3TYbzXylkFBBqzJtHmIv1gVwYn1uMqjazY7F5EnQkBr1mucOeGjgE39HM/QAsF5lRLIqoWWTjg/q/giWRJgv1BzuqNIsdjK3Wc09Cv1X8LU98CNXxFLeRUHIyuoKlkfQA1RwFrPmSoZPNJYCqX3LWndZDWC0IV3PPODcckcLQfSG2/4PA3Glhs3oiAugqdnnniNBUIJaQfBmMAUNAlxjnh0p8OMvj9Jx2aIJWQqk1OImIj0xY5sGMxS4Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, May 13, 2025 at 9:52=E2=80=AFAM Zi Yan wrote: > > On 13 May 2025, at 12:47, Zi Yan wrote: > > > On 13 May 2025, at 12:41, Juan Yescas wrote: > > > >> On Tue, May 13, 2025 at 8:08=E2=80=AFAM Zi Yan wrote: > >>> > >>> On 10 May 2025, at 13:16, kernel test robot wrote: > >>> > >>>> Hi Juan, > >>>> > >>>> kernel test robot noticed the following build errors: > >>>> > >>>> [auto build test ERROR on linus/master] > >>>> [also build test ERROR on v6.15-rc5] > >>>> [cannot apply to akpm-mm/mm-everything next-20250509] > >>>> [If your patch is applied to the wrong git tree, kindly drop us a no= te. > >>>> And when submitting patch, we suggest to use '--base' as documented = in > >>>> https://git-scm.com/docs/git-format-patch#_base_tree_information] > >>>> > >>>> url: https://github.com/intel-lab-lkp/linux/commits/Juan-Yescas/m= m-Add-CONFIG_PAGE_BLOCK_ORDER-to-select-page-block-order/20250510-090501 > >>>> base: linus/master > >>>> patch link: https://lore.kernel.org/r/20250510010338.3978696-1-jy= escas%40google.com > >>>> patch subject: [PATCH v4] mm: Add CONFIG_PAGE_BLOCK_ORDER to select = page block order > >>>> config: powerpc-allmodconfig (https://download.01.org/0day-ci/archiv= e/20250511/202505110035.wtOWnL8o-lkp@intel.com/config) > >>>> compiler: powerpc64-linux-gcc (GCC) 14.2.0 > >>>> reproduce (this is a W=3D1 build): (https://download.01.org/0day-ci/= archive/20250511/202505110035.wtOWnL8o-lkp@intel.com/reproduce) > >>>> > >>>> If you fix the issue in a separate patch/commit (i.e. not just a new= version of > >>>> the same patch/commit), kindly add following tags > >>>> | Reported-by: kernel test robot > >>>> | Closes: https://lore.kernel.org/oe-kbuild-all/202505110035.wtOWnL8= o-lkp@intel.com/ > >>>> > >>>> All errors (new ones prefixed by >>): > >>>> > >>>> In file included from include/linux/gfp.h:7, > >>>> from include/linux/xarray.h:16, > >>>> from include/linux/list_lru.h:14, > >>>> from include/linux/fs.h:14, > >>>> from include/linux/compat.h:17, > >>>> from arch/powerpc/kernel/asm-offsets.c:12: > >>>>>> include/linux/mmzone.h:53:2: error: #error MAX_PAGE_ORDER must be = >=3D PAGE_BLOCK_ORDER > >>>> 53 | #error MAX_PAGE_ORDER must be >=3D PAGE_BLOCK_ORDER > >>>> | ^~~~~ > >>>> make[3]: *** [scripts/Makefile.build:98: arch/powerpc/kernel/asm-= offsets.s] Error 1 > >>> > >>> In this config, CONFIG_ARCH_FORCE_MAX_ORDER is set to 8, lower than > >>> the default PAGE_BLOCK_ORDER value, 10. I wonder if the error should > >>> be changed to ignore CONFIG_PAGE_BLOCK_ORDER when MAX_PAGE_ORDER is > >>> set by CONFIG_ARCH_FORCE_MAX_ORDER and give a warning instead. > >> > >> In ARMv8, MAX_PAGE_ORDER is set up by CONFIG_ARCH_FORCE_MAX_ORDER > >> and CONFIG_PAGE_BLOCK_ORDER is also set up, so we need to take into ac= count > >> CONFIG_PAGE_BLOCK_ORDER. For other architectures, the default will be: > >> CONFIG_ARCH_FORCE_MAX_ORDER =3D CONFIG_PAGE_BLOCK_ORDER. > > > > It seems that the Kconfig =E2=80=9Crange 1 ARCH_FORCE_MAX_ORDER if ARCH= _FORCE_MAX_ORDER=E2=80=9D > > is not working. The above powerpc-allmodconfig has CONFIG_ARCH_FORCE_MA= X_ORDER > > set to 8 and CONFIG_PAGE_BLOCK_ORDER is set to 10, leading to the compi= lation > > error. > > You can get the same config by running =E2=80=9CARCH=3Dpowerpc make allmo= dconfig=E2=80=9D. > Thanks, that works! > > > >> > >> Is there any valid case where the MAX_PAGE_ORDER needs to be smaller t= han > >> the page block order? > > > > I am not aware of any. > > > >> > >> Thanks > >> Juan > >>> > >>>> make[3]: Target 'prepare' not remade because of errors. > >>>> make[2]: *** [Makefile:1275: prepare0] Error 2 > >>>> make[2]: Target 'prepare' not remade because of errors. > >>>> make[1]: *** [Makefile:248: __sub-make] Error 2 > >>>> make[1]: Target 'prepare' not remade because of errors. > >>>> make: *** [Makefile:248: __sub-make] Error 2 > >>>> make: Target 'prepare' not remade because of errors. > >>>> > >>>> > >>>> vim +53 include/linux/mmzone.h > >>>> > >>>> 46 > >>>> 47 /* > >>>> 48 * The MAX_PAGE_ORDER, which defines the max order of = pages to be allocated > >>>> 49 * by the buddy allocator, has to be larger or equal t= o the PAGE_BLOCK_ORDER, > >>>> 50 * which defines the order for the number of pages tha= t can have a migrate type > >>>> 51 */ > >>>> 52 #if (PAGE_BLOCK_ORDER > MAX_PAGE_ORDER) > >>>> > 53 #error MAX_PAGE_ORDER must be >=3D PAGE_BLOCK_ORDER > >>>> 54 #endif > >>>> 55 > >>>> > >>>> -- > >>>> 0-DAY CI Kernel Test Service > >>>> https://github.com/intel/lkp-tests/wiki > >>> > >>> > >>> Best Regards, > >>> Yan, Zi > > > > > > Best Regards, > > Yan, Zi > > > Best Regards, > Yan, Zi