From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EACFAC3ABCC for ; Tue, 13 May 2025 16:41:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 162396B00EE; Tue, 13 May 2025 12:41:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 110FE6B00EF; Tue, 13 May 2025 12:41:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EA5D46B00F0; Tue, 13 May 2025 12:41:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id C7E366B00EE for ; Tue, 13 May 2025 12:41:37 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id B84671611B6 for ; Tue, 13 May 2025 16:41:39 +0000 (UTC) X-FDA: 83438450718.10.428A4C4 Received: from mail-qt1-f176.google.com (mail-qt1-f176.google.com [209.85.160.176]) by imf19.hostedemail.com (Postfix) with ESMTP id C4B9C1A0010 for ; Tue, 13 May 2025 16:41:37 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=cmtuBuf2; spf=pass (imf19.hostedemail.com: domain of jyescas@google.com designates 209.85.160.176 as permitted sender) smtp.mailfrom=jyescas@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747154497; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6BnDDfyJoznq74Fy9bepDWSIw4wPa6h1sLOGzU/61vk=; b=579Jb9ubm8FHaNBNdO+lGSncmTsmnwgaoBjz/i4Kj6MhdSHjL2xaIDY0jP3qmAQ3Y0pU0R BpwbHcHYynU1VGeaCbV5VkX+CKPYE0AerThBBPApc3f8uoQ0LsCPxy9KSQnqEsNFGsMSAM 9cBEx4fVeQdkyitTkcdacimUobLdzKY= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=cmtuBuf2; spf=pass (imf19.hostedemail.com: domain of jyescas@google.com designates 209.85.160.176 as permitted sender) smtp.mailfrom=jyescas@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747154497; a=rsa-sha256; cv=none; b=T36/F97EWSfLA8RcEH1xLsd5Lg5LiwijxiCAB+k2N6IxcjumZHuM6hGt3LXBmnxcblUY4j h3IW+fUM3GTPOPF8sfrY9z5gW0sTwI7i/bSVroc7ORzh4J9jGR9TZzTiena9v5kp0Olymu c8dbwHHEj+w5bRnoRQnLC1IAILJjW1k= Received: by mail-qt1-f176.google.com with SMTP id d75a77b69052e-48b7747f881so1061cf.1 for ; Tue, 13 May 2025 09:41:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1747154497; x=1747759297; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=6BnDDfyJoznq74Fy9bepDWSIw4wPa6h1sLOGzU/61vk=; b=cmtuBuf2643vD3NVEf49NxSlC+GA/2I8SoYn4TmeTmqfBMPb8N9soNuo6VqjHAceOT GG7i21qNTMQb03oZZmW6e1Ci/bATcCF8RIA9v/CpSeniC2dy9MdnDjLBXajXrnEnlyms OCeyBNTlFam8TRHuTDvJRZy2A/3hcTQChHkA1UlhD7l4+B6jgW01yV3CQdA0DRdPtVwX xEQCHndTCqg2aZVSNBc9QieTlrcDFijSisNk/6+JSGWdm7l5WyvkyAEQ3q3htJruULtH LTN+6o0mtVfIp1+fwHfQ8dKnhLjgaTTL1XI4nK9Ujr6eOBP+6WQz4/tLc47ZLcasLAeo XKcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747154497; x=1747759297; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6BnDDfyJoznq74Fy9bepDWSIw4wPa6h1sLOGzU/61vk=; b=B+9PZwMNLHSwd7esJ6i6dN1Ngul1qprGJxzy+hOjhJ7NgUzSCNpBjMRwy+sPJDKuho E26ztn4RuEgDHAdmLECnTmTi5BKTblijROncnSXBcn6D23LZoKApFilyub2UmqsVSFmX gS+p40lanX78mCRdmgAaIKgRUP/ywTic07Ed5+YtXLQkSU6rPcRSHrCJSeh4QX8q4R5Z mGfbNc45CePU6BWY4OHd9v9r3Z9n8/XYL0pKkIyODIAoXb6FwgCh0sARt+TiufhTIz7h rk+9F9B4F+uRuEY2Pzs2zMfY5amIma7MTPB29u0533EGjjubEFEBVOrTWxus1KfGdjva jU3A== X-Forwarded-Encrypted: i=1; AJvYcCUQgEaJpBzdeL5KXiozNOJqXtjTxk+XOGuIBIQamCh7mrIq4z2IPjI2GPYAmz9YhNervoh00bv+MA==@kvack.org X-Gm-Message-State: AOJu0YwqmYcyNo+xzofqzHHNCkJzFdApHN6h/gAb9mj1maPO44oLG/f0 J/pprwV2Lyq+ZHAnSF2NsCHJCgZSKTb6R6zSjX2uXtsHb+2iOu/ZKKid7EZ/XAaRDHI1b5QAYDg hvBNnxcaGG4qofNAeD6W1hH18aJrPKNUlhjfLTG/U X-Gm-Gg: ASbGncvTCLHBKrU+J9YkWuzh3WYUTtm9NhD9cXCZ64SZZKmjR1q5+c3rQ9e7sdeK7mD /SQgOKtddWj1KhbvMG+ECWCmBK5BhM/JuG4PhjLKmJ38ZCdq+Pu/jksDLXbWBGN6c13/1sbgGu6 MCK6GLio9172A8S+wSJjjy6bmtHOewLYcBJg== X-Google-Smtp-Source: AGHT+IEJHAdBReTtQOM+Du77qJGTcBmfyorO99vnOGQflRem28oWY3TBlhFPfh4hozV7waawUleyczMmoCPeFGe6apM= X-Received: by 2002:a05:622a:1b9f:b0:47d:4e8a:97f0 with SMTP id d75a77b69052e-4948990f38dmr3883821cf.29.1747154496402; Tue, 13 May 2025 09:41:36 -0700 (PDT) MIME-Version: 1.0 References: <20250510010338.3978696-1-jyescas@google.com> <202505110035.wtOWnL8o-lkp@intel.com> In-Reply-To: From: Juan Yescas Date: Tue, 13 May 2025 09:41:24 -0700 X-Gm-Features: AX0GCFuQ__xLeJQ79EFOWN0yV7Y9yxsqU-iVJS9r_l0AKVbr7f7W4t90YzZtWWI Message-ID: Subject: Re: [PATCH v4] mm: Add CONFIG_PAGE_BLOCK_ORDER to select page block order To: Zi Yan Cc: Andrew Morton , kernel test robot , linux-kernel@vger.kernel.org, oe-kbuild-all@lists.linux.dev, Linux Memory Management List , tjmercier@google.com, isaacmanjarres@google.com, surenb@google.com, kaleshsingh@google.com, Vlastimil Babka , "Liam R. Howlett" , Lorenzo Stoakes , David Hildenbrand , Mike Rapoport , Minchan Kim Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam10 X-Stat-Signature: z6r5futug5zoz1h6eugyihr8xg5d1d4g X-Rspamd-Queue-Id: C4B9C1A0010 X-Rspam-User: X-HE-Tag: 1747154497-160572 X-HE-Meta: U2FsdGVkX18y7dYSREZ4bGryX9drzD+jUTzvjYzaaxfwfMnZmDKT6lpqi7V3gBfrHlv2absCOqCrWZ6tuF9tf/EKCdLzCrtsrmvmLK2+o81hMi2QmKJaT3RgOwnz7JqJ0NCwKEWLFu3D9HDvQUi4mKAagQkQPZLaCUnHVLYxTein/aHLJN6vmS6IatrKT4TPL6R/R+gGRl3AmIRQxsoJc6cBtTidkXcXxi2HJfAfapYNSQX9ogNAmsupCbeZlG+5l5njYKSKJcCqZkRJ2XpRjzOIPwHnaJqUzm/UEoyOFUutlzit8KB71E2ILgVQkzlSAO96MNCaxLaBQwH2pXtEpyhkRNFhKxTGm/XRFwSwMJ/NCE4EyGuULmZL/31/j/jBxl4sP5TY6HYTnMQtsXGHxyDzqVJHVArpnZNI5RBLVJAEqdT0uzlNY7ptSPWQW8Ccq11Jppr7eTjJnL5okfyrsAewb414uCRKxVpPxqeQxbX+ul/3/vtNnP4IJj3nUMElq1AVfZrOC8YLO0ETMea3Gze8fjuvSmb+JpEyOeXK0V5qv5OMSWF1rhe7TWYznaLLhlc0Q9Ia/YlOswIiAXyVV49okw0t7gglq/m1x3KSitSbFgQgyVPUapAUKo4O95E1Lf7S8CsSBYwcxQrxa7U9B4orP4EP2lsmfL6OUQUd+zUVNbDbUwN8ZKhNuC7h1mcE7a1ZL55/eguKxdQnmcUjowYaZEjuMUEN352KHX9hWO4iacvJQj568V19P//CWM1R5+pcKsYh1RB8CAOJ8Pcpdz7jO7qgC2j1pHYlWrcVmut5qCWjwyPLyY66pQhA1e49jtZZEaX66Uiwh5aRKHuYbC1znoj4trpmDLciTv14h8bW2k6C2MCwEviluPve+R0IFCpqeJR0uvV7Xl2mrbNkES5dj7OB8DBCYuqxAGEMyvHyZWpvzd6utxi4lxmyYdC2L7DLa4Xj4154zLBvY5i b7N8ohak NPFYmlTVD5yJOeYnTRBzAdLtbNM0xcUlMci3qvfrtDfpvjeJ5bPfxo6FJDauctBisglidcoOcYEZitcrIKcYnccdg2wYmL1+8buIiwYgVzchOGfVGwP9CD1DaK/cm62DLMDJgF1nixINRAlCf0NP6bjCSDtrlsx6/ZUan1nsnxkMBJlE0e6BAe2xH8X/lELhYiRDz6rTFiZuUzNX7h+Q3dr80mlRZUkeZNbT5P+z7QbiT6oRPOy0JQeDQn4/gEga92HM6gUpFKi4GePMlNHJeB0vTI1t8Lqqbn+Ch1/ToVOGzWtkjhY9NF4CZDr9DhS05wtE/WnIE5Vxq2wswTPpk4QV0/H4IZh9DH1ryoeMGUL9m2KoAqbrrFe/22rGFe4IlQgJZcB1MY6+jbCpdrARp3yNINlHJcPTFPDenuLVbvBSySFK6k07z7o5Yiw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, May 13, 2025 at 8:08=E2=80=AFAM Zi Yan wrote: > > On 10 May 2025, at 13:16, kernel test robot wrote: > > > Hi Juan, > > > > kernel test robot noticed the following build errors: > > > > [auto build test ERROR on linus/master] > > [also build test ERROR on v6.15-rc5] > > [cannot apply to akpm-mm/mm-everything next-20250509] > > [If your patch is applied to the wrong git tree, kindly drop us a note. > > And when submitting patch, we suggest to use '--base' as documented in > > https://git-scm.com/docs/git-format-patch#_base_tree_information] > > > > url: https://github.com/intel-lab-lkp/linux/commits/Juan-Yescas/mm-A= dd-CONFIG_PAGE_BLOCK_ORDER-to-select-page-block-order/20250510-090501 > > base: linus/master > > patch link: https://lore.kernel.org/r/20250510010338.3978696-1-jyesc= as%40google.com > > patch subject: [PATCH v4] mm: Add CONFIG_PAGE_BLOCK_ORDER to select pag= e block order > > config: powerpc-allmodconfig (https://download.01.org/0day-ci/archive/2= 0250511/202505110035.wtOWnL8o-lkp@intel.com/config) > > compiler: powerpc64-linux-gcc (GCC) 14.2.0 > > reproduce (this is a W=3D1 build): (https://download.01.org/0day-ci/arc= hive/20250511/202505110035.wtOWnL8o-lkp@intel.com/reproduce) > > > > If you fix the issue in a separate patch/commit (i.e. not just a new ve= rsion of > > the same patch/commit), kindly add following tags > > | Reported-by: kernel test robot > > | Closes: https://lore.kernel.org/oe-kbuild-all/202505110035.wtOWnL8o-l= kp@intel.com/ > > > > All errors (new ones prefixed by >>): > > > > In file included from include/linux/gfp.h:7, > > from include/linux/xarray.h:16, > > from include/linux/list_lru.h:14, > > from include/linux/fs.h:14, > > from include/linux/compat.h:17, > > from arch/powerpc/kernel/asm-offsets.c:12: > >>> include/linux/mmzone.h:53:2: error: #error MAX_PAGE_ORDER must be >= =3D PAGE_BLOCK_ORDER > > 53 | #error MAX_PAGE_ORDER must be >=3D PAGE_BLOCK_ORDER > > | ^~~~~ > > make[3]: *** [scripts/Makefile.build:98: arch/powerpc/kernel/asm-off= sets.s] Error 1 > > In this config, CONFIG_ARCH_FORCE_MAX_ORDER is set to 8, lower than > the default PAGE_BLOCK_ORDER value, 10. I wonder if the error should > be changed to ignore CONFIG_PAGE_BLOCK_ORDER when MAX_PAGE_ORDER is > set by CONFIG_ARCH_FORCE_MAX_ORDER and give a warning instead. In ARMv8, MAX_PAGE_ORDER is set up by CONFIG_ARCH_FORCE_MAX_ORDER and CONFIG_PAGE_BLOCK_ORDER is also set up, so we need to take into account CONFIG_PAGE_BLOCK_ORDER. For other architectures, the default will be: CONFIG_ARCH_FORCE_MAX_ORDER =3D CONFIG_PAGE_BLOCK_ORDER. Is there any valid case where the MAX_PAGE_ORDER needs to be smaller than the page block order? Thanks Juan > > > make[3]: Target 'prepare' not remade because of errors. > > make[2]: *** [Makefile:1275: prepare0] Error 2 > > make[2]: Target 'prepare' not remade because of errors. > > make[1]: *** [Makefile:248: __sub-make] Error 2 > > make[1]: Target 'prepare' not remade because of errors. > > make: *** [Makefile:248: __sub-make] Error 2 > > make: Target 'prepare' not remade because of errors. > > > > > > vim +53 include/linux/mmzone.h > > > > 46 > > 47 /* > > 48 * The MAX_PAGE_ORDER, which defines the max order of pag= es to be allocated > > 49 * by the buddy allocator, has to be larger or equal to t= he PAGE_BLOCK_ORDER, > > 50 * which defines the order for the number of pages that c= an have a migrate type > > 51 */ > > 52 #if (PAGE_BLOCK_ORDER > MAX_PAGE_ORDER) > > > 53 #error MAX_PAGE_ORDER must be >=3D PAGE_BLOCK_ORDER > > 54 #endif > > 55 > > > > -- > > 0-DAY CI Kernel Test Service > > https://github.com/intel/lkp-tests/wiki > > > Best Regards, > Yan, Zi