From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80DAFC3ABC3 for ; Tue, 13 May 2025 17:32:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 27F446B00DF; Tue, 13 May 2025 13:32:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 209146B00E1; Tue, 13 May 2025 13:32:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 00DD56B00E3; Tue, 13 May 2025 13:32:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id D03936B00DF for ; Tue, 13 May 2025 13:32:30 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 620E6BED43 for ; Tue, 13 May 2025 17:32:32 +0000 (UTC) X-FDA: 83438578944.10.AAFF2A6 Received: from mail-qt1-f178.google.com (mail-qt1-f178.google.com [209.85.160.178]) by imf12.hostedemail.com (Postfix) with ESMTP id 444F540010 for ; Tue, 13 May 2025 17:32:30 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=KSsXapBp; spf=pass (imf12.hostedemail.com: domain of jyescas@google.com designates 209.85.160.178 as permitted sender) smtp.mailfrom=jyescas@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747157550; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2DOowbSxIBNFz77Dq0SWuQaa+felhYyndn2kYV4C73o=; b=ctag2vdAWKqmcf5qyaQqRk7DLubkKF0TkGT6HA7wHfFjjlxoAWWLztO1IwbbxspbbYRHUL K5/xQaWpW+R9RPc1az0EqKENexboUGZB7GqhiVJYzY9H6Ah2QZ8r5yY2mAxqhbIz4T28xR xqEXoX3BcfQkYtvINOXiPERTw7oz4NE= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=KSsXapBp; spf=pass (imf12.hostedemail.com: domain of jyescas@google.com designates 209.85.160.178 as permitted sender) smtp.mailfrom=jyescas@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747157550; a=rsa-sha256; cv=none; b=7OXrMUaGxcEb9U7Zt1xJJAc/1/EklZNWWoz6nie4MN+s1+S2QobJborZ9ADKxpSRS7TB2t NoFX/lv5J8k8amaEfeB5xsbQj4XKpGUBj523UOh52C+bg7kCRq8qF8ewcGmBkcUDHG1X5H 4ffo9pj4r/wrBEwjBR0Fj/GIb9UuQ5w= Received: by mail-qt1-f178.google.com with SMTP id d75a77b69052e-48b7747f881so23701cf.1 for ; Tue, 13 May 2025 10:32:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1747157549; x=1747762349; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=2DOowbSxIBNFz77Dq0SWuQaa+felhYyndn2kYV4C73o=; b=KSsXapBpF7RJcSNvMBdLvxqnL+oj2R1GSj1a8b3wOlQ+c1NCbNwuWGczUdi5V8zf+g d28T0Q2z3Xz+lbKymqa+wrF/TNG4OInbusJ+l1AJ2BIEM7kdO1959CjhSL1KlhWAONkW 0GpMLSRYndGqzujgmO39mngOOv+CHh/7gnCP+DUVIUZjiSbxiD3EjdmJNH6xx/RY6SIz /6IChlMh/O2N8uXOt2xMGmgyPK5PXZgGyVkQBrs7t2EIDNy7bpSWR8cJ/snAjqiMsoW0 GpWcmXMhtYvsG2gqNy1sm8c+QhhOaGAcmI/StUvWp2wS5ei7Zh+VBGKts7p9eaA+ON/0 0JVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747157549; x=1747762349; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2DOowbSxIBNFz77Dq0SWuQaa+felhYyndn2kYV4C73o=; b=bOjrwaD9WnXQHfT8DD1R0NQUgJLF31WZMgPy9oEuKquXWT9266sKTB/hOooUQQs85m NWG7jRjzYh1YP2HIv5gtgnzvj7lhbWezZoiixgbJdwDWmrL9poAZU0SBlhS0WCX2Mmbz ns3xbKPoFlL7oslrv8yskuzkdRqFrocV7+0RNXUe7QfZVFlq80WWJdgfvoOslRXl8aDx 1LAPn+OpbOph/TU3MV0bwsvP/ybdW9+u5j6R1BRYzeRaTAVo9Or8oE9wXwsfketL1UB6 Xv+zx7sueeNeGOwju4ltyFesTDhogzXyx9I0gqfo89ki/OzPPVrJM+epi3VSAZBh3EKr KVLA== X-Forwarded-Encrypted: i=1; AJvYcCVzi4i85b9N4qjm3NPRBz1ue0RYiKg0t3Pj1SDPww/s6U1J+OGsQVLke6g/gLyCyH6fdIkFmX12JA==@kvack.org X-Gm-Message-State: AOJu0YwQWdy1Em1nd2nrAXaPx1RjEEcz7hbUqvu2u+38xS8c8BW4gT56 lOqajRJMz/VqGYyPODggK/PDKL2oU8UFkysHi93aiQ7jKObHAoztg/qZieOxmSZR4QR2fFYYfod V25WGxjYjMWUSZALNqIHX9BKtFgdPVtxJ7T7qOFMA X-Gm-Gg: ASbGncsd78hRTJFrlD0gIsKziwobnJgh6mv6T0ORdpXao6dH92zHSL0VFMYlcIpB5lc JciL3iLbc+worf3Rj0g1g2dSaAttC1YMk3j3WbYWK0Oay6o3hDoJNT229zC5QgIx/Id6vVIEWtS ttJsbo+hfiYIdjGQOl8BZRzFI63UzEfofIfQ== X-Google-Smtp-Source: AGHT+IG+8VLEF5LwFCMQ0UHlKUUGTtV36GRRRSd04x5eFCzOeewR4VGbhq+2ryDt5b+wtk8+cDAHA/Jvf+AKp3ItYCg= X-Received: by 2002:a05:622a:202:b0:471:eab0:ef21 with SMTP id d75a77b69052e-494898efbb9mr4851341cf.13.1747157548610; Tue, 13 May 2025 10:32:28 -0700 (PDT) MIME-Version: 1.0 References: <20250510010338.3978696-1-jyescas@google.com> <202505110035.wtOWnL8o-lkp@intel.com> <2513BE19-5527-45A4-8BE8-A447B53654C0@nvidia.com> In-Reply-To: <2513BE19-5527-45A4-8BE8-A447B53654C0@nvidia.com> From: Juan Yescas Date: Tue, 13 May 2025 10:32:17 -0700 X-Gm-Features: AX0GCFtkFGhhXiBkpciVK_nVdr9uM4M6rZUdEjYlxAZyTsZ4doe_1wm8rW9p5rM Message-ID: Subject: Re: [PATCH v4] mm: Add CONFIG_PAGE_BLOCK_ORDER to select page block order To: Zi Yan Cc: Andrew Morton , kernel test robot , linux-kernel@vger.kernel.org, oe-kbuild-all@lists.linux.dev, Linux Memory Management List , tjmercier@google.com, isaacmanjarres@google.com, surenb@google.com, kaleshsingh@google.com, Vlastimil Babka , "Liam R. Howlett" , Lorenzo Stoakes , David Hildenbrand , Mike Rapoport , Minchan Kim Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 444F540010 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: xsj6usma3ikfwkzwsugs5y9swxaaj8rf X-HE-Tag: 1747157550-704493 X-HE-Meta: U2FsdGVkX1+F5Aqw8Tmugq2bnw7Tnx1bdPpb6HIh+aDsJdwQQAMaIdoBktqG6q6wR4QtJwfjbyWuW5jxn7WItq4AL8OGKYPTmBSLpdCWwZSUN7lBh8/mk1KpqfdqKiumkDoIZVmMcFSBGCND1iolzhMydAy96a75aS5uuQSM51MizO9pGQDaLN+NcGhuqLyI1U5xP+1dVSB6uO23mRw5nzRAUJYpvgVhP5I2I2c8fAf6aWzM20DFk0yIEMTSj/srsHVP3WU8+mND1+1PzsmRy3k4cuUiIxJXMtc4i8UnBxeKSjWD1FLPVLJ0hbaklhQX/uYw9yWUXRt3FcaWKSIzBDIJ2flZKs+scfuWkItvFRUV86co4VqoPIEcBhNbiF3W2YG2SlNwE3v1FZp44CI9q5NTDGyXvlR86H5e727jPVxITIAquyIF018RsRMlaWldvPcohzZetgm93/u3PmD7pPNxl/0IE/gtF5HN2cZHpPT8KFJwpjuo0IrwSkeKGach0Gpi/UI8dTUQmIub1FB0H1d+AnS/ptbOkW5gIaiELnOKv4mn9SJlfRmwnGu5ssAyQWSrZ+RziJZGsSOWYut64hmSh3X2aHenJ3Dl9/oyUukYF2sesHg2xBeOmBbdkeljN5HhGa5rRFOzeFh3Pdyz9T5Pr4365EXMtpVlP6qf0eJTCAuz5FNBxWTt90i9jXoqAxjJ7jLBEirqFwTtfhqGiGNnQLcalcBx1Xj8ikV2UFPGT+qYJSoTbU1IMiiQfpSbrOftkyG0St4ezvLpM6tnoyb1vxYqtbDlbPU0sx1TjpS1PUGZn2cVhv+eHJhHU5Q3J1R+QXrSDUMBQkMxmXFF7/IZoRl4zqXCcEuCUz7I7w/zRCog3hOK8efYhlmeJNIgRWj8ZyufKoo7zWDe8PqZYOfZhn81NdE+pUoAceSf7nDfW1ruIsY8vP5ng/cii9MBzzAUTtVHer+VWS6Q5gy 0ENo5/1g e0QcPjCXFr0g48RKvjBUoTx/7JBNWjB78WB2Mwsasyuvyynx9vMXVKF1QGjDWO5A1IAKLckpzBGTXxnGZ79AcYV1hiU7lg/2fyR2Rs5ac++A6xBcIob7SjPYWbem8WTuMpWaWb67/WNPXq7vliOL29mvDibFhqj6Oqh99y6E85bXCd7F5GXMltftOYNakJEQFK3Wa1l5dGxBix0sOYFsjWYV5ltWuqp7XUFR5xu6GXe6Ue8S9qYHeHE2x3uCkNeH1CWVvQDEG8Qpy6Yjq1r4gvG7e4T10ou79smaVN0Apthu/0OxwY4jjvOX9kwcq/TujnddLcAwaN+DrKdbNqfgk3Oak+CJcWqvPqDEsUXYmzUudoz55x1eStTuZo8p9rRWAr4G+sOHzgd3a6TzymSoyl6BhkEzqrkXXvvt6/46NIVv1RgGaFUFbOV7kkL4wFTxm/FrUN8OnqQdrOayUUYOyc1b3/x5ObZWIkJ7DOlFmGLp156zVEa85AZlRhA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, May 13, 2025 at 9:47=E2=80=AFAM Zi Yan wrote: > > On 13 May 2025, at 12:41, Juan Yescas wrote: > > > On Tue, May 13, 2025 at 8:08=E2=80=AFAM Zi Yan wrote: > >> > >> On 10 May 2025, at 13:16, kernel test robot wrote: > >> > >>> Hi Juan, > >>> > >>> kernel test robot noticed the following build errors: > >>> > >>> [auto build test ERROR on linus/master] > >>> [also build test ERROR on v6.15-rc5] > >>> [cannot apply to akpm-mm/mm-everything next-20250509] > >>> [If your patch is applied to the wrong git tree, kindly drop us a not= e. > >>> And when submitting patch, we suggest to use '--base' as documented i= n > >>> https://git-scm.com/docs/git-format-patch#_base_tree_information] > >>> > >>> url: https://github.com/intel-lab-lkp/linux/commits/Juan-Yescas/mm= -Add-CONFIG_PAGE_BLOCK_ORDER-to-select-page-block-order/20250510-090501 > >>> base: linus/master > >>> patch link: https://lore.kernel.org/r/20250510010338.3978696-1-jye= scas%40google.com > >>> patch subject: [PATCH v4] mm: Add CONFIG_PAGE_BLOCK_ORDER to select p= age block order > >>> config: powerpc-allmodconfig (https://download.01.org/0day-ci/archive= /20250511/202505110035.wtOWnL8o-lkp@intel.com/config) > >>> compiler: powerpc64-linux-gcc (GCC) 14.2.0 > >>> reproduce (this is a W=3D1 build): (https://download.01.org/0day-ci/a= rchive/20250511/202505110035.wtOWnL8o-lkp@intel.com/reproduce) > >>> > >>> If you fix the issue in a separate patch/commit (i.e. not just a new = version of > >>> the same patch/commit), kindly add following tags > >>> | Reported-by: kernel test robot > >>> | Closes: https://lore.kernel.org/oe-kbuild-all/202505110035.wtOWnL8o= -lkp@intel.com/ > >>> > >>> All errors (new ones prefixed by >>): > >>> > >>> In file included from include/linux/gfp.h:7, > >>> from include/linux/xarray.h:16, > >>> from include/linux/list_lru.h:14, > >>> from include/linux/fs.h:14, > >>> from include/linux/compat.h:17, > >>> from arch/powerpc/kernel/asm-offsets.c:12: > >>>>> include/linux/mmzone.h:53:2: error: #error MAX_PAGE_ORDER must be >= =3D PAGE_BLOCK_ORDER > >>> 53 | #error MAX_PAGE_ORDER must be >=3D PAGE_BLOCK_ORDER > >>> | ^~~~~ > >>> make[3]: *** [scripts/Makefile.build:98: arch/powerpc/kernel/asm-o= ffsets.s] Error 1 > >> > >> In this config, CONFIG_ARCH_FORCE_MAX_ORDER is set to 8, lower than > >> the default PAGE_BLOCK_ORDER value, 10. I wonder if the error should > >> be changed to ignore CONFIG_PAGE_BLOCK_ORDER when MAX_PAGE_ORDER is > >> set by CONFIG_ARCH_FORCE_MAX_ORDER and give a warning instead. > > > > In ARMv8, MAX_PAGE_ORDER is set up by CONFIG_ARCH_FORCE_MAX_ORDER > > and CONFIG_PAGE_BLOCK_ORDER is also set up, so we need to take into acc= ount > > CONFIG_PAGE_BLOCK_ORDER. For other architectures, the default will be: > > CONFIG_ARCH_FORCE_MAX_ORDER =3D CONFIG_PAGE_BLOCK_ORDER. > > It seems that the Kconfig =E2=80=9Crange 1 ARCH_FORCE_MAX_ORDER if ARCH_F= ORCE_MAX_ORDER=E2=80=9D > is not working. The above powerpc-allmodconfig has CONFIG_ARCH_FORCE_MAX_= ORDER > set to 8 and CONFIG_PAGE_BLOCK_ORDER is set to 10, leading to the compila= tion > error. > Right, Kconfig restriction is being ignored by powerpc, however, it is respected by ARMv8. The main difference that I see between arch/arm64/Kconfig and arch/powerpc/Kconfig is that powerpc/Kconfig is using ranges, but not in arm64/Kconfig https://elixir.bootlin.com/linux/v6.14.6/source/arch/arm64/Kconfig#L1637 config ARCH_FORCE_MAX_ORDER int default "13" if ARM64_64K_PAGES default "11" if ARM64_16K_PAGES default "10" https://elixir.bootlin.com/linux/v6.14.6/source/arch/powerpc/Kconfig#L918 config ARCH_FORCE_MAX_ORDER int "Order of maximal physically contiguous allocations" range 7 8 if PPC64 && PPC_64K_PAGES default "8" if PPC64 && PPC_64K_PAGES range 12 12 if PPC64 && !PPC_64K_PAGES default "12" if PPC64 && !PPC_64K_PAGES range 8 10 if PPC32 && PPC_16K_PAGES > > > > Is there any valid case where the MAX_PAGE_ORDER needs to be smaller th= an > > the page block order? > > I am not aware of any. > > > > > Thanks > > Juan > >> > >>> make[3]: Target 'prepare' not remade because of errors. > >>> make[2]: *** [Makefile:1275: prepare0] Error 2 > >>> make[2]: Target 'prepare' not remade because of errors. > >>> make[1]: *** [Makefile:248: __sub-make] Error 2 > >>> make[1]: Target 'prepare' not remade because of errors. > >>> make: *** [Makefile:248: __sub-make] Error 2 > >>> make: Target 'prepare' not remade because of errors. > >>> > >>> > >>> vim +53 include/linux/mmzone.h > >>> > >>> 46 > >>> 47 /* > >>> 48 * The MAX_PAGE_ORDER, which defines the max order of p= ages to be allocated > >>> 49 * by the buddy allocator, has to be larger or equal to= the PAGE_BLOCK_ORDER, > >>> 50 * which defines the order for the number of pages that= can have a migrate type > >>> 51 */ > >>> 52 #if (PAGE_BLOCK_ORDER > MAX_PAGE_ORDER) > >>> > 53 #error MAX_PAGE_ORDER must be >=3D PAGE_BLOCK_ORDER > >>> 54 #endif > >>> 55 > >>> > >>> -- > >>> 0-DAY CI Kernel Test Service > >>> https://github.com/intel/lkp-tests/wiki > >> > >> > >> Best Regards, > >> Yan, Zi > > > Best Regards, > Yan, Zi