From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5071DC3ABC9 for ; Fri, 9 May 2025 20:43:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DD2E96B00F2; Fri, 9 May 2025 16:43:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D81D06B00F3; Fri, 9 May 2025 16:43:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C48856B00F4; Fri, 9 May 2025 16:43:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 9FAFA6B00F2 for ; Fri, 9 May 2025 16:43:47 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id CED8EC0760 for ; Fri, 9 May 2025 20:43:48 +0000 (UTC) X-FDA: 83424545736.01.4711E38 Received: from mail-qt1-f171.google.com (mail-qt1-f171.google.com [209.85.160.171]) by imf01.hostedemail.com (Postfix) with ESMTP id EF6354000A for ; Fri, 9 May 2025 20:43:46 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=CsJnsajd; spf=pass (imf01.hostedemail.com: domain of jyescas@google.com designates 209.85.160.171 as permitted sender) smtp.mailfrom=jyescas@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746823427; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8S9NHraWVhA5CGR8FuQ2evTvmLpkENRuPNxBlSnU8Ag=; b=vLrZAWJaIgWwzKXBC2sdcHRS0T85+r3APNiU2wV1HzmPzaTgdN0M7Ighjg6SZSXAzCo83w yqYIAl2eeV8V6fIL+VMZc+GrtblsJRNpDAp3OGuHwCW6Qeo5D31WQbM6/4Ipr2mBBY4hpP wNzFoX1BWtlMserOViJAhF3xOCxMt/M= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746823427; a=rsa-sha256; cv=none; b=48c62ESfRT6C3hlG4TcutwjDDFVC2RkBAhWnM73sQ00kXdHodvp6bFp3+gOV/F8DbRNiMR FFLxyy38yh2Fl32uNAzXSfzYMAZZIbVpQig+dBMQJutEtLqtJH+1Z/gwniUWmNOjSDla4+ XQPOZiFjht7VYHaIeWTw99cOO67Go1k= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=CsJnsajd; spf=pass (imf01.hostedemail.com: domain of jyescas@google.com designates 209.85.160.171 as permitted sender) smtp.mailfrom=jyescas@google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-qt1-f171.google.com with SMTP id d75a77b69052e-47e9fea29easo28021cf.1 for ; Fri, 09 May 2025 13:43:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1746823426; x=1747428226; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=8S9NHraWVhA5CGR8FuQ2evTvmLpkENRuPNxBlSnU8Ag=; b=CsJnsajdkZauufNTDbcRX8lTZZ6UrVDXgEaX+xxDxLI3zo9aLKHuobKASnFUgWMcdl qU6i/73s8fZZtCXs3MLXMVeqaKNClh/ss2fg20l80iz7k8iZPynvquPMY9yS4jD6l8h9 NaEcKrlSjYtYasJ35pv5pZ4kIACZTsboxTZ7en2JIct2uR98VPA+zNapL3stR/nxDclZ qRy+m6rxWHxFxniqKvizU97arGi3wuYjuo2vyd91r5l1Xzfl+LVVoONeCaXxeH8IR4AG De7X4IT/SA+8eFS0S4zO/2vRhB+oPMEvoiQV7qKTzVUualfVUhTahpuLB96Oii6hU3OJ /p/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746823426; x=1747428226; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8S9NHraWVhA5CGR8FuQ2evTvmLpkENRuPNxBlSnU8Ag=; b=LBClgqSyNFK3TQbMFBFxj+B/MnWU4dllEBmT6UZgpjcfD0N9LgCSmb5jFzY8msGzxW JyFbs4LEj+zWHuS+DOo2aLMNQWJZWBAhIobXvX6JmEFDd1+bdZ/sZbmTWK5EqATpx+yU l8/EweG2NRcJ9FuPRKGAmY7piNYufbyLiZV1j9a/ax92aHJ8Vy86/3YFD7DjBVL+2aw3 204Cqd5CMPVN6yd4IJNoQfDL08q0Y3fUMj1yv28Atc3hDxvMxK18a9f5EtwiJi+fCnQd 8jzDtnHPp4Rw6saChR8Dnn+Qr5jg8kdL53AxqMKHUp1joYxeyOaswVUOsqO5lQbFO73C 3ZrA== X-Forwarded-Encrypted: i=1; AJvYcCVHrfc0zEf3Oq7DzcLch239fMHDmfhtwne16/0XZ7aPHUlLgIQ6sX28PCIC+xOtf3Az4xbpbs14sA==@kvack.org X-Gm-Message-State: AOJu0Yyn4ysjWXVbIQRIynCZMugDjPizBhzFaCYw7hRTUW/9rae6bg/A gG1n1aEHZPmTVK7C13EBSnAZVnEUvguuwk7/+/EaHLcbBi3Dtxu8f+9pgn4SlPjKaRELjVLhEhy i5NobLEGhQJYfiYm8FKOdn15zeqytnnxhA85S X-Gm-Gg: ASbGncuCAUaT6wObDgn/Ws04KzvPEM1/7YjskuLee+aoIGGFTBLJA9Y/awEdky3RQoh XfgjYRZTcRm8pUMIGudG03c8WxZo5V0ASoIVGk/z7R6EuMWpmHi50PN7QLWywOhfkvUAmmJG+hx oa5yrIrUiX0byfXs4IynXUU6+QE4v0Adss6ac0Hvl/NtXBo0frKd6JDg8hZrudbeNPiQ== X-Google-Smtp-Source: AGHT+IGHbLxSdgDiRdqpu5IsKbOwcQeghplROXmb1QUUS125WaJgxyS3JDFVGnT0YPtAbyOXi6XdqTtO8JunNw7kVZU= X-Received: by 2002:a05:622a:142:b0:47b:840:7f5b with SMTP id d75a77b69052e-4946140c4a0mr856271cf.29.1746823425828; Fri, 09 May 2025 13:43:45 -0700 (PDT) MIME-Version: 1.0 References: <202505091548.FuKO4b4v-lkp@intel.com> In-Reply-To: <202505091548.FuKO4b4v-lkp@intel.com> From: Juan Yescas Date: Fri, 9 May 2025 13:43:33 -0700 X-Gm-Features: AX0GCFsZTeKjpGqsZHfpiRvRSlAXTQwTHSA-4izTlST0ai6tD2Yb-XjSBDggkGQ Message-ID: Subject: Re: [akpm-mm:mm-unstable 333/334] include/linux/mmzone.h:1816:8: warning: left shift count is negative To: kernel test robot Cc: oe-kbuild-all@lists.linux.dev, Andrew Morton , Linux Memory Management List Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: wseo86mxxm54wcqxdgts3mnodijtzrbp X-Rspamd-Queue-Id: EF6354000A X-Rspam-User: X-Rspamd-Server: rspam02 X-HE-Tag: 1746823426-103302 X-HE-Meta: U2FsdGVkX1+pljTRQSA0ARRoR4xTSqvEKq+20KERlkV24ML6tGMpXImqCakg7ziErBKqGV0nFo4I9jVmNC+T+wrf4rnnlhjFIJqgHvRGu2Hoe8nq5nQov7PANUzbcShI979YKRmWkvRocON4UwFuubjIK4IEX3cd+MYscbq1EBFfa4a0y1/GDR2mZCI+HOdIjeOdZgW1yNiBs3sKsHfX6Wqj5NXGeZDEwxJQtg/HhQE0Z47lyDyuCGknMINZpmK4u9MHQN7M05X1c+/gWdj+9HI4SCOWmIft0zY2DuoUBhrIn/6rBaAB0HHpr3vW/TDnzcsxBIHWCY/gSzP17y2D30xApFxZFryhqpqfxMbHskI7/RGcyHRbWGBX0bTBl9vLIhHRv1fhmrzmzBdTLgMBmjl2WP0MRhHRTTCcHx6Zm8F5iHrb3wDflK1hBqRHn0yEae5QjYb9+ewmG57ONYxChYs4yD3tRiE7S0Epn+IG/4MOiTzhtg7zvquriNcAf1q4C3JnUOscwvLGNCGGsYzmJBf44hN0gRDYNZwTLTmufHhxyYDPZ7iHwBNO95B9XJZY7UcT/50fCaTRnhX2y5okBle03XMfUnpgh+aGDDoP7xHTQmoflW6XAxkdEbbFn01sgaxrPJL8GerJe/fEWttL6sGsdwOJjNZgT5/l/vRisoz7OO3gcov2quGGEYNdeBBTT7qMueInNQAXxyMS+TEBVyhwr9uYlyu2c7FHMJE9pYh8hME6B3uUHTHGcR48jCbJ2GNL6WQ9N5xEp0NOLl/3NACA0lQ5y5fEbYZmPuYJCL+EurBs+xvVDPOvrUH+GbxDJQrLZ38FB821BvZR3TgDpevYzIb61PeESCNQgObxGQLPEk19VJg0OZOLv7e/fsjA/iQATJ2ZuNEgR4G2MN4zWKjUB9C5PVczQ/uS35YMzTKTNIAfmL9nwXeFp42C//Ob0bveeSfrecs4oaNpQ1n kv2pmvI0 vSaksfOs5DuHOO7njH+WIAYekaQZiEm7viRpEjcR9Inxrdy+PKZzuBtgz5T782Beym/8W+Y1J+7SJ13w2/DWT/DP4DZv9r9tRv8P0mHVcpGYxTL9wkbFYTFBcCQXPyICncwqWMU8Agn3f6Qtjjwkl41xCjO9yRsnPQ/r2+BDTfpJrjIEmtxxhYf6ft9CeE3KRgmuZJChHXW/K3m/WvaCSwMEVa/EJG4bvpIlBnptlTEK0SiyTJwehjdG4aylca84C3RwhfEty6j5M1DjIgGztaDO1ZFpYdUCgEmsjr1kTxBHkp7wtFHR00kZXFGq1rX4OF141MumlEP5LCtVdMCTpiZAdjfWYpi1pbMaQbKCW3T0Xxg4bIP0k53fYKWe7YDOcWS+9 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, May 9, 2025 at 12:49=E2=80=AFAM kernel test robot w= rote: > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-un= stable > head: 930c125f685d7e8eef566fcd563390b76a28d824 > commit: 16994f2b09a22523885d371caa59f17999686805 [333/334] mm: add CONFIG= _PAGE_BLOCK_ORDER to select page block order > config: powerpc64-randconfig-003-20250509 (https://download.01.org/0day-c= i/archive/20250509/202505091548.FuKO4b4v-lkp@intel.com/config) > compiler: powerpc64-linux-gcc (GCC) 10.5.0 > reproduce (this is a W=3D1 build): (https://download.01.org/0day-ci/archi= ve/20250509/202505091548.FuKO4b4v-lkp@intel.com/reproduce) > > If you fix the issue in a separate patch/commit (i.e. not just a new vers= ion of > the same patch/commit), kindly add following tags > | Reported-by: kernel test robot > | Closes: https://lore.kernel.org/oe-kbuild-all/202505091548.FuKO4b4v-lkp= @intel.com/ > > All warnings (new ones prefixed by >>): > > In file included from include/vdso/const.h:5, > from include/linux/const.h:4, > from include/linux/bits.h:5, > from include/linux/ratelimit_types.h:5, > from include/linux/printk.h:9, > from include/asm-generic/bug.h:22, > from arch/powerpc/include/asm/bug.h:116, > from include/linux/bug.h:5, > from include/linux/mmdebug.h:5, > from include/linux/mm.h:6, > from mm/sparse.c:5: > mm/sparse.c: In function 'usemap_size': > >> include/linux/mmzone.h:1816:8: warning: left shift count is negative [= -Wshift-count-negative] > 1816 | ((1UL << (PFN_SECTION_SHIFT - pageblock_order)) * NR_PAGEBLOC= K_BITS) > | ^~ > include/uapi/linux/const.h:51:40: note: in definition of macro '__KERN= EL_DIV_ROUND_UP' > 51 | #define __KERNEL_DIV_ROUND_UP(n, d) (((n) + (d) - 1) / (d)) > | ^ > mm/sparse.c:301:9: note: in expansion of macro 'BITS_TO_LONGS' > 301 | return BITS_TO_LONGS(SECTION_BLOCKFLAGS_BITS) * sizeof(unsign= ed long); > | ^~~~~~~~~~~~~ > mm/sparse.c:301:23: note: in expansion of macro 'SECTION_BLOCKFLAGS_BI= TS' > 301 | return BITS_TO_LONGS(SECTION_BLOCKFLAGS_BITS) * sizeof(unsign= ed long); > | ^~~~~~~~~~~~~~~~~~~~~~~ > > > vim +1816 include/linux/mmzone.h > > d41dee369bff3b Andy Whitcroft 2005-06-23 1814 > 835c134ec4dd75 Mel Gorman 2007-10-16 1815 #define SECTION_BLOCKFLAG= S_BITS \ > d9c2340052278d Mel Gorman 2007-10-16 @1816 ((1UL << (PFN_SEC= TION_SHIFT - pageblock_order)) * NR_PAGEBLOCK_BITS) > 835c134ec4dd75 Mel Gorman 2007-10-16 1817 > Thanks for testing, The reason for the warning is because CONFIG_PAGE_BLOCK_ORDER > CONFIG_ARCH_FORCE_MAX_ORDER. This config: powerpc64-randconfig-003-20250509 (https://download.01.org/0day-ci/archive/20250509/202505091548.FuKO4b4v-lkp= @intel.com/config) is not respecting the range config below. Should the test make sure that the ranges are valid? config PAGE_BLOCK_ORDER int "Page Block Order" range 1 10 if !ARCH_FORCE_MAX_ORDER default 10 if !ARCH_FORCE_MAX_ORDER range 1 ARCH_FORCE_MAX_ORDER if ARCH_FORCE_MAX_ORDER default ARCH_FORCE_MAX_ORDER if ARCH_FORCE_MAX_ORDER I can add a check in include/linux/pageblock-flags.h /* * The PAGE_BLOCK_ORDER, which defines the order for the number of pages * that can have a migrate type, must be less or equal to the MAX_PAGE_ORDE= R, * which defines the max order of pages to be allocated by the buddy alloca= tor. */ BUILD_BUG_ON_MSG(PAGE_BLOCK_ORDER > MAX_PAGE_ORDER, "MAX_PAGE_ORDER must be >=3D PAGE_BLOCK_ORDER"); Is there any preference? > :::::: The code at line 1816 was first introduced by commit > :::::: d9c2340052278d8eb2ffb16b0484f8f794def4de Do not depend on MAX_ORDE= R when grouping pages by mobility > > :::::: TO: Mel Gorman > :::::: CC: Linus Torvalds > > -- > 0-DAY CI Kernel Test Service > https://github.com/intel/lkp-tests/wiki