From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E02A9C4345F for ; Sat, 27 Apr 2024 00:54:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 763706B009A; Fri, 26 Apr 2024 20:54:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6ECF66B009C; Fri, 26 Apr 2024 20:54:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 567756B00A0; Fri, 26 Apr 2024 20:54:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 385336B009A for ; Fri, 26 Apr 2024 20:54:09 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id E1E97A1D9A for ; Sat, 27 Apr 2024 00:54:08 +0000 (UTC) X-FDA: 82053490176.29.5B09773 Received: from mail-lf1-f43.google.com (mail-lf1-f43.google.com [209.85.167.43]) by imf13.hostedemail.com (Postfix) with ESMTP id 1565E20004 for ; Sat, 27 Apr 2024 00:54:06 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=km0lHMa8; spf=pass (imf13.hostedemail.com: domain of yosryahmed@google.com designates 209.85.167.43 as permitted sender) smtp.mailfrom=yosryahmed@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714179247; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+CEIqz3rmh2iubHOxS8JkJvUfvEGVm+LnxGZutLpHYk=; b=3W2bN9DJpYLaVAirbPKVbYEpBBNhsGIArD/qRhnhYAAdl82urpOlYFVlxyGRTMpweXibiZ ih3+Aa0PQ/xKi0f0EyqzsvGqYISw50qLeP3NBRNU3+S59kmTc1ndLFJc/JjNnMMczlL8Vh o2V9MsGItRxilLzVWKoEkCZ3JnNd9VU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714179247; a=rsa-sha256; cv=none; b=rqvguJzHf3rXHPkb9cqnE4odjkApkQnbQ3KDqFsZB9ViemDwoSwOpE99+a3yTCCzCXeJvZ vQaOHx3WhUTbcmdStLib7AXezREBUz+a2xJBYviVIRrQSC6fqRMC1MxlhhFcU7u/2amTUH RRwZ5bFjv/ApUOF9u7Y/xZQm446pV/U= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=km0lHMa8; spf=pass (imf13.hostedemail.com: domain of yosryahmed@google.com designates 209.85.167.43 as permitted sender) smtp.mailfrom=yosryahmed@google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-lf1-f43.google.com with SMTP id 2adb3069b0e04-51abd9fcbf6so4649574e87.1 for ; Fri, 26 Apr 2024 17:54:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1714179245; x=1714784045; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=+CEIqz3rmh2iubHOxS8JkJvUfvEGVm+LnxGZutLpHYk=; b=km0lHMa8j88qaheAtiMLT8GIvZdUN960+LcZN/m3RYNxs1n2LwJ1KHwfTryvEkllV3 JUmNtSI9oh2Y+Hif5b1E3UTvp6yhNvi17hCF5qHpDFBZYyTnGWCim8WUhce6IFJ4AqYK kKC0P1woCsnZpejGwtPhRM96GPycy4Qxx3k8HdlPc3qDt7dGt29cO/LU5MrDi84SJCsv 5CRZhaRzUlAnoV8rW57lnWmqmCyKpWJzTG3pFJx9C55w0yKa5yPZwqb0X43iNeu9rpxB /5ctecrufKuCYNhht44WW4NdtYTZkR2cg9H/cSBDI3Y+/CyRCdDbZmSBAhrT4HMXkuPY kn1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714179245; x=1714784045; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+CEIqz3rmh2iubHOxS8JkJvUfvEGVm+LnxGZutLpHYk=; b=t8/c8Dvd931X/grnKP3ot+yhx3+utGtVSk3HiSn9TGK1os2LSDRa0ALxqRnlAEocq1 RKT1dI9Wtxdy7+ZM69C3EZoO27r5iEu+JfjWD2iulKpnb4O3Ns0tGKpZ1qxcnvpDqw8a /6Ise/tTIAd1V1XMIcVmWGUg3Z6luk0boFySoXgC8GsdrvsYmUO7XQ2yJF1Z4Zzp3657 hiHDGpxG4b1aaFnB4hWglcPgFjb+scWCHlocyAt5/LCqXchS5f21qYB9snu0+0hRhGFb sIpeDqahHk1VBqeMatPoMlAeUK//vFHOKwmLjUaO3jK1eN4jz0t0z4ZNdKxbiQMOEJRu 6cwQ== X-Forwarded-Encrypted: i=1; AJvYcCUPf2C3BE69lg3n/Gg/7HjP8JhoETu5BVH/6ERN0fRWl3/fqzeuUWA0m9HB7hPgjXP/pO6JGN0HCHl6lOX8wDTU4wY= X-Gm-Message-State: AOJu0YyZw8N+NgcG+5LXqFzYoocFlJhnn1ZOBTrE/gOuQwiW4LI7XcMs 2OSbvvky+9DntsD8fjahI8zIlayxeeMR3kdS0qugVN34AE0emwnoDNVmd6TKSNXjcBOp08OtfT8 Go93pEOX9NoTfAJipdFfS5c3/80MH/kQTgsx4 X-Google-Smtp-Source: AGHT+IH33jn2znwyrxRHKKv4ph3YkibD90xJSbJ3dZFe7grEgK0acZVtb0LBNdCXJts6dyeDEayeKUfZVGdmUnCBcB4= X-Received: by 2002:a19:8c1a:0:b0:51b:e707:74dd with SMTP id o26-20020a198c1a000000b0051be70774ddmr3117973lfd.33.1714179244845; Fri, 26 Apr 2024 17:54:04 -0700 (PDT) MIME-Version: 1.0 References: <20240427003733.3898961-1-shakeel.butt@linux.dev> <20240427003733.3898961-5-shakeel.butt@linux.dev> In-Reply-To: <20240427003733.3898961-5-shakeel.butt@linux.dev> From: Yosry Ahmed Date: Fri, 26 Apr 2024 17:53:28 -0700 Message-ID: Subject: Re: [PATCH v2 4/7] memcg: cleanup __mod_memcg_lruvec_state To: Shakeel Butt Cc: Andrew Morton , Johannes Weiner , Michal Hocko , Roman Gushchin , Muchun Song , linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Stat-Signature: iips5krsq996eozgwong7w9796c4wjgd X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 1565E20004 X-HE-Tag: 1714179246-463603 X-HE-Meta: U2FsdGVkX1+YlCKD1iPILw/NNyulE+Ch0j40wVnlKoalft6HE/HGOv2UuGARFfymw2gArF+fi2kq0SXMgPVuM9JXKmJzPXTzVM5Njc9AokCq3E40SfI9TUDqefAssgl0h4fMxb1cvhkeSDi22mCVylXutmgjwZ6hUKu/yA5Ze2DjWqC74k0/uWOY1nwOF4221gq9V/Xp/jNEDIEAV5s0JkRouOlu4RqFK7uqFDKx50hv6w4R2fT9ywifU+fsETYlK2tfmP+NK6iUnWQCk0o2f1TAZ/s5eUsHWVDXtE+mtL9v/fQhjOP4ggDmdQUi3m76+NfGTY6n8j1FoTX/6Hrb1q2qQIOcbS3RD9oPPSdnvgZvOjjiCRRpRMMMOeBlN2xJiRK/2g/uBYhnNogW/o1gObhfA74MNjo7EX3YLc8pVOaAvA/EBxClNZh4n+o7o3YeVxTbVWYTWj+kzthPp5HOoiOANFdWLnzgVphhDTP2DGs3dr4MyMVNyPbxy/1lyfsMB/c5ptllQwOE1J2Rie1unEjcZo9CvB0yh6qtKXa0pd5BdzH92F5d3YoJfTzP11KGKZLsr+6mUeTNEuppUq6YSIApcnrGjtBNF2095m/aMwBN0HnlBnOUlhmf8KwrcxdXcLNNVF+kEG1Y1mX/gBLAd9mhsVnmtgPXLGdXiKkM4eUrqqxCnSokixCSZXkBTdI/d+ddGkXJvdNP7nSbCCZHPuYEXhFWNbNRHAqbgMQPlDYkRaRCWn70mW6b2ACi3K7klxMGPX/vxwrTbHOJBsP6RAiG5qbY9Tt7eiMy7WKDndmmSyahnBBXZ31VOqT6RhTe42qK9zcuBlhxcLajOt64Qj7/mIYL2PuBWdanLHu0iZ4+T6G9AO3ACEDB/lV+7m8gplyajlov5326TH3J0+sTWycLiXeMzCtxTJtp3A4OAGXBL7bTm+G3V/Anp4Lqs6rzoMuFMbPQPaFdHtdlmsb E13P7AxJ yWrPVkJln0R75YsIw9y8ificPbkNE2hPy0w2iO1kJ5CSlRSAH0hyrrUxf9cxXpT4IR/coWqlaUswFwzLUIjq26Y1OeqpsNNZA6qxnG2G7W7v11qKJIY/RYV6P7fUXkMUKUWgmTc0PZSIoVj6g0GnYtV0bQdrkklZmM5f0a8Cbq0tSrwXnNHiry6kHP3VpQJbiwAhe8X4DHWKQU1wc6kOe1W+EK4HmjMKYmn8ZFVt3ZlLIpeoLo8yvHf89lKfIzmfXvp4y2nEugCySKaQ+B0LmJaYQEJNZr+Kzvec6 X-Bogosity: Ham, tests=bogofilter, spamicity=0.002153, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Apr 26, 2024 at 5:38=E2=80=AFPM Shakeel Butt wrote: > > There are no memcg specific stats for NR_SHMEM_PMDMAPPED and > NR_FILE_PMDMAPPED. Let's remove them. > > Signed-off-by: Shakeel Butt Reviewed-by: Yosry Ahmed > --- > mm/memcontrol.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index c164bc9b8ed6..103e0e53e20a 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -1009,8 +1009,6 @@ static void __mod_memcg_lruvec_state(struct lruvec = *lruvec, > case NR_ANON_MAPPED: > case NR_FILE_MAPPED: > case NR_ANON_THPS: > - case NR_SHMEM_PMDMAPPED: > - case NR_FILE_PMDMAPPED: > if (WARN_ON_ONCE(!in_task())) > pr_warn("stat item index: %d\n", idx); > break; > -- > 2.43.0 > >