From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC9F5C83F2F for ; Thu, 31 Aug 2023 16:40:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 556948D0016; Thu, 31 Aug 2023 12:40:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4DF618D0001; Thu, 31 Aug 2023 12:40:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 381A78D0016; Thu, 31 Aug 2023 12:40:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 25CF88D0001 for ; Thu, 31 Aug 2023 12:40:47 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id E49E61A0378 for ; Thu, 31 Aug 2023 16:40:46 +0000 (UTC) X-FDA: 81184963692.22.52BD7AF Received: from mail-ej1-f50.google.com (mail-ej1-f50.google.com [209.85.218.50]) by imf07.hostedemail.com (Postfix) with ESMTP id 987E140024 for ; Thu, 31 Aug 2023 16:40:44 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=A5uxzxgK; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf07.hostedemail.com: domain of yosryahmed@google.com designates 209.85.218.50 as permitted sender) smtp.mailfrom=yosryahmed@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1693500044; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=drcv5mKJ9RhO4L7vLkvVuevPSBYeBJBAmcU4Oua4F00=; b=tM+IsprYwXnTnj5ST3HJpaDh1BzIlA+RjLcr0lGeuMYomVJt225PFdFDCYiVhX4rG5d06g zti3HKBhH0qyJn8dfYU+PqzsTr3VWEYVFyr61xhc7MqWW3YfBW3OSH3I0NN9EWbKDg92xp jfY750dDWTzKr+4DqSmXsgNC//5vJbg= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=A5uxzxgK; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf07.hostedemail.com: domain of yosryahmed@google.com designates 209.85.218.50 as permitted sender) smtp.mailfrom=yosryahmed@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1693500044; a=rsa-sha256; cv=none; b=A8QipMUDAz4rIhqCslAkpTNA2WACN+/was0OIF09/4NkEhErUrWmVNqQRyo7WT+a9tsbsE 3v1hqBwS24kjITnAu9k87v+mHo1pwIptZ0qTI35fAktN/yE+xYh66Z007iUAi4PioS0VqG 4Qj+BXmFTx0QmnO2lZarYjAgNcO4BjA= Received: by mail-ej1-f50.google.com with SMTP id a640c23a62f3a-99c1d03e124so113217866b.2 for ; Thu, 31 Aug 2023 09:40:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1693500043; x=1694104843; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=drcv5mKJ9RhO4L7vLkvVuevPSBYeBJBAmcU4Oua4F00=; b=A5uxzxgKF8ZFJ8mb+H+QkFdnLYTwVPBJuwlZk4qg65z/eqvos8un+Xi/RXRhdNIJAs xccAHb/NmMFYKcojL9qyRLzrkSqHWOFbCMmKg9/8/JThtBioHX1XzVkRKOe6A8kXREyw I0kmVhh71vRgEqVHsLcSGJKaKPJFF+kHuoNoG9VgwbntCysXYziloQLyoFetIQQFkctb 6reGlYMMamX6NPGj1QErk9rAOPRWB+VaFAAAcn6/NVKXGNwCxsy3+3PDXAuQtzp656M4 x0UBLaPhEV2C6UtniaVuBWHuOo7x5IjXco/NkudljLdEjg9O+cEyROaCA+Tsta3D66pu 45wg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693500043; x=1694104843; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=drcv5mKJ9RhO4L7vLkvVuevPSBYeBJBAmcU4Oua4F00=; b=cLl/M6iHiqS1heFD5RoJFBfMfRRpOkjNkeGoauoJifmWd8n+PwOnlqfL+Fq2oI0ejX QhciqAnAJl3hEeNiNTMvqcdmWaKwCJZIJ9xo9ynLRoLNZ2jBN5pLiu3cdZfb6TtqHbU/ lbgybzIQ2Zq+0Umo7EfRoO9wlMKc2vBj+X1jfuo+xLs8042NP/N74hkwLOLEtm5IDfC/ Z4sHSVoYChZ8CKo1Kqm5/MhR/bJYNRjBjoLHXZV+rd09ulipujJAQFUPHnzm/x3wprnG ksjkMl+jSO62OFZoWEo5ezw+gT15PvsY0CJRv/FE4wvhX2pgY64CE6neMG62Pl8rVWM6 jC7w== X-Gm-Message-State: AOJu0YxHmGadLWKjrBCvhS3UKNjEHBl1ZbjJ9w/OuBLBo1+cjqv9Vhjl Qwq2MdI/MaEN9Ir/43VMG0Taax3G1sPOlmEu4LqoqQ== X-Google-Smtp-Source: AGHT+IGV24LZs9Ao9Nl3shUgQtSezVqin+bodeBsASR3yYN0F0gmiEmn2HA+jI3wOLaoklU27jzdjhbQxQ19eonVUNw= X-Received: by 2002:a17:906:8450:b0:9a1:db2e:9dbb with SMTP id e16-20020a170906845000b009a1db2e9dbbmr4355097ejy.0.1693500042855; Thu, 31 Aug 2023 09:40:42 -0700 (PDT) MIME-Version: 1.0 References: <20230830175335.1536008-5-yosryahmed@google.com> <202308311025.538QuXBV-lkp@intel.com> In-Reply-To: <202308311025.538QuXBV-lkp@intel.com> From: Yosry Ahmed Date: Thu, 31 Aug 2023 09:40:03 -0700 Message-ID: Subject: Re: [PATCH v3 4/4] mm: memcg: use non-unified stats flushing for userspace reads To: kernel test robot Cc: Andrew Morton , llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, Linux Memory Management List , Johannes Weiner , Michal Hocko , Roman Gushchin , Shakeel Butt , Muchun Song , Ivan Babrou , Tejun Heo , =?UTF-8?Q?Michal_Koutn=C3=BD?= , Waiman Long , cgroups@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 987E140024 X-Stat-Signature: fwzwcoeztmf6fhcpn45wemjouafrfw6b X-Rspam-User: X-HE-Tag: 1693500044-672631 X-HE-Meta: U2FsdGVkX19+M0bNifoUZzBT3XBydWENsaLh/9iKiy/or4tPYwl1sqzdRxCg7ZpctJ190orz8MEL7PozrlXH06lPhlaOuCXQ24oIib+fiZdyDgcXsWB+evRPpxe1YOnLdrY+Te8Y6O0bvyce/5Yh/7YFTMR8f3AnY0sKt0YzT+wWF+YF05UIO5F5UvggtNRrkGYL8e+OAfDQWUpChVFp+cj63sVBPIewq8tGSVPtxg4jFIeAGMzVgOZIuZz3YfJUIB28YK07wBGstEPkjKpIlbdkWQKx6tddzsbunbwZ4ScRS1ea8j/zg+V1QWtmBFy15ZtjtebjnDx7RzWp9nn7tP9QWJhrQRg3VN3vxEpgryEpbH9sDdI2XRxW8qW1/N5a3eMFcZnVIDKryFJ4hdJjwCqTi6boEGLqyvFNSX4uWklm4xSyKKHhE6YchBdQ3BfuJJtdNbVst+wmjPz+Klz7YDyrzUmj5LNOC+24vD2NqunRdt4/q9nXwuXqS4PTRndb90bFipBWsYC7eb2zNCkGzH26wNzffDOuEdogOFzxoat1wmVynPtRopGi3pTH7izYo+w0Kn3NkSz9E4wQlbYYVAIl1nPAM3ScOCrk00ueIlIWIJJot4egLKl+/uEyuXHS+y9vMoJQ4aSTouzpEY77UCcAyAum4g5btRXgNQGl+Y9fDmCRce7mhDXVqhta6qdTHoxHfLiC9GQiEmUvjIrej8XiSjf0E+PibmqPpzctO0PepIyKTwa6if8Kf6slTLZ1ggz/55bCI54wvl0+ZKM/ds9OXqnvakpYH3s8edp3p7tGi3VHUdtGWBbozhxBbVVSYGsfEbASmzqncAwH9n90YK7tJQbITshRomI7AH7sTXvlvSqG+ib6zS8mQCeRoG3YEO2E4r73oIH9kNUYCx0gYMLYcWEQsfSJHbZfuytxkoQyIOrPKh4dEPGH0q45tDtdIGimAzOvZI7DiyaR70L XznXyecN NeKdqN1XlvD+O0tEzxP8aN0tEav328Bup+5sliFkMlcUzGPV1u7YIVgvffZO+SWauekg1ODrjZzrOyAf3yAbI/+tmDilaM0ta+GzXdrIa+9IZyphhtq9OCF+9lF7qmUjykMXGH3MCD4bl8h/6MHq3Z8q0BmxA/KID2I9rHPEbbAw3hGZCLbBo/vlKsNgE1pe88BCgcq4kP5pAWMU8m8XAZRURQQYyw1n9RSVOsNJzcga+HXKhHzuPNwUhwQcRV9PDQj4Ua2p1tBOQZunMvSgNoiGxk+SgsmxPoJ0Ke5aEMrrY/Pf6+3mTLX/iGaDG6uuTtPCKbYADnmMaEsbpM9PzxRRaL2s0lfbGRL6Jd9fg5qABTp+iry9y+SxVfdrvV3ByAz5T1Lg6kv5U7Ga7uNCi1OjemfsLSsLYwy0QMPTbsinpLwyl3+Cq8gr1mGKVoqOPBDQvzOIOj7qQlYPpkfMbptWVgWna2v4uzcgV X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Aug 30, 2023 at 8:08=E2=80=AFPM kernel test robot w= rote: > > Hi Yosry, > > kernel test robot noticed the following build warnings: > > [auto build test WARNING on akpm-mm/mm-everything] > [also build test WARNING on linus/master next-20230830] > [cannot apply to v6.5] > [If your patch is applied to the wrong git tree, kindly drop us a note. > And when submitting patch, we suggest to use '--base' as documented in > https://git-scm.com/docs/git-format-patch#_base_tree_information] > > url: https://github.com/intel-lab-lkp/linux/commits/Yosry-Ahmed/mm-mem= cg-properly-name-and-document-unified-stats-flushing/20230831-015518 > base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-ev= erything > patch link: https://lore.kernel.org/r/20230830175335.1536008-5-yosryah= med%40google.com > patch subject: [PATCH v3 4/4] mm: memcg: use non-unified stats flushing f= or userspace reads > config: i386-randconfig-r013-20230831 (https://download.01.org/0day-ci/ar= chive/20230831/202308311025.538QuXBV-lkp@intel.com/config) > compiler: clang version 16.0.4 (https://github.com/llvm/llvm-project.git = ae42196bc493ffe877a7e3dff8be32035dea4d07) > reproduce (this is a W=3D1 build): (https://download.01.org/0day-ci/archi= ve/20230831/202308311025.538QuXBV-lkp@intel.com/reproduce) > > If you fix the issue in a separate patch/commit (i.e. not just a new vers= ion of > the same patch/commit), kindly add following tags > | Reported-by: kernel test robot > | Closes: https://lore.kernel.org/oe-kbuild-all/202308311025.538QuXBV-lkp= @intel.com/ > > All warnings (new ones prefixed by >>): > > >> mm/memcontrol.c:667:6: warning: no previous prototype for function 'me= m_cgroup_user_flush_stats' [-Wmissing-prototypes] > void mem_cgroup_user_flush_stats(struct mem_cgroup *memcg) > ^ > mm/memcontrol.c:667:1: note: declare 'static' if the function is not i= ntended to be used outside of this translation unit > void mem_cgroup_user_flush_stats(struct mem_cgroup *memcg) > ^ > static > 1 warning generated. Ah silly mistake on my end. Will send v4 after making mem_cgroup_user_flush_stats() static. > > > vim +/mem_cgroup_user_flush_stats +667 mm/memcontrol.c > > 658 > 659 /* > 660 * mem_cgroup_user_flush_stats - do a stats flush for a user read > 661 * @memcg: memory cgroup to flush > 662 * > 663 * Flush the subtree of @memcg. A mutex is used for userspace rea= ders to gate > 664 * the global rstat spinlock. This protects in-kernel flushers fr= om userspace > 665 * readers hogging the lock. > 666 */ > > 667 void mem_cgroup_user_flush_stats(struct mem_cgroup *memcg) > 668 { > 669 mutex_lock(&stats_user_flush_mutex); > 670 do_stats_flush(memcg); > 671 mutex_unlock(&stats_user_flush_mutex); > 672 } > 673 > > -- > 0-DAY CI Kernel Test Service > https://github.com/intel/lkp-tests/wiki