From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51D24C00140 for ; Wed, 24 Aug 2022 17:26:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A9B0E940008; Wed, 24 Aug 2022 13:26:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A4A77940007; Wed, 24 Aug 2022 13:26:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 938D8940008; Wed, 24 Aug 2022 13:26:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 84E2E940007 for ; Wed, 24 Aug 2022 13:26:22 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 5E403AC280 for ; Wed, 24 Aug 2022 17:26:22 +0000 (UTC) X-FDA: 79835165004.21.CD89C38 Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) by imf17.hostedemail.com (Postfix) with ESMTP id 070AA40019 for ; Wed, 24 Aug 2022 17:26:21 +0000 (UTC) Received: by mail-wr1-f44.google.com with SMTP id u5so13807319wrt.11 for ; Wed, 24 Aug 2022 10:26:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=PyL5R0h/l4gJt239ptqG1oF6MWjvvRhnBKs2TUqoy18=; b=jQo8Hnb2GH3hf1ONG3xswu3V43RapwZZQv/uLqocxPR835oyqTUFMASIxiUoHL6XPp EbyicGfCO/sXpp4HRUcZkK6eb5S/FJk3LCRWifleT2kwRNWUQdb3Pycb7gz+LLxmY/R5 cAwAKSjcgIGBXG8vtmnslPBHLQtM2g3cCibWehD2SbdsVHqGT2G9+BKT5dnCmoA5yLS/ NVGYZip8bdVm+/+hyVO7QlJ3mzWEUYz9x/mwMcK90WZe3i29zVqh6PZXN9gfUwGFhwoX BqhSoPB12QVEr5eJwWyR6ofuIoW/nLes2Q//tqKQFwWjS9S5Pc7b3jtbxpG9zRwoyvst uW2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=PyL5R0h/l4gJt239ptqG1oF6MWjvvRhnBKs2TUqoy18=; b=TtcUfwzCBWbWX9hUPhPouSOVAonk6vPuQZFZh4WbNIwOC95Ol8u+CmM4hetzbUB2r/ MdVyQL2pZ89jKaHC+fwf6rotwurTHMSioF9uk2hG+fP1A865tioL0iCbZnm5DZ5CdcBf F1C76Pn19TPkRhE0gacTyafGG6+DhTCLkSF46V4PL3BbhJIKGt+9dCQE0MNeWaqhDRre mpMww1qYouMI+Vn8C0QioiOmjJW/GSDEw1aE2BgQM1QWXa7Jv+bmXOQnjw09uosXp8fb l9HlWCJYVzLAyrT0umqBleUUJdSPnglO0K453Ct476uc3HsPTfwPDk/mdrujLdGGpsFR RCBg== X-Gm-Message-State: ACgBeo3HOtX/PglZ7YMjXJavbMg+roZ0VAKpBb5W9KPvS7NuGILMoFYE fN8MKlfcn1CVB/nO643rwoMgWCxs5OxGfsWEONf9VA== X-Google-Smtp-Source: AA6agR7iXw73BTfjDZ8jZn+Fm8FhmEI+9YASQfOV4iSJ8ZIWQgBMY6R5SVjUTupDZtCPK8fsP9gfgnCHrt3adgZF1rc= X-Received: by 2002:adf:9ccf:0:b0:225:4934:53e3 with SMTP id h15-20020adf9ccf000000b00225493453e3mr158800wre.210.1661361980453; Wed, 24 Aug 2022 10:26:20 -0700 (PDT) MIME-Version: 1.0 References: <20220823004639.2387269-1-yosryahmed@google.com> <20220823004639.2387269-2-yosryahmed@google.com> <5ac13c91-0e42-533b-42d0-c78573c7aef3@arm.com> In-Reply-To: <5ac13c91-0e42-533b-42d0-c78573c7aef3@arm.com> From: Yosry Ahmed Date: Wed, 24 Aug 2022 10:25:43 -0700 Message-ID: Subject: Re: [PATCH v7 1/4] mm: add NR_SECONDARY_PAGETABLE to count secondary page table uses. To: Ryan Roberts Cc: Tejun Heo , Johannes Weiner , Zefan Li , Marc Zyngier , James Morse , Alexandru Elisei , Suzuki K Poulose , Paolo Bonzini , Sean Christopherson , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Andrew Morton , Michal Hocko , Roman Gushchin , Shakeel Butt , Oliver Upton , kvm@vger.kernel.org, Linux Kernel Mailing List , Huang@google.com, Shaoqin , Linux-MM , Cgroups , kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org, nd@arm.com Content-Type: text/plain; charset="UTF-8" ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=jQo8Hnb2; spf=pass (imf17.hostedemail.com: domain of yosryahmed@google.com designates 209.85.221.44 as permitted sender) smtp.mailfrom=yosryahmed@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1661361982; a=rsa-sha256; cv=none; b=J3G+lDjnQ/s/E9GJ3treE8B2Hi2h1hSV45NAMR1mj5Qso4B3Pi/xJtrTGh6s6sXqhFNY9P p4hOcrZuEFJwCZYw1MdwP8iYGRYki5riveeI5jb5Ehd0ffSTIfwjJGKBEagu7d5gO623J6 NAz7cW94AJiohpQTTrS4h90gvWf45+Y= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1661361982; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=PyL5R0h/l4gJt239ptqG1oF6MWjvvRhnBKs2TUqoy18=; b=iSUXeAHuyhrxTF+97EArgSktWUWyClNfDyOSP9GjFNy4WPUYxDu7a6xIW5yj07enTIJ4mA Y+ZPoOQP4DUQil5KcpSqezfmnR4zs/m58/gQe0UUFrUyysbCSndeET6NgYsO2X2frRCTxW tHTRgqXIqq0PrLE80X+5PJSOCuBFWKg= Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=jQo8Hnb2; spf=pass (imf17.hostedemail.com: domain of yosryahmed@google.com designates 209.85.221.44 as permitted sender) smtp.mailfrom=yosryahmed@google.com; dmarc=pass (policy=reject) header.from=google.com X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 070AA40019 X-Stat-Signature: a46ypt19p3qcf6hkqy9ferrmeo4oojqh X-HE-Tag: 1661361981-230732 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Aug 24, 2022 at 6:42 AM Ryan Roberts wrote: > > > diff --git a/Documentation/filesystems/proc.rst b/Documentation/filesystems/proc.rst > > index e7aafc82be99..898c99eae8e4 100644 > > --- a/Documentation/filesystems/proc.rst > > +++ b/Documentation/filesystems/proc.rst > > @@ -982,6 +982,7 @@ Example output. You may not have all of these fields. > > SUnreclaim: 142336 kB > > KernelStack: 11168 kB > > PageTables: 20540 kB > > + SecPageTables: 0 kB > > NFS_Unstable: 0 kB > > Bounce: 0 kB > > WritebackTmp: 0 kB > > @@ -1090,6 +1091,9 @@ KernelStack > > Memory consumed by the kernel stacks of all tasks > > PageTables > > Memory consumed by userspace page tables > > +SecPageTables > > + Memory consumed by secondary page tables, this currently > > + currently includes KVM mmu allocations on x86 and arm64. > > nit: I think you have a typo here: "currently currently". Sorry I missed this, thanks for catching it. The below diff fixes it (let me know if I need to send v8 for this, hopefully not). diff --git a/Documentation/filesystems/proc.rst b/Documentation/filesystems/proc.rst index 898c99eae8e4..0b3778ec12e1 100644 --- a/Documentation/filesystems/proc.rst +++ b/Documentation/filesystems/proc.rst @@ -1093,7 +1093,7 @@ PageTables Memory consumed by userspace page tables SecPageTables Memory consumed by secondary page tables, this currently - currently includes KVM mmu allocations on x86 and arm64. + includes KVM mmu allocations on x86 and arm64. NFS_Unstable Always zero. Previous counted pages which had been written to the server, but has not been committed to stable storage. > > Thanks, > Ryan