From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65009C43334 for ; Mon, 27 Jun 2022 16:29:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0783C8E0002; Mon, 27 Jun 2022 12:29:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 000CF8E0001; Mon, 27 Jun 2022 12:29:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DBDCE8E0002; Mon, 27 Jun 2022 12:29:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id C7AB98E0001 for ; Mon, 27 Jun 2022 12:29:50 -0400 (EDT) Received: from smtpin31.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay13.hostedemail.com (Postfix) with ESMTP id 9F04A609D2 for ; Mon, 27 Jun 2022 16:29:50 +0000 (UTC) X-FDA: 79624552140.31.219CAF0 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) by imf27.hostedemail.com (Postfix) with ESMTP id 430574003E for ; Mon, 27 Jun 2022 16:29:50 +0000 (UTC) Received: by mail-wm1-f54.google.com with SMTP id o19-20020a05600c4fd300b003a0489f414cso2438878wmq.4 for ; Mon, 27 Jun 2022 09:29:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=kCgDBgQt6lsYAKDyUa0fPFsfL97zuKyIxwCybKNVm6o=; b=IuiG/blkJ7gXjOQhLgtlkFYoJRK5r8pgakqSWN1/zlxqf40s05Q2KxgVLRnXAzs+fg ulTgDq4Xa1IQ2RvaytKxJcvgFOnViaFiqQeqoT8bFMwQmOfmx5WYvBOMGbjbujaxBKq2 ZxRw26go6NuTS6kLvJS34xZfj51gNbDxnvzESq7KPA+97DIORIk3qqV6wvZaFYlRyp37 iYjN5F2Fx3qCzsMwgAJwoELntygw5WoMYjcgqI9vY49AS4kLGOtkbsV2NX3QusZYb24t UMBgY7EFeybOiOqeaEkIwXo3wZRzJbzLQJE66d9iQWRd6teu2XSLOdmiKZKg0XoS0prd qUlg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=kCgDBgQt6lsYAKDyUa0fPFsfL97zuKyIxwCybKNVm6o=; b=w0VSPiwHbcKl0ug+YvWM0307IaKEk7e27L81aVFngzO5ECLU2zOGs43DPwgHGg72LA TMxGFEUITEdZJM5Wr8Fy1YIFRG5QjQQds1UOtT/0U0t8Fox1UyMfaYvhQOYJfltdTVz+ +3WdN4EaUFOg8Og8/w7+L2fivc0OrVIHpw1iYHe2moUUCBHLsvWR7zROsjL8DJbuPyrc /l5eR8LV9QXR2gMWCaeP9ZAHhEzWffxBj1imFu37mNkkSkvbXPyUWHnbWN8vizkGfmsE AKwcYuFe5Dwa68tMyeZ1wyOMeeJR0f86dXJSXorbigINxCyYp6PR46LkBDJR+JYVya17 4tBQ== X-Gm-Message-State: AJIora/K4T+lnuG1qLoRchO5tZwouEzP8qIZWsfl8hu711jiIQssbWk7 4AcxmYQyF7s08Nb+sm6W4YDrIFXK4e3/Kbv9yBQWyA== X-Google-Smtp-Source: AGRyM1vrDRm9Dztps4OpWjfEHDZNDaLLcMTy/XMsmuqPQoMJ/tNBlVur8bjCqgfF0MDzD0AVg6RDeZvfzsVoc13BMio= X-Received: by 2002:a05:600c:34cc:b0:39c:832c:bd92 with SMTP id d12-20020a05600c34cc00b0039c832cbd92mr16254989wmq.24.1656347388958; Mon, 27 Jun 2022 09:29:48 -0700 (PDT) MIME-Version: 1.0 References: <20220606222058.86688-1-yosryahmed@google.com> <20220606222058.86688-4-yosryahmed@google.com> In-Reply-To: From: Yosry Ahmed Date: Mon, 27 Jun 2022 09:29:12 -0700 Message-ID: Subject: Re: [PATCH v5 3/4] KVM: x86/mmu: count KVM mmu usage in secondary pagetable stats. To: Sean Christopherson Cc: Tejun Heo , Johannes Weiner , Zefan Li , Marc Zyngier , James Morse , Alexandru Elisei , Suzuki K Poulose , Paolo Bonzini , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Andrew Morton , Michal Hocko , Roman Gushchin , Shakeel Butt , Oliver Upton , Cgroups , Linux Kernel Mailing List , linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, Linux-MM Content-Type: text/plain; charset="UTF-8" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1656347390; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=kCgDBgQt6lsYAKDyUa0fPFsfL97zuKyIxwCybKNVm6o=; b=N82Nc9a5aTNjG2D3E2w3Rj3k5KMrxKXfh75ARJuwhpdZPUHxyj57yLgKLYkKGfv+dLTdCa QuYo/atUwl//jT1YgfXCNWPFa7giMa7EGoWMv7slcq8mFVEnOr/h+mwo5kicVZnMgr6m2i yUbWVRzrjf0NNO0P5KrLGk5lu+vMtTI= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1656347390; a=rsa-sha256; cv=none; b=k/MDUSyfVLqBYd6LWuEReq5qC//wiUQenbgfHvv4Xh0reSxECsNKL/W5lQFo2M9fAJ8erJ O1GrF+SUmYRqRsHnoXS45TGvNWbcsMTrYCAAuwYqkclJVv7x3yD+bX3olZc4Y7VxQub2PG idNK+gb36xGbLrSYfZ8RReOYQNuL+qA= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b="IuiG/blk"; spf=pass (imf27.hostedemail.com: domain of yosryahmed@google.com designates 209.85.128.54 as permitted sender) smtp.mailfrom=yosryahmed@google.com; dmarc=pass (policy=reject) header.from=google.com X-Rspam-User: Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b="IuiG/blk"; spf=pass (imf27.hostedemail.com: domain of yosryahmed@google.com designates 209.85.128.54 as permitted sender) smtp.mailfrom=yosryahmed@google.com; dmarc=pass (policy=reject) header.from=google.com X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 430574003E X-Stat-Signature: jd5sq55m7r4ukazdeqh1i8spd45c3967 X-HE-Tag: 1656347390-47159 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jun 27, 2022 at 9:22 AM Sean Christopherson wrote: > > On Mon, Jun 06, 2022, Yosry Ahmed wrote: > > Count the pages used by KVM mmu on x86 for in secondary pagetable stats. > > "for in" is funky. And it's worth providing a brief explanation of what the > secondary pagetable stats actually are. "secondary" is confusingly close to > "second level pagetables", e.g. might be misconstrued as KVM counters for the > number of stage-2 / two-dimension paging page (TDP) tables. > > Code looks good, though it needs a rebased on kvm/queue. Will rebase and modify the commit message accordingly, thanks!