From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71059C64EC4 for ; Wed, 8 Mar 2023 06:55:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6CA896B0072; Wed, 8 Mar 2023 01:55:24 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 67BAE6B0074; Wed, 8 Mar 2023 01:55:24 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 54121280001; Wed, 8 Mar 2023 01:55:24 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 439D56B0072 for ; Wed, 8 Mar 2023 01:55:24 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 15586160AA9 for ; Wed, 8 Mar 2023 06:55:24 +0000 (UTC) X-FDA: 80544819768.01.195EAC6 Received: from mail-ed1-f43.google.com (mail-ed1-f43.google.com [209.85.208.43]) by imf06.hostedemail.com (Postfix) with ESMTP id 36640180011 for ; Wed, 8 Mar 2023 06:55:21 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=SvJRYpGb; spf=pass (imf06.hostedemail.com: domain of yosryahmed@google.com designates 209.85.208.43 as permitted sender) smtp.mailfrom=yosryahmed@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678258522; a=rsa-sha256; cv=none; b=ugOiHkt/4pe5TI+UIQiiwAcnPBWYkP4zrhfaEih5vB7Pkc0AlN67IWbyPh1NhpWQE7OyEs iGYZWq7HKfTEyzNXF/TVAg4+WKHXbK9WCjJ9747WLT4tbbDyCwrMnrxqIGmHkfoLXaCj+U 661zAP8oT+0YCjpYl3e0cFj+TP3PHeg= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=SvJRYpGb; spf=pass (imf06.hostedemail.com: domain of yosryahmed@google.com designates 209.85.208.43 as permitted sender) smtp.mailfrom=yosryahmed@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678258522; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=t70odTwmK6O77z83bIqLAvXxKp0qE+ApIEsl/k0TwRg=; b=Lj+vvMA5/vbXiwKcGw3DsDcSBPhTD6rBMn39tHDpayWjAiOhf64XAMLnNWWKnJMuj5u1Or EmJcJJurRou0WDfJjVnEnPGoOETv8RI66YsaZV6Jt8HxRUfltp5XEUg2/WRsA2P/pD9MrL C9QenJdqBkrYFvTQ5xcj3uecSoux/3c= Received: by mail-ed1-f43.google.com with SMTP id x3so61639457edb.10 for ; Tue, 07 Mar 2023 22:55:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; t=1678258520; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=t70odTwmK6O77z83bIqLAvXxKp0qE+ApIEsl/k0TwRg=; b=SvJRYpGbYBjKv59H4HCKsI7FHXUk8wNeT5ln9OF9p4Yo/DzY3x+JBriHlUCsLHkbLx uHAd7HHnZs0HddC1hWysXar5oL4ukgo/NxGJ1wHVSC6czBH1euLkijk1EOW7+Sww2Z8D cUoOFf5GHkzBlSvQ04vt5G4UBXvzz0wyCHSZTsrPaUV8ptoJoHjnZwVBZuVm8Q9gnRVj wrRPSR0xKEskGh/0nSPNtRDNdYx0vvgjbeyLF8NumIBinb2rdsXWQKYiG8dIcOQLYSf7 t1D/nGvITRdRK8fmju2RQ7t6cDKNmxR2RdOKMy/7/Qy3fhn2/EdDNb3dgGy7vU2RY/OE 0qEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678258520; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=t70odTwmK6O77z83bIqLAvXxKp0qE+ApIEsl/k0TwRg=; b=FlJZ/57Rgl3GZNvQm8Ids4b0jQ0LSimA7GsJeBQ6f6bfGNHxItUFT9zS7R/uqjWvB3 VyLG8eaYZ8sYQd/NZ0DDVmpnjDAKznRCNly9EBgrCj9rxFd/wT1jHNVmH7GGPOz1JuZx KZtFMvEiicXS/ORAHmlF32X5VvbsOV2kOFZApobHDR8dz6IhVnlpHW66gx6NLQi2WTUj XL0YE+W0hlk0KdNFQG6OdLjQH3g/5xRB52M/wLswoHu2S8sBIpcnKPbkdnNhKG+/+/Q8 HeYMxSedLM2p1V12dSeERioIuux9VFEvNe8ln9cyzb8R3wD8dDlzM56BPkwxwz9THiXO fC1g== X-Gm-Message-State: AO0yUKXKZnMi9fWdJqp5Qo8IUAp+rMsoKHqHnvqNSEguEh4EH+hhqnVH vQpPgCaE3amxU7FdB9LaOHt15zVndNIxN3dLncgrCw== X-Google-Smtp-Source: AK7set84EqwKbbWtBzLqoI2WBaXzcxS36AWRY3R571B29UifEtRwl/Oaa3UiGOLEMSR+VMGnJ9LPtwdL8OLwQH7/Z6w= X-Received: by 2002:a50:8750:0:b0:4c2:ed2:1196 with SMTP id 16-20020a508750000000b004c20ed21196mr9453336edv.5.1678258520463; Tue, 07 Mar 2023 22:55:20 -0800 (PST) MIME-Version: 1.0 References: <20230228085002.2592473-1-yosryahmed@google.com> In-Reply-To: <20230228085002.2592473-1-yosryahmed@google.com> From: Yosry Ahmed Date: Tue, 7 Mar 2023 22:54:44 -0800 Message-ID: Subject: Re: [PATCH v1 0/2] Ignore non-LRU-based reclaim in memcg reclaim To: Alexander Viro , "Darrick J. Wong" , Christoph Lameter , David Rientjes , Joonsoo Kim , Vlastimil Babka , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, "Matthew Wilcox (Oracle)" , Miaohe Lin , David Hildenbrand , Johannes Weiner , Peter Xu , NeilBrown , Shakeel Butt , Michal Hocko Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Queue-Id: 36640180011 X-Rspamd-Server: rspam01 X-Stat-Signature: jsuirp6kpw4pmp89imqqu8cctdwkeq6d X-HE-Tag: 1678258521-405833 X-HE-Meta: U2FsdGVkX1+foqjKU8l872nDOpSvknUib3xRfZOah8vWiRTJjGELCiFvNuWkhSfLkYlOMkg3aenQUudwk7AB74F6onAJYpy/NM+H1wuqeS/5mgwg6SnMhWf7X8M+/9qS4X9QuGaPRQbfKkBYyooTutAB1hE+r2LZTZo9WI/Mb7iUGPZAxV190bYlVjVTRxrafSTh3fTUmiAvl7nHyvWXZiLGTxUEXUVNGfo3MPXHmvc343sY32a2sZpiQULu8utpw/4Ltg5+IW/ExcySu8Zsnkyu+qqRhwFS9XkYR9ISQoHvJPUVcMc+Mlp7hFmBGSGZ2+vFYR5aEeGArVG1nsMzNID3gawWrQhyperdx8v5F5DJ555IGt35xRzqMOjdv+dTOmiZDxRmujo5RbsWrHJmu/erlNj6iXrd0z9j9lE62HNjgImJ4lpozzoSv8pPnpBRi5PlUuWO5sAJ4Z5FXxXTV571NI09wH5d5FtL5kfqd2FHfzJI/sWO+Kt8ZTa0fYjMkQIYJoLWLHimUFzCgL2HbmPOo2/23YApWYrVqfc9s4xa/CT7mCmz1MRV4SirulMM9ADoItadEqUJIlXH4vs7OIGCCG4JBV0E2mwLoVNecuJJugGNGEKsWXUp1CBTCWA+YhrLLzjA1QrB2yBW/3HQHSdQ9BnT0S2sk8xjn25bH6ANEmCsxAMwWREcGmEJ1V0W1foX1gL8xBHuGyvay4P1VnRDpIUHFGTNhoq5wIzjJf5vTOxc1t6+Ywq0k1X6wzO09kAD7xPTbryYRSSylHlh9tjALP6BX96/z/7dPBWpxU7FM3k8zkBEhS4s+WnP/Ec8Jen19FZWAbStSI30z/tF1B9yOnjei50fQh5RfyszWAHTDUuOoP2E9kcKJ5gFk/CmsE27XXg+O1rd1UcsMBoQb1pg4BAnlpUP6/PCyCGnvndqqVQ/zXa+9Bj9PzGHnSWj7tA3Tjtt0z85fswJ6+8 ipUsMqlK 66C4GEu0hv5I4/yEWZ/DAwPImfP2Wt7NJD8Am5rSlTZBWqaryc414U2yIluA6lf5lC8frW/xpHHNm2lKvLnEFI92OSbV6l3Nhi4UipEWwnCOCI4vROFPY4It4oQ6+9DF3Q0m5pCcHtqIYPtSKxUSaKaLbQvqgNUTMZYFk5Y88IFt/bvWzL5DJYe1ZqlNDGM3jcnNAck2vG2whXP9/6fYVPiMgLbf4nL/PJhtPmPYh7EQGQYKqRYLhJCT0gnQkbZvTEaafDm+aho+VDnwJ2HGOTETgu4WdMPKJ4cXNXC7kvS1LaCvPLNjzmfg4Z+rm6HNlApGkq+zDVzUZh18UpJcIVjJkOw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Feb 28, 2023 at 12:50=E2=80=AFAM Yosry Ahmed wrote: > > Reclaimed pages through other means than LRU-based reclaim are tracked > through reclaim_state in struct scan_control, which is stashed in > current task_struct. These pages are added to the number of reclaimed > pages through LRUs. For memcg reclaim, these pages generally cannot be > linked to the memcg under reclaim and can cause an overestimated count > of reclaimed pages. This short series tries to address that. > > Patch 1 is just refactoring updating reclaim_state into a helper > function, and renames reclaimed_slab to just reclaimed, with a comment > describing its true purpose. > > Patch 2 ignores pages reclaimed outside of LRU reclaim in memcg reclaim. > The pages are uncharged anyway, so even if we end up under-reporting > reclaimed pages we will still succeed in making progress during > charging. > > Do not let the diff stat trick you, patch 2 is a one-line change. All > the rest is moving a couple of functions around and a huge comment :) > > RFC -> v1: > - Exported report_freed_pages in case XFS is built as a module (Matthew > Wilcox). > - Renamed reclaimed_slab to reclaim in previously missed MGLRU code. > - Refactored using reclaim_state to update sc->nr_reclaimed into a > helper and added an XL comment explaining why we ignore > reclaim_state->reclaimed in memcg reclaim (Johannes Weiner). > > Yosry Ahmed (2): > mm: vmscan: refactor updating reclaimed pages in reclaim_state > mm: vmscan: ignore non-LRU-based reclaim in memcg reclaim > > fs/inode.c | 3 +- > fs/xfs/xfs_buf.c | 3 +- > include/linux/swap.h | 5 ++- > mm/slab.c | 3 +- > mm/slob.c | 6 ++-- > mm/slub.c | 5 ++- > mm/vmscan.c | 79 +++++++++++++++++++++++++++++++++++--------- > 7 files changed, 74 insertions(+), 30 deletions(-) > > -- > 2.39.2.722.g9855ee24e9-goog > Friendly ping on this series, any comments or thoughts -- especially on the memcg side?