From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BBEF8CDB474 for ; Fri, 20 Oct 2023 17:43:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 37B4A8D01D3; Fri, 20 Oct 2023 13:43:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 32BD88D0003; Fri, 20 Oct 2023 13:43:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1CEF58D01D3; Fri, 20 Oct 2023 13:43:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 0D0448D0003 for ; Fri, 20 Oct 2023 13:43:42 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id CD661B5800 for ; Fri, 20 Oct 2023 17:43:41 +0000 (UTC) X-FDA: 81366562242.27.68BFE58 Received: from mail-ej1-f47.google.com (mail-ej1-f47.google.com [209.85.218.47]) by imf14.hostedemail.com (Postfix) with ESMTP id D609D100030 for ; Fri, 20 Oct 2023 17:43:39 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=ZNmsnqQO; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf14.hostedemail.com: domain of yosryahmed@google.com designates 209.85.218.47 as permitted sender) smtp.mailfrom=yosryahmed@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1697823819; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=N1heveFnCrEJOdM4DCy3MHM1wUBeG4YS6MC7cDodL18=; b=fMzFU9z15Bvn8rnuv8WmnwNY5fZKG0xIWZIDUcVwBKs6iw/AOgpaqk08Y2N9NIOPPbfreM 4RLW/p0+u9cHF0ubE4/siAGQmvBAsFTZ+wf5pxXI0IaoKkdJ+PhROM4qRhAaoZM0B3aMhS lvxeOZz99eYKmt4n9moDyenfKpJfW1w= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=ZNmsnqQO; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf14.hostedemail.com: domain of yosryahmed@google.com designates 209.85.218.47 as permitted sender) smtp.mailfrom=yosryahmed@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1697823819; a=rsa-sha256; cv=none; b=y1lX6Jrhmln+k2BtwE0HU+demQwATGgTxao9X26VQsA8E4a5kfCVfVjC9mMVGCsORoD6KW 5QWRlxeuzow6Xtrh0F6u+cmZbbHX6PyXg3mhm3uoebQLJxrkTjDiU9Mq/r9pCP0fvscJwA ouvUny0/aaEp4KpwLB319bosBt0hBMQ= Received: by mail-ej1-f47.google.com with SMTP id a640c23a62f3a-9be1ee3dc86so166589366b.1 for ; Fri, 20 Oct 2023 10:43:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1697823818; x=1698428618; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=N1heveFnCrEJOdM4DCy3MHM1wUBeG4YS6MC7cDodL18=; b=ZNmsnqQOKv0xoDTq8GXsNLId2CwmAcQihWAyPLnKPFWji2OlNRZ8AVkH7kI/mLav2q sriNvIhbUSbqJPYWWrkJXVwOnq4FSxnaLvfnj9SZpOsPRmr1Xz6w2j73cPMiiU5I7gyW U3EjiZ+11QZOgV0LzT89Ah1dpytQ4Isw/qyvNQhK4UG8EQaSutkUH3S2uR87nN3TZdfg toy+0hAtmlUwpgQMQmdgOcCOVOdeL9cnFmy3DwM8xo/uL0ShJqs80ptk3+C3IfShlqLK xBoymawtBiaKKDYSh5go3qmmzfjYHQf/k+El9IGIYHSEGdVqeAyNQDWX5aawDaNsuP+t c57w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697823818; x=1698428618; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=N1heveFnCrEJOdM4DCy3MHM1wUBeG4YS6MC7cDodL18=; b=Eu2qvPXmAbXsPCP/bHYWWV2XklWP2nzkMgD8zFcGpWP1064rJ8MRue2cveqZhIMSld gkacXR4YVCGQXk1YlTuG0nuGBBGZPq0+VRJasngiM3PLdHQqhnluslPJaltEOoCtUdNz 07QNGlJMF+/pApB33t/2ZWO+CRlGR/YNoXiOBlkTbKAnnS5xjiTgcYJHUl/JPg9sE0KR H/+crF9XH4vC652iJftbBH3OYY/ddme0/u2gftWRquZbHNg2fJRhBwO3v6VTFeX5bu48 p1r7fQKPpJRIOQzECOHK0id18uKKdXPL9uIn1FvgHjvE5bvHc7TGSqkSckEaWcoG0UOF ZWpw== X-Gm-Message-State: AOJu0Yx85G1EC7UY78U39DYfjlwNHih2uHmpv8FB5SWE1WhUwnBhW56b EPyMnhHn1XmABdT3wXZ2nKFxLxk5Cd0g4GW3yfA9Ug== X-Google-Smtp-Source: AGHT+IEXZwXYQoD3qalHsmHbpcJqzZ7tmC/iIYPTkqCHECXMuZkRt9k/MgXunNY1rLGD07LOxsOxhXyUsPRzCRi/Qag= X-Received: by 2002:a17:906:da8c:b0:9ae:52fb:2202 with SMTP id xh12-20020a170906da8c00b009ae52fb2202mr1823652ejb.40.1697823818063; Fri, 20 Oct 2023 10:43:38 -0700 (PDT) MIME-Version: 1.0 References: <20231010032117.1577496-4-yosryahmed@google.com> <202310202303.c68e7639-oliver.sang@intel.com> In-Reply-To: From: Yosry Ahmed Date: Fri, 20 Oct 2023 10:42:58 -0700 Message-ID: Subject: Re: [PATCH v2 3/5] mm: memcg: make stats flushing threshold per-memcg To: Shakeel Butt Cc: kernel test robot , oe-lkp@lists.linux.dev, lkp@intel.com, cgroups@vger.kernel.org, linux-mm@kvack.org, ying.huang@intel.com, feng.tang@intel.com, fengwei.yin@intel.com, Andrew Morton , Johannes Weiner , Michal Hocko , Roman Gushchin , Muchun Song , Ivan Babrou , Tejun Heo , =?UTF-8?Q?Michal_Koutn=C3=BD?= , Waiman Long , kernel-team@cloudflare.com, Wei Xu , Greg Thelen , linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Stat-Signature: b3rfx6fs8zx56tewhmjhgysf1z8bi36d X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: D609D100030 X-HE-Tag: 1697823819-817438 X-HE-Meta: U2FsdGVkX19VzL+OJo3tkr0+43XTabuX0+rfCza4eyHrY0aZzx/lXor5ESciiiGeir6UYzK2TQUPSVVRI+I6goSIBMTo7tIFOGtBI+PdtmGgRuU0JpSrhKATJUxKTuQ6NrnYNA2shgGwFv8dMdGwOfCuQslEzSZbNSvR6OSs+p/0WDld4lzE38L7flSB0G6FMwWnulmPX2qymhk2I9NIU7A5uWvhMLJuib+M8PE5SN9JwgPQinScZcTZctQZHyr3PyL3SzQgHdH/R0umSaZOHuOXl78vn/ENRE2pO62bGmGoTS7PsjukwJA4U8GzmyQiYjzCdOKQ7EDSo1OSUaHg8M0CPeA9QrNNEUqHNkRiEXaLbs8+zIksqkeGH9e2zG5cVnYhc9wRc+NO8jRpLRibOBD4+PRmniZ/FEdDKFW1g7zt+kXLr+I8Kq1YBzY4mncNQGEMPBjBLujO6RFzaEGWiRRYw5bGR9cc4kJFwm7G7llbZDiKekf2ksP7k6pPsWLE6i24OgTRytno1m9macbXbRfxzDoYVhd58BEeHJD31sfJyeFf2MzPc1yi8iiAnrHahj+unoErRG5D7h+NaT7mRPvP9fvqSztUiGX9sE1hJi9imm02r60k1OUp59Ma5EBAT/F5pSEa3O0ZkQP5l3LV8KWq8dvLWONYigT9o3+3jqEG/kOJ7jk2/xJURP+e4Kr5lZRliwhCdAH6IhBLnX/DhAyV7rag7bxE/IPQMIGG4PKuk5XQpwE4N3dyxsVnfoVWeo2I4AILlcMA6Q542+jf+IGuV1or6aQWdRLJy1/Hkq7bV3xr2kiIBJqsy17BbMeaEjrP/yBJ0/BzdgOlbSj3y1bRfaJEJSAa+CDpE0viX0OELZmUfHhdY43I9BXj1JoRBAaPpO06gtD1kUyEClH2jJbNvbnXB+vDZSigTVM7q+m9k7xiCYNy1slb8DKEsE7CpNWruFuRoLHjYxCYwnF t1WtlHEg yDLZCBa6P8kqhk6P9OkIm+Qe7w8i9zkZQ6MoTEng92cYPGo/BEpe0lpiyo5oLwd5MNFkUazAcF5w7rrHZHLDTfq/Uau0F2BjJR0xdAsdtOXyBW1XXAthd2f0dO/p8TqQiQxEVv+tJVrG9SEqxU0Pbi8+sGYydCIKxJ8JxlviP2f2vd6GUjQxW9shGf8zOSPqVkKZIOHWNYdZvuhJEc6tYXlFSlI/WUvWuLf+tegUfvPkpB0CKkYXQDi/D1UGBjW356YZOpwSyJkGNTYwxbNyWIQWdhLjrAkpbznr7EnQh3gaOCORxl4DqNy7obn5s4uYoNVWKOl9R29jSp33AMZmTqHwtkyGLaOxFx5lU X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Oct 20, 2023 at 10:23=E2=80=AFAM Shakeel Butt = wrote: > > On Fri, Oct 20, 2023 at 9:18=E2=80=AFAM kernel test robot wrote: > > > > > > > > Hello, > > > > kernel test robot noticed a -25.8% regression of will-it-scale.per_thre= ad_ops on: > > > > > > commit: 51d74c18a9c61e7ee33bc90b522dd7f6e5b80bb5 ("[PATCH v2 3/5] mm: m= emcg: make stats flushing threshold per-memcg") > > url: https://github.com/intel-lab-lkp/linux/commits/Yosry-Ahmed/mm-memc= g-change-flush_next_time-to-flush_last_time/20231010-112257 > > base: https://git.kernel.org/cgit/linux/kernel/git/akpm/mm.git mm-every= thing > > patch link: https://lore.kernel.org/all/20231010032117.1577496-4-yosrya= hmed@google.com/ > > patch subject: [PATCH v2 3/5] mm: memcg: make stats flushing threshold = per-memcg > > > > testcase: will-it-scale > > test machine: 104 threads 2 sockets (Skylake) with 192G memory > > parameters: > > > > nr_task: 100% > > mode: thread > > test: fallocate1 > > cpufreq_governor: performance > > > > > > In addition to that, the commit also has significant impact on the foll= owing tests: > > > > +------------------+---------------------------------------------------= ------------+ > > | testcase: change | will-it-scale: will-it-scale.per_thread_ops -30.0%= regression | > > | test machine | 104 threads 2 sockets (Skylake) with 192G memory = | > > | test parameters | cpufreq_governor=3Dperformance = | > > | | mode=3Dthread = | > > | | nr_task=3D50% = | > > | | test=3Dfallocate1 = | > > +------------------+---------------------------------------------------= ------------+ > > > > Yosry, I don't think 25% to 30% regression can be ignored. Unless > there is a quick fix, IMO this series should be skipped for the > upcoming kernel open window. I am currently looking into it. It's reasonable to skip the next merge window if a quick fix isn't found soon. I am surprised by the size of the regression given the following: 1.12 =C4=85 5% +1.4 2.50 =C4=85 2% perf-profile.self.cycles-pp.__mod_memcg_lruvec_state IIUC we are only spending 1% more time in __mod_memcg_lruvec_state().