From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 598E7C02185 for ; Wed, 15 Jan 2025 01:40:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DB9FA6B007B; Tue, 14 Jan 2025 20:40:07 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D6B076B0082; Tue, 14 Jan 2025 20:40:07 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C31D06B0083; Tue, 14 Jan 2025 20:40:07 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id A82216B007B for ; Tue, 14 Jan 2025 20:40:07 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 5735CC0F2E for ; Wed, 15 Jan 2025 01:40:07 +0000 (UTC) X-FDA: 83007980454.15.33B4D16 Received: from mail-qk1-f176.google.com (mail-qk1-f176.google.com [209.85.222.176]) by imf06.hostedemail.com (Postfix) with ESMTP id 8333218000A for ; Wed, 15 Jan 2025 01:40:05 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=zJ1gLB94; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf06.hostedemail.com: domain of yosryahmed@google.com designates 209.85.222.176 as permitted sender) smtp.mailfrom=yosryahmed@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736905205; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ZiiJFWVgdb4jW+ugK+i4jrVS7AIheM6MMFwsTAa0sgg=; b=4hHYHi0/xSptcBXyWd5kzsR6s7zUT5ObfsFe/qzyUQM83bFzDqJ4EGcO4Dy/LR5Mc6Cqos rO3KzOnQovUCrW/MqnUPU/RubJpJP1UPgI4/KLKxXxPCnDj9N7Fe5MNlHQq5ugXEpVIWZT wHacOAlrRn6KPKJ2W00D5yGtPDJKrYs= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736905205; a=rsa-sha256; cv=none; b=ptcitUSqhxDS4ffVD/xf+SQ0zr5JElhKlnNCSQnm4noHMILCZIboV6MGpxhG6OZh0WeWwv 1IKH0jbONHYH6tuOTwM40Gg/eDcpWdSNsWrcnA67w9Hd+glybdVtk20CYk0faMaD0nqqRI vIuTqOhyaWjDxxhOVJvYVtW6ecNhHHU= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=zJ1gLB94; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf06.hostedemail.com: domain of yosryahmed@google.com designates 209.85.222.176 as permitted sender) smtp.mailfrom=yosryahmed@google.com Received: by mail-qk1-f176.google.com with SMTP id af79cd13be357-7b98a2e3b3eso339735885a.2 for ; Tue, 14 Jan 2025 17:40:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1736905204; x=1737510004; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=ZiiJFWVgdb4jW+ugK+i4jrVS7AIheM6MMFwsTAa0sgg=; b=zJ1gLB94fHWu+RJSFQ1MAM0pku39ypWopIzqKOa6wYPLwS2RIPaw4HKrswxaXv7XBp GosMSs4pb9Gpgr19jWX/kxsxw6lQ/d53OITapsUNLufD6L/X3vI4CQdSaSw54nWjk3s3 tMJ4Uucm+IAyAQ47QtrF0tUEZVyiClWaB/ZP+21EH+nkGwMhJpuomJrlUKf2/JhS85Dd o4vQKiuQkVtAq3YiAOHLEaaolhlbMdQmKvS1m8WlHUaxSDNjT+ipX3czjjdyn+O2In/m 8lKiSRR8rWQSxeyEnOY8jpxtDHjDfpGfDqfISyrs+ImhxM0co6rg//RnXWhtBQY0xTqb UgBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736905204; x=1737510004; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ZiiJFWVgdb4jW+ugK+i4jrVS7AIheM6MMFwsTAa0sgg=; b=Gqk50SfON7MF9PEwv8Om1vq9lmQraAbb4db8BHLEuD0PwpZZoysi+HN8F6ikYER3f5 YxWlPRMNyrN9mP4Bc5NaUrv/rW5XJG4qdsnBdiN51ITOP078Afiaxsu8jXzmCwHxupXW eX84N6Fan3a4PxZDIB/hGgKgCwI5l8+8W6/f6qNCVUx6+FWM/ysP+E7y2imIvhAIjDLp KTWtLxJs7DcsFRYT9k7yzUHVYaiMhSs/srk5sjQfpvZHKl5gVH0GtJvCntiJn8vAx5pP MHg7I6ONiSxFlGZHuZIRkkWPGNVKMGs3+dA6sBwx7rSaZ52RMiK9taVOLIvQ8m01oAx0 /0yg== X-Forwarded-Encrypted: i=1; AJvYcCU4/xagpOvTEUyX+jhf8nScqjxonvFHCA7CijaKWAlslGdCh6yS/x7uLDwH6IbxMPPkFxrI9KfJ1Q==@kvack.org X-Gm-Message-State: AOJu0YzyrgVHJqXE+oNIzWPCCP0Z/WLNV0xctXnmNjaZff4iJe3ppcRz bsHMKHitnBiX0Zb9p68tH27p6F4epzayo7vzB0OvBvbiD2digpm6n9yJ6U4XgbJXe3zHpyagx8w CuPg8Ys8wPnz2kDn3P2wpiqyW+7Kh3DIBVfwa X-Gm-Gg: ASbGncsZJHGD+j5aSYAP14hjMadBUEsEz8V9stBlX8Cs46UV5WgS4pHgb0LQ38YJcqM puTw8Za57Sv9+RsM3TdOF0m4UqLisCwXcVY9Nmz61vKFuZX7vF2mqmG57TZdszkahWUWx X-Google-Smtp-Source: AGHT+IHfwPncaMotev11QjY/IBBc2ozTptdW01qlXHfZTluvxk1Gclq6xG2iESy181Z7aro77brAUxuUUsmdWa24hMM= X-Received: by 2002:ad4:5964:0:b0:6d8:d5f6:8c72 with SMTP id 6a1803df08f44-6df9b230aecmr429451286d6.19.1736905204305; Tue, 14 Jan 2025 17:40:04 -0800 (PST) MIME-Version: 1.0 References: <20241224011402.134009-1-inwardvessel@gmail.com> <3wew3ngaqq7cjqphpqltbq77de5rmqviolyqphneer4pfzu5h5@4ucytmd6rpfa> <3348742b-4e49-44c1-b447-b21553ff704a@gmail.com> In-Reply-To: <3348742b-4e49-44c1-b447-b21553ff704a@gmail.com> From: Yosry Ahmed Date: Tue, 14 Jan 2025 17:39:27 -0800 X-Gm-Features: AbW1kvaTKtPeLPEx9TMyttpFIcFaL9JR1NZ9USgYjcO-hjQ3cn5O9M_EJfckXrM Message-ID: Subject: Re: [PATCH 0/9 RFC] cgroup: separate rstat trees To: JP Kobryn Cc: Shakeel Butt , =?UTF-8?Q?Michal_Koutn=C3=BD?= , hannes@cmpxchg.org, akpm@linux-foundation.org, linux-mm@kvack.org, cgroups@vger.kernel.org, Tejun Heo Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: pypbfk1hyhzeso7ooq337j44kapz44j3 X-Rspamd-Queue-Id: 8333218000A X-Rspam-User: X-Rspamd-Server: rspam01 X-HE-Tag: 1736905205-799909 X-HE-Meta: U2FsdGVkX19wJo+q8sZibpbHAKAwf27v7R46xBUlAcQDNwLoo5cWmRE65clzKPsBNTMU2pKAKUNkNiYwsNpF9gaxxaG+0ZPSy/nMbC/thzSNjm1MTw1MCE9evHdE4czEwo2c8PG/L45ry4S6r8iqY5IOvv8CkvuBKS57b+TLvifKMN1vfE7phBr2PX8ep9bmePyQzHMHqNOWjLHC1dtTy9Q3N+sIjSWdKRriXYiVcgFkt+tdGrm3LUujL4Ac1LonA6tfZCQ17nygSEBd0J+8nAyU0IdQg4rMvgGZ7XoLsHnb7ZlT+SXRR4naBiPluAvlBh5AeACh9s80m2hJ2PAps17uUqRnhJWTMiZpvvtuVJFIQ29Q/Oi1wIDeVEZ7L59OTUaQRYgi64NuQKMmo1iteIj7cZ3vTFvxLyK8g+ZkMCD0KtRaRw75VS0ztq6UMqO1KmyiUskEbLWuKSm+SGaTa7OJGXsvMLhmUz7vCyuBQ3dikC8k0Z4AiVVXIB4wEJ9qHTv4vXsPq/3Ar/JmNzrdHTSW2nG+fi3LUD6rbeG/EU94bjmiHZcn0IuKFJAEqVR0lA05caCVq2T7OjWa0DpjU3o9D29huE5uawz3t836CnjjTJWuPPidh68IHdqQoz2ukGIbVx2Th9kVrCe0mnqa+wBV25SK5VMM7s5Nenaiwn34NhhwBkpTgQlcTo/5ve/Bz0xOQdwzslSEcKMgV+IfLwXTTxxEPBhlFXckondPFLZCPZicHApouz9148bTs8AVGZBpeTDQ2C5IJtoOmQecEgHLE7o35B6eTA/W1bYGSJlgmn+ghjUBW480O+S3aqEmZJ2oEwxTl2eASTc3Cxz1tTWzedrGuaS3xyZaJHuoKJC3CH9ga2e9zjft0teZeB3URAVKdwR2Y5Cm+dPfkcGUbjBwAdqnzDLRjMs3NJ4r+7H7eEb8dIhnDNwB6G9Tvmui3oMvgjACUQ4PdSa2xY9 5B6p26Qe awIaNwJhT98hR12/f/NyqhEbPkkPQs0Xx1IzbApcPzCvCxYxoampTDtIJLNqDeP9krk+sg0oVYDJK9GP7nrfRMuUsmhyNEZ86CVBvVjcqCI9+1HN2JJiG6FO/2w0fyzm7uO8epY8KdjCj4eTrIgWQnAn3nCG3w6hoQtZKZNaVXvDX5lzZINlLxis8AzgcAXjfkQwJB9NbpBxWP4xIAKHVpe0pcw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000034, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jan 14, 2025 at 5:33=E2=80=AFPM JP Kobryn = wrote: > > Hi Michal, > > On 1/13/25 10:25 AM, Shakeel Butt wrote: > > On Wed, Jan 08, 2025 at 07:16:47PM +0100, Michal Koutn=C3=BD wrote: > >> Hello JP. > >> > >> On Mon, Dec 23, 2024 at 05:13:53PM -0800, JP Kobryn wrote: > >>> I've been experimenting with these changes to allow for separate > >>> updating/flushing of cgroup stats per-subsystem. > >> > >> Nice. > >> > >>> I reached a point where this started to feel stable in my local testi= ng, so I > >>> wanted to share and get feedback on this approach. > >> > >> The split is not straight-forwardly an improvement -- > > > > The major improvement in my opinion is the performance isolation for > > stats readers i.e. cpu stats readers do not need to flush memory stats. > > > >> there's at least > >> higher memory footprint > > > > Yes this is indeed the case and JP, can you please give a ballmark on > > the memory overhead? > > Yes, the trade-off is using more memory to allow for separate trees. > With these patches the changes in allocated memory for the > cgroup_rstat_cpu instances and their associated locks are: > static > reduced by 58% > dynamic > increased by 344% > > The threefold increase on the dynamic side is attributed to now having 3 > rstat trees per cgroup (1 for base stats, 1 for memory, 1 for io), > instead of originally just 1. The number will change if more subsystems > start or stop using rstat in the future. Feel free to let me know if you > would like to see the detailed breakdown of these values. What is the absolute per-CPU memory usage?