From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 596EDC4345F for ; Fri, 3 May 2024 02:07:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BB5016B0088; Thu, 2 May 2024 22:07:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B3E436B0089; Thu, 2 May 2024 22:07:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9B76E6B008A; Thu, 2 May 2024 22:07:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 771556B0088 for ; Thu, 2 May 2024 22:07:32 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id E2544A021E for ; Fri, 3 May 2024 02:07:31 +0000 (UTC) X-FDA: 82075447902.30.6F184B2 Received: from mail-lj1-f176.google.com (mail-lj1-f176.google.com [209.85.208.176]) by imf11.hostedemail.com (Postfix) with ESMTP id 1536740011 for ; Fri, 3 May 2024 02:07:28 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=HPtlLO04; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf11.hostedemail.com: domain of yosryahmed@google.com designates 209.85.208.176 as permitted sender) smtp.mailfrom=yosryahmed@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714702049; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=wJrtYsU7ekXDKHkSe8mX9YgTBJPSi4fRDqN6RMmLDgA=; b=aRvnkeRq3kh8rhh0kzqAMB7AZWGLbbHpVCjd+4cCZDVdpxHqdqh12KBemFM4n2/x3k6AP8 GyGKIyymHIx0MH6ptp+5aI9eSphu4bweYV6E37eYBOxv86CZvP7r73Oy6auwkzhNZVXC0t gQcoICYvTubM+8TMsduBrhU4pvhE3qc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714702049; a=rsa-sha256; cv=none; b=Ce8WaJe5CVhCN/QxQ397OAitJZBZBNw6KAxL1VRPALj4n9sL/ejVnKAQ0iUpF6oFp4H4/1 9328b/2OGtM3t2O8zIHTEMCLOKbvjbyzWp3nFmSEpgOBuC9b1nLBLoKbCQJSIsvuxBVRDa hrdlNs72/eGUJ6woPTEp2wZMGshvZU4= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=HPtlLO04; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf11.hostedemail.com: domain of yosryahmed@google.com designates 209.85.208.176 as permitted sender) smtp.mailfrom=yosryahmed@google.com Received: by mail-lj1-f176.google.com with SMTP id 38308e7fff4ca-2dd6c14d000so106018441fa.0 for ; Thu, 02 May 2024 19:07:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1714702047; x=1715306847; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=wJrtYsU7ekXDKHkSe8mX9YgTBJPSi4fRDqN6RMmLDgA=; b=HPtlLO04cJCZYhnsVw1IQgAtiTJb5NxMSYployeI84lmZu5HRxUb4ChJwP1QsSRaDh jQll76OcNYIMzwJTYWvH9ZkzxBdWhGv6qhWaHJa8dnzC3/49Du+nK5SduotnIsO54InB Mn4wDm8CaoVR9Jl/15gL6EVeC+XCculwrAlcC5pm5LjNG6lVjPUbyAWlZpCtXAekLs4N sHyb1R3i4WQysJWkOAFL76s8oeIrcfNzd5TMmEJmjQrtBH7Nin7toHw34rAHsCbBgQHr AO4/fq7vEQWFiSnSQUw+qNJ9k98roOWv/pku/GKelw36/2e5Ho2a+qgcbRVNhHdjNN7V lPjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714702047; x=1715306847; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wJrtYsU7ekXDKHkSe8mX9YgTBJPSi4fRDqN6RMmLDgA=; b=acysf+VwyaPKpbHNgfBDf+aRgAf6juVWqb3y3OxWEVWPYIYZ3iJDst/cKVmpmRcevZ pA19WHY39fu6chprmgxrdVWagVlxaN+i3agBEUcGlEnjcnVH9r6R98piCafA7bsgH6ur Rp2wrQlyspdhx1LFt/YUl3sWgSYGki4mECMglAaspuk0/iqrkwzmheA+1OLeVra+Zp54 2MztdnbW8tgnQFEahvAVb1Op0/ybsds+5Xgwu6HiAJsQppQi7DmLD6HGyg9lPY2TdxjZ ViIZVNXWJ/MHmrluHvp7qpzLlSQf3+t5iYVhj5UbSu9b2diX3gTgfvr5dhLf7xEE9Jxt WZqA== X-Forwarded-Encrypted: i=1; AJvYcCXodkU4BWfcIEMlOxq3Oe74EKAHzozFgYx/vHTj8bimLgIC3cKs5v0uF/k+6uSD0E8h0W2OPkMORhJ82Y0gTs0kFJM= X-Gm-Message-State: AOJu0YwC32hQ3tvijhw38reOKbYYN3AJd44WTvZZsguqFx8TqvTa5APJ YsyUECsD/drL3GbobwKauk4CIJ9/ZG3hi5aKjt3Tm0sdlAOJ1cFg45cgFYg5NhLajZpSZvaCd44 6kUGDvfV/VRdglDHdOTuZW7fLr7Iya4yUFazr X-Google-Smtp-Source: AGHT+IH3BNa+OfWhcjhYgjYPNeUgQUqIL3S8QOwfCsVAA9Rubgu4KLI4vw8am1ku907CHfrHR/bze4P6anRW1GMqaaE= X-Received: by 2002:a19:9118:0:b0:518:a55b:b612 with SMTP id t24-20020a199118000000b00518a55bb612mr812100lfd.54.1714702047015; Thu, 02 May 2024 19:07:27 -0700 (PDT) MIME-Version: 1.0 References: <20240502200529.4193651-1-usamaarif642@gmail.com> <20240502200529.4193651-2-usamaarif642@gmail.com> In-Reply-To: <20240502200529.4193651-2-usamaarif642@gmail.com> From: Yosry Ahmed Date: Thu, 2 May 2024 19:06:50 -0700 Message-ID: Subject: Re: [PATCH v2 1/1] selftests: cgroup: remove redundant addition of memory controller To: Usama Arif Cc: akpm@linux-foundation.org, hannes@cmpxchg.org, nphamcs@gmail.com, chengming.zhou@linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-team@meta.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 1536740011 X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: iz96swg6cckoqouemwcsxjbnix43rc4y X-HE-Tag: 1714702048-478472 X-HE-Meta: U2FsdGVkX1/O5h5T2J4r5vUvRa3pKaIDqNozeFKWbFAsMyAqh4pHh/tuBmM37Ig2mIKcyEjX/v7m9xduYjSnKvpD7CFgjle7/KJXm0S1M5Vb157W5Xg8V/R4n4ZF5VAN0dEF4Pwr3LSCHu3wDkwRFhEsoK6JkYPHKT7Dz/x2Psl+2kQ5yN6nLQSYboQEPpUAtbvX82IYMKj3c4PQ58hlOgmtHHsjTP9qLq1AxKiyLcve0hF5RKvzoipEmEWgbBck7Av3l5O76VE4XaJHQDDC6hLMEENi71LoC+vHHXz6Y7xcABuk9QETwuVM1GK135/RuYqJz5sOY6tmnZANotMObHH9rHDcnym+L+DGiQmEsH0SBTLTNO4x2cGg+wGnW2yN9KMA8HfcuxUH+obPWoZ3FcJbmadgIfZl4VfoL9s5i5UGbrcMjTHdirhUPhn6TLTk35WcVuG9FrNTIiQhSWeYrQDe1DbNBcOI7K2Sqpe/VYb7MHYhb3hUEX4Ik4c2wXhfWgQ5ps5iLq8yMv82XJ13VmihMg6MpsEjgMgeZaZ6TYhXBgWXIRGdbaB3fBjYXNfL56g7+mNKYJU60cjHG2qSfHSj4lxGe4g+Nf0VVpgZNtAw0EQwz/VQN3QLLy3VG3EHcqeNGzXCYbSzFuzU/91m2Cv2JKmUYb+Zcp56rt2M4jCF9l49kdpWm8gTdgmC9SNPMAS3aQcjq+8yRlsGOsjNVc90/gYgyvnhZgtp1y/9SEyAG24vwvWtmEeCsGYsCxiHytIMjuy2ko8OYhEHp+x5CmISsAEpnYiFavjInZtdBZa3eQj9Rfijzar9EkHDELAt10p10DnZI/+mdXQrLyvJIenf+fcRkfEPi8IOo4qVuOee4R0Dx7H9GSR5/E1uOetLn6Us5yrsWZJJbMC+JdaxlHTocTj8nIkBo/46zJ+wR3bydfISqbg8r/Jac3GUNLn1PUDtiJLAY/XQL5TXIyk 0WWhU2lk DHSyHPewMYJ4ceWj5/YJR071DIePmB13860veAan4XsEUcB+dvXOBB75y/ybHwo2cUIMRS6v1BgTJUlq7Zq/vPSLegRZ+5/YvZ1VsPuvuVjSRe0HZ+fvItKZpOFcd+UZkYP2fQBsywh+yKbXWZWVqwyUFTcXFJ/IsxeK98yztEY6keIJD+tQdYApY34NG9ryxyjlp3ghfFHmtEOode/k5EhxvQUDZ1jayO0ZONam7CE+Yl9GPMQVMjVEk+TmhtABWIyuls9jYRtgW+It+nMF+mxHcVA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.024927, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, May 2, 2024 at 1:05=E2=80=AFPM Usama Arif = wrote: > > Memory controller is already added in main which invokes > the test, hence this does not need to be done in test_no_kmem_bypass. nit: The memory controller is "enabled", not added. Same for the subject li= ne. > > Signed-off-by: Usama Arif Acked-by: Yosry Ahmed > --- > tools/testing/selftests/cgroup/test_zswap.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/tools/testing/selftests/cgroup/test_zswap.c b/tools/testing/= selftests/cgroup/test_zswap.c > index cd864ab825d0..19ac29c533e0 100644 > --- a/tools/testing/selftests/cgroup/test_zswap.c > +++ b/tools/testing/selftests/cgroup/test_zswap.c > @@ -485,8 +485,6 @@ static int test_no_kmem_bypass(const char *root) > trigger_allocation_size =3D sys_info.totalram / 20; > > /* Set up test memcg */ > - if (cg_write(root, "cgroup.subtree_control", "+memory")) > - goto out; > test_group =3D cg_name(root, "kmem_bypass_test"); > if (!test_group) > goto out; > -- > 2.43.0 >