From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C281E8FDAF for ; Tue, 3 Oct 2023 19:48:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 99DA18D008C; Tue, 3 Oct 2023 15:48:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 94DD38D0003; Tue, 3 Oct 2023 15:48:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 815E38D008C; Tue, 3 Oct 2023 15:48:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 681C48D0003 for ; Tue, 3 Oct 2023 15:48:08 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 4927840461 for ; Tue, 3 Oct 2023 19:48:08 +0000 (UTC) X-FDA: 81305186256.13.E633453 Received: from mail-ej1-f42.google.com (mail-ej1-f42.google.com [209.85.218.42]) by imf07.hostedemail.com (Postfix) with ESMTP id 6705E40013 for ; Tue, 3 Oct 2023 19:48:06 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=t4ulTwI+; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf07.hostedemail.com: domain of yosryahmed@google.com designates 209.85.218.42 as permitted sender) smtp.mailfrom=yosryahmed@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1696362486; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=BOpsGqr/1X6QNuekTXnkVYBCRlCRIHiN3DAE7IpST8U=; b=kwVWj82o6wtbEV1U/oASXDI00reZBrNdtOhizChvWNPN4lsxGhOxKfqhJwPFRcg9m0iIWC YtgCAHsg3rLOD2b97YYEDrOC3PX2EZeQo0pw/xhnhKhDDiP2c/nS5Fy/vckjiHWnVNU/4i fgjbv2PgsSfaUt5QuAbaV11UbgC4gqc= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=t4ulTwI+; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf07.hostedemail.com: domain of yosryahmed@google.com designates 209.85.218.42 as permitted sender) smtp.mailfrom=yosryahmed@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1696362486; a=rsa-sha256; cv=none; b=mqIGgh7j1NAZA6wQ38rzQ+NpDKzQ8dPx6/5tH8AP6ETq/HDohAmNN2DD2zxbVPa5a7gaGp Hw/kFX+plnAaqtMWZ5z3K/vdsfj6jkV9XK8++p/itBBmI+8Ds+c20KZADjjNya8UmsoyZV +deVLfGAVDfSy7sECIGF6zPk1jT/kac= Received: by mail-ej1-f42.google.com with SMTP id a640c23a62f3a-9adb9fa7200so40389166b.0 for ; Tue, 03 Oct 2023 12:48:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1696362485; x=1696967285; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=BOpsGqr/1X6QNuekTXnkVYBCRlCRIHiN3DAE7IpST8U=; b=t4ulTwI+nzfJOytc8KF0ixFjG9kUj/cvl99NCwuGcaOBzelYg2beX9sXIHUfWaZFG9 2pfKtGsmK9etu4dq/qsMPX8kHZlWA95ysnn/nC5EPgp9NQDlHNja+5pYeyajmMw1Ic7d Swq4uUrmvOB3TSe+XM7aIJP9mD8o9c/bepuUcFxlkB5deKXX7sBCexU5OF/Gby5r5O3L PdWDacHvtky/JQ39W2ZK/XHGJ2ve44AacrmJaPg9M2VIJ6tCQb2aBjlIVQWh2GCTssJb T2gdqLwckt0V08Mp+FzTOOYVPMfwe0LfjDAx4bLFZy3j2FVh7DWmOB+9RgJXNQZcQD5S c/Rg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696362485; x=1696967285; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=BOpsGqr/1X6QNuekTXnkVYBCRlCRIHiN3DAE7IpST8U=; b=hRU+YwEhIRZR9sSvFvEGQ/XRRUCOA9pq+/va4OFOhFd5sII42u4laWmXMjJWb3PzJ4 fLfGd0abk9XvLMsMo2bVhc7n1TcYlkDltCv/dyQzdBQqfGC+sg/0O3fKk7FaQr4MXgA8 rh1/rJEeN6D7Gl3YAifllEmXcAyk7PXvC49NPzpzDkd5PYLGak42apcsK1rXe4BkBYut ROMxK6oXNT0SLEDEpLxpr9aTs8RMgqZG8jQN28dsD1Lwd1RnvGrLHOIuX0g1hxDoGqtY StHStDVfJ3f+GsO6wxbhMck1fhD7GTXGz3QtK1wxyTHQyikNzTrTj/v13HMpSxvtyJ8c ni3g== X-Gm-Message-State: AOJu0YweKdCkVv9/JX3R1xt7dAz7MiYqGMbjo8YRvCL/qyHxVqoNVOZr RbIi3CgwVcA9JNllG+6230vwmpf82Yd0ZF3MYZGd0RMTlwFjPGVacmVe9Q== X-Google-Smtp-Source: AGHT+IEduj8Ue23tVtZwd5CtZZj5Q4zwMVYXYYDO6HK5+K42BJDPJ0e73p0G3lOHo3Nav0AoLLfFBkaPQhiBGYvWD34= X-Received: by 2002:a17:906:846a:b0:9ad:e41c:e9c9 with SMTP id hx10-20020a170906846a00b009ade41ce9c9mr203402ejc.3.1696362484670; Tue, 03 Oct 2023 12:48:04 -0700 (PDT) MIME-Version: 1.0 References: <20230922175741.635002-1-yosryahmed@google.com> <20230922175741.635002-2-yosryahmed@google.com> In-Reply-To: From: Yosry Ahmed Date: Tue, 3 Oct 2023 12:47:25 -0700 Message-ID: Subject: Re: [PATCH v2 1/2] mm: memcg: refactor page state unit helpers To: =?UTF-8?Q?Michal_Koutn=C3=BD?= Cc: Andrew Morton , Shakeel Butt , Johannes Weiner , Michal Hocko , Roman Gushchin , Muchun Song , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 6705E40013 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: 6eradw9ya6bj3hq64cueyaeaytdcf4h8 X-HE-Tag: 1696362486-319928 X-HE-Meta: U2FsdGVkX1/dgULG89ZF6l78tmjvry5yZnxJK6XOgTxs6JDSK/KvMAMMGuxUWfJ9e6haybHIMDJAAMsYDr4wQmwOgOzCiwo+Z6uM8lHG6zX5qWHvwgD3HkpgLJf0/56/QTCJhtTqQi/hX4CSD1FsCO60o4cK599/no7mihyPWF2gYGuzkS0MeAkCdT2LK3hyOGoojhovq+LPzx1Qb6tSGXymt7JKg9J2gXrCQ7un2yy7fiCg3zmfmfW0rMDIh/yh+NjnAscIUNw0evi7+WF8MyJoFUy+b/4RP/s3qv+ZowpDYYk0Sc8O4zgxvQzald1ylJSBB80lJMlKMidCaaYswlWz0ZCkWobugVFgJfkIV8EqxweWtNvwr6vDA2UbwrbNd/BYCDWAgfJcF8Zn+9SdgJWwpNEHlS/z6bJGDv+favY0AZJQbD+zM1mBkd3ngK4SOUzoQwB32ohWSsKD7/k/m1423TIrDEjdFIsfiTk028eSjZh0kTTYv2hgPpExUUWL2oTI4Rw4IJf6kbjvaYSpJAF0M7B2OqOzxQjo7LrZ/+EVRBfmFmLdATEEmnjJQUwbJVb505gnNcNh8iSV6nDTFyNxAaJvyjy31pJp7PhgIqVzywOiTEr8Erc2Bt+dddyJafThMXowlQ2OsPeBlVRtCpZJzOei5eBlGvmq8oW9Pk9snTdpPkb+3MdE5eE63SzKrEp/bP+cS3tAOFMHXlOmzrRpMhyyb43Era2CXQsmRI+2dJWXieth1iGKVr7q9LfYulLemjh1o/sEDAya/Y2dNlze8Ou83eWfeFpdi5qpKZG3E16qUvf3LxK+a5zvimBQ6nkPwSZUN1IbmVroqXkVwpValVPKYPnoXYaGYk7gTNTTzmM5uaMRQozKoKloDT3qamCH1jiT53N1Pti7H+BB7y5I53p3K38nvBaw20AJgmG1k6SG8+ll6ZkdorY2euThg89dgqJoiAPtyx4HiFS Q093Drll AHRLKnpxUtz7/8l+sACLDr5YJrGuCuODHx9kB+gVbszLeli8P5/IbQBCpTgHrc09DLLN3gYoCJ70tRYLDynWhqThRorNkmy76hsXdaGEihcFtWRb+SMmPcebQw3OX4qZKgmc8XuuolbMcx2bJhyR3oYjcDgy8e4PlcUDGqPfViTNIjSn9uh7J0AUrf+RQ4QTObBFRuW53er0yVDxxAs5Jfl5EJFOkknIY/OPEs4zyFKkuVpCfZ3S2tx+y5DyBo57tmIrbJTapdA5rt7c8oJmom6rJ/BlnjtlWFs3kAVr3iXZEWy8DhtIH6+T47w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000038, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Oct 3, 2023 at 11:11=E2=80=AFAM Michal Koutn=C3=BD wrote: > > On Fri, Sep 22, 2023 at 05:57:39PM +0000, Yosry Ahmed wrote: > > memcg_page_state_unit() is currently used to identify the unit of a > > memcg state item so that all stats in memory.stat are in bytes. However= , > > it lies about the units of WORKINGSET_* stats. These stats actually > > represent pages, but we present them to userspace as a scalar number of > > events. In retrospect, maybe those stats should have been memcg "events= " > > rather than memcg "state". > > Why isn't it possible to move WORKINGSET_* stats under the events now? > (Instead of using internal and external units.) Those constants are shared with code outside of memcg, namely enum node_stat_item and enum vm_event_item, and IIUC they are used differently outside of memcg. Did I miss something? > > Thanks, > Michal