From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F38B0C001B0 for ; Fri, 11 Aug 2023 23:21:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 505D16B0074; Fri, 11 Aug 2023 19:21:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 48F466B0078; Fri, 11 Aug 2023 19:21:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2E1726B007B; Fri, 11 Aug 2023 19:21:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 1BB196B0074 for ; Fri, 11 Aug 2023 19:21:38 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id D64F08014E for ; Fri, 11 Aug 2023 23:21:37 +0000 (UTC) X-FDA: 81113397834.03.471E941 Received: from mail-ej1-f50.google.com (mail-ej1-f50.google.com [209.85.218.50]) by imf05.hostedemail.com (Postfix) with ESMTP id ECC67100018 for ; Fri, 11 Aug 2023 23:21:35 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=i3xYc732; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf05.hostedemail.com: domain of yosryahmed@google.com designates 209.85.218.50 as permitted sender) smtp.mailfrom=yosryahmed@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691796096; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=41cGtG6cdoUsfVpP0qVw+Y1Bpx5c38TTy0gk82Cpz6Q=; b=KTjvmo+62qI+s3apQJzRby7Hap3lyE4sc8WByY7JZVtDc4JbwhLQv9qR8pwNyNxSOh7xGn lOrPrjOdLvfnmDPOzU+XzZGRasdHJH2kpZ4CuX5sIo7J9Cx12E665/xE+Kd0a/+etvd+U0 COgMS9VVM6KOkOXLCbPdGRp5PX3Xb6g= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=i3xYc732; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf05.hostedemail.com: domain of yosryahmed@google.com designates 209.85.218.50 as permitted sender) smtp.mailfrom=yosryahmed@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1691796096; a=rsa-sha256; cv=none; b=CX7wiIQwKQwkGnfB8uWgs3HvQV6CflTMCJTPkxJn/7nGlorgtMalPrqvZF2WIMPUDSczVp zRY1W0hPU5F4mL4pEnnCecRkJsA2HDiH6ix4pGIcuSccT0tLm2VoV/G1TUkf0Z4AE1u1nx 2zf5Xz4d3ROTIh2qdadLUDRMaW889HI= Received: by mail-ej1-f50.google.com with SMTP id a640c23a62f3a-99bf9252eddso347385666b.3 for ; Fri, 11 Aug 2023 16:21:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1691796094; x=1692400894; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=41cGtG6cdoUsfVpP0qVw+Y1Bpx5c38TTy0gk82Cpz6Q=; b=i3xYc732/iiDpKNh2N66tltWCbh4Pdkji90m3sEPA3eqCoMvq8rrH9AJKAO0glDt02 w44/2DktBIECOWW+F4A3uAf6dwRdb6D0PEqfMpyRyoXqPBzuG2mvEJ2l3mK4RKy6MK+K tDDPi70JJuqZ/+ewiwLdqaXRRwSCN115ivKPzo/BtizjxXUasab5EaLzt3NL6Jk7oHU/ rxTQ/uZvmDM4aiHF/qxT+1lYpoPI1pxBto0kRN3eaOBU5cTTYm4b2N2sf0TA6D/mZEYv 6Hfs6W+y69TyEW53KcWe9KHzOMAL+O29tHUOuJ8wx+hT+ofM/WY/u7t6CmK53NJe5nTq M+yw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691796094; x=1692400894; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=41cGtG6cdoUsfVpP0qVw+Y1Bpx5c38TTy0gk82Cpz6Q=; b=YvuhDTl621WIBB4/r2Y/R3TdsmMp8lttJwq749PrL01I5oQXSgR8rVplu0/Wt9CBJy PZg2G+fyGoGvtPyqO+7qucVygVZwHe7a4Y572sLUGhAISPN4XMF1m1BK+F+lDc7sYPYb nwv5M2EhYmGJCoceLuy4VeiTG78TIRFamR5aUBTkJHpJqbEw18bVSKv/ojOGLylE4vOX fVOGavzcMXq1iPHBh+rIhICYprOrHxyfCc9AMkvCHU6LTL1dR5GffB3ll7AgyOCXzpnG bHEe83I7AiG7WdtLkcGUGfFrxAloMkR9i19TibvqD78Molkcc8jte5IvMchB/k7IWeGN xTlw== X-Gm-Message-State: AOJu0YyxOATYvlkBhiTt/vd/KenNywoeGVEjAQsjtCS2KU2uXR+GV88i BbTzeSpf3e0Brry/wu6IGrwBXhMD8vvrtyaFXMenzQ== X-Google-Smtp-Source: AGHT+IFsPB8co56cHDOqbaePaJ0/dhH50ArKYwr/+PHCZSEHSYO0iewdDv3H/FJuolhANWWjoh89CFtRuPwqSPnPPxw= X-Received: by 2002:a17:907:784d:b0:99c:e1f4:271f with SMTP id lb13-20020a170907784d00b0099ce1f4271fmr2988726ejc.18.1691796094347; Fri, 11 Aug 2023 16:21:34 -0700 (PDT) MIME-Version: 1.0 References: <20230620194644.3142384-1-yosryahmed@google.com> <20230811141920.2f9bab6f21ab635ff1bd63ac@linux-foundation.org> In-Reply-To: <20230811141920.2f9bab6f21ab635ff1bd63ac@linux-foundation.org> From: Yosry Ahmed Date: Fri, 11 Aug 2023 16:20:57 -0700 Message-ID: Subject: Re: [PATCH v3] mm: zswap: multiple zpools support To: Andrew Morton Cc: Nhat Pham , Konrad Rzeszutek Wilk , Seth Jennings , Dan Streetman , Vitaly Wool , Johannes Weiner , Domenico Cerasuolo , Yu Zhao , linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: ECC67100018 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: tciaf9f3rfhhc7gqf6aqhfhgdr9kzind X-HE-Tag: 1691796095-501107 X-HE-Meta: U2FsdGVkX188zxAJf+ipBpBliW12pEWOeH/7fIVqqE2u+OO64gCsp5Q1yT+RbOt2r/Sqk8X3a+lNi4jKs/Ox8QsBZiBYVeBckQe24MbrONPNEDBinMZ9PI5fvqcVk8dHDh7XPXsPzGElW4byyaoCBBDOcFm2WoV2PcbMAy+dEgrWzOoi/Ml7FXuzZ0iUo/yl8UtY1oGz6MSg3f8tlLwdWivDlj0uyZl99xvfjC0gReOSVIgOFfZ9vwy0El6UIaIFA0/FG2ZgRijTCeWj44hNm1Ba1UjZ26L46kDZy/xc35E0MUFTnCZ9POeQ8Hg4HjhfguwDHG/IX4j293h0WRdE8SrrIrQhfEXms2HBo65Naj5pCzYz1RCIL9jwkB3r7DOMBFQNrmr+cLvwfWwYEOHuxXo0MknJTY0Lo0l5/FN4MRPWYiMLcrazaQ+bhrKndk2wI+iXC7KeSO8dljFS0VwWUSYxVdbTgIPIwHVGvVevUptX+UK4f3ur2bs16l/IIsB2GiseNSqJgJiUz1UQdBbFGDpAuLiO6XAMBtgFJs5KRMXb//1x7dz3tL13ZkFOaAzeVwliDpbQubHoIyNZb5Rc01wMdmug7uFLiefdP1+qPiRapW26cVjTKKuxf/oFAvlwmBPdoqattq4JZ6RC8d6Rjx9LIodrF6j0s0yKpDns65mD/QtN7B5Akx2HvH3CryLd+zarQ8xeyg3LyaDxkR0tbvUaGDMGACH/iprLN4K6FscdKMsZ8LZNlyDznPQlx6c4cewbwmsQR/6Xhn57Jh4CyD1wc+kfOWfiRivGh6pd/Otz3kNXAhL15OP8wF0/itsjEi1ZNNay5LRTpNGDD35cGB342kmFk7Azo2uUI9vf7WxdXNbvS1SaI/XW5X3ZKYWcvUndt8ZXhuXlOsvC5UufBPaQbUu8urHOI6Rn1UTYzY7Fidve743B8l5o+nq5iDJt5OJftEX3iDqA065+tLW +AtqBGUL 8W4uvU0nCruCZMLfjGyBJC2G73CmX1xrRtOyKy6kLWahZg7wSGKIJqCzQnbZucuwemtk3B9RpPYT1TbQqm/XDyDi4HQ8rpN4/hXCS0teIBLDo+grY5AmQD1oBlxYM0vdRTv65ydZfJI0XfCdycActY0StE7XZj10eoN0V9AlNdk1KeIsmaU7OP+yXgXPvjzAUqvL+TLOdb7g/3Cdnx7ijU4egq24roN6iFvYgzAr7dFpQ+OegRzWE+BDIk3Rwtm4HLH3oA9MMnQQ1D2PqLbLT3H9qYcQ9lTa7IUZSwkrYR89zveTLrjimTUaMXg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Aug 11, 2023 at 2:19=E2=80=AFPM Andrew Morton wrote: > > On Thu, 13 Jul 2023 03:35:25 -0700 Yosry Ahmed wr= ote: > > > > > > > I'm experimenting with some other zswap changes - if I have > > > extra cycles and resources I'll try to apply this patch and see how t= he > > > numbers play out. > > > > That would be amazing. Looking forward to any numbers you can dig :) > > So this patch seems stuck. I can keep it in mm.git until the fog > clears, but would prefer not to. Can we please revisit and decide on a > way forward? Johannes did not like a config option so I proposed it here as a constant (like SWAP_CLUSTER_MAX and others we have). This is a value that we have been using in our data centers for almost a decade, so it has seen a ton of testing. I was hoping Johannes would get time to take a look, or Nhat would get time to test it out, but neither of these things happen. I obviously want it to be merged, but hopefully someone will chime in here = :)