From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE79AC3DA6E for ; Thu, 28 Dec 2023 15:19:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E72508D0016; Thu, 28 Dec 2023 10:19:48 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E22B88D0012; Thu, 28 Dec 2023 10:19:48 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CEA4D8D0016; Thu, 28 Dec 2023 10:19:48 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id BC0F08D0012 for ; Thu, 28 Dec 2023 10:19:48 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 82F7FA022C for ; Thu, 28 Dec 2023 15:19:48 +0000 (UTC) X-FDA: 81616586856.04.771EB88 Received: from mail-lf1-f49.google.com (mail-lf1-f49.google.com [209.85.167.49]) by imf06.hostedemail.com (Postfix) with ESMTP id D82FC180016 for ; Thu, 28 Dec 2023 15:19:46 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=hHeTTgNM; spf=pass (imf06.hostedemail.com: domain of yosryahmed@google.com designates 209.85.167.49 as permitted sender) smtp.mailfrom=yosryahmed@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1703776787; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8Ha+pAOWsoDIh9rt3FhMOiZJHiegkUy/cwMrNu3tQCw=; b=HaPkYYLUvoc0xG8RcE86VSI7tGabPkaluvShj7ZLyLull1jUs2j8nOBxBB3EVHJiyhHIZ/ U2dyGTHfDVRfb1OWJoXH6De4r3+QuSa8j8p625aVmSgpVyH2asu27YaoSTZ2CTIo4DDd9N 9yvto0w+PWl+B51gZG+RS2spqmP53Es= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1703776787; a=rsa-sha256; cv=none; b=ns46CLns/5+g+Pi/ftIGCjYkul0hYm0YTdGB5zaV1mQYigyET+K4Q4oJuTFWIjMA2eXr/d ZdrbxEPpgU479/P11J+M92uHOum85cNeL6iD4kghYQKTz7EhjHKbELVCa19AWUOCBZCIu2 MoeocKQmIWUuwKdCxRC9dpEjNoEiEC8= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=hHeTTgNM; spf=pass (imf06.hostedemail.com: domain of yosryahmed@google.com designates 209.85.167.49 as permitted sender) smtp.mailfrom=yosryahmed@google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-lf1-f49.google.com with SMTP id 2adb3069b0e04-50e7aed09adso3555556e87.0 for ; Thu, 28 Dec 2023 07:19:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1703776785; x=1704381585; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=8Ha+pAOWsoDIh9rt3FhMOiZJHiegkUy/cwMrNu3tQCw=; b=hHeTTgNM2+1ShQ/AaoESTiQbUwV57DR12HQa5r86WwPzbTuZejnMWHjcmt4l0lamth hW2X5i8uwK5tj4hqP6Oz5qqr4aDbjR/5D9XEaDD4FKb6ECdNu/rPjAsicamxswdwK7cS 7Li0cy9i3fLe4uGa4tSaKyhZppTkg/XbjZwGGCoTw56ZjOUvnEZLPora2wndymfBQNEN M7WOgrI6wcZ7mzJ7XpYxJTy5ZIfWTeZZO/KbBr4KMc6P8dF0JGlhADM03j2o/0kiw/yq qko0jpuSJkOauB8qqXALVszivxmkpj/1VW6d+Wk/ysAZstMgh3w8PToPdvPf72wDrHFL lQIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703776785; x=1704381585; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8Ha+pAOWsoDIh9rt3FhMOiZJHiegkUy/cwMrNu3tQCw=; b=jcLuLgPX5EI3No5ncVT5rcQ2z+HIdX6MFzr/LzZLCXwo1EnbQ/ggNcx4JUXES51sl+ HeEzf7TbHt6wtYil85rkkJ2R85Xs+qoouoy70sRF/jhCt/ctsijtWmTzG8Ndxwv6pnF/ Z50HhiAln5aCoo/Z2iUZDYKeONdp/kp2f/eXZGV82kSvPHSCHHu94GKMZeY+yk+j4Vn6 JfT5fS+QGRxWa4xkZCVJzTC+j1Zrrwfmm6Wc7YwMS5wITyWJh1ehmrJfy0TW6QKNQcpB BBatnr7MXB78zPtyoi+50PbIC0oUkX1mZZNg+lHZqle984Q1rMWIjDLcr7svBm9QBVEH /lew== X-Gm-Message-State: AOJu0YyI3SrzqXGjMnO7RxBW6fbw3SL7/qbq8sYysyhJplwOVwIpsRrY 37w2/kjQZDauH9Mdf0ZWIMIiY7GQz0gz7KX2aq2rFZ4WXuFO X-Google-Smtp-Source: AGHT+IFNY57uXAYiuNoisdfoK3o+0pMDBpwcVA50bsXFgyoyptZU2V5fBdcVs9EEPUiT5eyE1TLUAMSGFGCrTXBHPEQ= X-Received: by 2002:a05:6512:1329:b0:50e:8ccc:6df5 with SMTP id x41-20020a056512132900b0050e8ccc6df5mr554370lfu.27.1703776784726; Thu, 28 Dec 2023 07:19:44 -0800 (PST) MIME-Version: 1.0 References: <20231213-zswap-dstmem-v5-0-9382162bbf05@bytedance.com> <20231213-zswap-dstmem-v5-5-9382162bbf05@bytedance.com> In-Reply-To: <20231213-zswap-dstmem-v5-5-9382162bbf05@bytedance.com> From: Yosry Ahmed Date: Thu, 28 Dec 2023 07:19:08 -0800 Message-ID: Subject: Re: [PATCH v5 5/5] mm/zswap: change per-cpu mutex and buffer to per-acomp_ctx To: Chengming Zhou Cc: Barry Song <21cnbao@gmail.com>, Nhat Pham , Andrew Morton , Dan Streetman , Vitaly Wool , Johannes Weiner , Chris Li , Seth Jennings , Chris Li , linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: D82FC180016 X-Rspam-User: X-Stat-Signature: 4ixex9yt4e8da5cdowegsq7eo44wqnb5 X-Rspamd-Server: rspam03 X-HE-Tag: 1703776786-756447 X-HE-Meta: U2FsdGVkX1+NPrwAAEYNcmOGh5XXbsCP3N6Nv+t1ymbio+aknZ0dTtUMTV6BFuvWnrX9o8q98i2xG3BOy9DlzqE/TpihFc6Jct4D+WXUfTl3ljTKnJMFwlfxORcfoTsiU11QJFgy3VEypIfWwbRLP7CMac1yHC9JJBj4GS9m6cKBORAg8J6FpNwKO2tOjfkIQOc5gJRN2s/APLtyyBguYfKAx6QHE71HkQHFoXAaTg2OmvOCeo3aWGDuhojnPmvrvCzR6qp9DYZaHUJbwojC1VIuarsHnZAL5x9HGPECTaxpDpAEYEvJqrEwHnP6fqJvl+nsOytBpeLzM4jo7r8uHY0GNZkA9xheOIV08lJUdGxgVNloh6wj8XS0GtylBuQOiRADm2gTTF0iGA3LbQ7JwzrbBr2lVlQBAOJYFYgBoyXj9SGl8oS4NwSSq9jEaQj3MovLVU4xOMYN5NvQ6sSKUPVsVkCf8kpp38pTnme3nThdvixKSgR6yABO6YM9WnxUJSXt7MPpc0tzkxjhhA+9x/wAv9IWD7ttcECHoyGV5FB4F3KqoPq47sleYOAhIql+0ZYHoRluT/skNNDJNZR4o6/wQPidGUt6yM+m/9L5nDJ5JDuTB7trYafBiv+NZqw3rUUYLNfaGWVEA1WjMqZQRfJjxQbi3hOUM7hum/+k4Dj3Vicge2uOySTA/BgYkj4vtIDbTVtw6zHCwGarKessnJ1yrJB21RhHmyLkVF9yywmbkXfHqIc7B12WMImcIOPC50FkqHaP1CNiTwtGKl9rLx+5F6XWPKhVvdUAnFNF2I6O7Hc/t6CJU+hUWyYwaffNQZv4PpM6J2D7o1EAEE6iaUjE6kPZ98R0wkCHbyZ+pe6xE9NTMyydqc7XQ7VMd7df8vpmVbT6QFWhtXrgyX2qHwITzY62lkihvc9SOXRYXPtSZjmT664yHuXuF4pvaGDaZV1TUoiEZCRc8ky1nXl cD5ZJ1FP l4vewnAs9EYp26Z1t2+mdMoADYnV7NTPtalFcr37BRptVZhQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000025, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Dec 28, 2023 at 1:46=E2=80=AFAM Chengming Zhou wrote: > > First of all, we need to rename acomp_ctx->dstmem field to buffer, > since we are now using for purposes other than compression. > > Then we change per-cpu mutex and buffer to per-acomp_ctx, since > them belong to the acomp_ctx and are necessary parts when used > in the compress/decompress contexts. > > So we can remove the old per-cpu mutex and dstmem. > > Acked-by: Chris Li (Google) > Reviewed-by: Nhat Pham > Signed-off-by: Chengming Zhou Instead of hardcoding PAGE_SIZE * 2 multiple times, can we define a constant for this and document the need for the buffer size there? Even better if that constant is based on WORST_COMPR_FACTOR and shared between zswap and zram -- but this can be a follow up change.